178968 2017-10-27 17:58:16 -0700 [GTK] Build more files under WebCore as unified sources 2018-02-07 08:31:38 -0800 1 1 1 Unclassified WebKit WebKitGTK Other PC Linux RESOLVED FIXED P2 Normal --- 178964 1 mcatanzaro mcatanzaro annulen bugs-noreply keith_miller mcatanzaro oldest_to_newest 1365602 0 mcatanzaro 2017-10-27 17:58:16 -0700 Build more files under WebCore as unified sources (after landing the patch in bug #178964). 1366315 1 mcatanzaro 2017-10-30 20:51:53 -0700 It will take some work (and understanding of Ruby) to be able to build WebCorePlatformGTK and WebCorePlatformGTK2 using unified sources, since they are two different build targets that are built with the same sources, and there is a useful check to ensure the same file is not accidentally listed twice that I don't want to remove. Plus I don't really understand that code. But there are still many files here that can easily be built unified. 1366316 2 325422 mcatanzaro 2017-10-30 20:53:18 -0700 Created attachment 325422 Patch 1366319 3 325422 keith_miller 2017-10-30 21:18:40 -0700 Comment on attachment 325422 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=325422&action=review > Source/WebCore/SourcesWPE.txt:40 > +# This can't go into SourcesGLib.txt because it has to go into WebCorePlatformGTK. # => // 1366326 4 325422 keith_miller 2017-10-30 22:28:07 -0700 Comment on attachment 325422 Patch r=me if you fix the WPE issue. 1366392 5 mcatanzaro 2017-10-31 08:08:10 -0700 (In reply to Keith Miller from comment #4) > Comment on attachment 325422 [details] > Patch > > r=me if you fix the WPE issue. That's not really possible to fix, which is why I removed the FIXME. The problem is that for GTK it needs to be complied into a different build target than all the other files in SourcesGLib. It will just have to be special, I guess. 1366393 6 mcatanzaro 2017-10-31 08:10:51 -0700 Oh wait, I misunderstood... I see now WPE is broken because I used # instead of //. Comment #3. Yeah. 1366394 7 mcatanzaro 2017-10-31 08:16:11 -0700 Committed r224233: <https://trac.webkit.org/changeset/224233> 1397133 8 annulen 2018-02-07 03:31:21 -0800 Is it really worthwhile? I don't have any statistics, but from my personal experience it's rather likely that GTK developers should modify platform-specific files more often than port-independent core during their work, and having files built as a part of unified system adds penalty to incremental rebuild time. OTOH, platform-specific files take a small fraction of total build time so speed up in complete rebuild is not so significant. 1397142 9 mcatanzaro 2018-02-07 05:50:28 -0800 (In reply to Konstantin Tokarev from comment #8) > Is it really worthwhile? I don't have any statistics, but from my personal > experience it's rather likely that GTK developers should modify > platform-specific files more often than port-independent core during their > work, and having files built as a part of unified system adds penalty to > incremental rebuild time. OTOH, platform-specific files take a small > fraction of total build time so speed up in complete rebuild is not so > significant. The platform-specific files actually do have a significant impact on build time. The WPE port builds roughly 25% faster than the GTK port, which is insane. I'm hoping to cut down on this by unifying as much as possible, notably the GTK DOM API, which seems to be one of the major differences between GTK and WPE. Current limitations: * The sources under WebCore/platform are difficult to unify, because the build files rely on USE_[LIBRARY] style flags instead of feature flags defined in WebKitFeatures.cmake. I'm not certain, but I don't believe we can use those in conditionals inside the Sources.txt. * We can only unify files that are built into a WebKit framework declared with the WEBKIT_FRAMEWORK macros. This means it's hard to unify the PluginProcessGTK2 build, which is the other main difference between GTK and WPE. 1397150 10 annulen 2018-02-07 06:01:28 -0800 (In reply to Michael Catanzaro from comment #9) Thanks for explanation. > The platform-specific files actually do have a significant impact on build > time. The WPE port builds roughly 25% faster than the GTK port, which is > insane. I'm hoping to cut down on this by unifying as much as possible, > notably the GTK DOM API, which seems to be one of the major differences > between GTK and WPE. If only DOM API is unified, could it make a qualitative change? > > Current limitations: > > * The sources under WebCore/platform are difficult to unify, because the > build files rely on USE_[LIBRARY] style flags instead of feature flags > defined in WebKitFeatures.cmake. I'm not certain, but I don't believe we can > use those in conditionals inside the Sources.txt. > * We can only unify files that are built into a WebKit framework declared > with the WEBKIT_FRAMEWORK macros. This means it's hard to unify the > PluginProcessGTK2 build, which is the other main difference between GTK and > WPE. It may be useful to factorize WEBKIT_FRAMEWORK to be useful for non-libraries, and/or use modern property-based approach instead of relying on variable names. (Actually, I think having unified variable names in all targets is a good thing) 1397185 11 mcatanzaro 2018-02-07 08:31:38 -0800 (In reply to Konstantin Tokarev from comment #10) > If only DOM API is unified, could it make a qualitative change? I haven't tried it yet. I'll try after bug #182450 lands. 325422 2017-10-30 20:53:18 -0700 2017-10-30 22:28:07 -0700 Patch bug-178968-20171030225318.patch text/plain 11102 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjI0MjA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzE4ZWE1YjUxZWQwYjFl ZTc2NmQzYjVhMTMzMGVjMzQ1ZmRiNDg2Ni4uZTAyMjRjMTdhOTM4Yzc4NTI3ZTllODA3ODlkZjcy NWIzMGZkMzE5NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE3IEBACiAyMDE3LTEwLTMwICBNaWNo YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KIAorICAgICAgICBbR1RLXSBC dWlsZCBtb3JlIGZpbGVzIHVuZGVyIFdlYkNvcmUgYXMgdW5pZmllZCBzb3VyY2VzCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzg5NjgKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFBsYXRmb3JtR1RLLmNt YWtlOgorICAgICAgICAqIFBsYXRmb3JtV1BFLmNtYWtlOgorICAgICAgICAqIFNvdXJjZXNHVEsu dHh0OiBBZGRlZC4KKyAgICAgICAgKiBTb3VyY2VzV1BFLnR4dDoKKworMjAxNy0xMC0zMCAgTWlj aGFlbCBDYXRhbnphcm8gIDxtY2F0YW56YXJvQGlnYWxpYS5jb20+CisKICAgICAgICAgV0tCdW5k bGVQYWdlV2lsbFNlbmRTdWJtaXRFdmVudENhbGxiYWNrIGlzIGNhbGxlZCB3aXRoIGluY29ycmVj dCBmcmFtZSBwYXJhbWV0ZXIKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE3NjcxOQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9QbGF0Zm9ybUdU Sy5jbWFrZSBiL1NvdXJjZS9XZWJDb3JlL1BsYXRmb3JtR1RLLmNtYWtlCmluZGV4IGIwNzM5YzAx NjZjYjBlOGUxOWI4MmJjM2JkNmQ1MDRiN2Y5OTg4YmUuLjZlNTYwZDE1MTFiYmVhMGNlNzFiNzdj OGFjZjMzMjk1NTYxMmE0MTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL1BsYXRmb3JtR1RL LmNtYWtlCisrKyBiL1NvdXJjZS9XZWJDb3JlL1BsYXRmb3JtR1RLLmNtYWtlCkBAIC0xMCw2ICsx MCwxMyBAQCBlbmRpZiAoKQogCiBzZXQoV2ViQ29yZV9PVVRQVVRfTkFNRSBXZWJDb3JlR1RLKQog CitsaXN0KEFQUEVORCBXZWJDb3JlX1VOSUZJRURfU09VUkNFX0xJU1RfRklMRVMKKyAgICAiU291 cmNlc0dUSy50eHQiCisKKyAgICAicGxhdGZvcm0vU291cmNlc0dMaWIudHh0IgorICAgICJwbGF0 Zm9ybS9Tb3VyY2VzU291cC50eHQiCispCisKIGxpc3QoQVBQRU5EIFdlYkNvcmVfSU5DTFVERV9E SVJFQ1RPUklFUwogICAgICIke1RISVJEUEFSVFlfRElSfS9BTkdMRS8iCiAgICAgIiR7VEhJUkRQ QVJUWV9ESVJ9L0FOR0xFL2luY2x1ZGUvS0hSIgpAQCAtMzIsMTE5ICszOSw2IEBAIGxpc3QoQVBQ RU5EIFdlYkNvcmVfSU5DTFVERV9ESVJFQ1RPUklFUwogICAgICIke1dFQkNPUkVfRElSfS9wbGF0 Zm9ybS90ZXh0L2d0ayIKICkKIAotbGlzdChBUFBFTkQgV2ViQ29yZV9TT1VSQ0VTCi0gICAgYWNj ZXNzaWJpbGl0eS9hdGsvQVhPYmplY3RDYWNoZUF0ay5jcHAKLSAgICBhY2Nlc3NpYmlsaXR5L2F0 ay9BY2Nlc3NpYmlsaXR5T2JqZWN0QXRrLmNwcAotICAgIGFjY2Vzc2liaWxpdHkvYXRrL1dlYktp dEFjY2Vzc2libGVIeXBlcmxpbmsuY3BwCi0gICAgYWNjZXNzaWJpbGl0eS9hdGsvV2ViS2l0QWNj ZXNzaWJsZUludGVyZmFjZUFjdGlvbi5jcHAKLSAgICBhY2Nlc3NpYmlsaXR5L2F0ay9XZWJLaXRB Y2Nlc3NpYmxlSW50ZXJmYWNlQ29tcG9uZW50LmNwcAotICAgIGFjY2Vzc2liaWxpdHkvYXRrL1dl YktpdEFjY2Vzc2libGVJbnRlcmZhY2VEb2N1bWVudC5jcHAKLSAgICBhY2Nlc3NpYmlsaXR5L2F0 ay9XZWJLaXRBY2Nlc3NpYmxlSW50ZXJmYWNlRWRpdGFibGVUZXh0LmNwcAotICAgIGFjY2Vzc2li aWxpdHkvYXRrL1dlYktpdEFjY2Vzc2libGVJbnRlcmZhY2VIeXBlcmxpbmtJbXBsLmNwcAotICAg IGFjY2Vzc2liaWxpdHkvYXRrL1dlYktpdEFjY2Vzc2libGVJbnRlcmZhY2VIeXBlcnRleHQuY3Bw Ci0gICAgYWNjZXNzaWJpbGl0eS9hdGsvV2ViS2l0QWNjZXNzaWJsZUludGVyZmFjZUltYWdlLmNw cAotICAgIGFjY2Vzc2liaWxpdHkvYXRrL1dlYktpdEFjY2Vzc2libGVJbnRlcmZhY2VTZWxlY3Rp b24uY3BwCi0gICAgYWNjZXNzaWJpbGl0eS9hdGsvV2ViS2l0QWNjZXNzaWJsZUludGVyZmFjZVRh YmxlLmNwcAotICAgIGFjY2Vzc2liaWxpdHkvYXRrL1dlYktpdEFjY2Vzc2libGVJbnRlcmZhY2VU YWJsZUNlbGwuY3BwCi0gICAgYWNjZXNzaWJpbGl0eS9hdGsvV2ViS2l0QWNjZXNzaWJsZUludGVy ZmFjZVRleHQuY3BwCi0gICAgYWNjZXNzaWJpbGl0eS9hdGsvV2ViS2l0QWNjZXNzaWJsZUludGVy ZmFjZVZhbHVlLmNwcAotICAgIGFjY2Vzc2liaWxpdHkvYXRrL1dlYktpdEFjY2Vzc2libGVVdGls LmNwcAotICAgIGFjY2Vzc2liaWxpdHkvYXRrL1dlYktpdEFjY2Vzc2libGVXcmFwcGVyQXRrLmNw cAotCi0gICAgZWRpdGluZy9hdGsvRnJhbWVTZWxlY3Rpb25BdGsuY3BwCi0KLSAgICBsb2FkZXIv c291cC9DYWNoZWRSYXdSZXNvdXJjZVNvdXAuY3BwCi0gICAgbG9hZGVyL3NvdXAvU3VicmVzb3Vy Y2VMb2FkZXJTb3VwLmNwcAotCi0gICAgcGFnZS9saW51eC9SZXNvdXJjZVVzYWdlT3ZlcmxheUxp bnV4LmNwcAotICAgIHBhZ2UvbGludXgvUmVzb3VyY2VVc2FnZVRocmVhZExpbnV4LmNwcAotCi0g ICAgcGxhdGZvcm0vU2Nyb2xsQW5pbWF0aW9uS2luZXRpYy5jcHAKLSAgICBwbGF0Zm9ybS9TdGF0 aWNQYXN0ZWJvYXJkLmNwcAotICAgIHBsYXRmb3JtL1VzZXJBZ2VudFF1aXJrcy5jcHAKLQotICAg IHBsYXRmb3JtL2F1ZGlvL2dsaWIvQXVkaW9CdXNHTGliLmNwcAotCi0gICAgcGxhdGZvcm0vZ2Vv Y2x1ZS9HZW9sb2NhdGlvblByb3ZpZGVyR2VvY2x1ZS5jcHAKLQotICAgIHBsYXRmb3JtL2dsaWIv RXZlbnRMb29wR2xpYi5jcHAKLSAgICBwbGF0Zm9ybS9nbGliL0ZpbGVNb25pdG9yR0xpYi5jcHAK LSAgICBwbGF0Zm9ybS9nbGliL0ZpbGVTeXN0ZW1HbGliLmNwcAotICAgIHBsYXRmb3JtL2dsaWIv S2V5ZWREZWNvZGVyR2xpYi5jcHAKLSAgICBwbGF0Zm9ybS9nbGliL0tleWVkRW5jb2RlckdsaWIu Y3BwCi0gICAgcGxhdGZvcm0vZ2xpYi9Mb3dQb3dlck1vZGVOb3RpZmllckdMaWIuY3BwCi0gICAg cGxhdGZvcm0vZ2xpYi9NYWluVGhyZWFkU2hhcmVkVGltZXJHTGliLmNwcAotICAgIHBsYXRmb3Jt L2dsaWIvU1NMS2V5R2VuZXJhdG9yR0xpYi5jcHAKLSAgICBwbGF0Zm9ybS9nbGliL1NoYXJlZEJ1 ZmZlckdsaWIuY3BwCi0gICAgcGxhdGZvcm0vZ2xpYi9Vc2VyQWdlbnRHTGliLmNwcAotCi0gICAg cGxhdGZvcm0vZ3JhcGhpY3MvR0xDb250ZXh0LmNwcAotICAgIHBsYXRmb3JtL2dyYXBoaWNzL0dy YXBoaWNzQ29udGV4dDNEUHJpdmF0ZS5jcHAKLQotICAgIHBsYXRmb3JtL2dyYXBoaWNzL2NhaXJv L0JhY2tpbmdTdG9yZUJhY2tlbmRDYWlyb1gxMS5jcHAKLQotICAgIHBsYXRmb3JtL2dyYXBoaWNz L2VnbC9HTENvbnRleHRFR0wuY3BwCi0gICAgcGxhdGZvcm0vZ3JhcGhpY3MvZWdsL0dMQ29udGV4 dEVHTFdheWxhbmQuY3BwCi0gICAgcGxhdGZvcm0vZ3JhcGhpY3MvZWdsL0dMQ29udGV4dEVHTFgx MS5jcHAKLQotICAgIHBsYXRmb3JtL2dyYXBoaWNzL2dseC9HTENvbnRleHRHTFguY3BwCi0KLSAg ICBwbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvSW1hZ2VHU3RyZWFtZXJDYWlyby5jcHAKLQot ICAgIHBsYXRmb3JtL2dyYXBoaWNzL29wZW5nbC9FeHRlbnNpb25zM0RPcGVuR0xDb21tb24uY3Bw Ci0gICAgcGxhdGZvcm0vZ3JhcGhpY3Mvb3BlbmdsL0dyYXBoaWNzQ29udGV4dDNET3BlbkdMQ29t bW9uLmNwcAotICAgIHBsYXRmb3JtL2dyYXBoaWNzL29wZW5nbC9UZW1wb3JhcnlPcGVuR0xTZXR0 aW5nLmNwcAotCi0gICAgcGxhdGZvcm0vZ3JhcGhpY3Mvb3BlbnR5cGUvT3BlblR5cGVWZXJ0aWNh bERhdGEuY3BwCi0KLSAgICBwbGF0Zm9ybS9ncmFwaGljcy93YXlsYW5kL1BsYXRmb3JtRGlzcGxh eVdheWxhbmQuY3BwCi0KLSAgICBwbGF0Zm9ybS9ncmFwaGljcy94MTEvUGxhdGZvcm1EaXNwbGF5 WDExLmNwcAotICAgIHBsYXRmb3JtL2dyYXBoaWNzL3gxMS9YRXJyb3JUcmFwcGVyLmNwcAotICAg IHBsYXRmb3JtL2dyYXBoaWNzL3gxMS9YVW5pcXVlUmVzb3VyY2UuY3BwCi0KLSAgICBwbGF0Zm9y bS9ndGsvRHJhZ0RhdGFHdGsuY3BwCi0gICAgcGxhdGZvcm0vZ3RrL0xvY2FsaXplZFN0cmluZ3NH dGsuY3BwCi0gICAgcGxhdGZvcm0vZ3RrL1Bhc3RlYm9hcmRHdGsuY3BwCi0gICAgcGxhdGZvcm0v Z3RrL1Njcm9sbEFuaW1hdG9yR3RrLmNwcAotICAgIHBsYXRmb3JtL2d0ay9TZWxlY3Rpb25EYXRh LmNwcAotCi0gICAgcGxhdGZvcm0vbmV0d29yay9nbGliL05ldHdvcmtTdGF0ZU5vdGlmaWVyR0xp Yi5jcHAKLQotICAgIHBsYXRmb3JtL25ldHdvcmsvc291cC9BdXRoZW50aWNhdGlvbkNoYWxsZW5n ZVNvdXAuY3BwCi0gICAgcGxhdGZvcm0vbmV0d29yay9zb3VwL0NlcnRpZmljYXRlSW5mby5jcHAK LSAgICBwbGF0Zm9ybS9uZXR3b3JrL3NvdXAvQ29va2llSmFyU291cC5jcHAKLSAgICBwbGF0Zm9y bS9uZXR3b3JrL3NvdXAvQ29va2llU3RvcmFnZVNvdXAuY3BwCi0gICAgcGxhdGZvcm0vbmV0d29y ay9zb3VwL0NyZWRlbnRpYWxTdG9yYWdlU291cC5jcHAKLSAgICBwbGF0Zm9ybS9uZXR3b3JrL3Nv dXAvRE5TU291cC5jcHAKLSAgICBwbGF0Zm9ybS9uZXR3b3JrL3NvdXAvR1JlZlB0clNvdXAuY3Bw Ci0gICAgcGxhdGZvcm0vbmV0d29yay9zb3VwL05ldHdvcmtTdG9yYWdlU2Vzc2lvblNvdXAuY3Bw Ci0gICAgcGxhdGZvcm0vbmV0d29yay9zb3VwL1Byb3h5U2VydmVyU291cC5jcHAKLSAgICBwbGF0 Zm9ybS9uZXR3b3JrL3NvdXAvUmVzb3VyY2VFcnJvclNvdXAuY3BwCi0gICAgcGxhdGZvcm0vbmV0 d29yay9zb3VwL1Jlc291cmNlSGFuZGxlU291cC5jcHAKLSAgICBwbGF0Zm9ybS9uZXR3b3JrL3Nv dXAvUmVzb3VyY2VSZXF1ZXN0U291cC5jcHAKLSAgICBwbGF0Zm9ybS9uZXR3b3JrL3NvdXAvUmVz b3VyY2VSZXNwb25zZVNvdXAuY3BwCi0gICAgcGxhdGZvcm0vbmV0d29yay9zb3VwL1NvY2tldFN0 cmVhbUhhbmRsZUltcGxTb3VwLmNwcAotICAgIHBsYXRmb3JtL25ldHdvcmsvc291cC9Tb3VwTmV0 d29ya1Nlc3Npb24uY3BwCi0gICAgcGxhdGZvcm0vbmV0d29yay9zb3VwL1N5bmNocm9ub3VzTG9h ZGVyQ2xpZW50U291cC5jcHAKLSAgICBwbGF0Zm9ybS9uZXR3b3JrL3NvdXAvV2ViS2l0U291cFJl cXVlc3RHZW5lcmljLmNwcAotCi0gICAgcGxhdGZvcm0vc291cC9QdWJsaWNTdWZmaXhTb3VwLmNw cAotICAgIHBsYXRmb3JtL3NvdXAvU2hhcmVkQnVmZmVyU291cC5jcHAKLSAgICBwbGF0Zm9ybS9z b3VwL1VSTFNvdXAuY3BwCi0KLSAgICBwbGF0Zm9ybS90ZXh0L0h5cGhlbmF0aW9uLmNwcAotICAg IHBsYXRmb3JtL3RleHQvTG9jYWxlSUNVLmNwcAotCi0gICAgcGxhdGZvcm0vdGV4dC9lbmNoYW50 L1RleHRDaGVja2VyRW5jaGFudC5jcHAKLQotICAgIHBsYXRmb3JtL3RleHQvaHlwaGVuL0h5cGhl bmF0aW9uTGliSHlwaGVuLmNwcAotCi0gICAgcGxhdGZvcm0vdW5peC9Mb2dnaW5nVW5peC5jcHAK LQotICAgIHBsYXRmb3JtL3hkZy9NSU1FVHlwZVJlZ2lzdHJ5WGRnLmNwcAotKQotCiBsaXN0KEFQ UEVORCBXZWJDb3JlUGxhdGZvcm1HVEtfU09VUkNFUwogICAgIGVkaXRpbmcvZ3RrL0VkaXRvckd0 ay5jcHAKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvUGxhdGZvcm1XUEUuY21ha2UgYi9T b3VyY2UvV2ViQ29yZS9QbGF0Zm9ybVdQRS5jbWFrZQppbmRleCBkY2QzMDcyN2E2MTI1ZTQxZWY2 MzQwODI2NTQxNTY5YjcwNDQ2NzQ3Li5lODE0NWZhMzQxYzg2NTlkNzg4OGVkNTIyMzRhNTZlMDE1 MmNlZjkzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9QbGF0Zm9ybVdQRS5jbWFrZQorKysg Yi9Tb3VyY2UvV2ViQ29yZS9QbGF0Zm9ybVdQRS5jbWFrZQpAQCAtMTIsMTEgKzEyLDYgQEAgbGlz dChBUFBFTkQgV2ViQ29yZV9VTklGSUVEX1NPVVJDRV9MSVNUX0ZJTEVTCiAgICAgInBsYXRmb3Jt L1NvdXJjZXNTb3VwLnR4dCIKICkKIAotIyBGSVhNRTogVGhpcyBjYW4ndCBnbyBpbnRvIFNvdXJj ZXNHTGliLnR4dCBiZWNhdXNlIGl0IGhhcyB0byBnbyBpbnRvIFdlYkNvcmVQbGF0Zm9ybUdUSy4K LWxpc3QoQVBQRU5EIFdlYkNvcmVfU09VUkNFUwotICAgIHBsYXRmb3JtL2dsaWIvRXZlbnRIYW5k bGVyR0xpYi5jcHAKLSkKLQogIyBBbGxvdyBidWlsZGluZyBBTkdMRSBvbiBwbGF0Zm9ybXMgdGhh dCBkb24ndCBwcm92aWRlIFgxMSBoZWFkZXJzLgogbGlzdChBUFBFTkQgQU5HTEVfUExBVEZPUk1f REVGSU5JVElPTlMgIlVTRV9XUEUiKQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Tb3Vy Y2VzR1RLLnR4dCBiL1NvdXJjZS9XZWJDb3JlL1NvdXJjZXNHVEsudHh0Cm5ldyBmaWxlIG1vZGUg MTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjA4 MDZkYjI1MDZlYjNjNzcyYWUzMjMzMTMxNmE3OTY2ZmJjMWZkMWQKLS0tIC9kZXYvbnVsbAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9Tb3VyY2VzR1RLLnR4dApAQCAtMCwwICsxLDk2IEBACisvLyBDb3B5 cmlnaHQgKEMpIDIwMTcgSWdhbGlhIFMuTC4KKy8vCisvLyBSZWRpc3RyaWJ1dGlvbiBhbmQgdXNl IGluIHNvdXJjZSBhbmQgYmluYXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQKKy8vIG1vZGlmaWNh dGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xsb3dpbmcgY29uZGl0aW9u cworLy8gYXJlIG1ldDoKKy8vIDEuIFJlZGlzdHJpYnV0aW9ucyBvZiBzb3VyY2UgY29kZSBtdXN0 IHJldGFpbiB0aGUgYWJvdmUgY29weXJpZ2h0CisvLyAgICBub3RpY2UsIHRoaXMgbGlzdCBvZiBj b25kaXRpb25zIGFuZCB0aGUgZm9sbG93aW5nIGRpc2NsYWltZXIuCisvLyAyLiBSZWRpc3RyaWJ1 dGlvbnMgaW4gYmluYXJ5IGZvcm0gbXVzdCByZXByb2R1Y2UgdGhlIGFib3ZlIGNvcHlyaWdodAor Ly8gICAgbm90aWNlLCB0aGlzIGxpc3Qgb2YgY29uZGl0aW9ucyBhbmQgdGhlIGZvbGxvd2luZyBk aXNjbGFpbWVyIGluIHRoZQorLy8gICAgZG9jdW1lbnRhdGlvbiBhbmQvb3Igb3RoZXIgbWF0ZXJp YWxzIHByb3ZpZGVkIHdpdGggdGhlIGRpc3RyaWJ1dGlvbi4KKy8vCisvLyBUSElTIFNPRlRXQVJF IElTIFBST1ZJREVEIEJZIEFQUExFIElOQy4gQU5EIElUUyBDT05UUklCVVRPUlMgYGBBUyBJUycn CisvLyBBTkQgQU5ZIEVYUFJFU1MgT1IgSU1QTElFRCBXQVJSQU5USUVTLCBJTkNMVURJTkcsIEJV VCBOT1QgTElNSVRFRCBUTywKKy8vIFRIRSBJTVBMSUVEIFdBUlJBTlRJRVMgT0YgTUVSQ0hBTlRB QklMSVRZIEFORCBGSVRORVNTIEZPUiBBIFBBUlRJQ1VMQVIKKy8vIFBVUlBPU0UgQVJFIERJU0NM QUlNRUQuIElOIE5PIEVWRU5UIFNIQUxMIEFQUExFIElOQy4gT1IgSVRTIENPTlRSSUJVVE9SUwor Ly8gQkUgTElBQkxFIEZPUiBBTlkgRElSRUNULCBJTkRJUkVDVCwgSU5DSURFTlRBTCwgU1BFQ0lB TCwgRVhFTVBMQVJZLCBPUgorLy8gQ09OU0VRVUVOVElBTCBEQU1BR0VTIChJTkNMVURJTkcsIEJV VCBOT1QgTElNSVRFRCBUTywgUFJPQ1VSRU1FTlQgT0YKKy8vIFNVQlNUSVRVVEUgR09PRFMgT1Ig U0VSVklDRVM7IExPU1MgT0YgVVNFLCBEQVRBLCBPUiBQUk9GSVRTOyBPUiBCVVNJTkVTUworLy8g SU5URVJSVVBUSU9OKSBIT1dFVkVSIENBVVNFRCBBTkQgT04gQU5ZIFRIRU9SWSBPRiBMSUFCSUxJ VFksIFdIRVRIRVIgSU4KKy8vIENPTlRSQUNULCBTVFJJQ1QgTElBQklMSVRZLCBPUiBUT1JUIChJ TkNMVURJTkcgTkVHTElHRU5DRSBPUiBPVEhFUldJU0UpCisvLyBBUklTSU5HIElOIEFOWSBXQVkg T1VUIE9GIFRIRSBVU0UgT0YgVEhJUyBTT0ZUV0FSRSwgRVZFTiBJRiBBRFZJU0VEIE9GCisvLyBU SEUgUE9TU0lCSUxJVFkgT0YgU1VDSCBEQU1BR0UuCisKK2FjY2Vzc2liaWxpdHkvYXRrL0FYT2Jq ZWN0Q2FjaGVBdGsuY3BwCithY2Nlc3NpYmlsaXR5L2F0ay9BY2Nlc3NpYmlsaXR5T2JqZWN0QXRr LmNwcAorYWNjZXNzaWJpbGl0eS9hdGsvV2ViS2l0QWNjZXNzaWJsZUh5cGVybGluay5jcHAKK2Fj Y2Vzc2liaWxpdHkvYXRrL1dlYktpdEFjY2Vzc2libGVJbnRlcmZhY2VBY3Rpb24uY3BwIEBuby11 bmlmeQorYWNjZXNzaWJpbGl0eS9hdGsvV2ViS2l0QWNjZXNzaWJsZUludGVyZmFjZUNvbXBvbmVu dC5jcHAKK2FjY2Vzc2liaWxpdHkvYXRrL1dlYktpdEFjY2Vzc2libGVJbnRlcmZhY2VEb2N1bWVu dC5jcHAKK2FjY2Vzc2liaWxpdHkvYXRrL1dlYktpdEFjY2Vzc2libGVJbnRlcmZhY2VFZGl0YWJs ZVRleHQuY3BwCithY2Nlc3NpYmlsaXR5L2F0ay9XZWJLaXRBY2Nlc3NpYmxlSW50ZXJmYWNlSHlw ZXJsaW5rSW1wbC5jcHAKK2FjY2Vzc2liaWxpdHkvYXRrL1dlYktpdEFjY2Vzc2libGVJbnRlcmZh Y2VIeXBlcnRleHQuY3BwCithY2Nlc3NpYmlsaXR5L2F0ay9XZWJLaXRBY2Nlc3NpYmxlSW50ZXJm YWNlSW1hZ2UuY3BwCithY2Nlc3NpYmlsaXR5L2F0ay9XZWJLaXRBY2Nlc3NpYmxlSW50ZXJmYWNl U2VsZWN0aW9uLmNwcAorYWNjZXNzaWJpbGl0eS9hdGsvV2ViS2l0QWNjZXNzaWJsZUludGVyZmFj ZVRhYmxlLmNwcAorYWNjZXNzaWJpbGl0eS9hdGsvV2ViS2l0QWNjZXNzaWJsZUludGVyZmFjZVRh YmxlQ2VsbC5jcHAKK2FjY2Vzc2liaWxpdHkvYXRrL1dlYktpdEFjY2Vzc2libGVJbnRlcmZhY2VU ZXh0LmNwcAorYWNjZXNzaWJpbGl0eS9hdGsvV2ViS2l0QWNjZXNzaWJsZUludGVyZmFjZVZhbHVl LmNwcAorYWNjZXNzaWJpbGl0eS9hdGsvV2ViS2l0QWNjZXNzaWJsZVV0aWwuY3BwCithY2Nlc3Np YmlsaXR5L2F0ay9XZWJLaXRBY2Nlc3NpYmxlV3JhcHBlckF0ay5jcHAKKworZWRpdGluZy9hdGsv RnJhbWVTZWxlY3Rpb25BdGsuY3BwCisKK2xvYWRlci9zb3VwL0NhY2hlZFJhd1Jlc291cmNlU291 cC5jcHAKK2xvYWRlci9zb3VwL1N1YnJlc291cmNlTG9hZGVyU291cC5jcHAKKworcGFnZS9saW51 eC9SZXNvdXJjZVVzYWdlT3ZlcmxheUxpbnV4LmNwcAorcGFnZS9saW51eC9SZXNvdXJjZVVzYWdl VGhyZWFkTGludXguY3BwCisKK3BsYXRmb3JtL1Njcm9sbEFuaW1hdGlvbktpbmV0aWMuY3BwCitw bGF0Zm9ybS9TY3JvbGxBbmltYXRpb25TbW9vdGguY3BwCitwbGF0Zm9ybS9Vc2VyQWdlbnRRdWly a3MuY3BwCisKK3BsYXRmb3JtL2dlb2NsdWUvR2VvbG9jYXRpb25Qcm92aWRlckdlb2NsdWUuY3Bw CisKK3BsYXRmb3JtL2dyYXBoaWNzL0dMQ29udGV4dC5jcHAKK3BsYXRmb3JtL2dyYXBoaWNzL0dy YXBoaWNzQ29udGV4dDNEUHJpdmF0ZS5jcHAKKworcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vQmFj a2luZ1N0b3JlQmFja2VuZENhaXJvWDExLmNwcAorCitwbGF0Zm9ybS9ncmFwaGljcy9lZ2wvR0xD b250ZXh0RUdMLmNwcAorcGxhdGZvcm0vZ3JhcGhpY3MvZWdsL0dMQ29udGV4dEVHTFdheWxhbmQu Y3BwIEBuby11bmlmeQorcGxhdGZvcm0vZ3JhcGhpY3MvZWdsL0dMQ29udGV4dEVHTFgxMS5jcHAK KworcGxhdGZvcm0vZ3JhcGhpY3MvZ2x4L0dMQ29udGV4dEdMWC5jcHAKKworcGxhdGZvcm0vZ3Jh cGhpY3MvZ3N0cmVhbWVyL0ltYWdlR1N0cmVhbWVyQ2Fpcm8uY3BwCisKK3BsYXRmb3JtL2dyYXBo aWNzL29wZW5nbC9FeHRlbnNpb25zM0RPcGVuR0xDb21tb24uY3BwCitwbGF0Zm9ybS9ncmFwaGlj cy9vcGVuZ2wvR3JhcGhpY3NDb250ZXh0M0RPcGVuR0xDb21tb24uY3BwCitwbGF0Zm9ybS9ncmFw aGljcy9vcGVuZ2wvVGVtcG9yYXJ5T3BlbkdMU2V0dGluZy5jcHAKKworcGxhdGZvcm0vZ3JhcGhp Y3Mvb3BlbnR5cGUvT3BlblR5cGVWZXJ0aWNhbERhdGEuY3BwCisKK3BsYXRmb3JtL2dyYXBoaWNz L3dheWxhbmQvUGxhdGZvcm1EaXNwbGF5V2F5bGFuZC5jcHAKKworcGxhdGZvcm0vZ3JhcGhpY3Mv eDExL1BsYXRmb3JtRGlzcGxheVgxMS5jcHAKK3BsYXRmb3JtL2dyYXBoaWNzL3gxMS9YRXJyb3JU cmFwcGVyLmNwcAorcGxhdGZvcm0vZ3JhcGhpY3MveDExL1hVbmlxdWVSZXNvdXJjZS5jcHAKKwor cGxhdGZvcm0vZ3RrL0RyYWdEYXRhR3RrLmNwcAorcGxhdGZvcm0vZ3RrL0xvY2FsaXplZFN0cmlu Z3NHdGsuY3BwCitwbGF0Zm9ybS9ndGsvUGFzdGVib2FyZEd0ay5jcHAKK3BsYXRmb3JtL2d0ay9T Y3JvbGxBbmltYXRvckd0ay5jcHAKK3BsYXRmb3JtL2d0ay9TZWxlY3Rpb25EYXRhLmNwcAorCitw bGF0Zm9ybS90ZXh0L0h5cGhlbmF0aW9uLmNwcAorcGxhdGZvcm0vdGV4dC9Mb2NhbGVJQ1UuY3Bw CisKK3BsYXRmb3JtL3RleHQvZW5jaGFudC9UZXh0Q2hlY2tlckVuY2hhbnQuY3BwCisKK3BsYXRm b3JtL3RleHQvaHlwaGVuL0h5cGhlbmF0aW9uTGliSHlwaGVuLmNwcAorCitwbGF0Zm9ybS91bml4 L0xvZ2dpbmdVbml4LmNwcAorCitwbGF0Zm9ybS94ZGcvTUlNRVR5cGVSZWdpc3RyeVhkZy5jcHAK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL1NvdXJjZXNXUEUudHh0IGIvU291cmNlL1dlYkNv cmUvU291cmNlc1dQRS50eHQKaW5kZXggNGYyMTE5ZTg0Y2FmZjU3ZWNlNDJjZGVjNTUyMjY2Yzkx MGFlMGZhOC4uYTIwMDA4N2M4YTRlY2IzYTI4NjI5NThhNGI3OTFjNzM0Njc2MjZmYyAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvU291cmNlc1dQRS50eHQKKysrIGIvU291cmNlL1dlYkNvcmUv U291cmNlc1dQRS50eHQKQEAgLTM3LDYgKzM3LDkgQEAgcGFnZS9zY3JvbGxpbmcvY29vcmRpbmF0 ZWRncmFwaGljcy9TY3JvbGxpbmdTdGF0ZU5vZGVDb29yZGluYXRlZEdyYXBoaWNzLmNwcAogCiBw bGF0Zm9ybS9Vc2VyQWdlbnRRdWlya3MuY3BwCiAKKyMgVGhpcyBjYW4ndCBnbyBpbnRvIFNvdXJj ZXNHTGliLnR4dCBiZWNhdXNlIGl0IGhhcyB0byBnbyBpbnRvIFdlYkNvcmVQbGF0Zm9ybUdUSy4K K3BsYXRmb3JtL2dsaWIvRXZlbnRIYW5kbGVyR0xpYi5jcHAKKwogcGxhdGZvcm0vZ3JhcGhpY3Mv R0xDb250ZXh0LmNwcAogcGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3NDb250ZXh0M0RQcml2YXRl LmNwcAogcGxhdGZvcm0vZ3JhcGhpY3MvUGxhdGZvcm1EaXNwbGF5LmNwcAo=