178936 2017-10-27 06:48:08 -0700 [GTK][CMake] Incorrect conditional check when adding build dir to GIR runtime library path 2017-10-27 10:33:59 -0700 1 1 1 Unclassified WebKit WebKitGTK Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 aperez aperez bugs-noreply cgarcia clopez commit-queue mcatanzaro zan oldest_to_newest 1365344 0 aperez 2017-10-27 06:48:08 -0700 This, in “OptionsGTK.cmake”, around line 1113: string(COMPARE EQUAL "${PREV_LOADER_LIBRARY_PATH}" "" ld_library_path_not_exist) if (ld_library_path_does_not_exist) ... Notice the different spelling of the variable used for the condition. 1365345 1 325158 aperez 2017-10-27 06:52:07 -0700 Created attachment 325158 Patch 1365421 2 325158 commit-queue 2017-10-27 10:33:57 -0700 Comment on attachment 325158 Patch Clearing flags on attachment: 325158 Committed r224118: <https://trac.webkit.org/changeset/224118> 1365422 3 commit-queue 2017-10-27 10:33:59 -0700 All reviewed patches have been landed. Closing bug. 325158 2017-10-27 06:52:07 -0700 2017-10-27 10:33:57 -0700 Patch bug-178936-20171027165205.patch text/plain 1402 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjI0MTA3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDI2ODFlMmMxNzZjOGRmZTYy NGQ2ZGNhODE2ODU4MDY5NzdhZDQwNWQuLjE2YTQ1M2FjOWYyMjI3ZmQ3MDdjMzg0NTIwMzJhY2Rh ZGJhODc0OWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTctMTAtMjcgIEFkcmlhbiBQ ZXJleiBkZSBDYXN0cm8gIDxhcGVyZXpAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXVtDTWFr ZV0gSW5jb3JyZWN0IGNvbmRpdGlvbmFsIGNoZWNrIHdoZW4gYWRkaW5nIGJ1aWxkIGRpciB0byBH SVIgcnVudGltZSBsaWJyYXJ5IHBhdGgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE3ODkzNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogUGxhdGZvcm1HVEsuY21ha2U6IEZpeCBzcGVsbGluZyBvZiB2YXJp YWJsZSB1c2VkIGluIGNvbmRpdGlvbmFsLgorCiAyMDE3LTEwLTI3ICBEYXZpZCBLaWx6ZXIgIDxk ZGtpbHplckBhcHBsZS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTiAocjIyNDA3Nyk6IERlcHJl Y2F0ZWRHbG9iYWxTZXR0aW5nczo6c2V0QVZLaXRFbmFibGVkKCkgbm90IHByb3RlY3RlZCBieSBI QVZFKEFWS0lUKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9QbGF0Zm9ybUdUSy5jbWFrZSBi L1NvdXJjZS9XZWJLaXQvUGxhdGZvcm1HVEsuY21ha2UKaW5kZXggZDBjMjg5YzQ1NGExNzk2YjNj MWZhNTM4MmUzN2VmZDhhNDZkNjc5NC4uNzRiNTkyMjc1MjM0NjllNWRjMWRmMDJmMTVmYjRjMTY2 ZjI3MjllMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9QbGF0Zm9ybUdUSy5jbWFrZQorKysg Yi9Tb3VyY2UvV2ViS2l0L1BsYXRmb3JtR1RLLmNtYWtlCkBAIC0xMTEwLDcgKzExMTAsNyBAQCBl bHNlICgpCiAgICAgc2V0KFBSRVZfTE9BREVSX0xJQlJBUllfUEFUSCAiJEVOVntMRF9MSUJSQVJZ X1BBVEh9IikKIGVuZGlmICgpCiAKLXN0cmluZyhDT01QQVJFIEVRVUFMICIke1BSRVZfTE9BREVS X0xJQlJBUllfUEFUSH0iICIiIGxkX2xpYnJhcnlfcGF0aF9ub3RfZXhpc3QpCitzdHJpbmcoQ09N UEFSRSBFUVVBTCAiJHtQUkVWX0xPQURFUl9MSUJSQVJZX1BBVEh9IiAiIiBsZF9saWJyYXJ5X3Bh dGhfZG9lc19ub3RfZXhpc3QpCiBpZiAobGRfbGlicmFyeV9wYXRoX2RvZXNfbm90X2V4aXN0KQog ICAgIHNldChJTlRST1NQRUNUSU9OX0FERElUSU9OQUxfTElCUkFSWV9QQVRICiAgICAgICAgICIk e0NNQUtFX0xJQlJBUllfT1VUUFVUX0RJUkVDVE9SWX0iCg==