<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>178918</bug_id>
          
          <creation_ts>2017-10-26 18:33:00 -0700</creation_ts>
          <short_desc>[WPE] Build gst-plugins-base without pango support</short_desc>
          <delta_ts>2017-11-15 12:09:32 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WPE WebKit</component>
          <version>Other</version>
          <rep_platform>PC</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=178896</see_also>
    
    <see_also>https://bugs.webkit.org/show_bug.cgi?id=179171</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Michael Catanzaro">mcatanzaro</reporter>
          <assigned_to name="Michael Catanzaro">mcatanzaro</assigned_to>
          <cc>bugs-noreply</cc>
    
    <cc>cgarcia</cc>
    
    <cc>commit-queue</cc>
    
    <cc>mcatanzaro</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1365178</commentid>
    <comment_count>0</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2017-10-26 18:33:00 -0700</bug_when>
    <thetext>When trying to run dyz inside our jhbuild environment, I see the following error:

(gst-plugin-scanner:16711): GStreamer-WARNING **: Failed to load plugin &apos;/home/mcatanzaro/Projects/WebKit/WebKitBuild/DependenciesWPE/Root/lib/gstreamer-1.0/libgstpango.so&apos;: /lib64/libpango-1.0.so.0: undefined symbol: g_log_structured

The problem is that pango is missing from our jhbuild environment. The modulesets will never work reliably if we have system libraries in the middle of our dependency graph, since they will sometimes depend on newer versions of libraries than we have inside the jhbuild.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1365187</commentid>
    <comment_count>1</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2017-10-26 18:48:03 -0700</bug_when>
    <thetext>Specifically, in this case, our glib is so old that it does not contain the structured logging support required by my system copy of pango.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1365190</commentid>
    <comment_count>2</comment_count>
      <attachid>325096</attachid>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2017-10-26 18:51:54 -0700</bug_when>
    <thetext>Created attachment 325096
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1365276</commentid>
    <comment_count>3</comment_count>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2017-10-27 00:07:11 -0700</bug_when>
    <thetext>I don&apos;t think we should build pango. We could either bump the glib version, or build gst without pango.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1365357</commentid>
    <comment_count>4</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2017-10-27 08:24:06 -0700</bug_when>
    <thetext>(In reply to Carlos Garcia Campos from comment #3)
&gt; I don&apos;t think we should build pango. We could either bump the glib version,

That&apos;s not good enough, it will break again in the future. The jhbuild environment has to be complete or it won&apos;t be reliable.

&gt; or build gst without pango.

If that&apos;s possible, then this we could do. Let me check. (Anyway, I have absolutely no clue why GStreamer could possibly depend on pango.)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1365394</commentid>
    <comment_count>5</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2017-10-27 09:57:46 -0700</bug_when>
    <thetext>(In reply to Michael Catanzaro from comment #4)
&gt; If that&apos;s possible, then this we could do. Let me check. (Anyway, I have
&gt; absolutely no clue why GStreamer could possibly depend on pango.)

This works</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1365395</commentid>
    <comment_count>6</comment_count>
      <attachid>325169</attachid>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2017-10-27 09:59:18 -0700</bug_when>
    <thetext>Created attachment 325169
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1365736</commentid>
    <comment_count>7</comment_count>
      <attachid>325169</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2017-10-28 10:18:49 -0700</bug_when>
    <thetext>Comment on attachment 325169
Patch

Clearing flags on attachment: 325169

Committed r224151: &lt;https://trac.webkit.org/changeset/224151&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1365737</commentid>
    <comment_count>8</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2017-10-28 10:18:51 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>325096</attachid>
            <date>2017-10-26 18:51:54 -0700</date>
            <delta_ts>2017-10-27 09:59:16 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-178918-20171026205153.patch</filename>
            <type>text/plain</type>
            <size>2276</size>
            <attacher name="Michael Catanzaro">mcatanzaro</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjI0MDU3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg
Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOTliZDhlMGM4ZjZiMGNjYTA1NTljYTc0MTdkNDE0YTI0
ZTEzNzVhNS4uNjRlNjM3NWUyZDZhMDA5MTcwZmQ4MjdmZjIzOGE4OTlhYzYwNjBmMyAxMDA2NDQK
LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2
IEBACisyMDE3LTEwLTI2ICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNv
bT4KKworICAgICAgICBbV1BFXSBBZGQgcGFuZ28gdG8gamhidWlsZCBlbnZpcm9ubWVudAorICAg
ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc4OTE4CisKKyAg
ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIHBhbmdvIHRv
IG91ciBqaGJ1aWxkIGVudmlyb25tZW50LCBzaW5jZSBpdCdzIHJlcXVpcmVkIGJ5IEdTdHJlYW1l
ciBmb3Igc29tZSByZWFzb24sIGFuZAorICAgICAgICB0aGUgbW9kdWxlc2V0IHdpbGwgbmV2ZXIg
d29yayByZWxpYWJseSB3aXRob3V0IGl0LiBBbHNvLCBidWlsZCBoYXJmYnV6ei1nbGliLCB3aGlj
aCBpcworICAgICAgICByZXF1aXJlZCBieSBwYW5nby4KKworICAgICAgICAqIHdwZS9qaGJ1aWxk
Lm1vZHVsZXM6CisKIDIwMTctMTAtMjYgIEVyaWMgQ2FybHNvbiAgPGVyaWMuY2FybHNvbkBhcHBs
ZS5jb20+CiAKICAgICAgICAgTm93UGxheWluZ0luZm8gc2hvdWxkIGNvbnRhaW4gYSB1bmlxdWUg
aWRlbnRpZmllcgpkaWZmIC0tZ2l0IGEvVG9vbHMvd3BlL2poYnVpbGQubW9kdWxlcyBiL1Rvb2xz
L3dwZS9qaGJ1aWxkLm1vZHVsZXMKaW5kZXggYTEyMmViN2E5NGM3ODI5YWIwZjAyY2NkNjZlZjE5
MWNmMzZhZTNjYi4uOGU5YjAzMzcwYjM3NzA4NDE5OGM1MzRiYjBiMWNiYTY3MDRjMmM1MiAxMDA2
NDQKLS0tIGEvVG9vbHMvd3BlL2poYnVpbGQubW9kdWxlcworKysgYi9Ub29scy93cGUvamhidWls
ZC5tb2R1bGVzCkBAIC0yNCw2ICsyNCw3IEBACiAgICAgICA8ZGVwIHBhY2thZ2U9ImxpYmdjcnlw
dCIvPgogICAgICAgPGRlcCBwYWNrYWdlPSJsaWJlcG94eSIvPgogICAgICAgPGRlcCBwYWNrYWdl
PSJkeXoiLz4KKyAgICAgIDxkZXAgcGFja2FnZT0icGFuZ28iLz4KICAgICA8L2RlcGVuZGVuY2ll
cz4KICAgPC9tZXRhbW9kdWxlPgogCkBAIC0xMTksNyArMTIwLDcgQEAKICAgPC9hdXRvdG9vbHM+
CiAKICAgPGF1dG90b29scyBpZD0iaGFyZmJ1enoiIGF1dG9nZW4tc2g9ImNvbmZpZ3VyZSIKLSAg
ICAgICAgYXV0b2dlbmFyZ3M9Ii0td2l0aC1jYWlybz1ubyAtLXdpdGgtZ2xpYj1ubyAtLXdpdGgt
ZnJlZXR5cGU9eWVzIC0td2l0aC1mb250Y29uZmlnPXllcyI+CisgICAgICAgIGF1dG9nZW5hcmdz
PSItLXdpdGgtY2Fpcm89bm8gLS13aXRoLWZyZWV0eXBlPXllcyAtLXdpdGgtZm9udGNvbmZpZz15
ZXMiPgogICAgIDxkZXBlbmRlbmNpZXM+CiAgICAgICA8ZGVwIHBhY2thZ2U9ImZyZWV0eXBlNiIv
PgogICAgICAgPGRlcCBwYWNrYWdlPSJmb250Y29uZmlnIi8+CkBAIC0yMzYsNCArMjM3LDE5IEBA
CiAgICAgPC9kZXBlbmRlbmNpZXM+CiAgIDwvZGlzdHV0aWxzPgogCisgIDwhLS0gRGVwZW5kZW5j
aWVzIGxpc3RlZCBiZWxvdyB0aGlzIHBvaW50IGFyZSBub3QgdGhvdWdodCB0byBhZmZlY3QgdGVz
dCByZXN1bHRzLCBhbmQgYXJlIG9ubHkKKyAgICAgICBpbmNsdWRlZCBiZWNhdXNlIHRoZXkgdGhl
bXNlbHZlcyBkZXBlbmQgb24gb3RoZXIgZGVwZW5kZW5jaWVzIGJ1aWx0IGJ5IGpoYnVpbGQuIC0t
PgorCisgIDxhdXRvdG9vbHMgaWQ9InBhbmdvIgorCSAgICAgYXV0b2dlbi1zaD0iY29uZmlndXJl
IgorCSAgICAgYXV0b2dlbmFyZ3M9Ii0td2l0aC1jYWlybyAtLWRpc2FibGUtaW50cm9zcGVjdGlv
biI+CisgICAgPGJyYW5jaCBtb2R1bGU9InB1Yi9HTk9NRS9zb3VyY2VzL3BhbmdvLzEuNDAvcGFu
Z28tMS40MC41LnRhci54eiIgdmVyc2lvbj0iMS40MC41IgorCSAgICByZXBvPSJmdHAuZ25vbWUu
b3JnIgorCSAgICBoYXNoPSJzaGEyNTY6MjQ3NDgxNDA0NTZjNDIzNjBiMDdiMmM3N2ExYTJlMTIx
NmQwN2MwNTY2MzIwNzk1NTdjZDRlODE1YjlkMDFjOSIvPgorICAgIDxkZXBlbmRlbmNpZXM+Cisg
ICAgICA8ZGVwIHBhY2thZ2U9ImdsaWIiLz4KKyAgICAgIDxkZXAgcGFja2FnZT0iY2Fpcm8iLz4K
KyAgICA8L2RlcGVuZGVuY2llcz4KKyAgPC9hdXRvdG9vbHM+CisKIDwvbW9kdWxlc2V0Pgo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>325169</attachid>
            <date>2017-10-27 09:59:18 -0700</date>
            <delta_ts>2017-10-28 10:18:49 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-178918-20171027115917.patch</filename>
            <type>text/plain</type>
            <size>2308</size>
            <attacher name="Michael Catanzaro">mcatanzaro</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjI0MDgwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg
Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOTljNDBlZTQyYzAxNjUxMWY4ZWU3M2E5YmE2NjI0ODYy
NDY1MDNiNi4uMmE5YWE5NzRlZGMwODdmYjgwODkxNGMyYmE3M2QxOWE5ZDkzZjczMSAxMDA2NDQK
LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3
IEBACisyMDE3LTEwLTI3ICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNv
bT4KKworICAgICAgICBbV1BFXSBCdWlsZCBnc3QtcGx1Z2lucy1iYXNlIHdpdGhvdXQgcGFuZ28g
c3VwcG9ydAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9
MTc4OTE4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg
V2UgbmVlZCB0byBidWlsZCBnc3QtcGx1Z2lucy1iYXNlIHdpdGhvdXQgcGFuZ28gc3VwcG9ydCBm
b3IgV1BFLiBMZXQncyB1c2UgSkhCdWlsZAorICAgICAgICBjb25kaXRpb25zIHNvIHdlIGNhbiBt
YWtlIHBsYXRmb3JtLXNwZWNpZmljIGNoYW5nZXMgaW4gdGhlIHNoYXJlZCBHU3RyZWFtZXIgbW9k
dWxlc2V0LgorCisgICAgICAgICogZ3N0cmVhbWVyL2poYnVpbGQubW9kdWxlczoKKyAgICAgICAg
KiBndGsvamhidWlsZHJjOgorICAgICAgICAqIHdwZS9qaGJ1aWxkcmM6CisKIDIwMTctMTAtMjUg
IFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAgICAgV2hlbiBu
YXZpZ2F0aW5nIGJhY2sgdG8gYSBwYWdlLCBjb21wb3NpdGluZyBsYXllcnMgbWF5IG5vdCB1c2Ug
YWNjZWxlcmF0ZWQgZHJhd2luZwpkaWZmIC0tZ2l0IGEvVG9vbHMvZ3N0cmVhbWVyL2poYnVpbGQu
bW9kdWxlcyBiL1Rvb2xzL2dzdHJlYW1lci9qaGJ1aWxkLm1vZHVsZXMKaW5kZXggYmRmNzk4NGVk
OWVlYmRlMWE1NTU2YmM1NDVkNjIzYmVkNWNiOTg0ZC4uZWE2OTgxNTQzODVkOWZmMDk0ZTdmMjlh
Mzk2OTIzMzU0Y2VkNzE2OSAxMDA2NDQKLS0tIGEvVG9vbHMvZ3N0cmVhbWVyL2poYnVpbGQubW9k
dWxlcworKysgYi9Ub29scy9nc3RyZWFtZXIvamhidWlsZC5tb2R1bGVzCkBAIC01Nyw2ICs1Nyw5
IEBACiAgIDxhdXRvdG9vbHMgaWQ9ImdzdC1wbHVnaW5zLWJhc2UiCiAgICAgICAgICAgICAgYXV0
b2dlbi1zaD0iY29uZmlndXJlIgogICAgICAgICAgICAgIGF1dG9nZW5hcmdzPSItLWRpc2FibGUt
ZXhhbXBsZXMgLS1kaXNhYmxlLWd0ay1kb2MgLS1kaXNhYmxlLWludHJvc3BlY3Rpb24iPgorICAg
IDxpZiBjb25kaXRpb24tc2V0PSJ3cGUiPgorICAgICAgPGF1dG9nZW5hcmdzIHZhbHVlPSItLWRp
c2FibGUtcGFuZ28iLz4KKyAgICA8L2lmPgogICAgIDxkZXBlbmRlbmNpZXM+CiAgICAgICA8ZGVw
IHBhY2thZ2U9ImdzdHJlYW1lciIvPgogICAgIDwvZGVwZW5kZW5jaWVzPgpkaWZmIC0tZ2l0IGEv
VG9vbHMvZ3RrL2poYnVpbGRyYyBiL1Rvb2xzL2d0ay9qaGJ1aWxkcmMKaW5kZXggMWZmMzljNjA3
YmUxODA3N2EzNmYxNWRlMjI0OWY2OGVkNmZkMDg5YS4uMjJkMWRmZTQ3OWE2OTFkMWY2NjJlZmIx
ZDg3MjM2MmFlYjg3OGNjYSAxMDA2NDQKLS0tIGEvVG9vbHMvZ3RrL2poYnVpbGRyYworKysgYi9U
b29scy9ndGsvamhidWlsZHJjCkBAIC00MiwzICs0Miw1IEBAIGlmICdydW4nIG5vdCBpbiBzeXMu
YXJndjoKICAgICBvcy5lbnZpcm9uWydDWFhGTEFHUyddID0gJy1Xbm8tZXJyb3IgLU8yIC1nMScK
ICAgICAjIEZvciBidWlsZGluZyBnc3RyZWFtZXIgcGx1Z2lucyBvbiB0aGUgTWFjLgogICAgIG9z
LmVudmlyb25bJ09CSkNGTEFHUyddID0gJy1Xbm8tZXJyb3IgLU8yIC1nMScKKworY29uZGl0aW9u
cy5hZGQoJ2d0aycpCmRpZmYgLS1naXQgYS9Ub29scy93cGUvamhidWlsZHJjIGIvVG9vbHMvd3Bl
L2poYnVpbGRyYwppbmRleCBlMmZhODhkNzJhOWFhMjY0ODUzYWZmNTE0ODkyNDU3OGE2MTExOTQ0
Li45Njg5MDE2YmM3Mjk5NjkxZjFlNjBkODM5MDk1NzczZTY0MjE3M2QzIDEwMDY0NAotLS0gYS9U
b29scy93cGUvamhidWlsZHJjCisrKyBiL1Rvb2xzL3dwZS9qaGJ1aWxkcmMKQEAgLTIzLDMgKzIz
LDUgQEAgaW1wb3J0IGpoYnVpbGRyY19jb21tb24KIGpoYnVpbGRyY19jb21tb24uaW5pdChnbG9i
YWxzKCksICJ3cGUiKQogIyBFbmFibGUgYnVpbGRkaXIgIT0gc3JjZGlyIGJ1aWxkcy4KIGJ1aWxk
cm9vdCA9IG9zLnBhdGguam9pbihvcy5wYXRoLmRpcm5hbWUoY2hlY2tvdXRyb290KSwgIkJ1aWxk
IikKKworY29uZGl0aW9ucy5hZGQoJ3dwZScpCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>