178902 2017-10-26 17:12:37 -0700 Windows and WebViews are retained after re-configure 2018-06-29 15:23:45 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=186542 InRadar P2 Normal --- 1 jbedard jbedard aakash_jain ap commit-queue lforschler thorton webkit-bug-importer oldest_to_newest 1365131 0 jbedard 2017-10-26 17:12:37 -0700 Because the AutoRelease pool is declared in main, we don't release Windows and WebViews when a test changes configuration settings. This is, in effect, a memory leak when running layout tests. Note that this isn't the only memory leak when running WK2 layout tests. 1365134 1 webkit-bug-importer 2017-10-26 17:17:00 -0700 <rdar://problem/35211518> 1365135 2 webkit-bug-importer 2017-10-26 17:17:01 -0700 <rdar://problem/35211519> 1365146 3 325083 jbedard 2017-10-26 17:24:35 -0700 Created attachment 325083 Patch 1365167 4 325083 ap 2017-10-26 17:48:57 -0700 Comment on attachment 325083 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=325083&action=review > Tools/WebKitTestRunner/TestController.cpp:1180 > + WTF::AutodrainedPool pool; Please remove "WTF::", AutodrainedPool is exported to the global scope (as should all public WTF symbols). 1365354 5 325161 jbedard 2017-10-27 07:45:05 -0700 Created attachment 325161 Patch for landing 1365412 6 commit-queue 2017-10-27 10:21:16 -0700 The commit-queue encountered the following flaky tests while processing attachment 325161: The commit-queue is continuing to process your patch. 1365458 7 325161 commit-queue 2017-10-27 12:10:28 -0700 Comment on attachment 325161 Patch for landing Clearing flags on attachment: 325161 Committed r224124: <https://trac.webkit.org/changeset/224124> 1365459 8 commit-queue 2017-10-27 12:10:29 -0700 All reviewed patches have been landed. Closing bug. 325083 2017-10-26 17:24:35 -0700 2017-10-27 07:45:04 -0700 Patch bug-178902-20171026172434.patch text/plain 1677 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIyNDA3MSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE4IEBACisyMDE3LTEwLTI2ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBXaW5kb3dzIGFuZCBXZWJWaWV3cyBhcmUgcmV0YWluZWQgYWZ0ZXIgcmUt Y29uZmlndXJlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNzg5MDIKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzM1MjExNTE4PgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSB0ZXN0IHJ1bm5lciBlZmZl Y3RpdmVseSBsZWFrcyB3aW5kb3dzIGV2ZXJ5IHRpbWUgYSB0ZXN0IGNoYW5nZXMgY29uZmlndXJh dGlvbi4KKyAgICAgICAgV2UgZ2l2ZSBlYWNoIHRlc3QgaXQncyBvd24gQXV0b3JlbGVhc2VQb29s IHRvIGZpeCB0aGlzIHByb2JsZW0uCisKKyAgICAgICAgKiBXZWJLaXRUZXN0UnVubmVyL1Rlc3RD b250cm9sbGVyLmNwcDoKKyAgICAgICAgKFdUUjo6VGVzdENvbnRyb2xsZXI6OnJ1blRlc3QpOiBB ZGQgYW4gQXV0b1JlbGVhc2UgcG9vbCBzY29waW5nIGEgdGVzdCBydW4KKyAgICAgICAgc28gdGhh dCB3aGVuIGEgY29uZmlndXJhdGlvbiBjaGFuZ2VzLCB0aGUgb2xkIHdpbmRvdyBhbmQgV2ViVmll dyBhcmUgcmVsZWFzZWQuCisKIDIwMTctMTAtMjYgIEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0 ZW5zZW5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBNb3ZlIFdLV2ViVmlld0NvbmZpZ3VyYXRpb24g dmFsaWRhdGlvbiB0byBXS1dlYlZpZXcgY29uc3RydWN0aW9uCkluZGV4OiBUb29scy9XZWJLaXRU ZXN0UnVubmVyL1Rlc3RDb250cm9sbGVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9XZWJLaXRU ZXN0UnVubmVyL1Rlc3RDb250cm9sbGVyLmNwcAkocmV2aXNpb24gMjIzODkyKQorKysgVG9vbHMv V2ViS2l0VGVzdFJ1bm5lci9UZXN0Q29udHJvbGxlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTY3 LDYgKzY3LDcgQEAKICNpbmNsdWRlIDxzdGRsaWIuaD4KICNpbmNsdWRlIDxzdHJpbmc+CiAjaW5j bHVkZSA8dW5pc3RkLmg+CisjaW5jbHVkZSA8d3RmL0F1dG9kcmFpbmVkUG9vbC5oPgogI2luY2x1 ZGUgPHd0Zi9DcnlwdG9ncmFwaGljYWxseVJhbmRvbU51bWJlci5oPgogI2luY2x1ZGUgPHd0Zi9I ZXhOdW1iZXIuaD4KICNpbmNsdWRlIDx3dGYvTWFpblRocmVhZC5oPgpAQCAtMTE3Niw2ICsxMTc3 LDggQEAgVGVzdENvbW1hbmQgcGFyc2VJbnB1dExpbmUoY29uc3Qgc3RkOjpzdAogCiBib29sIFRl c3RDb250cm9sbGVyOjpydW5UZXN0KGNvbnN0IGNoYXIqIGlucHV0TGluZSkKIHsKKyAgICBXVEY6 OkF1dG9kcmFpbmVkUG9vbCBwb29sOworICAgIAogICAgIFdLVGV4dENoZWNrZXJTZXRUZXN0aW5n TW9kZSh0cnVlKTsKICAgICBUZXN0Q29tbWFuZCBjb21tYW5kID0gcGFyc2VJbnB1dExpbmUoc3Rk OjpzdHJpbmcoaW5wdXRMaW5lKSk7CiAK 325161 2017-10-27 07:45:05 -0700 2017-10-27 12:10:28 -0700 Patch for landing bug-178902-20171027074505.patch text/plain 1691 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIyNDEwOSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE4IEBACisyMDE3LTEwLTI3ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBXaW5kb3dzIGFuZCBXZWJWaWV3cyBhcmUgcmV0YWluZWQgYWZ0ZXIgcmUt Y29uZmlndXJlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNzg5MDIKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzM1MjExNTE4PgorCisgICAgICAgIFJl dmlld2VkIGJ5IEFsZXhleSBQcm9za3VyeWFrb3YuCisKKyAgICAgICAgVGhlIHRlc3QgcnVubmVy IGVmZmVjdGl2ZWx5IGxlYWtzIHdpbmRvd3MgZXZlcnkgdGltZSBhIHRlc3QgY2hhbmdlcyBjb25m aWd1cmF0aW9uLgorICAgICAgICBXZSBnaXZlIGVhY2ggdGVzdCBpdCdzIG93biBBdXRvcmVsZWFz ZVBvb2wgdG8gZml4IHRoaXMgcHJvYmxlbS4KKworICAgICAgICAqIFdlYktpdFRlc3RSdW5uZXIv VGVzdENvbnRyb2xsZXIuY3BwOgorICAgICAgICAoV1RSOjpUZXN0Q29udHJvbGxlcjo6cnVuVGVz dCk6IEFkZCBhbiBBdXRvUmVsZWFzZSBwb29sIHNjb3BpbmcgYSB0ZXN0IHJ1bgorICAgICAgICBz byB0aGF0IHdoZW4gYSBjb25maWd1cmF0aW9uIGNoYW5nZXMsIHRoZSBvbGQgd2luZG93IGFuZCBX ZWJWaWV3IGFyZSByZWxlYXNlZC4KKwogMjAxNy0xMC0yNiAgRnVqaWkgSGlyb25vcmkgIDxIaXJv bm9yaS5GdWppaUBzb255LmNvbT4KIAogICAgICAgICBbR1RLXVtXUEVdIGluc3RhbGwtZGVwZW5k ZW5jaWVzIGNhbid0IGZpbmQgbGliYXBhY2hlMi1tb2QtcGhwNy4wIG9uIFVidW50dSAxNy4xMApJ bmRleDogVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9UZXN0Q29udHJvbGxlci5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9UZXN0Q29udHJvbGxlci5jcHAJKHJldmlzaW9u IDIyNDEwOSkKKysrIFRvb2xzL1dlYktpdFRlc3RSdW5uZXIvVGVzdENvbnRyb2xsZXIuY3BwCSh3 b3JraW5nIGNvcHkpCkBAIC02Nyw2ICs2Nyw3IEBACiAjaW5jbHVkZSA8c3RkbGliLmg+CiAjaW5j bHVkZSA8c3RyaW5nPgogI2luY2x1ZGUgPHVuaXN0ZC5oPgorI2luY2x1ZGUgPHd0Zi9BdXRvZHJh aW5lZFBvb2wuaD4KICNpbmNsdWRlIDx3dGYvQ3J5cHRvZ3JhcGhpY2FsbHlSYW5kb21OdW1iZXIu aD4KICNpbmNsdWRlIDx3dGYvSGV4TnVtYmVyLmg+CiAjaW5jbHVkZSA8d3RmL01haW5UaHJlYWQu aD4KQEAgLTExNzYsNiArMTE3Nyw4IEBAIFRlc3RDb21tYW5kIHBhcnNlSW5wdXRMaW5lKGNvbnN0 IHN0ZDo6c3QKIAogYm9vbCBUZXN0Q29udHJvbGxlcjo6cnVuVGVzdChjb25zdCBjaGFyKiBpbnB1 dExpbmUpCiB7CisgICAgQXV0b2RyYWluZWRQb29sIHBvb2w7CisgICAgCiAgICAgV0tUZXh0Q2hl Y2tlclNldFRlc3RpbmdNb2RlKHRydWUpOwogICAgIFRlc3RDb21tYW5kIGNvbW1hbmQgPSBwYXJz ZUlucHV0TGluZShzdGQ6OnN0cmluZyhpbnB1dExpbmUpKTsKIAo=