178895 2017-10-26 16:46:31 -0700 Web Automation: denying user permission for getUserMedia doesn't work 2017-10-26 19:32:08 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 bburg bburg bburg commit-queue inspector-bugzilla-changes webkit-bug-importer youennf oldest_to_newest 1365108 0 bburg 2017-10-26 16:46:31 -0700 The ordering of special cases is incorrect. Our hardcoded "allow mock devices and don't prompt for them" settings are short-circuiting the automation session's getUserMedia permission check. 1365109 1 bburg 2017-10-26 16:46:42 -0700 rdar://problem/35210121 1365110 2 325079 bburg 2017-10-26 16:50:35 -0700 Created attachment 325079 Proposed Fix 1365119 3 youennf 2017-10-26 16:53:25 -0700 LGTM. At some point, we might want to remove mockCaptureDevicesPromptEnabled since WebDriver is a better solution. 1365207 4 325079 commit-queue 2017-10-26 19:32:07 -0700 Comment on attachment 325079 Proposed Fix Clearing flags on attachment: 325079 Committed r224082: <https://trac.webkit.org/changeset/224082> 1365208 5 commit-queue 2017-10-26 19:32:08 -0700 All reviewed patches have been landed. Closing bug. 325079 2017-10-26 16:50:35 -0700 2017-10-26 19:32:07 -0700 Proposed Fix bug-178895-20171026165034.patch text/plain 3429 bburg U3VidmVyc2lvbiBSZXZpc2lvbjogMjIzOTU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDVjYzk0NWM0OTQ0ODg4Nzc5 MzA3ZWY3NWQ3MmJiYjcwOGE0NDM4MDUuLmNkNGE5OTI1NDY0ZGIzMzFlYzQ2NjdiZjAwYzQwNzU2 YmUwMGRiM2IgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTctMTAtMjYgIEJyaWFuIEJ1 cmcgIDxiYnVyZ0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEF1dG9tYXRpb246IGRlbnlpbmcg dXNlciBwZXJtaXNzaW9uIGZvciBnZXRVc2VyTWVkaWEgZG9lc24ndCB3b3JrCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzg4OTUKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9Vc2VyTWVk aWFQZXJtaXNzaW9uUmVxdWVzdE1hbmFnZXJQcm94eS5jcHA6CisgICAgICAgIChXZWJLaXQ6OlVz ZXJNZWRpYVBlcm1pc3Npb25SZXF1ZXN0TWFuYWdlclByb3h5OjpyZXF1ZXN0VXNlck1lZGlhUGVy bWlzc2lvbkZvckZyYW1lKToKKyAgICAgICAgVGhlIG9yZGVyaW5nIG9mIHNwZWNpYWwgY2FzZXMg aXMgaW5jb3JyZWN0LiBTYWZhcmkgY29uZmlndXJlcyBpdHMgYXV0b21hdGlvbiB2aWV3cyB0bwor ICAgICAgICBhbGxvdyBtb2NrIGRldmljZXMgYW5kIG5ldmVyIHByb21wdCBmb3IgdGhlbS4gVGhl c2UgY2hlY2tzIHdlcmUgYmVmb3JlIHRoZSBjaGVjayBmb3IKKyAgICAgICAgdGhlIGF1dG9tYXRp b24gc2Vzc2lvbidzIGdldFVzZXJNZWRpYSBwZXJtaXNzaW9uLiBTd2l0Y2ggdGhlc2UgY2hlY2tz LgorCisgICAgICAgIEFsc28gY2hhbmdlIHRoZSBkZW55IHJlYXNvbiBzbyB0aGF0IHN1YnNlcXVl bnQgcmVxdWVzdHMgYXJlIGFsc28gZGVuaWVkLiBUaGlzIG1hdGNoZXMKKyAgICAgICAgYmVoYXZp b3Igd2hlbiBhIHVzZXIgZGVuaWVzIGEgcGVybWlzc2lvbiByZXF1ZXN0IG9uIGEgcmVhbCBkaWFs b2cuIFdpdGggdGhpcyBjaGFuZ2UsCisgICAgICAgIHRoZSBET00gZXJyb3IgY2hhbmdlcyBmcm9t IFNlY3VyaXR5RXJyb3IgdG8gTm90QWxsb3dlZEVycm9yLCB3aGljaCBtYWtlcyBtb3JlIHNlbnNl LgorCiAyMDE3LTEwLTI1ICBBZHJpYW4gUGVyZXogZGUgQ2FzdHJvICA8YXBlcmV6QGlnYWxpYS5j b20+CiAKICAgICAgICAgW1dQRV0gUmVtb3ZlIEdMaWIgQVBJIGZ1bmN0aW9ucyB3aGljaCB1c2Ug Q2Fpcm8KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1VzZXJNZWRpYVBlcm1p c3Npb25SZXF1ZXN0TWFuYWdlclByb3h5LmNwcCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1Vz ZXJNZWRpYVBlcm1pc3Npb25SZXF1ZXN0TWFuYWdlclByb3h5LmNwcAppbmRleCAxMDY5NmQyNWFm MDMwMGVmYWZiYzlkMmZkMjE1MTdjZDJlNDVhMDEwLi44ZjVmNjFmOWNmODgzYzAzNWE3MTY1MWQz ZGZiYTk5NTY1MGFhODllIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9Vc2Vy TWVkaWFQZXJtaXNzaW9uUmVxdWVzdE1hbmFnZXJQcm94eS5jcHAKKysrIGIvU291cmNlL1dlYktp dC9VSVByb2Nlc3MvVXNlck1lZGlhUGVybWlzc2lvblJlcXVlc3RNYW5hZ2VyUHJveHkuY3BwCkBA IC0yOTgsMjIgKzI5OCwyMiBAQCB2b2lkIFVzZXJNZWRpYVBlcm1pc3Npb25SZXF1ZXN0TWFuYWdl clByb3h5OjpyZXF1ZXN0VXNlck1lZGlhUGVybWlzc2lvbkZvckZyYW1lKAogCiAgICAgICAgIGF1 dG8gcmVxdWVzdCA9IGNyZWF0ZVJlcXVlc3QodXNlck1lZGlhSUQsIG1fcGFnZS5tYWluRnJhbWUo KS0+ZnJhbWVJRCgpLCBmcmFtZUlELCBXVEZNb3ZlKHVzZXJNZWRpYURvY3VtZW50T3JpZ2luKSwg V1RGTW92ZSh0b3BMZXZlbERvY3VtZW50T3JpZ2luKSwgV1RGTW92ZShhdWRpb0RldmljZVVJRHMp LCBXVEZNb3ZlKHZpZGVvRGV2aWNlVUlEcyksIFdURk1vdmUoZGV2aWNlSWRlbnRpZmllckhhc2hT YWx0KSk7CiAKLSAgICAgICAgaWYgKG1fcGFnZS5wcmVmZXJlbmNlcygpLm1vY2tDYXB0dXJlRGV2 aWNlc0VuYWJsZWQoKSAmJiAhbV9wYWdlLnByZWZlcmVuY2VzKCkubW9ja0NhcHR1cmVEZXZpY2Vz UHJvbXB0RW5hYmxlZCgpKSB7Ci0gICAgICAgICAgICBhbGxvd1JlcXVlc3QocmVxdWVzdCk7Ci0g ICAgICAgICAgICByZXR1cm47Ci0gICAgICAgIH0KLSAgICAgICAgCiAgICAgICAgIGlmIChtX3Bh Z2UuaXNDb250cm9sbGVkQnlBdXRvbWF0aW9uKCkpIHsKICAgICAgICAgICAgIGlmIChXZWJBdXRv bWF0aW9uU2Vzc2lvbiogYXV0b21hdGlvblNlc3Npb24gPSBtX3BhZ2UucHJvY2VzcygpLnByb2Nl c3NQb29sKCkuYXV0b21hdGlvblNlc3Npb24oKSkgewogICAgICAgICAgICAgICAgIGlmIChhdXRv bWF0aW9uU2Vzc2lvbi0+c2hvdWxkQWxsb3dHZXRVc2VyTWVkaWFGb3JQYWdlKG1fcGFnZSkpCiAg ICAgICAgICAgICAgICAgICAgIGFsbG93UmVxdWVzdChyZXF1ZXN0KTsKICAgICAgICAgICAgICAg ICBlbHNlCi0gICAgICAgICAgICAgICAgICAgIHVzZXJNZWRpYUFjY2Vzc1dhc0RlbmllZCh1c2Vy TWVkaWFJRCwgVXNlck1lZGlhUGVybWlzc2lvblJlcXVlc3RQcm94eTo6VXNlck1lZGlhQWNjZXNz RGVuaWFsUmVhc29uOjpVc2VyTWVkaWFEaXNhYmxlZCk7CisgICAgICAgICAgICAgICAgICAgIHVz ZXJNZWRpYUFjY2Vzc1dhc0RlbmllZCh1c2VyTWVkaWFJRCwgVXNlck1lZGlhUGVybWlzc2lvblJl cXVlc3RQcm94eTo6VXNlck1lZGlhQWNjZXNzRGVuaWFsUmVhc29uOjpQZXJtaXNzaW9uRGVuaWVk KTsKIAogICAgICAgICAgICAgICAgIHJldHVybjsKICAgICAgICAgICAgIH0KICAgICAgICAgfQog CisgICAgICAgIGlmIChtX3BhZ2UucHJlZmVyZW5jZXMoKS5tb2NrQ2FwdHVyZURldmljZXNFbmFi bGVkKCkgJiYgIW1fcGFnZS5wcmVmZXJlbmNlcygpLm1vY2tDYXB0dXJlRGV2aWNlc1Byb21wdEVu YWJsZWQoKSkgeworICAgICAgICAgICAgYWxsb3dSZXF1ZXN0KHJlcXVlc3QpOworICAgICAgICAg ICAgcmV0dXJuOworICAgICAgICB9CisKICAgICAgICAgaWYgKCFtX3BhZ2UudWlDbGllbnQoKS5k ZWNpZGVQb2xpY3lGb3JVc2VyTWVkaWFQZXJtaXNzaW9uUmVxdWVzdChtX3BhZ2UsICptX3BhZ2Uu cHJvY2VzcygpLndlYkZyYW1lKGZyYW1lSUQpLCBXVEZNb3ZlKHVzZXJNZWRpYU9yaWdpbiksIFdU Rk1vdmUodG9wTGV2ZWxPcmlnaW4pLCByZXF1ZXN0LmdldCgpKSkKICAgICAgICAgICAgIHVzZXJN ZWRpYUFjY2Vzc1dhc0RlbmllZCh1c2VyTWVkaWFJRCwgVXNlck1lZGlhUGVybWlzc2lvblJlcXVl c3RQcm94eTo6VXNlck1lZGlhQWNjZXNzRGVuaWFsUmVhc29uOjpVc2VyTWVkaWFEaXNhYmxlZCk7 CiAgICAgfTsK