178893 2017-10-26 16:26:07 -0700 Revisit WebKit api pattern where Page owns the client. 2017-10-26 16:26:25 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified NEW P2 Normal --- 1 jeremyj-wk webkit-unassigned oldest_to_newest 1365086 0 jeremyj-wk 2017-10-26 16:26:07 -0700 > This API seems a bit weird. Normally you don't pass ownership of a client to > the thing that it's a client of. You hold ownership, and the client > relationship is weak. Search for '_page->set[a-zA-Z]*Client\(' shows this pattern in lots of places: _page->setFindClient(std::make_unique<WebKit::FindClient>(self)); _page->setDiagnosticLoggingClient(std::make_unique<WebKit::DiagnosticLoggingClient>(self)); _page->setNavigationClient(_navigationState->createNavigationClient()); _page->setContextMenuClient(_uiDelegate->createContextMenuClient()); _page->setUIClient(_uiDelegate->createUIClient()); _page->setIconLoadingClient(_iconLoadingDelegate->createIconLoadingClient()); _page->setHistoryClient(_navigationState->createHistoryClient()); _page->setFormClient(std::make_unique<FormClient>(self)); m_page->setFullscreenClient(std::make_unique<WebKit::FullscreenClient>(view)); _page->setFindMatchesClient(std::make_unique<TextFinderFindClient>(self)); Maybe this should be revisited 1365087 1 jeremyj-wk 2017-10-26 16:26:25 -0700 From comments on https://bugs.webkit.org/show_bug.cgi?id=178089