178886 2017-10-26 14:35:29 -0700 Audit init*Event() method to make sure they reset internal data members 2017-10-28 17:48:34 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=178670 P2 Normal --- 1 cdumez cdumez buildbot commit-queue darin dbates esprehn+autocc kangil.han rniwa oldest_to_newest 1365027 0 cdumez 2017-10-26 14:35:29 -0700 Audit init*Event() method to make sure they reset internal data members. 1365028 1 325055 cdumez 2017-10-26 14:36:35 -0700 Created attachment 325055 Patch 1365386 2 325055 cdumez 2017-10-27 09:50:15 -0700 Comment on attachment 325055 Patch r224115 1365440 3 325055 darin 2017-10-27 11:00:18 -0700 Comment on attachment 325055 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=325055&action=review > Source/WebCore/dom/MouseRelatedEvent.h:58 > + void setIsSimulated(bool value) { m_isSimulated = value; } protected instead? 1365441 4 darin 2017-10-27 11:00:44 -0700 If there was any effect of these changes, it would be nice to cover the effect in tests. Of course, the effects might be subtle so it might be hard to write tests. 1365773 5 325055 darin 2017-10-28 17:48:34 -0700 Comment on attachment 325055 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=325055&action=review > Source/WebCore/dom/Event.cpp:93 > + m_underlyingEvent = nullptr; This doesn’t cover everything. A website could call initEvent on, say, a MouseEvent, and we might want it to reset a data member such as MouseEvent::m_dataTransfer. I am not sure what we should do about this. 325055 2017-10-26 14:36:35 -0700 2017-10-27 09:50:15 -0700 Patch bug-178886-20171026143634.patch text/plain 6766 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjI0MDQzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDNlN2UzYjhhMDJkYWEx MjE4YjJiYzgxNjRlNWZkNDhmZDdkNzQ2ZC4uNTIyMWVkYjhhZWJhZjdhN2M4NjY2MzEzNTY5OTZj N2Y1ZTQ1NThmMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI5IEBACiAyMDE3LTEwLTI2ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKKyAgICAgICAgQXVkaXQgaW5pdCpFdmVudCgp IG1ldGhvZCB0byBtYWtlIHN1cmUgdGhleSByZXNldCBpbnRlcm5hbCBkYXRhIG1lbWJlcnMKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3ODg4NgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEF1ZGl0IGluaXQq RXZlbnQoKSBtZXRob2QgdG8gbWFrZSBzdXJlIHRoZXkgcmVzZXQgaW50ZXJuYWwgZGF0YSBtZW1i ZXJzLgorCisgICAgICAgICogZG9tL0V2ZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkV2ZW50 Ojppbml0RXZlbnQpOgorICAgICAgICAqIGRvbS9LZXlib2FyZEV2ZW50LmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OktleWJvYXJkRXZlbnQ6OmluaXRLZXlib2FyZEV2ZW50KToKKyAgICAgICAgKiBk b20vTWVzc2FnZUV2ZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok1lc3NhZ2VFdmVudDo6aW5p dE1lc3NhZ2VFdmVudCk6CisgICAgICAgICogZG9tL01vdXNlRXZlbnQuY3BwOgorICAgICAgICAo V2ViQ29yZTo6TW91c2VFdmVudDo6aW5pdE1vdXNlRXZlbnQpOgorICAgICAgICAqIGRvbS9Nb3Vz ZVJlbGF0ZWRFdmVudC5oOgorICAgICAgICAoV2ViQ29yZTo6TW91c2VSZWxhdGVkRXZlbnQ6OnNl dElzU2ltdWxhdGVkKToKKyAgICAgICAgKiBkb20vVGV4dEV2ZW50LmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OlRleHRFdmVudDo6aW5pdFRleHRFdmVudCk6CisgICAgICAgICogZG9tL1doZWVsRXZl bnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6V2hlZWxFdmVudDo6aW5pdFdoZWVsRXZlbnQpOgor CisyMDE3LTEwLTI2ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKICAgICAgICAg QnJpbmcgYmFjayBTV0NvbnRleHRNYW5hZ2VyIGFic3RyYWN0aW9uIGluIFdlYkNvcmUKICAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3ODg3NgogCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vRXZlbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvZG9t L0V2ZW50LmNwcAppbmRleCBkMzNjYmE2ZTA5OTllMzI0ZmY5Yzc1MTI5MTE5OTAwMDY0MDIwNGJj Li4xNGI1MjI5ZTU0Y2M4ZDFmMDMzMTIyN2QyNTVjYzBlZDZmODM1YWQ0IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9kb20vRXZlbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9FdmVu dC5jcHAKQEAgLTg5LDYgKzg5LDggQEAgdm9pZCBFdmVudDo6aW5pdEV2ZW50KGNvbnN0IEF0b21p Y1N0cmluZyYgZXZlbnRUeXBlQXJnLCBib29sIGNhbkJ1YmJsZUFyZywgYm9vbAogICAgIG1fdHlw ZSA9IGV2ZW50VHlwZUFyZzsKICAgICBtX2NhbkJ1YmJsZSA9IGNhbkJ1YmJsZUFyZzsKICAgICBt X2NhbmNlbGFibGUgPSBjYW5jZWxhYmxlQXJnOworCisgICAgbV91bmRlcmx5aW5nRXZlbnQgPSBu dWxscHRyOwogfQogCiBib29sIEV2ZW50Ojpjb21wb3NlZCgpIGNvbnN0CmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9kb20vS2V5Ym9hcmRFdmVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9kb20v S2V5Ym9hcmRFdmVudC5jcHAKaW5kZXggNDAzYWZhOTU0MGU5MDM3MDY2MzI4ZGZkZWNlNzc4ODg1 MWUwMzIwYi4uYTdlOTI1M2M2NDVmOWJkZmFiOTI2OWY4NTUxYTE1M2Q0YzY5YjA3MyAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL0tleWJvYXJkRXZlbnQuY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL2RvbS9LZXlib2FyZEV2ZW50LmNwcApAQCAtMTU3LDYgKzE1Nyw3IEBAIHZvaWQgS2V5 Ym9hcmRFdmVudDo6aW5pdEtleWJvYXJkRXZlbnQoY29uc3QgQXRvbWljU3RyaW5nJiB0eXBlLCBi b29sIGNhbkJ1YmJsZSwKIAogICAgIGluaXRVSUV2ZW50KHR5cGUsIGNhbkJ1YmJsZSwgY2FuY2Vs YWJsZSwgdmlldywgMCk7CiAKKyAgICBtX2tleUV2ZW50ID0gbnVsbHB0cjsKICAgICBtX2tleUlk ZW50aWZpZXIgPSBrZXlJZGVudGlmaWVyOwogICAgIG1fbG9jYXRpb24gPSBsb2NhdGlvbjsKICAg ICBtX2N0cmxLZXkgPSBjdHJsS2V5OwpAQCAtMTY0LDYgKzE2NSwxMSBAQCB2b2lkIEtleWJvYXJk RXZlbnQ6OmluaXRLZXlib2FyZEV2ZW50KGNvbnN0IEF0b21pY1N0cmluZyYgdHlwZSwgYm9vbCBj YW5CdWJibGUsCiAgICAgbV9hbHRLZXkgPSBhbHRLZXk7CiAgICAgbV9tZXRhS2V5ID0gbWV0YUtl eTsKICAgICBtX2FsdEdyYXBoS2V5ID0gYWx0R3JhcGhLZXk7CisKKyNpZiBQTEFURk9STShDT0NP QSkKKyAgICBtX2hhbmRsZWRCeUlucHV0TWV0aG9kID0gZmFsc2U7CisgICAgbV9rZXlwcmVzc0Nv bW1hbmRzID0geyB9OworI2VuZGlmCiB9CiAKIGJvb2wgS2V5Ym9hcmRFdmVudDo6Z2V0TW9kaWZp ZXJTdGF0ZShjb25zdCBTdHJpbmcmIGtleUlkZW50aWZpZXIpIGNvbnN0CmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9kb20vTWVzc2FnZUV2ZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9N ZXNzYWdlRXZlbnQuY3BwCmluZGV4IGU5ODg5ZTU2Y2ZmMTUzMDNjODBjMjU3Yjc4YjQxMjBhZjFm NDQyOTguLjRiODBkY2YxYTNlYzIwYTc5NjhmYTQ3NGIyMjQ3YTViM2M4YmU2ZjAgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9NZXNzYWdlRXZlbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL2RvbS9NZXNzYWdlRXZlbnQuY3BwCkBAIC0xNDQsNiArMTQ0LDkgQEAgdm9pZCBNZXNzYWdl RXZlbnQ6OmluaXRNZXNzYWdlRXZlbnQoRXhlY1N0YXRlJiBzdGF0ZSwgY29uc3QgQXRvbWljU3Ry aW5nJiB0eXBlLAogICAgIG1fZGF0YUFzU2NyaXB0VmFsdWUgPSBEZXByZWNhdGVkOjpTY3JpcHRW YWx1ZShzdGF0ZS52bSgpLCBkYXRhKTsKICAgICBtX2RhdGFBc1NlcmlhbGl6ZWRTY3JpcHRWYWx1 ZSA9IG51bGxwdHI7CiAgICAgbV90cmllZFRvU2VyaWFsaXplID0gZmFsc2U7CisgICAgbV9kYXRh QXNTdHJpbmcgPSB7IH07CisgICAgbV9kYXRhQXNCbG9iID0gbnVsbHB0cjsKKyAgICBtX2RhdGFB c0FycmF5QnVmZmVyID0gbnVsbHB0cjsKICAgICBtX29yaWdpbiA9IG9yaWdpbjsKICAgICBtX2xh c3RFdmVudElkID0gbGFzdEV2ZW50SWQ7CiAgICAgbV9zb3VyY2UgPSBXVEZNb3ZlKHNvdXJjZSk7 CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vTW91c2VFdmVudC5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9kb20vTW91c2VFdmVudC5jcHAKaW5kZXggMDBkMDVkZWJjMzZiZGJhZDk0MThlZTAw OTAxZjk5MjdiOWI5NDQyNi4uYzA2ZGZhYjliNTA0NDdhOThkMWY0ODcwZjZkMDYwY2Q3ZmRjNjYx YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL01vdXNlRXZlbnQuY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL2RvbS9Nb3VzZUV2ZW50LmNwcApAQCAtMTQ2LDggKzE0Niw4IEBAIHZvaWQg TW91c2VFdmVudDo6aW5pdE1vdXNlRXZlbnQoY29uc3QgQXRvbWljU3RyaW5nJiB0eXBlLCBib29s IGNhbkJ1YmJsZSwgYm9vbCBjCiAKICAgICBpbml0Q29vcmRpbmF0ZXMoSW50UG9pbnQoY2xpZW50 WCwgY2xpZW50WSkpOwogCi0gICAgLy8gRklYTUU6IG1faXNTaW11bGF0ZWQgaXMgbm90IHNldCB0 byBmYWxzZSBoZXJlLgotICAgIC8vIEZJWE1FOiBtX2RhdGFUcmFuc2ZlciBpcyBub3Qgc2V0IHRv IDAgaGVyZS4KKyAgICBzZXRJc1NpbXVsYXRlZChmYWxzZSk7CisgICAgbV9kYXRhVHJhbnNmZXIg PSBudWxscHRyOwogfQogCiAvLyBGSVhNRTogV2UgbmVlZCB0aGlzIHF1aXJrIGJlY2F1c2UgaUFk IFByb2R1Y2VyIGlzIGNhbGxpbmcgdGhpcyBmdW5jdGlvbiB3aXRoIGEgcmVsYXRlZFRhcmdldCB0 aGF0IGlzIG5vdCBhbiBFdmVudFRhcmdldCAocmRhcjovL3Byb2JsZW0vMzA2NDAxMDEpLgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL01vdXNlUmVsYXRlZEV2ZW50LmggYi9Tb3VyY2Uv V2ViQ29yZS9kb20vTW91c2VSZWxhdGVkRXZlbnQuaAppbmRleCBlMzVkMjkzYzQxMTRmMDU5M2Yz YzllZGRlYWZiMzIwMmQwMDEwZjhjLi4wZDgzYzM2MDlmNzFlYWZlZjIxNzFhOWNkMGQ0MzFhZTZk ODU0ZjhiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vTW91c2VSZWxhdGVkRXZlbnQu aAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vTW91c2VSZWxhdGVkRXZlbnQuaApAQCAtNTUsNiAr NTUsNyBAQCBwdWJsaWM6CiAgICAgV0VCQ09SRV9FWFBPUlQgaW50IG9mZnNldFgoKTsKICAgICBX RUJDT1JFX0VYUE9SVCBpbnQgb2Zmc2V0WSgpOwogICAgIGJvb2wgaXNTaW11bGF0ZWQoKSBjb25z dCB7IHJldHVybiBtX2lzU2ltdWxhdGVkOyB9CisgICAgdm9pZCBzZXRJc1NpbXVsYXRlZChib29s IHZhbHVlKSB7IG1faXNTaW11bGF0ZWQgPSB2YWx1ZTsgfQogICAgIGludCBwYWdlWCgpIGNvbnN0 IGZpbmFsOwogICAgIGludCBwYWdlWSgpIGNvbnN0IGZpbmFsOwogICAgIFdFQkNPUkVfRVhQT1JU IEZsb2F0UG9pbnQgbG9jYXRpb25JblJvb3RWaWV3Q29vcmRpbmF0ZXMoKSBjb25zdDsKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9UZXh0RXZlbnQuY3BwIGIvU291cmNlL1dlYkNvcmUv ZG9tL1RleHRFdmVudC5jcHAKaW5kZXggM2VkNjY4NTUwMjc0NDM0MmMwODc5NDM2M2Y0ZmRmYmYw NzE3Mjg2ZC4uYmQwMjRlYTU1ZjZiYTg0ZTMyYzkwNDQ2ZmNiZjgyODIwNGQyYzMwYyAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL1RleHRFdmVudC5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvZG9tL1RleHRFdmVudC5jcHAKQEAgLTExMiw3ICsxMTIsMTUgQEAgdm9pZCBUZXh0RXZlbnQ6 OmluaXRUZXh0RXZlbnQoY29uc3QgQXRvbWljU3RyaW5nJiB0eXBlLCBib29sIGNhbkJ1YmJsZSwg Ym9vbCBjYW4KIAogICAgIGluaXRVSUV2ZW50KHR5cGUsIGNhbkJ1YmJsZSwgY2FuY2VsYWJsZSwg dmlldywgMCk7CiAKKyAgICBtX2lucHV0VHlwZSA9IFRleHRFdmVudElucHV0S2V5Ym9hcmQ7CisK ICAgICBtX2RhdGEgPSBkYXRhOworCisgICAgbV9wYXN0aW5nRnJhZ21lbnQgPSBudWxscHRyOwor ICAgIG1fc2hvdWxkU21hcnRSZXBsYWNlID0gZmFsc2U7CisgICAgbV9zaG91bGRNYXRjaFN0eWxl ID0gZmFsc2U7CisgICAgbV9tYWlsQmxvY2txdW90ZUhhbmRsaW5nID0gTWFpbEJsb2NrcXVvdGVI YW5kbGluZzo6UmVzcGVjdEJsb2NrcXVvdGU7CisgICAgbV9kaWN0YXRpb25BbHRlcm5hdGl2ZXMg PSB7IH07CiB9CiAKIEV2ZW50SW50ZXJmYWNlIFRleHRFdmVudDo6ZXZlbnRJbnRlcmZhY2UoKSBj b25zdApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL1doZWVsRXZlbnQuY3BwIGIvU291 cmNlL1dlYkNvcmUvZG9tL1doZWVsRXZlbnQuY3BwCmluZGV4IGQxNzUyYmYyOWU0MmRmZmEwMDQ2 NGI2ODE4YjIxMzhlNWY2ZDE0NzAuLjc5MzRmODk2NzRkOWE5MmQ0MDU0NDkzNjVmZTQzMWQyMDRm NTY0MTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9XaGVlbEV2ZW50LmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9kb20vV2hlZWxFdmVudC5jcHAKQEAgLTY5LDEzICs2OSw3IEBAIHZv aWQgV2hlZWxFdmVudDo6aW5pdFdoZWVsRXZlbnQoaW50IHJhd0RlbHRhWCwgaW50IHJhd0RlbHRh WSwgRE9NV2luZG93KiB2aWV3LCBpCiAgICAgaWYgKGlzQmVpbmdEaXNwYXRjaGVkKCkpCiAgICAg ICAgIHJldHVybjsKICAgICAKLSAgICBpbml0VUlFdmVudChldmVudE5hbWVzKCkud2hlZWxFdmVu dCwgdHJ1ZSwgdHJ1ZSwgdmlldywgMCk7Ci0gICAgCi0gICAgbV9zY3JlZW5Mb2NhdGlvbiA9IHsg c2NyZWVuWCwgc2NyZWVuWSB9OwotICAgIG1fY3RybEtleSA9IGN0cmxLZXk7Ci0gICAgbV9hbHRL ZXkgPSBhbHRLZXk7Ci0gICAgbV9zaGlmdEtleSA9IHNoaWZ0S2V5OwotICAgIG1fbWV0YUtleSA9 IG1ldGFLZXk7CisgICAgaW5pdE1vdXNlRXZlbnQoZXZlbnROYW1lcygpLndoZWVsRXZlbnQsIHRy dWUsIHRydWUsIHZpZXcsIDAsIHNjcmVlblgsIHNjcmVlblksIHBhZ2VYLCBwYWdlWSwgY3RybEtl eSwgYWx0S2V5LCBzaGlmdEtleSwgbWV0YUtleSwgMCwgbnVsbHB0cik7CiAKICAgICAvLyBOb3Jt YWxpemUgdG8gMTIwIG11bHRpcGxlIGZvciBjb21wYXRpYmlsaXR5IHdpdGggSUUuCiAgICAgbV93 aGVlbERlbHRhID0geyByYXdEZWx0YVggKiBUaWNrTXVsdGlwbGllciwgcmF3RGVsdGFZICogVGlj a011bHRpcGxpZXIgfTsKQEAgLTg0LDcgKzc4LDggQEAgdm9pZCBXaGVlbEV2ZW50Ojppbml0V2hl ZWxFdmVudChpbnQgcmF3RGVsdGFYLCBpbnQgcmF3RGVsdGFZLCBET01XaW5kb3cqIHZpZXcsIGkK IAogICAgIG1fZGVsdGFNb2RlID0gRE9NX0RFTFRBX1BJWEVMOwogCi0gICAgaW5pdENvb3JkaW5h dGVzKHsgcGFnZVgsIHBhZ2VZIH0pOworICAgIG1faW5pdGlhbGl6ZWRXaXRoUGxhdGZvcm1XaGVl bEV2ZW50ID0gZmFsc2U7CisgICAgbV93aGVlbEV2ZW50ID0geyB9OwogfQogCiBFdmVudEludGVy ZmFjZSBXaGVlbEV2ZW50OjpldmVudEludGVyZmFjZSgpIGNvbnN0Cg==