178864 2017-10-26 06:41:08 -0700 WebDriver: failing to process capabilities should produce InvalidArgument error not SessionNotCreated 2017-11-15 12:43:52 -0800 1 1 1 Unclassified WebKit WebDriver WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cgarcia webkit-unassigned bburg webkit-bug-importer oldest_to_newest 1364813 0 cgarcia 2017-10-26 06:41:08 -0700 See https://w3c.github.io/webdriver/webdriver-spec.html#processing-capabilities 1364814 1 325004 cgarcia 2017-10-26 06:43:07 -0700 Created attachment 325004 Patch 1364887 2 325004 bburg 2017-10-26 10:18:03 -0700 Comment on attachment 325004 Patch rs=me 1365278 3 cgarcia 2017-10-27 00:11:04 -0700 Committed r224088: <https://trac.webkit.org/changeset/224088> 1372225 4 webkit-bug-importer 2017-11-15 12:43:52 -0800 <rdar://problem/35568037> 325004 2017-10-26 06:43:07 -0700 2017-10-26 10:18:03 -0700 Patch wd-capabilities-errors.diff text/plain 6305 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJEcml2ZXIvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkRyaXZl ci9DaGFuZ2VMb2cKaW5kZXggNjNiZWZmYmI5OWUuLmJiMjFiODkyOTlmIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViRHJpdmVyL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViRHJpdmVyL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE4IEBACisyMDE3LTEwLTI2ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNn YXJjaWFAaWdhbGlhLmNvbT4KKworICAgICAgICBXZWJEcml2ZXI6IGZhaWxpbmcgdG8gcHJvY2Vz cyBjYXBhYmlsaXRpZXMgc2hvdWxkIHByb2R1Y2UgSW52YWxpZEFyZ3VtZW50IGVycm9yIG5vdCBT ZXNzaW9uTm90Q3JlYXRlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTc4ODY0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgRml4ZXMgbW9zdCBvZiB0aGUgdGVzdHMgaW4gaW1wb3J0ZWQvdzNjL3dlYmRyaXZl ci90ZXN0cy9zZXNzaW9ucy9uZXdfc2Vzc2lvbi9pbnZhbGlkX2NhcGFiaWxpdGllcy5weS4KKwor ICAgICAgICA3LjIgUHJvY2Vzc2luZyBDYXBhYmlsaXRpZXMKKyAgICAgICAgaHR0cHM6Ly93M2Mu Z2l0aHViLmlvL3dlYmRyaXZlci93ZWJkcml2ZXItc3BlYy5odG1sI3Byb2Nlc3NpbmctY2FwYWJp bGl0aWVzCisKKyAgICAgICAgKiBXZWJEcml2ZXJTZXJ2aWNlLmNwcDoKKyAgICAgICAgKFdlYkRy aXZlcjo6V2ViRHJpdmVyU2VydmljZTo6cHJvY2Vzc0NhcGFiaWxpdGllcyBjb25zdCk6CisKIDIw MTctMTAtMTAgIFNhbSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9yZz4KIAogICAgICAgICBSZXBsYWNl IGNvcHlLZXlzVG9WZWN0b3IvY29weVZhbHVlc1RvVmVjdG9yIHdpdGggY29weVRvVmVjdG9yKG1h cC5rZXlzKCkpL2NvcHlUb1ZlY3RvcihtYXAudmFsdWVzKCkpCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViRHJpdmVyL1dlYkRyaXZlclNlcnZpY2UuY3BwIGIvU291cmNlL1dlYkRyaXZlci9XZWJEcml2 ZXJTZXJ2aWNlLmNwcAppbmRleCA1ZWVjMmYwZTBlNy4uNDg2MmVhYzQyMGYgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJEcml2ZXIvV2ViRHJpdmVyU2VydmljZS5jcHAKKysrIGIvU291cmNlL1dlYkRy aXZlci9XZWJEcml2ZXJTZXJ2aWNlLmNwcApAQCAtNDc2LDcgKzQ3Niw3IEBAIFJlZlB0cjxJbnNw ZWN0b3JPYmplY3Q+IFdlYkRyaXZlclNlcnZpY2U6OnByb2Nlc3NDYXBhYmlsaXRpZXMoY29uc3Qg SW5zcGVjdG9yT2JqCiAgICAgLy8gMS4gTGV0IGNhcGFiaWxpdGllcyByZXF1ZXN0IGJlIHRoZSBy ZXN1bHQgb2YgZ2V0dGluZyB0aGUgcHJvcGVydHkgImNhcGFiaWxpdGllcyIgZnJvbSBwYXJhbWV0 ZXJzLgogICAgIFJlZlB0cjxJbnNwZWN0b3JPYmplY3Q+IGNhcGFiaWxpdGllc09iamVjdDsKICAg ICBpZiAoIXBhcmFtZXRlcnMuZ2V0T2JqZWN0KEFTQ0lJTGl0ZXJhbCgiY2FwYWJpbGl0aWVzIiks IGNhcGFiaWxpdGllc09iamVjdCkpIHsKLSAgICAgICAgY29tcGxldGlvbkhhbmRsZXIoQ29tbWFu ZFJlc3VsdDo6ZmFpbChDb21tYW5kUmVzdWx0OjpFcnJvckNvZGU6OlNlc3Npb25Ob3RDcmVhdGVk KSk7CisgICAgICAgIGNvbXBsZXRpb25IYW5kbGVyKENvbW1hbmRSZXN1bHQ6OmZhaWwoQ29tbWFu ZFJlc3VsdDo6RXJyb3JDb2RlOjpJbnZhbGlkQXJndW1lbnQpKTsKICAgICAgICAgcmV0dXJuIG51 bGxwdHI7CiAgICAgfQogCkBAIC00ODcsMTQgKzQ4NywxNCBAQCBSZWZQdHI8SW5zcGVjdG9yT2Jq ZWN0PiBXZWJEcml2ZXJTZXJ2aWNlOjpwcm9jZXNzQ2FwYWJpbGl0aWVzKGNvbnN0IEluc3BlY3Rv ck9iagogICAgICAgICAvLyAyLjEuIElmIHJlcXVpcmVkIGNhcGFiaWxpdGllcyBpcyB1bmRlZmlu ZWQsIHNldCB0aGUgdmFsdWUgdG8gYW4gZW1wdHkgSlNPTiBPYmplY3QuCiAgICAgICAgIHJlcXVp cmVkQ2FwYWJpbGl0aWVzID0gSW5zcGVjdG9yT2JqZWN0OjpjcmVhdGUoKTsKICAgICBlbHNlIGlm ICghcmVxdWlyZWRDYXBhYmlsaXRpZXNWYWx1ZS0+YXNPYmplY3QocmVxdWlyZWRDYXBhYmlsaXRp ZXMpKSB7Ci0gICAgICAgIGNvbXBsZXRpb25IYW5kbGVyKENvbW1hbmRSZXN1bHQ6OmZhaWwoQ29t bWFuZFJlc3VsdDo6RXJyb3JDb2RlOjpTZXNzaW9uTm90Q3JlYXRlZCwgU3RyaW5nKCJhbHdheXNN YXRjaCBpcyBpbnZhbGlkIGluIGNhcGFiaWxpdGllcyIpKSk7CisgICAgICAgIGNvbXBsZXRpb25I YW5kbGVyKENvbW1hbmRSZXN1bHQ6OmZhaWwoQ29tbWFuZFJlc3VsdDo6RXJyb3JDb2RlOjpJbnZh bGlkQXJndW1lbnQsIFN0cmluZygiYWx3YXlzTWF0Y2ggaXMgaW52YWxpZCBpbiBjYXBhYmlsaXRp ZXMiKSkpOwogICAgICAgICByZXR1cm4gbnVsbHB0cjsKICAgICB9CiAKICAgICAvLyAyLjIuIExl dCByZXF1aXJlZCBjYXBhYmlsaXRpZXMgYmUgdGhlIHJlc3VsdCBvZiB0cnlpbmcgdG8gdmFsaWRh dGUgY2FwYWJpbGl0aWVzIHdpdGggYXJndW1lbnQgcmVxdWlyZWQgY2FwYWJpbGl0aWVzLgogICAg IHJlcXVpcmVkQ2FwYWJpbGl0aWVzID0gdmFsaWRhdGVkQ2FwYWJpbGl0aWVzKCpyZXF1aXJlZENh cGFiaWxpdGllcyk7CiAgICAgaWYgKCFyZXF1aXJlZENhcGFiaWxpdGllcykgewotICAgICAgICBj b21wbGV0aW9uSGFuZGxlcihDb21tYW5kUmVzdWx0OjpmYWlsKENvbW1hbmRSZXN1bHQ6OkVycm9y Q29kZTo6U2Vzc2lvbk5vdENyZWF0ZWQsIFN0cmluZygiSW52YWxpZCBhbHdheXNNYXRjaCBjYXBh YmlsaXRpZXMiKSkpOworICAgICAgICBjb21wbGV0aW9uSGFuZGxlcihDb21tYW5kUmVzdWx0Ojpm YWlsKENvbW1hbmRSZXN1bHQ6OkVycm9yQ29kZTo6SW52YWxpZEFyZ3VtZW50LCBTdHJpbmcoIklu dmFsaWQgYWx3YXlzTWF0Y2ggY2FwYWJpbGl0aWVzIikpKTsKICAgICAgICAgcmV0dXJuIG51bGxw dHI7CiAgICAgfQogCkBAIC01MDcsNyArNTA3LDcgQEAgUmVmUHRyPEluc3BlY3Rvck9iamVjdD4g V2ViRHJpdmVyU2VydmljZTo6cHJvY2Vzc0NhcGFiaWxpdGllcyhjb25zdCBJbnNwZWN0b3JPYmoK ICAgICAgICAgZmlyc3RNYXRjaENhcGFiaWxpdGllc0xpc3QtPnB1c2hPYmplY3QoSW5zcGVjdG9y T2JqZWN0OjpjcmVhdGUoKSk7CiAgICAgfSBlbHNlIGlmICghZmlyc3RNYXRjaENhcGFiaWxpdGll c1ZhbHVlLT5hc0FycmF5KGZpcnN0TWF0Y2hDYXBhYmlsaXRpZXNMaXN0KSkgewogICAgICAgICAv LyAzLjIuIElmIGFsbCBmaXJzdCBtYXRjaCBjYXBhYmlsaXRpZXMgaXMgbm90IGEgSlNPTiBMaXN0 LCByZXR1cm4gZXJyb3Igd2l0aCBlcnJvciBjb2RlIGludmFsaWQgYXJndW1lbnQuCi0gICAgICAg IGNvbXBsZXRpb25IYW5kbGVyKENvbW1hbmRSZXN1bHQ6OmZhaWwoQ29tbWFuZFJlc3VsdDo6RXJy b3JDb2RlOjpTZXNzaW9uTm90Q3JlYXRlZCwgU3RyaW5nKCJmaXJzdE1hdGNoIGlzIGludmFsaWQg aW4gY2FwYWJpbGl0aWVzIikpKTsKKyAgICAgICAgY29tcGxldGlvbkhhbmRsZXIoQ29tbWFuZFJl c3VsdDo6ZmFpbChDb21tYW5kUmVzdWx0OjpFcnJvckNvZGU6OkludmFsaWRBcmd1bWVudCwgU3Ry aW5nKCJmaXJzdE1hdGNoIGlzIGludmFsaWQgaW4gY2FwYWJpbGl0aWVzIikpKTsKICAgICAgICAg cmV0dXJuIG51bGxwdHI7CiAgICAgfQogCkBAIC01MjAsMTMgKzUyMCwxMyBAQCBSZWZQdHI8SW5z cGVjdG9yT2JqZWN0PiBXZWJEcml2ZXJTZXJ2aWNlOjpwcm9jZXNzQ2FwYWJpbGl0aWVzKGNvbnN0 IEluc3BlY3Rvck9iagogICAgICAgICBSZWZQdHI8SW5zcGVjdG9yVmFsdWU+IGZpcnN0TWF0Y2hD YXBhYmlsaXRpZXNWYWx1ZSA9IGZpcnN0TWF0Y2hDYXBhYmlsaXRpZXNMaXN0LT5nZXQoaSk7CiAg ICAgICAgIFJlZlB0cjxJbnNwZWN0b3JPYmplY3Q+IGZpcnN0TWF0Y2hDYXBhYmlsaXRpZXM7CiAg ICAgICAgIGlmICghZmlyc3RNYXRjaENhcGFiaWxpdGllc1ZhbHVlLT5hc09iamVjdChmaXJzdE1h dGNoQ2FwYWJpbGl0aWVzKSkgewotICAgICAgICAgICAgY29tcGxldGlvbkhhbmRsZXIoQ29tbWFu ZFJlc3VsdDo6ZmFpbChDb21tYW5kUmVzdWx0OjpFcnJvckNvZGU6OlNlc3Npb25Ob3RDcmVhdGVk LCBTdHJpbmcoIkludmFsaWQgY2FwYWJpbGl0aWVzIGZvdW5kIGluIGZpcnN0TWF0Y2giKSkpOwor ICAgICAgICAgICAgY29tcGxldGlvbkhhbmRsZXIoQ29tbWFuZFJlc3VsdDo6ZmFpbChDb21tYW5k UmVzdWx0OjpFcnJvckNvZGU6OkludmFsaWRBcmd1bWVudCwgU3RyaW5nKCJJbnZhbGlkIGNhcGFi aWxpdGllcyBmb3VuZCBpbiBmaXJzdE1hdGNoIikpKTsKICAgICAgICAgICAgIHJldHVybiBudWxs cHRyOwogICAgICAgICB9CiAgICAgICAgIC8vIDUuMS4gTGV0IHZhbGlkYXRlZCBjYXBhYmlsaXRp ZXMgYmUgdGhlIHJlc3VsdCBvZiB0cnlpbmcgdG8gdmFsaWRhdGUgY2FwYWJpbGl0aWVzIHdpdGgg YXJndW1lbnQgZmlyc3QgbWF0Y2ggY2FwYWJpbGl0aWVzLgogICAgICAgICBmaXJzdE1hdGNoQ2Fw YWJpbGl0aWVzID0gdmFsaWRhdGVkQ2FwYWJpbGl0aWVzKCpmaXJzdE1hdGNoQ2FwYWJpbGl0aWVz KTsKICAgICAgICAgaWYgKCFmaXJzdE1hdGNoQ2FwYWJpbGl0aWVzKSB7Ci0gICAgICAgICAgICBj b21wbGV0aW9uSGFuZGxlcihDb21tYW5kUmVzdWx0OjpmYWlsKENvbW1hbmRSZXN1bHQ6OkVycm9y Q29kZTo6U2Vzc2lvbk5vdENyZWF0ZWQsIFN0cmluZygiSW52YWxpZCBmaXJzdE1hdGNoIGNhcGFi aWxpdGllcyIpKSk7CisgICAgICAgICAgICBjb21wbGV0aW9uSGFuZGxlcihDb21tYW5kUmVzdWx0 OjpmYWlsKENvbW1hbmRSZXN1bHQ6OkVycm9yQ29kZTo6SW52YWxpZEFyZ3VtZW50LCBTdHJpbmco IkludmFsaWQgZmlyc3RNYXRjaCBjYXBhYmlsaXRpZXMiKSkpOwogICAgICAgICAgICAgcmV0dXJu IG51bGxwdHI7CiAgICAgICAgIH0KICAgICAgICAgLy8gNS4yLiBBcHBlbmQgdmFsaWRhdGVkIGNh cGFiaWxpdGllcyB0byB2YWxpZGF0ZWQgZmlyc3QgbWF0Y2ggY2FwYWJpbGl0aWVzLgpAQCAtNTM5 LDcgKzUzOSw3IEBAIFJlZlB0cjxJbnNwZWN0b3JPYmplY3Q+IFdlYkRyaXZlclNlcnZpY2U6OnBy b2Nlc3NDYXBhYmlsaXRpZXMoY29uc3QgSW5zcGVjdG9yT2JqCiAgICAgICAgIC8vIDYuMS4gTGV0 IG1lcmdlZCBjYXBhYmlsaXRpZXMgYmUgdGhlIHJlc3VsdCBvZiB0cnlpbmcgdG8gbWVyZ2UgY2Fw YWJpbGl0aWVzIHdpdGggcmVxdWlyZWQgY2FwYWJpbGl0aWVzIGFuZCBmaXJzdCBtYXRjaCBjYXBh YmlsaXRpZXMgYXMgYXJndW1lbnRzLgogICAgICAgICBhdXRvIG1lcmdlZENhcGFiaWxpdGllcyA9 IG1lcmdlQ2FwYWJpbGl0aWVzKCpyZXF1aXJlZENhcGFiaWxpdGllcywgKnZhbGlkYXRlZEZpcnN0 TWF0Y2hDYXBhYmlsaWVzKTsKICAgICAgICAgaWYgKCFtZXJnZWRDYXBhYmlsaXRpZXMpIHsKLSAg ICAgICAgICAgIGNvbXBsZXRpb25IYW5kbGVyKENvbW1hbmRSZXN1bHQ6OmZhaWwoQ29tbWFuZFJl c3VsdDo6RXJyb3JDb2RlOjpTZXNzaW9uTm90Q3JlYXRlZCwgU3RyaW5nKCJTYW1lIGNhcGFiaWxp dHkgZm91bmQgaW4gZmlyc3RNYXRjaCBhbmQgYWx3YXlzTWF0Y2giKSkpOworICAgICAgICAgICAg Y29tcGxldGlvbkhhbmRsZXIoQ29tbWFuZFJlc3VsdDo6ZmFpbChDb21tYW5kUmVzdWx0OjpFcnJv ckNvZGU6OkludmFsaWRBcmd1bWVudCwgU3RyaW5nKCJTYW1lIGNhcGFiaWxpdHkgZm91bmQgaW4g Zmlyc3RNYXRjaCBhbmQgYWx3YXlzTWF0Y2giKSkpOwogICAgICAgICAgICAgcmV0dXJuIG51bGxw dHI7CiAgICAgICAgIH0KICAgICAgICAgLy8gNi4yLiBMZXQgbWF0Y2hlZCBjYXBhYmlsaXRpZXMg YmUgdGhlIHJlc3VsdCBvZiB0cnlpbmcgdG8gbWF0Y2ggY2FwYWJpbGl0aWVzIHdpdGggbWVyZ2Vk IGNhcGFiaWxpdGllcyBhcyBhbiBhcmd1bWVudC4KQEAgLTU1MCw3ICs1NTAsNyBAQCBSZWZQdHI8 SW5zcGVjdG9yT2JqZWN0PiBXZWJEcml2ZXJTZXJ2aWNlOjpwcm9jZXNzQ2FwYWJpbGl0aWVzKGNv bnN0IEluc3BlY3Rvck9iagogICAgICAgICB9CiAgICAgfQogCi0gICAgY29tcGxldGlvbkhhbmRs ZXIoQ29tbWFuZFJlc3VsdDo6ZmFpbChDb21tYW5kUmVzdWx0OjpFcnJvckNvZGU6OlNlc3Npb25O b3RDcmVhdGVkLCBlcnJvclN0cmluZyA/IGVycm9yU3RyaW5nLnZhbHVlKCkgOiBTdHJpbmcoIklu dmFsaWQgY2FwYWJpbGl0aWVzIikpKTsKKyAgICBjb21wbGV0aW9uSGFuZGxlcihDb21tYW5kUmVz dWx0OjpmYWlsKENvbW1hbmRSZXN1bHQ6OkVycm9yQ29kZTo6SW52YWxpZEFyZ3VtZW50LCBlcnJv clN0cmluZyA/IGVycm9yU3RyaW5nLnZhbHVlKCkgOiBTdHJpbmcoIkludmFsaWQgY2FwYWJpbGl0 aWVzIikpKTsKICAgICByZXR1cm4gbnVsbHB0cjsKIH0KIAo=