178842 2017-10-25 18:51:15 -0700 Fix issues with WebView subframe painting 2017-11-15 12:43:44 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Mac macOS 10.13 RESOLVED FIXED InRadar, PlatformOnly P1 Normal --- 1 simon.fraser simon.fraser commit-queue dbates simon.fraser webkit-bug-importer oldest_to_newest 1364626 0 simon.fraser 2017-10-25 18:51:15 -0700 Fix issues with WebView subframe painting 1364627 1 324940 simon.fraser 2017-10-25 18:53:17 -0700 Created attachment 324940 Patch 1364654 2 324940 dbates 2017-10-25 20:28:37 -0700 Comment on attachment 324940 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=324940&action=review > Source/WebKitLegacy/mac/ChangeLog:11 > + WebHTMLView overrides some NSView internal methods to make sure that AppKit doesn't paint > + subframes (WebKit controls subframe painting). The method signature of one of these changed in macOS > + High Sierra, so match the new signature. Is there an equivalent to C++11's override keyword to help us catch such changes in the future and/or can we write a unit test to ensure this does not regress? 1364895 3 simon.fraser 2017-10-26 10:36:42 -0700 (In reply to Daniel Bates from comment #2) > Comment on attachment 324940 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=324940&action=review > > > Source/WebKitLegacy/mac/ChangeLog:11 > > + WebHTMLView overrides some NSView internal methods to make sure that AppKit doesn't paint > > + subframes (WebKit controls subframe painting). The method signature of one of these changed in macOS > > + High Sierra, so match the new signature. > > Is there an equivalent to C++11's override keyword to help us catch such > changes in the future and/or can we write a unit test to ensure this does > not regress? The only think I can think of is a runtime assertion that NSView implements certain functions. 1364990 4 324940 commit-queue 2017-10-26 13:13:51 -0700 Comment on attachment 324940 Patch Clearing flags on attachment: 324940 Committed r224040: <https://trac.webkit.org/changeset/224040> 1364991 5 commit-queue 2017-10-26 13:13:52 -0700 All reviewed patches have been landed. Closing bug. 1372222 6 webkit-bug-importer 2017-11-15 12:43:44 -0800 <rdar://problem/35568031> 324940 2017-10-25 18:53:17 -0700 2017-10-26 13:13:51 -0700 Patch bug-178842-20171025185317.patch text/plain 4651 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjIzOTkyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0TGVn YWN5L21hYy9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9DaGFuZ2VMb2cKaW5k ZXggNGUwMzBkNWNjYzJjYjFhZTdmYTFiNTgxOTRiOWZmNDU1MWY1MTg1MC4uZTNmZTgzNDhkZDU0 MTMxYTBkYmFhNDQ3YzBlMzc0MGNjMGQ1YjE2MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdExl Z2FjeS9tYWMvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDIxIEBACisyMDE3LTEwLTI1ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFz ZXJAYXBwbGUuY29tPgorCisgICAgICAgIEZpeCBpc3N1ZXMgd2l0aCBXZWJWaWV3IHN1YmZyYW1l IHBhaW50aW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNzg4NDIKKyAgICAgICAgcmRhcjovL3Byb2JsZW0vMzQwNzIyNTMKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAgICAgCisgICAgICAgIFdlYkhUTUxWaWV3IG92 ZXJyaWRlcyBzb21lIE5TVmlldyBpbnRlcm5hbCBtZXRob2RzIHRvIG1ha2Ugc3VyZSB0aGF0IEFw cEtpdCBkb2Vzbid0IHBhaW50CisgICAgICAgIHN1YmZyYW1lcyAoV2ViS2l0IGNvbnRyb2xzIHN1 YmZyYW1lIHBhaW50aW5nKS4gVGhlIG1ldGhvZCBzaWduYXR1cmUgb2Ygb25lIG9mIHRoZXNlIGNo YW5nZWQgaW4gbWFjT1MKKyAgICAgICAgSGlnaCBTaWVycmEsIHNvIG1hdGNoIHRoZSBuZXcgc2ln bmF0dXJlLgorCisgICAgICAgIEFsc28gcmVuYW1lIHRoZSAncmVjdCcgcGFyYW0gdG8gJ2Rpc3Bs YXlSZWN0JyB0byBtYXRjaCBBcHBLaXQgY29kZS4KKworICAgICAgICAqIFdlYlZpZXcvV2ViSFRN TFZpZXcubW06CisgICAgICAgICgtW1dlYkhUTUxWaWV3IF9yZWN1cnNpdmU6ZGlzcGxheVJlY3RJ Z25vcmluZ09wYWNpdHk6aW5HcmFwaGljc0NvbnRleHQ6c2hvdWxkQ2hhbmdlRm9udFJlZmVyZW5j ZUNvbG9yOl9yZWN1cnNpdmU6ZGlzcGxheVJlY3RJZ25vcmluZ09wYWNpdHk6aW5HcmFwaGljc0Nv bnRleHQ6Q0dDb250ZXh0OnRvcFZpZXc6c2hvdWxkQ2hhbmdlRm9udFJlZmVyZW5jZUNvbG9yOl0p OgorICAgICAgICAoLVtXZWJIVE1MVmlldyBfcmVjdXJzaXZlOmRpc3BsYXlSZWN0SWdub3JpbmdP cGFjaXR5OmluR3JhcGhpY3NDb250ZXh0OkNHQ29udGV4dDpzaG91bGRDaGFuZ2VGb250UmVmZXJl bmNlQ29sb3I6X3JlY3Vyc2l2ZTpkaXNwbGF5UmVjdElnbm9yaW5nT3BhY2l0eTppbkdyYXBoaWNz Q29udGV4dDpDR0NvbnRleHQ6dG9wVmlldzpzaG91bGRDaGFuZ2VGb250UmVmZXJlbmNlQ29sb3I6 XSk6IERlbGV0ZWQuCisKIDIwMTctMTAtMjUgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUu Y29tPgogCiAgICAgICAgIEVuYWJsZSBTZXJ2aWNlV29ya2VyIHRvIGZldGNoIHJlc291cmNlcwpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdExlZ2FjeS9tYWMvV2ViVmlldy9XZWJIVE1MVmlldy5t bSBiL1NvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL1dlYlZpZXcvV2ViSFRNTFZpZXcubW0KaW5kZXgg ZjJhNzBjOTUxOTM1ZjUyMjFlMmJjYjk1NDgyZDZhNjIyNWI3ZTRmMy4uNjg5YmVmMGQ0MDkwOTM0 NjhiYWNmZTExM2U4MzJhYTE0NjkxYTA4MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdExlZ2Fj eS9tYWMvV2ViVmlldy9XZWJIVE1MVmlldy5tbQorKysgYi9Tb3VyY2UvV2ViS2l0TGVnYWN5L21h Yy9XZWJWaWV3L1dlYkhUTUxWaWV3Lm1tCkBAIC03MTMsNyArNzEzLDcgQEAgLSAodm9pZClfcmVj dXJzaXZlRGlzcGxheUFsbERpcnR5V2l0aExvY2tGb2N1czooQk9PTCluZWVkc0xvY2tGb2N1cyB2 aXNSZWN0OihOU1IKICNpZiBQTEFURk9STShNQUMpCiAjaWYgX19NQUNfT1NfWF9WRVJTSU9OX01J Tl9SRVFVSVJFRCA+PSAxMDEzMDAKIC0gKHZvaWQpX3JlY3Vyc2l2ZTooQk9PTClyZWN1cnNlIGRp c3BsYXlSZWN0SWdub3JpbmdPcGFjaXR5OihOU1JlY3QpZGlzcGxheVJlY3QgaW5Db250ZXh0OihO U0dyYXBoaWNzQ29udGV4dCAqKWNvbnRleHQgc2hvdWxkQ2hhbmdlRm9udFJlZmVyZW5jZUNvbG9y OihCT09MKXNob3VsZENoYW5nZUZvbnRSZWZlcmVuY2VDb2xvcjsKLS0gKHZvaWQpX3JlY3Vyc2l2 ZTooQk9PTClyZWN1cnNlWCBkaXNwbGF5UmVjdElnbm9yaW5nT3BhY2l0eTooTlNSZWN0KWRpc3Bs YXlSZWN0IGluR3JhcGhpY3NDb250ZXh0OihOU0dyYXBoaWNzQ29udGV4dCAqKWdyYXBoaWNzQ29u dGV4dCBDR0NvbnRleHQ6KENHQ29udGV4dFJlZiljdHggc2hvdWxkQ2hhbmdlRm9udFJlZmVyZW5j ZUNvbG9yOihCT09MKXNob3VsZENoYW5nZUZvbnRSZWZlcmVuY2VDb2xvcjsKKy0gKHZvaWQpX3Jl Y3Vyc2l2ZTooQk9PTClyZWN1cnNlWCBkaXNwbGF5UmVjdElnbm9yaW5nT3BhY2l0eTooTlNSZWN0 KWRpc3BsYXlSZWN0IGluR3JhcGhpY3NDb250ZXh0OihOU0dyYXBoaWNzQ29udGV4dCAqKWdyYXBo aWNzQ29udGV4dCBzaG91bGRDaGFuZ2VGb250UmVmZXJlbmNlQ29sb3I6KEJPT0wpc2hvdWxkQ2hh bmdlRm9udFJlZmVyZW5jZUNvbG9yOwogI2Vsc2UKIC0gKHZvaWQpX3JlY3Vyc2l2ZTooQk9PTCly ZWN1cnNlIGRpc3BsYXlSZWN0SWdub3JpbmdPcGFjaXR5OihOU1JlY3QpZGlzcGxheVJlY3QgaW5D b250ZXh0OihOU0dyYXBoaWNzQ29udGV4dCAqKWNvbnRleHQgdG9wVmlldzooQk9PTCl0b3BWaWV3 OwogLSAodm9pZClfcmVjdXJzaXZlOihCT09MKXJlY3Vyc2VYIGRpc3BsYXlSZWN0SWdub3JpbmdP cGFjaXR5OihOU1JlY3QpZGlzcGxheVJlY3QgaW5HcmFwaGljc0NvbnRleHQ6KE5TR3JhcGhpY3ND b250ZXh0ICopZ3JhcGhpY3NDb250ZXh0IENHQ29udGV4dDooQ0dDb250ZXh0UmVmKWN0eCB0b3BW aWV3OihCT09MKWlzVG9wVmlldyBzaG91bGRDaGFuZ2VGb250UmVmZXJlbmNlQ29sb3I6KEJPT0wp c2hvdWxkQ2hhbmdlRm9udFJlZmVyZW5jZUNvbG9yOwpAQCAtMTcwMiw3ICsxNzAyLDcgQEAgLSAo dm9pZClfcmVjdXJzaXZlOihCT09MKXJlY3Vyc2UgZGlzcGxheVJlY3RJZ25vcmluZ09wYWNpdHk6 KE5TUmVjdClkaXNwbGF5UmVjdAogCiAvLyBEb24ndCBsZXQgQXBwS2l0IGV2ZW4gZHJhdyBzdWJ2 aWV3cy4gV2UgdGFrZSBjYXJlIG9mIHRoYXQuCiAjaWYgX19NQUNfT1NfWF9WRVJTSU9OX01JTl9S RVFVSVJFRCA+PSAxMDEzMDAKLS0gKHZvaWQpX3JlY3Vyc2l2ZTooQk9PTClyZWN1cnNlWCBkaXNw bGF5UmVjdElnbm9yaW5nT3BhY2l0eTooTlNSZWN0KWRpc3BsYXlSZWN0IGluR3JhcGhpY3NDb250 ZXh0OihOU0dyYXBoaWNzQ29udGV4dCAqKWdyYXBoaWNzQ29udGV4dCBDR0NvbnRleHQ6KENHQ29u dGV4dFJlZiljdHggc2hvdWxkQ2hhbmdlRm9udFJlZmVyZW5jZUNvbG9yOihCT09MKXNob3VsZENo YW5nZUZvbnRSZWZlcmVuY2VDb2xvcgorLSAodm9pZClfcmVjdXJzaXZlOihCT09MKXJlY3Vyc2VY IGRpc3BsYXlSZWN0SWdub3JpbmdPcGFjaXR5OihOU1JlY3QpZGlzcGxheVJlY3QgaW5HcmFwaGlj c0NvbnRleHQ6KE5TR3JhcGhpY3NDb250ZXh0ICopZ3JhcGhpY3NDb250ZXh0IHNob3VsZENoYW5n ZUZvbnRSZWZlcmVuY2VDb2xvcjooQk9PTClzaG91bGRDaGFuZ2VGb250UmVmZXJlbmNlQ29sb3IK ICNlbHNlCiAtICh2b2lkKV9yZWN1cnNpdmU6KEJPT0wpcmVjdXJzZVggZGlzcGxheVJlY3RJZ25v cmluZ09wYWNpdHk6KE5TUmVjdClkaXNwbGF5UmVjdCBpbkdyYXBoaWNzQ29udGV4dDooTlNHcmFw aGljc0NvbnRleHQgKilncmFwaGljc0NvbnRleHQgQ0dDb250ZXh0OihDR0NvbnRleHRSZWYpY3R4 IHRvcFZpZXc6KEJPT0wpaXNUb3BWaWV3IHNob3VsZENoYW5nZUZvbnRSZWZlcmVuY2VDb2xvcjoo Qk9PTClzaG91bGRDaGFuZ2VGb250UmVmZXJlbmNlQ29sb3IKICNlbmRpZgpAQCAtMTcxNSw3ICsx NzE1LDcgQEAgLSAodm9pZClfcmVjdXJzaXZlOihCT09MKXJlY3Vyc2VYIGRpc3BsYXlSZWN0SWdu b3JpbmdPcGFjaXR5OihOU1JlY3QpZGlzcGxheVJlY3QKICAgICB9CiAgICAgCiAjaWYgX19NQUNf T1NfWF9WRVJTSU9OX01JTl9SRVFVSVJFRCA+PSAxMDEzMDAKLSAgICBbc3VwZXIgX3JlY3Vyc2l2 ZTpyZWN1cnNlWCBkaXNwbGF5UmVjdElnbm9yaW5nT3BhY2l0eTpkaXNwbGF5UmVjdCBpbkdyYXBo aWNzQ29udGV4dDpncmFwaGljc0NvbnRleHQgQ0dDb250ZXh0OmN0eCBzaG91bGRDaGFuZ2VGb250 UmVmZXJlbmNlQ29sb3I6c2hvdWxkQ2hhbmdlRm9udFJlZmVyZW5jZUNvbG9yXTsKKyAgICBbc3Vw ZXIgX3JlY3Vyc2l2ZTpyZWN1cnNlWCBkaXNwbGF5UmVjdElnbm9yaW5nT3BhY2l0eTpkaXNwbGF5 UmVjdCBpbkdyYXBoaWNzQ29udGV4dDpncmFwaGljc0NvbnRleHQgc2hvdWxkQ2hhbmdlRm9udFJl ZmVyZW5jZUNvbG9yOnNob3VsZENoYW5nZUZvbnRSZWZlcmVuY2VDb2xvcl07CiAjZWxzZQogICAg IFtzdXBlciBfcmVjdXJzaXZlOnJlY3Vyc2VYIGRpc3BsYXlSZWN0SWdub3JpbmdPcGFjaXR5OmRp c3BsYXlSZWN0IGluR3JhcGhpY3NDb250ZXh0OmdyYXBoaWNzQ29udGV4dCBDR0NvbnRleHQ6Y3R4 IHRvcFZpZXc6aXNUb3BWaWV3IHNob3VsZENoYW5nZUZvbnRSZWZlcmVuY2VDb2xvcjpzaG91bGRD aGFuZ2VGb250UmVmZXJlbmNlQ29sb3JdOwogI2VuZGlmCg==