17883 2008-03-16 16:29:10 -0700 Console completion should support bracket notation 2008-03-17 11:58:45 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 timothy timothy aroben oldest_to_newest 73994 0 timothy 2008-03-16 16:29:10 -0700 The console tab and auto completion should support getting properties with the bracket notation. For example typing: document["add should complete to: document["addEventListener"] 73995 1 19811 timothy 2008-03-16 16:38:07 -0700 Created attachment 19811 Patch 74125 2 19811 darin 2008-03-17 11:10:21 -0700 Comment on attachment 19811 Patch r=me 74133 3 timothy 2008-03-17 11:58:45 -0700 Landed in r31101. 19811 2008-03-16 16:38:07 -0700 2008-03-17 11:10:21 -0700 Patch 17883.patch text/plain 3973 timothy SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDMxMDg2 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjIgQEAKKzIwMDgtMDMt MTYgIFRpbW90aHkgSGF0Y2hlciAgPHRpbW90aHlAYXBwbGUuY29tPgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEJ1ZyAxNzg4MzogQ29uc29sZSBjb21w bGV0aW9uIHNob3VsZCBzdXBwb3J0IGJyYWNrZXQgbm90YXRpb24KKyAgICAgICAgaHR0cDovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc4ODMKKworICAgICAgICBBbHNvIGZpeGVz IGEgYnVnIHdoZXJlIHRoZSBJbnNwZWN0b3IncyB3aW5kb3cgb2JqZWN0IHdhcyB1c2VkIGluc3Rl YWQgb2YgdGhlCisgICAgICAgIGluc3BlY3RlZCB3aW5kb3cgb2JqZWN0LgorCisgICAgICAgICog cGFnZS9pbnNwZWN0b3IvQ29uc29sZVBhbmVsLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkNv bnNvbGVQYW5lbC5jb21wbGV0ZSk6IEFkZCBhIGNvbW1lbnQgYWJvdXQgdGhlIF9iYWNrd2FyZHNS YW5nZSBjYWxsLgorICAgICAgICAoV2ViSW5zcGVjdG9yLkNvbnNvbGVQYW5lbC5jb21wbGV0aW9u cyk6IEFkZCBhIGNvbW1lbnQgYWJvdXQgdGhlIF9iYWNrd2FyZHNSYW5nZSBjYWxsLgorICAgICAg ICBDaGVjayB0aGUgbGFzdCBjaGFyYWN0ZXIgb2YgdGhlIGV4cHJlc3Npb24gZm9yIGEgZG90IG9y IGJyYWNrZXQuIEZhbGxiYWNrCisgICAgICAgIHRvIHRoZSBJbnNwZWN0b3JDb250cm9sbGVyLmlu c3BlY3RlZFdpbmRvdygpIGluc3RlYWQgb2Ygd2luZG93LCB0aGlzIHdhcyBhIGJhZCBidWcuCisg ICAgICAgIElmIHRoZSBleHByZXNzaW9uIGNhdXNlZCBhbiBleGNlcHRpb24sIGp1c3QgY29uc2lk ZXIgdGhlIHByZWZpeCBhIHdpbmRvdyBwcm9wZXJ0eS4KKyAgICAgICAgV2hlbiBicmFja2V0IG5v dGF0aW9uIGlzIHVzZWQgcmVtZW1iZXIgd2hhdCBxdW90ZSB3YXMgdXNlZCBhbmQgY29tcGFyZWQg cHJvcGVydHkgbmFtZXMKKyAgICAgICAgd2l0aCB0aGF0IHF1b3RlIHN1cnJvdW5kaW5nIGl0LiBB bHNvIGVzY2FwZSB0aGUgcHJvcGVydHkgbmFtZSBmb3IgdGhlIHF1b3RlIGFuZCBiYWNrc2xhc2gu CisKIDIwMDgtMDMtMTYgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29tPgogCiAgICAgICAg IFJldmlld2VkIGJ5IE1hcmsgUm93ZS4KSW5kZXg6IHBhZ2UvaW5zcGVjdG9yL0NvbnNvbGVQYW5l bC5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBwYWdlL2luc3BlY3Rvci9Db25zb2xlUGFuZWwuanMJKHJldmlz aW9uIDMxMDc5KQorKysgcGFnZS9pbnNwZWN0b3IvQ29uc29sZVBhbmVsLmpzCSh3b3JraW5nIGNv cHkpCkBAIC0yMTEsNiArMjExLDcgQEAgV2ViSW5zcGVjdG9yLkNvbnNvbGVQYW5lbC5wcm90b3R5 cGUgPSB7CiAgICAgICAgICAgICB9CiAgICAgICAgIH0KIAorICAgICAgICAvLyBQYXNzIG1vcmUg Y2hhcmFjdGVycyB0byBfYmFja3dhcmRzUmFuZ2Ugc28gdGhlIHJhbmdlIHdpbGwgYmUgYXMgc2hv cnQgYXMgcG9zc2libGUuCiAgICAgICAgIHZhciB3b3JkUHJlZml4UmFuZ2UgPSB0aGlzLl9iYWNr d2FyZHNSYW5nZSgiIC49OlsoezsiLCBzZWxlY3Rpb25SYW5nZS5zdGFydENvbnRhaW5lciwgc2Vs ZWN0aW9uUmFuZ2Uuc3RhcnRPZmZzZXQsIHRoaXMucHJvbXB0RWxlbWVudCk7CiAKICAgICAgICAg dmFyIGNvbXBsZXRpb25zID0gdGhpcy5jb21wbGV0aW9ucyh3b3JkUHJlZml4UmFuZ2UsIGF1dG8p OwpAQCAtMjc4LDI2ICsyNzksNDMgQEAgV2ViSW5zcGVjdG9yLkNvbnNvbGVQYW5lbC5wcm90b3R5 cGUgPSB7CiAKICAgICBjb21wbGV0aW9uczogZnVuY3Rpb24od29yZFJhbmdlLCBiZXN0TWF0Y2hP bmx5KQogICAgIHsKLSAgICAgICAgdmFyIHByZWZpeCA9IHdvcmRSYW5nZS50b1N0cmluZygpOwot ICAgICAgICB2YXIgZXhwcmVzc2lvbiA9IHRoaXMuX2JhY2t3YXJkc1JhbmdlKCIgPTooezsiLCB3 b3JkUmFuZ2Uuc3RhcnRDb250YWluZXIsIHdvcmRSYW5nZS5zdGFydE9mZnNldCwgdGhpcy5wcm9t cHRFbGVtZW50KTsKLSAgICAgICAgdmFyIGV4cHJlc3Npb25TdHJpbmcgPSBleHByZXNzaW9uLnRv U3RyaW5nKCkucmVwbGFjZSgvXC4rJC8sICIiKTsKKyAgICAgICAgLy8gUGFzcyBsZXNzIGNoYXJh Y3RlcnMgdG8gX2JhY2t3YXJkc1JhbmdlIHNvIHRoZSByYW5nZSB3aWxsIGJlIGEgbW9yZSBjb21w bGV0ZSBleHByZXNzaW9uLgorICAgICAgICB2YXIgZXhwcmVzc2lvbiA9IHRoaXMuX2JhY2t3YXJk c1JhbmdlKCIgPTp7OyIsIHdvcmRSYW5nZS5zdGFydENvbnRhaW5lciwgd29yZFJhbmdlLnN0YXJ0 T2Zmc2V0LCB0aGlzLnByb21wdEVsZW1lbnQpOworICAgICAgICB2YXIgZXhwcmVzc2lvblN0cmlu ZyA9IGV4cHJlc3Npb24udG9TdHJpbmcoKTsKKyAgICAgICAgdmFyIGxhc3RJbmRleCA9IGV4cHJl c3Npb25TdHJpbmcubGVuZ3RoIC0gMTsKKworICAgICAgICB2YXIgZG90Tm90YXRpb24gPSAoZXhw cmVzc2lvblN0cmluZ1tsYXN0SW5kZXhdID09PSAiLiIpOworICAgICAgICB2YXIgYnJhY2tldE5v dGF0aW9uID0gKGV4cHJlc3Npb25TdHJpbmdbbGFzdEluZGV4XSA9PT0gIlsiKTsKIAorICAgICAg ICBpZiAoZG90Tm90YXRpb24gfHwgYnJhY2tldE5vdGF0aW9uKQorICAgICAgICAgICAgZXhwcmVz c2lvblN0cmluZyA9IGV4cHJlc3Npb25TdHJpbmcuc3Vic3RyKDAsIGxhc3RJbmRleCk7CisKKyAg ICAgICAgdmFyIHByZWZpeCA9IHdvcmRSYW5nZS50b1N0cmluZygpOwogICAgICAgICBpZiAoIWV4 cHJlc3Npb25TdHJpbmcgJiYgIXByZWZpeCkKICAgICAgICAgICAgIHJldHVybjsKIAotICAgICAg ICB2YXIgcmVzdWx0ID0gd2luZG93OworICAgICAgICB2YXIgcmVzdWx0ID0gSW5zcGVjdG9yQ29u dHJvbGxlci5pbnNwZWN0ZWRXaW5kb3coKTsKICAgICAgICAgaWYgKGV4cHJlc3Npb25TdHJpbmcp IHsKICAgICAgICAgICAgIHRyeSB7CiAgICAgICAgICAgICAgICAgcmVzdWx0ID0gdGhpcy5fZXZh bEluSW5zcGVjdGVkV2luZG93KGV4cHJlc3Npb25TdHJpbmcpOwogICAgICAgICAgICAgfSBjYXRj aChlKSB7Ci0gICAgICAgICAgICAgICAgcmV0dXJuOworICAgICAgICAgICAgICAgIC8vIERvIG5v dGhpbmcsIHRoZSBwcmVmaXggd2lsbCBiZSBjb25zaWRlcmVkIGEgd2luZG93IHByb3BlcnR5Lgog ICAgICAgICAgICAgfQogICAgICAgICB9CiAKKyAgICAgICAgaWYgKGJyYWNrZXROb3RhdGlvbikg eworICAgICAgICAgICAgaWYgKHByZWZpeC5sZW5ndGggJiYgcHJlZml4WzBdID09PSAiJyIpCisg ICAgICAgICAgICAgICAgdmFyIHF1b3RlVXNlZCA9ICInIjsKKyAgICAgICAgICAgIGVsc2UKKyAg ICAgICAgICAgICAgICB2YXIgcXVvdGVVc2VkID0gIlwiIjsKKyAgICAgICAgfQorCiAgICAgICAg IHZhciByZXN1bHRzID0gW107CiAgICAgICAgIHZhciBwcm9wZXJ0aWVzID0gT2JqZWN0LnNvcnRl ZFByb3BlcnRpZXMocmVzdWx0KTsKICAgICAgICAgZm9yICh2YXIgaSA9IDA7IGkgPCBwcm9wZXJ0 aWVzLmxlbmd0aDsgKytpKSB7CiAgICAgICAgICAgICB2YXIgcHJvcGVydHkgPSBwcm9wZXJ0aWVz W2ldOworICAgICAgICAgICAgaWYgKGJyYWNrZXROb3RhdGlvbikKKyAgICAgICAgICAgICAgICBw cm9wZXJ0eSA9IHF1b3RlVXNlZCArIHByb3BlcnR5LmVzY2FwZUNoYXJhY3RlcnMocXVvdGVVc2Vk ICsgIlxcIikgKyBxdW90ZVVzZWQgKyAiXSI7CiAgICAgICAgICAgICBpZiAocHJvcGVydHkubGVu Z3RoIDwgcHJlZml4Lmxlbmd0aCkKICAgICAgICAgICAgICAgICBjb250aW51ZTsKICAgICAgICAg ICAgIGlmIChwcm9wZXJ0eS5pbmRleE9mKHByZWZpeCkgIT09IDApCg==