178825 2017-10-25 13:25:47 -0700 REGRESSION(r223937): Use of -fobjc-weak causes build failures with older compilers 2017-10-25 14:12:43 -0700 1 1 1 Unclassified WebKit JavaScriptCore Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 msaboff msaboff buildbot commit-queue keith_miller mark.lam saam webkit-bug-importer oldest_to_newest 1364424 0 msaboff 2017-10-25 13:25:47 -0700 Turns out we can eliminate this setting and just turn on ARC for ARM64_32. 1364428 1 webkit-bug-importer 2017-10-25 13:28:56 -0700 <rdar://problem/35181521> 1364434 2 324882 msaboff 2017-10-25 13:34:16 -0700 Created attachment 324882 Patch 1364436 3 324882 mark.lam 2017-10-25 13:35:53 -0700 Comment on attachment 324882 Patch r=me 1364461 4 324882 commit-queue 2017-10-25 14:12:42 -0700 Comment on attachment 324882 Patch Clearing flags on attachment: 324882 Committed r223980: <https://trac.webkit.org/changeset/223980> 1364462 5 commit-queue 2017-10-25 14:12:43 -0700 All reviewed patches have been landed. Closing bug. 324882 2017-10-25 13:34:16 -0700 2017-10-25 14:12:42 -0700 Patch 178825.patch text/plain 1396 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjIzOTc2KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBA CisyMDE3LTEwLTI1ICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIFJFR1JFU1NJT04ocjIyMzkzNyk6IFVzZSBvZiAtZm9iamMtd2VhayBjYXVzZXMgYnVpbGQg ZmFpbHVyZXMgd2l0aCBvbGRlciBjb21waWxlcnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE3ODgyNQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEVuYWJsZSBBUkMgZm9yIEFSTTY0XzMyLiAgVGhpcyBlbGlt aW5hdGUgdGhlIG5lZWQgZm9yIHNldHRpbmcgQ0xBTkdfRU5BQkxFX09CSkNfV0VBSy4KKworICAg ICAgICAqIENvbmZpZ3VyYXRpb25zL1Rvb2xFeGVjdXRhYmxlLnhjY29uZmlnOgorCiAyMDE3LTEw LTI1ICBLZWl0aCBNaWxsZXIgIDxrZWl0aF9taWxsZXJAYXBwbGUuY29tPgogCiAgICAgICAgIEZp eCBpbXBsaWNpdCBjYXN0IG9mIGVudW0sIHdoaWNoIHNlZW1zIHRvIGJyZWFrIHRoZSB3aW5kb3dz IGJ1aWxkIG9mIHVuaWZpZWQgc291cmNlcy4KSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9D b25maWd1cmF0aW9ucy9Ub29sRXhlY3V0YWJsZS54Y2NvbmZpZwo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvQ29uZmlndXJhdGlvbnMvVG9vbEV4ZWN1dGFibGUueGNjb25maWcJ KHJldmlzaW9uIDIyMzk2NykKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9Db25maWd1cmF0aW9u cy9Ub29sRXhlY3V0YWJsZS54Y2NvbmZpZwkod29ya2luZyBjb3B5KQpAQCAtNTAsOCArNTAsNyBA QCBDTEFOR19FTkFCTEVfT0JKQ19BUkNfYXJtdjdrID0gWUVTOwogQ0xBTkdfRU5BQkxFX09CSkNf QVJDX2FybXY3cyA9IFlFUzsKIENMQU5HX0VOQUJMRV9PQkpDX0FSQ19hcm02NCA9IFlFUzsKIENM QU5HX0VOQUJMRV9PQkpDX0FSQ19hcm02NGUgPSBZRVM7Ci0KLUNMQU5HX0VOQUJMRV9PQkpDX1dF QUsgPSBZRVM7CitDTEFOR19FTkFCTEVfT0JKQ19BUkNfYXJtNjRfMzIgPSBZRVM7CiAKIE9USEVS X0NGTEFHUyA9ICQoQVNBTl9PVEhFUl9DRkxBR1MpIC1pc3lzdGVtIGljdTsKIE9USEVSX0xERkxB R1MgPSAkKEFTQU5fT1RIRVJfTERGTEFHUyk7Cg==