178817 2017-10-25 11:16:58 -0700 PerformanceTests/TailBench9000/merge-sort.js does not actually sort any of the large arrays it allocates 2017-11-15 12:47:44 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 rmorisset rmorisset buildbot cdumez commit-queue lforschler rniwa saam webkit-bug-importer oldest_to_newest 1364325 0 rmorisset 2017-10-25 11:16:58 -0700 More precisely, it allocates several arrays, some small, some large, some sorted, some sorted in reverse order, some random... then it only test the sort on the first of these, which is small and already sorted. I have a trivial patch for it. 1364386 1 324863 rmorisset 2017-10-25 12:31:32 -0700 Created attachment 324863 Patch 1364391 2 324863 saam 2017-10-25 12:33:31 -0700 Comment on attachment 324863 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=324863&action=review > PerformanceTests/TailBench9000/merge-sort.js:154 > +noInline(TEST_mergeSort); Why do this? This will make the test not-runnable in browser. 1368584 3 326112 rmorisset 2017-11-06 04:24:41 -0800 Created attachment 326112 Patch for landing 1368587 4 326112 commit-queue 2017-11-06 04:56:55 -0800 Comment on attachment 326112 Patch for landing Clearing flags on attachment: 326112 Committed r224485: <https://trac.webkit.org/changeset/224485> 1368588 5 commit-queue 2017-11-06 04:56:56 -0800 All reviewed patches have been landed. Closing bug. 1372249 6 webkit-bug-importer 2017-11-15 12:47:44 -0800 <rdar://problem/35568073> 324863 2017-10-25 12:31:32 -0700 2017-11-06 04:24:38 -0800 Patch bug-178817-20171025213130.patch text/plain 1695 rmorisset U3VidmVyc2lvbiBSZXZpc2lvbjogMjIzODM0CmRpZmYgLS1naXQgYS9QZXJmb3JtYW5jZVRlc3Rz L0NoYW5nZUxvZyBiL1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCmluZGV4IDI2YjlhOTI0NTkw ZmNjZGM3M2MxODIyZTI4NDI1OGVjNWZkYjI3OTcuLjM1NzAxMDAxOTViOGJiZTEwYmE5MjcwZWVm NTVlMjA2NDhjMGQ2NDcgMTAwNjQ0Ci0tLSBhL1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCisr KyBiL1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTUgQEAKIDIwMTctMTAt MjUgIFJvYmluIE1vcmlzc2V0ICA8cm1vcmlzc2V0QGFwcGxlLmNvbT4KIAorICAgICAgICBQZXJm b3JtYW5jZVRlc3RzL1RhaWxCZW5jaDkwMDAvbWVyZ2Utc29ydC5qcyBkb2VzIG5vdCBhY3R1YWxs eSBzb3J0IGFueSBvZiB0aGUgbGFyZ2UgYXJyYXlzIGl0IGFsbG9jYXRlcworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc4ODE3CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBUYWlsQmVuY2g5MDAwL21lcmdl LXNvcnQuanM6CisgICAgICAgIChURVNUX21lcmdlU29ydCk6CisKKzIwMTctMTAtMjUgIFJvYmlu IE1vcmlzc2V0ICA8cm1vcmlzc2V0QGFwcGxlLmNvbT4KKwogICAgICAgICBBZGQgYSB0aGlyZCBi ZW5jaG1hcmsgdG8gVGFpbEJlbmNoCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNzg4MTUKIApkaWZmIC0tZ2l0IGEvUGVyZm9ybWFuY2VUZXN0cy9UYWls QmVuY2g5MDAwL21lcmdlLXNvcnQuanMgYi9QZXJmb3JtYW5jZVRlc3RzL1RhaWxCZW5jaDkwMDAv bWVyZ2Utc29ydC5qcwppbmRleCA4NTgzNWU3MGQ5N2Y0Yjc2OWI5MzVjZjEzMDFjM2Q4ZmIyYzE4 ZmNiLi4yM2FlYThmZjBjNzIxNTExM2FlYjNkMzlhZDBmYjc2YjBjMmNlMGE1IDEwMDY0NAotLS0g YS9QZXJmb3JtYW5jZVRlc3RzL1RhaWxCZW5jaDkwMDAvbWVyZ2Utc29ydC5qcworKysgYi9QZXJm b3JtYW5jZVRlc3RzL1RhaWxCZW5jaDkwMDAvbWVyZ2Utc29ydC5qcwpAQCAtMTM0LDggKzEzNCw2 IEBAIGZ1bmN0aW9uIFRFU1RfbWVyZ2VTb3J0KCkKICAgICBsZXQgYXJyYXlzID0gWwogICAgICAg ICBidWlsZEFycmF5KDEwLCB4ID0+IHgpLAogICAgICAgICBidWlsZEFycmF5KDEwLCB4ID0+IC14 KSwKLSAgICAgICAgYnVpbGRBcnJheSgxMDAwLCB4ID0+IHgpLAotICAgICAgICBidWlsZEFycmF5 KDEwMDAwLCB4ID0+IC14KSwKICAgICAgICAgYnVpbGRBcnJheSgxMDAwMCwgeCA9PiByYW5kb20o KSkKICAgICBdOwogICAgIApAQCAtMTQ4LDEwICsxNDYsMTIgQEAgZnVuY3Rpb24gVEVTVF9tZXJn ZVNvcnQoKQogICAgICAgICBsZXQgc29ydGVkID0gbWVyZ2VTb3J0ZWQoYXJyYXksIChhLCBiKSA9 PiBhIDwgYiA/IC0xIDogYSA+IGIgPyAxIDogMCk7CiAgICAgICAgIGNoZWNrU29ydGVkKHNvcnRl ZCk7CiAgICAgICAgIGNoZWNrU3BlY3RydW0oYXJyYXksIHNvcnRlZCk7CisgICAgICAgIHRlc3Qo aW5kZXggKyAxKQogICAgIH0KICAgICAKICAgICB0ZXN0KDApOwogfQorbm9JbmxpbmUoVEVTVF9t ZXJnZVNvcnQpOwogCi1mb3IgKHZhciBpID0gMDsgaSA8IDMwMDA7ICsraSkKK2ZvciAodmFyIGkg PSAwOyBpIDwgMTAwOyArK2kpCiAgICAgVEVTVF9tZXJnZVNvcnQoKTsK 326112 2017-11-06 04:24:41 -0800 2017-11-06 04:56:55 -0800 Patch for landing bug-178817-20171106132440.patch text/plain 1589 rmorisset U3VidmVyc2lvbiBSZXZpc2lvbjogMjI0NDg0CmRpZmYgLS1naXQgYS9QZXJmb3JtYW5jZVRlc3Rz L0NoYW5nZUxvZyBiL1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCmluZGV4IGFiMjA1OWFlNDRl MWEzYmE0ODAyYmM3ZmYxOTE5ODkyNTFmYzlhNzcuLjg0YTJhOTYwN2VjODFmMTIwZTZiODM1ZTBi ODNkODkwM2VhOGYwYTkgMTAwNjQ0Ci0tLSBhL1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCisr KyBiL1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTctMTEt MDYgIFJvYmluIE1vcmlzc2V0ICA8cm1vcmlzc2V0QGFwcGxlLmNvbT4KKworICAgICAgICBQZXJm b3JtYW5jZVRlc3RzL1RhaWxCZW5jaDkwMDAvbWVyZ2Utc29ydC5qcyBkb2VzIG5vdCBhY3R1YWxs eSBzb3J0IGFueSBvZiB0aGUgbGFyZ2UgYXJyYXlzIGl0IGFsbG9jYXRlcworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc4ODE3CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgU2FhbSBCYXJhdGkuCisKKyAgICAgICAgKiBUYWlsQmVuY2g5MDAwL21lcmdlLXNv cnQuanM6CisgICAgICAgIChURVNUX21lcmdlU29ydCk6CisKIDIwMTctMTEtMDIgIEpvbiBMZWUg IDxqb25sZWVAYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBsaWNlbnNlIGZvciBNb3Rpb25NYXJr CmRpZmYgLS1naXQgYS9QZXJmb3JtYW5jZVRlc3RzL1RhaWxCZW5jaDkwMDAvbWVyZ2Utc29ydC5q cyBiL1BlcmZvcm1hbmNlVGVzdHMvVGFpbEJlbmNoOTAwMC9tZXJnZS1zb3J0LmpzCmluZGV4IDg1 ODM1ZTcwZDk3ZjRiNzY5YjkzNWNmMTMwMWMzZDhmYjJjMThmY2IuLjQ3MTRiOWNjMzk4NWY2ZmU2 OGU1OWRiYjcxZWY5NmNlMGE4NTRkMGYgMTAwNjQ0Ci0tLSBhL1BlcmZvcm1hbmNlVGVzdHMvVGFp bEJlbmNoOTAwMC9tZXJnZS1zb3J0LmpzCisrKyBiL1BlcmZvcm1hbmNlVGVzdHMvVGFpbEJlbmNo OTAwMC9tZXJnZS1zb3J0LmpzCkBAIC0xMzQsOCArMTM0LDYgQEAgZnVuY3Rpb24gVEVTVF9tZXJn ZVNvcnQoKQogICAgIGxldCBhcnJheXMgPSBbCiAgICAgICAgIGJ1aWxkQXJyYXkoMTAsIHggPT4g eCksCiAgICAgICAgIGJ1aWxkQXJyYXkoMTAsIHggPT4gLXgpLAotICAgICAgICBidWlsZEFycmF5 KDEwMDAsIHggPT4geCksCi0gICAgICAgIGJ1aWxkQXJyYXkoMTAwMDAsIHggPT4gLXgpLAogICAg ICAgICBidWlsZEFycmF5KDEwMDAwLCB4ID0+IHJhbmRvbSgpKQogICAgIF07CiAgICAgCkBAIC0x NDgsMTAgKzE0NiwxMSBAQCBmdW5jdGlvbiBURVNUX21lcmdlU29ydCgpCiAgICAgICAgIGxldCBz b3J0ZWQgPSBtZXJnZVNvcnRlZChhcnJheSwgKGEsIGIpID0+IGEgPCBiID8gLTEgOiBhID4gYiA/ IDEgOiAwKTsKICAgICAgICAgY2hlY2tTb3J0ZWQoc29ydGVkKTsKICAgICAgICAgY2hlY2tTcGVj dHJ1bShhcnJheSwgc29ydGVkKTsKKyAgICAgICAgdGVzdChpbmRleCArIDEpCiAgICAgfQogICAg IAogICAgIHRlc3QoMCk7CiB9CiAKLWZvciAodmFyIGkgPSAwOyBpIDwgMzAwMDsgKytpKQorZm9y ICh2YXIgaSA9IDA7IGkgPCAxMDA7ICsraSkKICAgICBURVNUX21lcmdlU29ydCgpOwo=