178813 2017-10-25 10:41:46 -0700 MediaSessionManager* needs to catch Obj-C exceptions 2017-10-25 11:21:46 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser simon.fraser bburg commit-queue jer.noble simon.fraser thorton webkit-bug-importer oldest_to_newest 1364298 0 simon.fraser 2017-10-25 10:41:46 -0700 MediaSessionManager* needs to catch Obj-C exceptions 1364299 1 324847 simon.fraser 2017-10-25 10:42:49 -0700 Created attachment 324847 Patch 1364301 2 simon.fraser 2017-10-25 10:43:09 -0700 rdar://problem/35042211 1364303 3 webkit-bug-importer 2017-10-25 10:46:15 -0700 <rdar://problem/35177224> 1364314 4 bburg 2017-10-25 11:00:52 -0700 rdar://problem/35042211 1364327 5 324847 commit-queue 2017-10-25 11:21:45 -0700 Comment on attachment 324847 Patch Clearing flags on attachment: 324847 Committed r223963: <https://trac.webkit.org/changeset/223963> 1364328 6 commit-queue 2017-10-25 11:21:46 -0700 All reviewed patches have been landed. Closing bug. 324847 2017-10-25 10:42:49 -0700 2017-10-25 11:21:45 -0700 Patch bug-178813-20171025104249.patch text/plain 7070 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjIzOTQ3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODEwYTJmMDQ4YzRhNTky MmNiMzZhNTdkNWZjYmQ2NjhkODIxOGE4ZC4uYmVmOTVlNjUwY2E4MGI1ZmU1MWQ3ZWE3MzdmZWJk NWNhNDAyMWNkNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDE3LTEwLTI1ICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIE1lZGlhU2Vzc2lv bk1hbmFnZXIqIG5lZWRzIHRvIGNhdGNoIE9iai1DIGV4Y2VwdGlvbnMKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3ODgxMworCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdyYXAgYWxsIGNhbGxzIG91dCB0byBP YmplY3RpdmUtQyB3aXRoIEJFR0lOX0JMT0NLX09CSkNfRVhDRVBUSU9OUy9FTkRfQkxPQ0tfT0JK Q19FWENFUFRJT05TLgorCisgICAgICAgICogcGxhdGZvcm0vYXVkaW8vaW9zL01lZGlhU2Vzc2lv bk1hbmFnZXJJT1MubW06CisgICAgICAgIChXZWJDb3JlOjpNZWRpYVNlc3Npb25NYW5hZ2VyaU9T OjpNZWRpYVNlc3Npb25NYW5hZ2VyaU9TKToKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhU2Vzc2lv bk1hbmFnZXJpT1M6On5NZWRpYVNlc3Npb25NYW5hZ2VyaU9TKToKKyAgICAgICAgKFdlYkNvcmU6 Ok1lZGlhU2Vzc2lvbk1hbmFnZXJpT1M6Omhhc1dpcmVsZXNzVGFyZ2V0c0F2YWlsYWJsZSk6Cisg ICAgICAgIChXZWJDb3JlOjpNZWRpYVNlc3Npb25NYW5hZ2VyaU9TOjpjb25maWd1cmVXaXJlTGVz c1RhcmdldE1vbml0b3JpbmcpOgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFTZXNzaW9uTWFuYWdl cmlPUzo6dXBkYXRlTm93UGxheWluZ0luZm8pOgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFTZXNz aW9uTWFuYWdlcmlPUzo6ZXh0ZXJuYWxPdXRwdXREZXZpY2VBdmFpbGFibGVEaWRDaGFuZ2UpOgor ICAgICAgICAoLVtXZWJNZWRpYVNlc3Npb25IZWxwZXIgYWxsb2NhdGVWb2x1bWVWaWV3XSk6Cisg ICAgICAgICgtW1dlYk1lZGlhU2Vzc2lvbkhlbHBlciBpbml0V2l0aENhbGxiYWNrOl0pOgorICAg ICAgICAqIHBsYXRmb3JtL2F1ZGlvL21hYy9NZWRpYVNlc3Npb25NYW5hZ2VyTWFjLm1tOgorICAg ICAgICAoV2ViQ29yZTo6TWVkaWFTZXNzaW9uTWFuYWdlck1hYzo6dXBkYXRlTm93UGxheWluZ0lu Zm8pOgorCiAyMDE3LTEwLTI0ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAg ICAgICAgIFJlbmRlclNWR01vZGVsT2JqZWN0OjpjaGVja0ludGVyc2VjdGlvbiB0cmlnZ2VycyBs YXlvdXQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2F1ZGlvL2lvcy9NZWRp YVNlc3Npb25NYW5hZ2VySU9TLm1tIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVkaW8vaW9z L01lZGlhU2Vzc2lvbk1hbmFnZXJJT1MubW0KaW5kZXggOTFiZTU5NjJlZDg1ZjI4YmY3ZDU0NjJm MWRhYzE2M2I2MDFiNmEwYi4uYWY1Mjk1MDEwYzM5YWExZTQ5Zjc5M2JiMTM5OTBiODU3OTM5MDQ0 YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVkaW8vaW9zL01lZGlhU2Vz c2lvbk1hbmFnZXJJT1MubW0KKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVkaW8vaW9z L01lZGlhU2Vzc2lvbk1hbmFnZXJJT1MubW0KQEAgLTQwLDYgKzQwLDcgQEAKICNpbXBvcnQgPFVJ S2l0L1VJQXBwbGljYXRpb24uaD4KICNpbXBvcnQgPG9iamMvcnVudGltZS5oPgogI2ltcG9ydCA8 cGFsL3NwaS9pb3MvTWVkaWFQbGF5ZXJTUEkuaD4KKyNpbXBvcnQgPHd0Zi9CbG9ja09iakNFeGNl cHRpb25zLmg+CiAjaW1wb3J0IDx3dGYvTWFpblRocmVhZC5oPgogI2ltcG9ydCA8d3RmL1JBTVNp emUuaD4KICNpbXBvcnQgPHd0Zi9SZXRhaW5QdHIuaD4KQEAgLTEzMCwxNCArMTMxLDE5IEBAIFBs YXRmb3JtTWVkaWFTZXNzaW9uTWFuYWdlciogUGxhdGZvcm1NZWRpYVNlc3Npb25NYW5hZ2VyOjpz aGFyZWRNYW5hZ2VySWZFeGlzdHMoCiAKIE1lZGlhU2Vzc2lvbk1hbmFnZXJpT1M6Ok1lZGlhU2Vz c2lvbk1hbmFnZXJpT1MoKQogICAgIDogUGxhdGZvcm1NZWRpYVNlc3Npb25NYW5hZ2VyKCkKLSAg ICAsIG1fb2JqY09ic2VydmVyKGFkb3B0TlMoW1tXZWJNZWRpYVNlc3Npb25IZWxwZXIgYWxsb2Nd IGluaXRXaXRoQ2FsbGJhY2s6dGhpc10pKQogeworICAgIEJFR0lOX0JMT0NLX09CSkNfRVhDRVBU SU9OUworICAgIG1fb2JqY09ic2VydmVyID0gYWRvcHROUyhbW1dlYk1lZGlhU2Vzc2lvbkhlbHBl ciBhbGxvY10gaW5pdFdpdGhDYWxsYmFjazp0aGlzXSk7CisgICAgRU5EX0JMT0NLX09CSkNfRVhD RVBUSU9OUwogICAgIHJlc2V0UmVzdHJpY3Rpb25zKCk7CiB9CiAKIE1lZGlhU2Vzc2lvbk1hbmFn ZXJpT1M6On5NZWRpYVNlc3Npb25NYW5hZ2VyaU9TKCkKIHsKKyAgICBCRUdJTl9CTE9DS19PQkpD X0VYQ0VQVElPTlMKICAgICBbbV9vYmpjT2JzZXJ2ZXIgY2xlYXJDYWxsYmFja107CisgICAgbV9v YmpjT2JzZXJ2ZXIgPSBuaWw7CisgICAgRU5EX0JMT0NLX09CSkNfRVhDRVBUSU9OUwogfQogCiB2 b2lkIE1lZGlhU2Vzc2lvbk1hbmFnZXJpT1M6OnJlc2V0UmVzdHJpY3Rpb25zKCkKQEAgLTE1OSw3 ICsxNjUsOSBAQCB2b2lkIE1lZGlhU2Vzc2lvbk1hbmFnZXJpT1M6OnJlc2V0UmVzdHJpY3Rpb25z KCkKIAogYm9vbCBNZWRpYVNlc3Npb25NYW5hZ2VyaU9TOjpoYXNXaXJlbGVzc1RhcmdldHNBdmFp bGFibGUoKQogeworICAgIEJFR0lOX0JMT0NLX09CSkNfRVhDRVBUSU9OUwogICAgIHJldHVybiBb bV9vYmpjT2JzZXJ2ZXIgaGFzV2lyZWxlc3NUYXJnZXRzQXZhaWxhYmxlXTsKKyAgICBFTkRfQkxP Q0tfT0JKQ19FWENFUFRJT05TCiB9CiAKIHZvaWQgTWVkaWFTZXNzaW9uTWFuYWdlcmlPUzo6Y29u ZmlndXJlV2lyZUxlc3NUYXJnZXRNb25pdG9yaW5nKCkKQEAgLTE3MCwxMCArMTc4LDE0IEBAIHZv aWQgTWVkaWFTZXNzaW9uTWFuYWdlcmlPUzo6Y29uZmlndXJlV2lyZUxlc3NUYXJnZXRNb25pdG9y aW5nKCkKIAogICAgIExPRyhNZWRpYSwgIk1lZGlhU2Vzc2lvbk1hbmFnZXJpT1M6OmNvbmZpZ3Vy ZVdpcmVMZXNzVGFyZ2V0TW9uaXRvcmluZyAtIHJlcXVpcmVzTW9uaXRvcmluZyA9ICVzIiwgcmVx dWlyZXNNb25pdG9yaW5nID8gInRydWUiIDogImZhbHNlIik7CiAKKyAgICBCRUdJTl9CTE9DS19P QkpDX0VYQ0VQVElPTlMKKwogICAgIGlmIChyZXF1aXJlc01vbml0b3JpbmcpCiAgICAgICAgIFtt X29iamNPYnNlcnZlciBzdGFydE1vbml0b3JpbmdBaXJQbGF5Um91dGVzXTsKICAgICBlbHNlCiAg ICAgICAgIFttX29iamNPYnNlcnZlciBzdG9wTW9uaXRvcmluZ0FpclBsYXlSb3V0ZXNdOworCisg ICAgRU5EX0JMT0NLX09CSkNfRVhDRVBUSU9OUwogfQogCiBib29sIE1lZGlhU2Vzc2lvbk1hbmFn ZXJpT1M6OnNlc3Npb25XaWxsQmVnaW5QbGF5YmFjayhQbGF0Zm9ybU1lZGlhU2Vzc2lvbiYgc2Vz c2lvbikKQEAgLTIyMiw2ICsyMzQsNyBAQCBQbGF0Zm9ybU1lZGlhU2Vzc2lvbiogTWVkaWFTZXNz aW9uTWFuYWdlcmlPUzo6bm93UGxheWluZ0VsaWdpYmxlU2Vzc2lvbigpCiAKIHZvaWQgTWVkaWFT ZXNzaW9uTWFuYWdlcmlPUzo6dXBkYXRlTm93UGxheWluZ0luZm8oKQogeworICAgIEJFR0lOX0JM T0NLX09CSkNfRVhDRVBUSU9OUwogICAgIE1QTm93UGxheWluZ0luZm9DZW50ZXIgKm5vd1BsYXlp bmcgPSAoTVBOb3dQbGF5aW5nSW5mb0NlbnRlciAqKVtnZXRNUE5vd1BsYXlpbmdJbmZvQ2VudGVy Q2xhc3MoKSBkZWZhdWx0Q2VudGVyXTsKICAgICBjb25zdCBQbGF0Zm9ybU1lZGlhU2Vzc2lvbiog Y3VycmVudFNlc3Npb24gPSB0aGlzLT5ub3dQbGF5aW5nRWxpZ2libGVTZXNzaW9uKCk7CiAKQEAg LTI2Niw2ICsyNzksNyBAQCB2b2lkIE1lZGlhU2Vzc2lvbk1hbmFnZXJpT1M6OnVwZGF0ZU5vd1Bs YXlpbmdJbmZvKCkKIAogICAgIG1fbm93UGxheWluZ0FjdGl2ZSA9IHRydWU7CiAgICAgW25vd1Bs YXlpbmcgc2V0Tm93UGxheWluZ0luZm86aW5mby5nZXQoKV07CisgICAgRU5EX0JMT0NLX09CSkNf RVhDRVBUSU9OUwogfQogCiBib29sIE1lZGlhU2Vzc2lvbk1hbmFnZXJpT1M6OnNlc3Npb25DYW5M b2FkTWVkaWEoY29uc3QgUGxhdGZvcm1NZWRpYVNlc3Npb24mIHNlc3Npb24pIGNvbnN0CkBAIC0y NzgsOSArMjkyLDExIEBAIGJvb2wgTWVkaWFTZXNzaW9uTWFuYWdlcmlPUzo6c2Vzc2lvbkNhbkxv YWRNZWRpYShjb25zdCBQbGF0Zm9ybU1lZGlhU2Vzc2lvbiYgc2VzCiAKIHZvaWQgTWVkaWFTZXNz aW9uTWFuYWdlcmlPUzo6ZXh0ZXJuYWxPdXRwdXREZXZpY2VBdmFpbGFibGVEaWRDaGFuZ2UoKQog eworICAgIEJFR0lOX0JMT0NLX09CSkNfRVhDRVBUSU9OUwogICAgIGZvckVhY2hTZXNzaW9uKFto YXZlVGFyZ2V0cyA9IFttX29iamNPYnNlcnZlciBoYXNXaXJlbGVzc1RhcmdldHNBdmFpbGFibGVd XSAoUGxhdGZvcm1NZWRpYVNlc3Npb24mIHNlc3Npb24sIHNpemVfdCkgewogICAgICAgICBzZXNz aW9uLmV4dGVybmFsT3V0cHV0RGV2aWNlQXZhaWxhYmxlRGlkQ2hhbmdlKGhhdmVUYXJnZXRzKTsK ICAgICB9KTsKKyAgICBFTkRfQkxPQ0tfT0JKQ19FWENFUFRJT05TCiB9CiAKIH0gLy8gbmFtZXNw YWNlIFdlYkNvcmUKQEAgLTI5NiwxMCArMzEyLDE0IEBAIC0gKHZvaWQpYWxsb2NhdGVWb2x1bWVW aWV3CiAKICAgICBSZXRhaW5QdHI8V2ViTWVkaWFTZXNzaW9uSGVscGVyPiBzdHJvbmdTZWxmID0g c2VsZjsKICAgICBkaXNwYXRjaF9hc3luYyhkaXNwYXRjaF9nZXRfbWFpbl9xdWV1ZSgpLCBbc3Ry b25nU2VsZl0oKSB7CisgICAgICAgIEJFR0lOX0JMT0NLX09CSkNfRVhDRVBUSU9OUwogICAgICAg ICBSZXRhaW5QdHI8TVBWb2x1bWVWaWV3PiB2b2x1bWVWaWV3ID0gYWRvcHROUyhbYWxsb2NNUFZv bHVtZVZpZXdJbnN0YW5jZSgpIGluaXRdKTsKICAgICAgICAgY2FsbE9uV2ViVGhyZWFkT3JEaXNw YXRjaEFzeW5jT25NYWluVGhyZWFkKFtzdHJvbmdTZWxmLCB2b2x1bWVWaWV3XSgpIHsKKyAgICAg ICAgICAgIEJFR0lOX0JMT0NLX09CSkNfRVhDRVBUSU9OUwogICAgICAgICAgICAgW3N0cm9uZ1Nl bGYgc2V0Vm9sdW1lVmlldzp2b2x1bWVWaWV3XTsKKyAgICAgICAgICAgIEVORF9CTE9DS19PQkpD X0VYQ0VQVElPTlMKICAgICAgICAgfSk7CisgICAgICAgIEVORF9CTE9DS19PQkpDX0VYQ0VQVElP TlMKICAgICB9KTsKIH0KIApAQCAtMzM5LDcgKzM1OSw5IEBAIC0gKGlkKWluaXRXaXRoQ2FsbGJh Y2s6KE1lZGlhU2Vzc2lvbk1hbmFnZXJpT1MqKWNhbGxiYWNrCiAKICAgICAvLyBOb3cgcGxheWlu ZyB3b24ndCB3b3JrIHVubGVzcyB3ZSB0dXJuIG9uIHRoZSBkZWxpdmVyeSBvZiByZW1vdGUgY29u dHJvbCBldmVudHMuCiAgICAgZGlzcGF0Y2hfYXN5bmMoZGlzcGF0Y2hfZ2V0X21haW5fcXVldWUo KSwgXiB7CisgICAgICAgIEJFR0lOX0JMT0NLX09CSkNfRVhDRVBUSU9OUwogICAgICAgICBbW1VJ QXBwbGljYXRpb24gc2hhcmVkQXBwbGljYXRpb25dIGJlZ2luUmVjZWl2aW5nUmVtb3RlQ29udHJv bEV2ZW50c107CisgICAgICAgIEVORF9CTE9DS19PQkpDX0VYQ0VQVElPTlMKICAgICB9KTsKIAog ICAgIHJldHVybiBzZWxmOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVk aW8vbWFjL01lZGlhU2Vzc2lvbk1hbmFnZXJNYWMubW0gYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9hdWRpby9tYWMvTWVkaWFTZXNzaW9uTWFuYWdlck1hYy5tbQppbmRleCBiM2M4Nzc2ODE5YmRi OWI3YTBhMTkzNGIwOGY0ZDQzY2FjMTJlYTVmLi5mMDVmMDI3YmJmZGU2Y2E4YzQzYzBlZmQ4ODUx YjljZGRiYTY0YWU5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9t YWMvTWVkaWFTZXNzaW9uTWFuYWdlck1hYy5tbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9hdWRpby9tYWMvTWVkaWFTZXNzaW9uTWFuYWdlck1hYy5tbQpAQCAtMzIsNiArMzIsNyBAQAog I2ltcG9ydCAiTG9nZ2luZy5oIgogI2ltcG9ydCAiTWVkaWFQbGF5ZXIuaCIKICNpbXBvcnQgIlBs YXRmb3JtTWVkaWFTZXNzaW9uLmgiCisjaW1wb3J0IDx3dGYvQmxvY2tPYmpDRXhjZXB0aW9ucy5o PgogCiAjaW1wb3J0ICJNZWRpYVJlbW90ZVNvZnRMaW5rLmgiCiAKQEAgLTEyNCw2ICsxMjUsOCBA QCB2b2lkIE1lZGlhU2Vzc2lvbk1hbmFnZXJNYWM6OnVwZGF0ZU5vd1BsYXlpbmdJbmZvKCkKICAg ICBpZiAoIWlzTWVkaWFSZW1vdGVGcmFtZXdvcmtBdmFpbGFibGUoKSkKICAgICAgICAgcmV0dXJu OwogCisgICAgQkVHSU5fQkxPQ0tfT0JKQ19FWENFUFRJT05TCisKICAgICBjb25zdCBQbGF0Zm9y bU1lZGlhU2Vzc2lvbiogY3VycmVudFNlc3Npb24gPSB0aGlzLT5ub3dQbGF5aW5nRWxpZ2libGVT ZXNzaW9uKCk7CiAKICAgICBMT0coTWVkaWEsICJNZWRpYVNlc3Npb25NYW5hZ2VyTWFjOjp1cGRh dGVOb3dQbGF5aW5nSW5mbyAtIGN1cnJlbnRTZXNzaW9uID0gJXAiLCBjdXJyZW50U2Vzc2lvbik7 CkBAIC0yMDIsNyArMjA1LDggQEAgdm9pZCBNZWRpYVNlc3Npb25NYW5hZ2VyTWFjOjp1cGRhdGVO b3dQbGF5aW5nSW5mbygpCiAgICAgICAgIE1STm93UGxheWluZ0NsaWVudFZpc2liaWxpdHkgdmlz aWJpbGl0eSA9IGN1cnJlbnRTZXNzaW9uLT5hbGxvd3NOb3dQbGF5aW5nQ29udHJvbHNWaXNpYmls aXR5KCkgPyBNUk5vd1BsYXlpbmdDbGllbnRWaXNpYmlsaXR5QWx3YXlzVmlzaWJsZSA6IE1STm93 UGxheWluZ0NsaWVudFZpc2liaWxpdHlOZXZlclZpc2libGU7CiAgICAgICAgIE1STWVkaWFSZW1v dGVTZXROb3dQbGF5aW5nVmlzaWJpbGl0eShNUk1lZGlhUmVtb3RlR2V0TG9jYWxPcmlnaW4oKSwg dmlzaWJpbGl0eSk7CiAgICAgfQotI2VuZGlmCisgICAgRU5EX0JMT0NLX09CSkNfRVhDRVBUSU9O UworI2VuZGlmIC8vIFVTRShNRURJQVJFTU9URSkKIH0KIAogfSAvLyBuYW1lc3BhY2UgV2ViQ29y ZQo=