178808 2017-10-25 10:23:44 -0700 REGRESSION: Web Inspector: context menu actions "Download Image" and "Open Image in New Window" don't work 2017-11-28 13:02:31 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 bburg webkit-unassigned bburg commit-queue inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1364276 0 bburg 2017-10-25 10:23:44 -0700 This reproduces for data URL images as well as normal images. This may have regressed with recent changes to adopt WKWebInspectorView on Mac port. 1364277 1 webkit-bug-importer 2017-10-25 10:24:20 -0700 <rdar://problem/35176608> 1375453 2 327769 joepeck 2017-11-28 12:05:01 -0800 Created attachment 327769 [PATCH] Proposed Fix 1375468 3 327769 bburg 2017-11-28 12:42:14 -0800 Comment on attachment 327769 [PATCH] Proposed Fix r=me 1375483 4 327769 commit-queue 2017-11-28 13:02:30 -0800 Comment on attachment 327769 [PATCH] Proposed Fix Clearing flags on attachment: 327769 Committed r225234: <https://trac.webkit.org/changeset/225234> 1375484 5 commit-queue 2017-11-28 13:02:31 -0800 All reviewed patches have been landed. Closing bug. 327769 2017-11-28 12:05:01 -0800 2017-11-28 13:02:30 -0800 [PATCH] Proposed Fix context-menu-1.patch text/plain 6317 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggNzdhOGQwODE5N2YuLjI0ZWZlMDE1ODEyIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwzICsx LDIxIEBACisyMDE3LTExLTI4ICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+ CisKKyAgICAgICAgUkVHUkVTU0lPTjogV2ViIEluc3BlY3RvcjogY29udGV4dCBtZW51IGFjdGlv bnMgIkRvd25sb2FkIEltYWdlIiBhbmQgIk9wZW4gSW1hZ2UgaW4gTmV3IFdpbmRvdyIgZG9uJ3Qg d29yaworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc4 ODA4CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zNTE3NjYwOD4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9tYWMvV0tJbnNwZWN0 b3JWaWV3Q29udHJvbGxlci5tbToKKyAgICAgICAgKC1bV0tJbnNwZWN0b3JWaWV3Q29udHJvbGxl ciBfd2ViVmlldzpjb250ZXh0TWVudTpmb3JFbGVtZW50Ol0pOgorICAgICAgICBDb250aW51ZSB0 byBoaWRlIHRoZSBpbWFnZSBjb250ZXh0IG1lbnUgYWN0aW9ucyBsaWtlIHdlIHVzZWQgdG8uCisg ICAgICAgIEludmVzdGlnYXRpbmcgbWFraW5nIHRoZXNlIGNvbnRleHQgbWVudXMgd29yayBjYW4g YmUgZG9uZSBhcyBhCisgICAgICAgIGZvbGxvdy11cCB0YXNrLgorCisgICAgICAgICogVUlQcm9j ZXNzL21hYy9XS1dlYkluc3BlY3RvcldLV2ViVmlldy5tbToKKyAgICAgICAgKC1bV0tXZWJJbnNw ZWN0b3JXS1dlYlZpZXcgaW5pdFdpdGhGcmFtZTpjb25maWd1cmF0aW9uOl0pOgorICAgICAgICBV c2UgbnVsbHB0ciBpbnN0ZWFkIG9mIDAuCisKIDIwMTctMTEtMjcgIENocmlzIER1bWV6ICA8Y2R1 bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBHaXZlIERvY3VtZW50IGEgc3Ryb25nbHkgdHlwZWQg aWRlbnRpZmllciBpbnN0ZWFkIG9mIGEgdWludDY0X3QKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQvVUlQcm9jZXNzL21hYy9XS0luc3BlY3RvclZpZXdDb250cm9sbGVyLm1tIGIvU291cmNlL1dl YktpdC9VSVByb2Nlc3MvbWFjL1dLSW5zcGVjdG9yVmlld0NvbnRyb2xsZXIubW0KaW5kZXggZmUx MmIxYWU2ZjUuLmFhNmIwYzZhNjRlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vz cy9tYWMvV0tJbnNwZWN0b3JWaWV3Q29udHJvbGxlci5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L1VJ UHJvY2Vzcy9tYWMvV0tJbnNwZWN0b3JWaWV3Q29udHJvbGxlci5tbQpAQCAtMTg5LDYgKzE4OSwy NyBAQCAtICh2b2lkKV93ZWJWaWV3OihXS1dlYlZpZXcgKil3ZWJWaWV3IGRlY2lkZURhdGFiYXNl UXVvdGFGb3JTZWN1cml0eU9yaWdpbjooV0tTZQogICAgIGRlY2lzaW9uSGFuZGxlcihzdGQ6Om1h eDx1bnNpZ25lZCBsb25nIGxvbmc+KGV4cGVjdGVkVXNhZ2UsIGN1cnJlbnRVc2FnZSAqIDEuMjUp KTsKIH0KIAorLSAoTlNNZW51ICopX3dlYlZpZXc6KFdLV2ViVmlldyAqKXdlYlZpZXcgY29udGV4 dE1lbnU6KE5TTWVudSAqKW1lbnUgZm9yRWxlbWVudDooX1dLQ29udGV4dE1lbnVFbGVtZW50SW5m byAqKWVsZW1lbnQKK3sKKyAgICBmb3IgKE5TSW50ZWdlciBpID0gbWVudS5udW1iZXJPZkl0ZW1z IC0gMTsgaSA+PSAwOyAtLWkpIHsKKyAgICAgICAgTlNNZW51SXRlbSAqaXRlbSA9IFttZW51IGl0 ZW1BdEluZGV4OmldOworICAgICAgICBzd2l0Y2ggKGl0ZW0udGFnKSB7CisgICAgICAgIGNhc2Ug a1dLQ29udGV4dE1lbnVJdGVtVGFnT3BlbkxpbmtJbk5ld1dpbmRvdzoKKyAgICAgICAgY2FzZSBr V0tDb250ZXh0TWVudUl0ZW1UYWdPcGVuSW1hZ2VJbk5ld1dpbmRvdzoKKyAgICAgICAgY2FzZSBr V0tDb250ZXh0TWVudUl0ZW1UYWdPcGVuRnJhbWVJbk5ld1dpbmRvdzoKKyAgICAgICAgY2FzZSBr V0tDb250ZXh0TWVudUl0ZW1UYWdPcGVuTWVkaWFJbk5ld1dpbmRvdzoKKyAgICAgICAgY2FzZSBr V0tDb250ZXh0TWVudUl0ZW1UYWdDb3B5SW1hZ2VVcmxUb0NsaXBib2FyZDoKKyAgICAgICAgY2Fz ZSBrV0tDb250ZXh0TWVudUl0ZW1UYWdDb3B5SW1hZ2VUb0NsaXBib2FyZDoKKyAgICAgICAgY2Fz ZSBrV0tDb250ZXh0TWVudUl0ZW1UYWdEb3dubG9hZExpbmtUb0Rpc2s6CisgICAgICAgIGNhc2Ug a1dLQ29udGV4dE1lbnVJdGVtVGFnRG93bmxvYWRJbWFnZVRvRGlzazoKKyAgICAgICAgICAgIFtt ZW51IHJlbW92ZUl0ZW1BdEluZGV4OmldOworICAgICAgICAgICAgYnJlYWs7CisgICAgICAgIH0K KyAgICB9CisKKyAgICByZXR1cm4gbWVudTsKK30KKwogLy8gTUFSSzogV0tOYXZpZ2F0aW9uRGVs ZWdhdGUgbWV0aG9kcwogCiAtICh2b2lkKXdlYlZpZXdXZWJDb250ZW50UHJvY2Vzc0RpZFRlcm1p bmF0ZTooV0tXZWJWaWV3ICopd2ViVmlldwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVBy b2Nlc3MvbWFjL1dLV2ViSW5zcGVjdG9yV0tXZWJWaWV3Lm1tIGIvU291cmNlL1dlYktpdC9VSVBy b2Nlc3MvbWFjL1dLV2ViSW5zcGVjdG9yV0tXZWJWaWV3Lm1tCmluZGV4IGEyOThkYWJlYmM1Li4x MzVhYmJhMTU0YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvbWFjL1dLV2Vi SW5zcGVjdG9yV0tXZWJWaWV3Lm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL21hYy9X S1dlYkluc3BlY3RvcldLV2ViVmlldy5tbQpAQCAtMTE1LDUyICsxMTUsNTIgQEAgLSAoaW5zdGFu Y2V0eXBlKWluaXRXaXRoRnJhbWU6KENHUmVjdClmcmFtZSBjb25maWd1cmF0aW9uOihXS1dlYlZp ZXdDb25maWd1cmF0aW8KIAogICAgIFdLUGFnZVVJQ2xpZW50VjIgdWlDbGllbnQgPSB7CiAgICAg ICAgIHsgMiwgc2VsZiB9LAotICAgICAgICAwLCAvLyBjcmVhdGVOZXdQYWdlX2RlcHJlY2F0ZWRG b3JVc2VXaXRoVjAKLSAgICAgICAgMCwgLy8gc2hvd1BhZ2UKLSAgICAgICAgMCwgLy8gY2xvc2VQ YWdlCi0gICAgICAgIDAsIC8vIHRha2VGb2N1cwotICAgICAgICAwLCAvLyBmb2N1cwotICAgICAg ICAwLCAvLyB1bmZvY3VzCi0gICAgICAgIDAsIC8vIHJ1bkphdmFTY3JpcHRBbGVydAotICAgICAg ICAwLCAvLyBydW5KYXZhU2NyaXB0Q29uZmlybQotICAgICAgICAwLCAvLyBydW5KYXZhU2NyaXB0 UHJvbXB0Ci0gICAgICAgIDAsIC8vIHNldFN0YXR1c1RleHQKLSAgICAgICAgMCwgLy8gbW91c2VE aWRNb3ZlT3ZlckVsZW1lbnRfZGVwcmVjYXRlZEZvclVzZVdpdGhWMAotICAgICAgICAwLCAvLyBt aXNzaW5nUGx1Z2luQnV0dG9uQ2xpY2tlZF9kZXByZWNhdGVkRm9yVXNlV2l0aFYwCi0gICAgICAg IDAsIC8vIGRpZE5vdEhhbmRsZUtleUV2ZW50Ci0gICAgICAgIDAsIC8vIGRpZE5vdEhhbmRsZVdo ZWVsRXZlbnQKLSAgICAgICAgMCwgLy8gYXJlVG9vbGJhcnNWaXNpYmxlCi0gICAgICAgIDAsIC8v IHNldFRvb2xiYXJzVmlzaWJsZQotICAgICAgICAwLCAvLyBpc01lbnVCYXJWaXNpYmxlCi0gICAg ICAgIDAsIC8vIHNldE1lbnVCYXJWaXNpYmxlCi0gICAgICAgIDAsIC8vIGlzU3RhdHVzQmFyVmlz aWJsZQotICAgICAgICAwLCAvLyBzZXRTdGF0dXNCYXJWaXNpYmxlCi0gICAgICAgIDAsIC8vIGlz UmVzaXphYmxlCi0gICAgICAgIDAsIC8vIHNldFJlc2l6YWJsZQorICAgICAgICBudWxscHRyLCAv LyBjcmVhdGVOZXdQYWdlX2RlcHJlY2F0ZWRGb3JVc2VXaXRoVjAKKyAgICAgICAgbnVsbHB0ciwg Ly8gc2hvd1BhZ2UKKyAgICAgICAgbnVsbHB0ciwgLy8gY2xvc2VQYWdlCisgICAgICAgIG51bGxw dHIsIC8vIHRha2VGb2N1cworICAgICAgICBudWxscHRyLCAvLyBmb2N1cworICAgICAgICBudWxs cHRyLCAvLyB1bmZvY3VzCisgICAgICAgIG51bGxwdHIsIC8vIHJ1bkphdmFTY3JpcHRBbGVydAor ICAgICAgICBudWxscHRyLCAvLyBydW5KYXZhU2NyaXB0Q29uZmlybQorICAgICAgICBudWxscHRy LCAvLyBydW5KYXZhU2NyaXB0UHJvbXB0CisgICAgICAgIG51bGxwdHIsIC8vIHNldFN0YXR1c1Rl eHQKKyAgICAgICAgbnVsbHB0ciwgLy8gbW91c2VEaWRNb3ZlT3ZlckVsZW1lbnRfZGVwcmVjYXRl ZEZvclVzZVdpdGhWMAorICAgICAgICBudWxscHRyLCAvLyBtaXNzaW5nUGx1Z2luQnV0dG9uQ2xp Y2tlZF9kZXByZWNhdGVkRm9yVXNlV2l0aFYwCisgICAgICAgIG51bGxwdHIsIC8vIGRpZE5vdEhh bmRsZUtleUV2ZW50CisgICAgICAgIG51bGxwdHIsIC8vIGRpZE5vdEhhbmRsZVdoZWVsRXZlbnQK KyAgICAgICAgbnVsbHB0ciwgLy8gYXJlVG9vbGJhcnNWaXNpYmxlCisgICAgICAgIG51bGxwdHIs IC8vIHNldFRvb2xiYXJzVmlzaWJsZQorICAgICAgICBudWxscHRyLCAvLyBpc01lbnVCYXJWaXNp YmxlCisgICAgICAgIG51bGxwdHIsIC8vIHNldE1lbnVCYXJWaXNpYmxlCisgICAgICAgIG51bGxw dHIsIC8vIGlzU3RhdHVzQmFyVmlzaWJsZQorICAgICAgICBudWxscHRyLCAvLyBzZXRTdGF0dXNC YXJWaXNpYmxlCisgICAgICAgIG51bGxwdHIsIC8vIGlzUmVzaXphYmxlCisgICAgICAgIG51bGxw dHIsIC8vIHNldFJlc2l6YWJsZQogICAgICAgICBnZXRXaW5kb3dGcmFtZSwKICAgICAgICAgc2V0 V2luZG93RnJhbWUsCi0gICAgICAgIDAsIC8vIHJ1bkJlZm9yZVVubG9hZENvbmZpcm1QYW5lbAot ICAgICAgICAwLCAvLyBkaWREcmF3Ci0gICAgICAgIDAsIC8vIHBhZ2VEaWRTY3JvbGwKKyAgICAg ICAgbnVsbHB0ciwgLy8gcnVuQmVmb3JlVW5sb2FkQ29uZmlybVBhbmVsCisgICAgICAgIG51bGxw dHIsIC8vIGRpZERyYXcKKyAgICAgICAgbnVsbHB0ciwgLy8gcGFnZURpZFNjcm9sbAogICAgICAg ICBleGNlZWRlZERhdGFiYXNlUXVvdGEsCiAgICAgICAgIHJ1bk9wZW5QYW5lbCwKLSAgICAgICAg MCwgLy8gZGVjaWRlUG9saWN5Rm9yR2VvbG9jYXRpb25QZXJtaXNzaW9uUmVxdWVzdAotICAgICAg ICAwLCAvLyBoZWFkZXJIZWlnaHQKLSAgICAgICAgMCwgLy8gZm9vdGVySGVpZ2h0Ci0gICAgICAg IDAsIC8vIGRyYXdIZWFkZXIKLSAgICAgICAgMCwgLy8gZHJhd0Zvb3RlcgotICAgICAgICAwLCAv LyBwcmludEZyYW1lCi0gICAgICAgIDAsIC8vIHJ1bk1vZGFsCi0gICAgICAgIDAsIC8vIHVudXNl ZAotICAgICAgICAwLCAvLyBzYXZlRGF0YVRvRmlsZUluRG93bmxvYWRzRm9sZGVyCi0gICAgICAg IDAsIC8vIHNob3VsZEludGVycnVwdEphdmFTY3JpcHQKLSAgICAgICAgMCwgLy8gY3JlYXRlUGFn ZQotICAgICAgICAwLCAvLyBtb3VzZURpZE1vdmVPdmVyRWxlbWVudAotICAgICAgICAwLCAvLyBk ZWNpZGVQb2xpY3lGb3JOb3RpZmljYXRpb25QZXJtaXNzaW9uUmVxdWVzdAotICAgICAgICAwLCAv LyB1bmF2YWlsYWJsZVBsdWdpbkJ1dHRvbkNsaWNrZWRfZGVwcmVjYXRlZEZvclVzZVdpdGhWMQot ICAgICAgICAwLCAvLyBzaG93Q29sb3JQaWNrZXIKLSAgICAgICAgMCwgLy8gaGlkZUNvbG9yUGlj a2VyCi0gICAgICAgIDAsIC8vIHVuYXZhaWxhYmxlUGx1Z2luQnV0dG9uQ2xpY2tlZAorICAgICAg ICBudWxscHRyLCAvLyBkZWNpZGVQb2xpY3lGb3JHZW9sb2NhdGlvblBlcm1pc3Npb25SZXF1ZXN0 CisgICAgICAgIG51bGxwdHIsIC8vIGhlYWRlckhlaWdodAorICAgICAgICBudWxscHRyLCAvLyBm b290ZXJIZWlnaHQKKyAgICAgICAgbnVsbHB0ciwgLy8gZHJhd0hlYWRlcgorICAgICAgICBudWxs cHRyLCAvLyBkcmF3Rm9vdGVyCisgICAgICAgIG51bGxwdHIsIC8vIHByaW50RnJhbWUKKyAgICAg ICAgbnVsbHB0ciwgLy8gcnVuTW9kYWwKKyAgICAgICAgbnVsbHB0ciwgLy8gdW51c2VkCisgICAg ICAgIG51bGxwdHIsIC8vIHNhdmVEYXRhVG9GaWxlSW5Eb3dubG9hZHNGb2xkZXIKKyAgICAgICAg bnVsbHB0ciwgLy8gc2hvdWxkSW50ZXJydXB0SmF2YVNjcmlwdAorICAgICAgICBudWxscHRyLCAv LyBjcmVhdGVQYWdlCisgICAgICAgIG51bGxwdHIsIC8vIG1vdXNlRGlkTW92ZU92ZXJFbGVtZW50 CisgICAgICAgIG51bGxwdHIsIC8vIGRlY2lkZVBvbGljeUZvck5vdGlmaWNhdGlvblBlcm1pc3Np b25SZXF1ZXN0CisgICAgICAgIG51bGxwdHIsIC8vIHVuYXZhaWxhYmxlUGx1Z2luQnV0dG9uQ2xp Y2tlZF9kZXByZWNhdGVkRm9yVXNlV2l0aFYxCisgICAgICAgIG51bGxwdHIsIC8vIHNob3dDb2xv clBpY2tlcgorICAgICAgICBudWxscHRyLCAvLyBoaWRlQ29sb3JQaWNrZXIKKyAgICAgICAgbnVs bHB0ciwgLy8gdW5hdmFpbGFibGVQbHVnaW5CdXR0b25DbGlja2VkCiAgICAgfTsKIAogICAgIFdl YlBhZ2VQcm94eSogaW5zcGVjdG9yUGFnZSA9IHNlbGYtPl9wYWdlLmdldCgpOwo=