178782 2017-10-25 03:54:14 -0700 Flakiness dashboard: Make GTK and WPE builds inherit expectations from WK2 2017-12-13 08:57:16 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aboya webkit-unassigned commit-queue lforschler mcatanzaro webkit-bug-importer zan oldest_to_newest 1364163 0 aboya 2017-10-25 03:54:14 -0700 The following layout test is having an unexpected result on GTK according to the flakiness dashboard: http/tests/loading/resourceLoadStatistics/grandfathering.html https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#tests=http%2Ftests%2Floading%2FresourceLoadStatistics%2Fgrandfathering.html The interesting bit is that it should not because it's marked as expected [ Pass Failure Timeout ] in WK2 expectations file. platform/wk2/TestExpectations 689:webkit.org/b/172452 http/tests/loading/resourceLoadStatistics/grandfathering.html [ Pass Failure Timeout ] And GTK+ tests are run with those expectations in mind: > run-webkit-tests --gtk http/tests/loading/resourceLoadStatistics/grandfathering.html Using port 'gtk-wk2' Test configuration: <, x86, release> Placing test results in /webkit/WebKitBuild/Release/layout-test-results Baseline search path: platform/gtk -> platform/wk2 -> generic Using Release build Pixel tests disabled Regular timeout: 15000, slow test timeout: 75000 Command line: /webkit/Tools/jhbuild/jhbuild-wrapper --gtk run /webkit/WebKitBuild/Release/bin/WebKitTestRunner - Found 1 test; running 1, skipping 0. Running 1 test Running 1 WebKitTestRunner. The test ran as expected. Stopping HTTP server ... 1380711 1 aboya 2017-12-12 10:45:10 -0800 Turns out the flakiness dashboard is assuming GTK ports are WK1, therefore WK2 expectations are not taken into account. https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showWrongExpectations=true&builder=GTK%20Linux%2064-bit%20Release%20(Tests) Look at the top: Expectations for GTK_LINUX_WK1-RELEASE This is the result of a logic in determineBuilderPlatform() that determines whether a platform is WK2 or WK1 based on its name: If it does not contain WK2, it assumes it's WK1. 1380745 2 329132 aboya 2017-12-12 11:34:56 -0800 Created attachment 329132 Patch 1380927 3 329132 commit-queue 2017-12-12 16:11:50 -0800 Comment on attachment 329132 Patch Clearing flags on attachment: 329132 Committed r225819: <https://trac.webkit.org/changeset/225819> 1380928 4 commit-queue 2017-12-12 16:11:51 -0800 All reviewed patches have been landed. Closing bug. 1380929 5 webkit-bug-importer 2017-12-12 16:12:26 -0800 <rdar://problem/36008110> 1381093 6 aboya 2017-12-13 03:11:37 -0800 The hosted version continues to run an old revision: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#builder=GTK%20Linux%2064-bit%20Release%20(Tests) Note it still says WK1. Who should I ping for fixing that? 1381120 7 mcatanzaro 2017-12-13 08:57:16 -0800 Try asking admin@webkit.org 329132 2017-12-12 11:34:56 -0800 2017-12-12 16:11:50 -0800 Patch bug-178782-20171212203454.patch text/plain 2950 aboya U3VidmVyc2lvbiBSZXZpc2lvbjogMjI0MjI4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMzc1YjFmN2RhNThhMmJlYzc4Y2RjMTRiYjkzNmVlNThh NmYwOTdmMS4uMjdiZmNkZWU5MzU2YzExODM4MTliMWE4ZTBjNDJiMDg3OTc5ODFjNyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEy IEBACisyMDE3LTEyLTEyICBBbGljaWEgQm95YSBHYXJjw61hICA8YWJveWFAaWdhbGlhLmNvbT4K KworICAgICAgICBGbGFraW5lc3MgZGFzaGJvYXJkOiBNYWtlIEdUSyBhbmQgV1BFIGJ1aWxkcyBp bmhlcml0IGV4cGVjdGF0aW9ucyBmcm9tIFdLMgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc4NzgyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBUZXN0UmVzdWx0U2VydmVyL3N0YXRpYy1kYXNoYm9hcmRz L2ZsYWtpbmVzc19kYXNoYm9hcmQuanM6CisKIDIwMTctMTItMDEgIEFsaWNpYSBCb3lhIEdhcmPD rWEgIDxhYm95YUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtdIEFkZCBTYW1wbGVNYXAuY3Bw IEFQSSB0ZXN0cyB0byBDTWFrZQpkaWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFJlc3VsdFNlcnZlci9z dGF0aWMtZGFzaGJvYXJkcy9mbGFraW5lc3NfZGFzaGJvYXJkLmpzIGIvVG9vbHMvVGVzdFJlc3Vs dFNlcnZlci9zdGF0aWMtZGFzaGJvYXJkcy9mbGFraW5lc3NfZGFzaGJvYXJkLmpzCmluZGV4IDlm MzdhOGEwNTY5OWQzZWI3NDY3NDAzMzBhNjBiOTZkNDVjMWI2YTcuLmE0MzNkNWI1M2Q0YzI0ZmNi NTE3NDg5YjIwMGJkZTdjMzliYWRjNTcgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Rlc3RSZXN1bHRTZXJ2 ZXIvc3RhdGljLWRhc2hib2FyZHMvZmxha2luZXNzX2Rhc2hib2FyZC5qcworKysgYi9Ub29scy9U ZXN0UmVzdWx0U2VydmVyL3N0YXRpYy1kYXNoYm9hcmRzL2ZsYWtpbmVzc19kYXNoYm9hcmQuanMK QEAgLTc1LDEyICs3NSw3IEBAIHZhciBQTEFURk9STVMgPSB7CiAgICAgJ0dUSyc6IHsKICAgICAg ICAgZXhwZWN0YXRpb25zRGlyZWN0b3J5OiAnZ3RrJywKICAgICAgICAgc3ViUGxhdGZvcm1zOiB7 Ci0gICAgICAgICAgICAnTElOVVgnOiB7Ci0gICAgICAgICAgICAgICAgc3ViUGxhdGZvcm1zOiB7 Ci0gICAgICAgICAgICAgICAgICAgICdXSzEnOiB7IGZhbGxiYWNrUGxhdGZvcm1zOiBbJ0dUSydd IH0sCi0gICAgICAgICAgICAgICAgICAgICdXSzInOiB7IGZhbGxiYWNrUGxhdGZvcm1zOiBbJ0dU SycsICdXSzInXSwgZXhwZWN0YXRpb25zRGlyZWN0b3J5OiAnZ3RrLXdrMicgfQotICAgICAgICAg ICAgICAgIH0KLSAgICAgICAgICAgIH0KKyAgICAgICAgICAgICdMSU5VWCc6IHsgZmFsbGJhY2tQ bGF0Zm9ybXM6IFsnR1RLJywgJ1dLMiddIH0KICAgICAgICAgfQogICAgIH0sCiAgICAgJ1dLMic6 IHsKQEAgLTkwLDcgKzg1LDcgQEAgdmFyIFBMQVRGT1JNUyA9IHsKICAgICAnV1BFJzogewogICAg ICAgICBleHBlY3RhdGlvbnNEaXJlY3Rvcnk6ICd3cGUnLAogICAgICAgICBzdWJQbGF0Zm9ybXM6 IHsKLSAgICAgICAgICAgICdMSU5VWCc6IHsgZmFsbGJhY2tQbGF0Zm9ybXM6IFsnV1BFJ10gfQor ICAgICAgICAgICAgJ0xJTlVYJzogeyBmYWxsYmFja1BsYXRmb3JtczogWydXUEUnLCAnV0syJ10g fQogICAgICAgICB9CiAgICAgfQogfTsKQEAgLTM1MCw2ICszNDUsMTEgQEAgZnVuY3Rpb24gZGV0 ZXJtaW5lQnVpbGRlclBsYXRmb3JtKGJ1aWxkZXJOYW1lVXBwZXJDYXNlKQogICAgIGlmIChzdHJp bmcuY29udGFpbnMoYnVpbGRlck5hbWVVcHBlckNhc2UsICdXSU4gWFAnKSkKICAgICAgICAgcmV0 dXJuICdBUFBMRV9XSU5fWFAnOwogCisgICAgaWYgKHN0cmluZy5jb250YWlucyhidWlsZGVyTmFt ZVVwcGVyQ2FzZSwgJ0dUSyBMSU5VWCcpKQorICAgICAgICByZXR1cm4gJ0dUS19MSU5VWCc7Cisg ICAgaWYgKHN0cmluZy5jb250YWlucyhidWlsZGVyTmFtZVVwcGVyQ2FzZSwgJ1dQRSBMSU5VWCcp KQorICAgICAgICByZXR1cm4gJ1dQRV9MSU5VWCc7CisKICAgICBpZiAoc3RyaW5nLmNvbnRhaW5z KGJ1aWxkZXJOYW1lVXBwZXJDYXNlLCAnSElHSFNJRVJSQScpKQogICAgICAgICByZXR1cm4gZGV0 ZXJtaW5lV0tQbGF0Zm9ybShidWlsZGVyTmFtZVVwcGVyQ2FzZSwgJ0FQUExFX01BQ19ISUdIU0lF UlJBJyk7CiAgICAgaWYgKHN0cmluZy5jb250YWlucyhidWlsZGVyTmFtZVVwcGVyQ2FzZSwgJ1NJ RVJSQScpKQpAQCAtMzYyLDEwICszNjIsNiBAQCBmdW5jdGlvbiBkZXRlcm1pbmVCdWlsZGVyUGxh dGZvcm0oYnVpbGRlck5hbWVVcHBlckNhc2UpCiAgICAgICAgIHJldHVybiBkZXRlcm1pbmVXS1Bs YXRmb3JtKGJ1aWxkZXJOYW1lVXBwZXJDYXNlLCAnQVBQTEVfTUFDX0xJT04nKTsKICAgICBpZiAo c3RyaW5nLmNvbnRhaW5zKGJ1aWxkZXJOYW1lVXBwZXJDYXNlLCAnIElPUyAnKSAmJiBzdHJpbmcu Y29udGFpbnMoYnVpbGRlck5hbWVVcHBlckNhc2UsICdTSU1VTEFUT1InKSkKICAgICAgICAgcmV0 dXJuIGRldGVybWluZVdLUGxhdGZvcm0oYnVpbGRlck5hbWVVcHBlckNhc2UsICdBUFBMRV9JT1Nf U0lNVUxBVE9SJyk7Ci0gICAgaWYgKHN0cmluZy5jb250YWlucyhidWlsZGVyTmFtZVVwcGVyQ2Fz ZSwgJ0dUSyBMSU5VWCcpKQotICAgICAgICByZXR1cm4gZGV0ZXJtaW5lV0tQbGF0Zm9ybShidWls ZGVyTmFtZVVwcGVyQ2FzZSwgJ0dUS19MSU5VWCcpOwotICAgIGlmIChzdHJpbmcuY29udGFpbnMo YnVpbGRlck5hbWVVcHBlckNhc2UsICdXUEUgTElOVVgnKSkKLSAgICAgICAgcmV0dXJuIGRldGVy bWluZVdLUGxhdGZvcm0oYnVpbGRlck5hbWVVcHBlckNhc2UsICdXUEVfTElOVVgnKTsKIH0KIAog ZnVuY3Rpb24gcGxhdGZvcm1BbmRCdWlsZFR5cGUoYnVpbGRlck5hbWUpCg==