178763 2017-10-24 16:56:55 -0700 Owner commit does not necessarily exist in the same commit set for an owned commit. 2019-06-16 21:18:58 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified NEW P2 Normal --- 1 dewei_zhu webkit-unassigned dewei_zhu rniwa oldest_to_newest 1364017 0 dewei_zhu 2017-10-24 16:56:55 -0700 Owner commit does not necessarily exist in the same commit set for an owned commit. 1364018 1 324759 dewei_zhu 2017-10-24 16:57:37 -0700 Created attachment 324759 Patch 1364026 2 324759 rniwa 2017-10-24 17:04:30 -0700 Comment on attachment 324759 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=324759&action=review > Websites/perf.webkit.org/ChangeLog:8 > + Remove the check based on previous incorrect assumption. Please add a test case. 324759 2017-10-24 16:57:37 -0700 2017-10-24 17:04:30 -0700 Patch bug-178763-20171024165736.patch text/plain 6334 dewei_zhu U3VidmVyc2lvbiBSZXZpc2lvbjogMjIzOTM4CmRpZmYgLS1naXQgYS9XZWJzaXRlcy9wZXJmLndl YmtpdC5vcmcvQ2hhbmdlTG9nIGIvV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL0NoYW5nZUxvZwpp bmRleCBmMTI5ZWU3YTE0OGYyM2Q1NWMyMWJiNzk1NjlhOTc1YjliYzQ2ODVmLi5hNmY1ZWUwYmY5 MmU5MTNiOGJlNjc3ZGZkNjk2Nzg3NmExNTg2NmNhIDEwMDY0NAotLS0gYS9XZWJzaXRlcy9wZXJm LndlYmtpdC5vcmcvQ2hhbmdlTG9nCisrKyBiL1dlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxNy0xMC0yNCAgRGV3ZWkgWmh1ICA8ZGV3ZWlfemh1 QGFwcGxlLmNvbT4KKworICAgICAgICBPd25lciBjb21taXQgZG9lcyBub3QgbmVjZXNzYXJpbHkg ZXhpc3QgaW4gdGhlIHNhbWUgY29tbWl0IHNldCBmb3IgYW4gb3duZWQgY29tbWl0LgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc4NzYzCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVtb3ZlIHRoZSBjaGVj ayBiYXNlZCBvbiBwcmV2aW91cyBpbmNvcnJlY3QgYXNzdW1wdGlvbi4KKworICAgICAgICAqIHB1 YmxpYy9wcml2aWxlZ2VkLWFwaS9jcmVhdGUtdGVzdC1ncm91cC5waHA6CisgICAgICAgICogc2Vy dmVyLXRlc3RzL3ByaXZpbGVnZWQtYXBpLWNyZWF0ZS10ZXN0LWdyb3VwLXRlc3RzLmpzOgorCiAy MDE3LTEwLTIwICBEZXdlaSBaaHUgIDxkZXdlaV96aHVAYXBwbGUuY29tPgogCiAgICAgICAgIFVw ZGF0ZSBwZXJmIGRhc2hib2FyZCB1cGxvYWQgbG9naWMgdG8gc3VwcG9ydCB1cGxvYWRpbmcgYmlu YXJpZXMgZnJvbSBvd25lZCBjb21taXRzLgpkaWZmIC0tZ2l0IGEvV2Vic2l0ZXMvcGVyZi53ZWJr aXQub3JnL3B1YmxpYy9wcml2aWxlZ2VkLWFwaS9jcmVhdGUtdGVzdC1ncm91cC5waHAgYi9XZWJz aXRlcy9wZXJmLndlYmtpdC5vcmcvcHVibGljL3ByaXZpbGVnZWQtYXBpL2NyZWF0ZS10ZXN0LWdy b3VwLnBocAppbmRleCA3ZTVlZjk1MzIzOGM0NDQ5ZGIxZWM5Y2Q2MmRmYzU2OThkYmU1NjRhLi5m YTU1MDM5Nzk2OTI0YzU1NjAxN2NkNWYwODlhODMyZGI5YTBhOWMwIDEwMDY0NAotLS0gYS9XZWJz aXRlcy9wZXJmLndlYmtpdC5vcmcvcHVibGljL3ByaXZpbGVnZWQtYXBpL2NyZWF0ZS10ZXN0LWdy b3VwLnBocAorKysgYi9XZWJzaXRlcy9wZXJmLndlYmtpdC5vcmcvcHVibGljL3ByaXZpbGVnZWQt YXBpL2NyZWF0ZS10ZXN0LWdyb3VwLnBocApAQCAtMTcwLDggKzE3MCw2IEBAIGZ1bmN0aW9uIGNv bW1pdF9zZXRzX2Zyb21fcmV2aXNpb25fc2V0cygkZGIsICR0cmlnZ2VyYWJsZV9pZCwgJHJldmlz aW9uX3NldF9saXN0CiAgICAgICAgICRjb21taXRfc2V0ID0gYXJyYXkoKTsKICAgICAgICAgJHJl cG9zaXRvcnlfbGlzdCA9IGFycmF5KCk7CiAgICAgICAgICRyZXBvc2l0b3J5X3dpdGhfcGF0Y2gg PSBhcnJheSgpOwotICAgICAgICAkcmVxdWlyZWRfb3duZXJfY29tbWl0cyA9IGFycmF5KCk7Ci0g ICAgICAgICRvd25lcl9jb21taXRzX2luX3NldCA9IGFycmF5KCk7CiAgICAgICAgIGZvcmVhY2gg KCRyZXZpc2lvbl9zZXQgYXMgJHJlcG9zaXRvcnlfaWQgPT4gJGRhdGEpIHsKICAgICAgICAgICAg IGlmICgkcmVwb3NpdG9yeV9pZCA9PSAnY3VzdG9tUm9vdHMnKSB7CiAgICAgICAgICAgICAgICAg JGZpbGVfaWRfbGlzdCA9ICRkYXRhOwpAQCAtMjE5LDkgKzIxNyw3IEBAIGZ1bmN0aW9uIGNvbW1p dF9zZXRzX2Zyb21fcmV2aXNpb25fc2V0cygkZGIsICR0cmlnZ2VyYWJsZV9pZCwgJHJldmlzaW9u X3NldF9saXN0CiAgICAgICAgICAgICAgICAgICAgIGV4aXRfd2l0aF9lcnJvcignSW52YWxpZENv bW1pdE93bmVyc2hpcCcsIGFycmF5KCdjb21taXRPd25lcicgPT4gJG93bmVyX2NvbW1pdFsnY29t bWl0X2lkJ10sICdjb21taXRPd25lZCcgPT4gJGNvbW1pdF9pZCkpOwogICAgICAgICAgICAgICAg ICRyZXBvc2l0b3JpZXNfcmVxdWlyZV9idWlsZFskcmVwb3NpdG9yeV9pZF0gPSAgVFJVRTsKICAg ICAgICAgICAgICAgICAkb3duZXJfY29tbWl0X2lkID0gJG93bmVyX2NvbW1pdFsnY29tbWl0X2lk J107Ci0gICAgICAgICAgICAgICAgJHJlcXVpcmVkX293bmVyX2NvbW1pdHNbJG93bmVyX2NvbW1p dF9pZF0gPSAkY29tbWl0X2lkOwotICAgICAgICAgICAgfSBlbHNlCi0gICAgICAgICAgICAgICAg JG93bmVyX2NvbW1pdHNfaW5fc2V0WyRjb21taXRfaWRdID0gVFJVRTsKKyAgICAgICAgICAgIH0K IAogICAgICAgICAgICAgYXJyYXlfcHVzaCgkY29tbWl0X3NldCwgYXJyYXkoJ2NvbW1pdCcgPT4g JGNvbW1pdF9pZCwgJ3BhdGNoX2ZpbGUnID0+ICRwYXRjaF9maWxlX2lkLCAncmVxdWlyZXNfYnVp bGQnID0+IEZBTFNFLCAnY29tbWl0X293bmVyJyA9PiAkb3duZXJfY29tbWl0X2lkKSk7CiAKQEAg LTI0MSwxMCArMjM3LDYgQEAgZnVuY3Rpb24gY29tbWl0X3NldHNfZnJvbV9yZXZpc2lvbl9zZXRz KCRkYiwgJHRyaWdnZXJhYmxlX2lkLCAkcmV2aXNpb25fc2V0X2xpc3QKICAgICAgICAgICAgICAg ICBleGl0X3dpdGhfZXJyb3IoJ1BhdGNoTm90QWNjZXB0ZWQnLCBhcnJheSgncmVwb3NpdG9yeScg PT4gJHJlcG9zaXRvcnlfaWQsICdyZXBvc2l0b3J5R3JvdXAnID0+ICRyZXBvc2l0b3J5X2dyb3Vw X2lkKSk7CiAgICAgICAgIH0KIAotICAgICAgICBmb3JlYWNoKCRyZXF1aXJlZF9vd25lcl9jb21t aXRzIGFzICRyZXF1aXJlZF9vd25lcl9jb21taXQgPT4gJG93bmVkX2NvbW1pdCkgewotICAgICAg ICAgICAgaWYgKCFhcnJheV9nZXQoJG93bmVyX2NvbW1pdHNfaW5fc2V0LCAkcmVxdWlyZWRfb3du ZXJfY29tbWl0LCBGQUxTRSkpCi0gICAgICAgICAgICAgICAgZXhpdF93aXRoX2Vycm9yKCdDb21t aXRPd25lck11c3RFeGlzdEluQ29tbWl0U2V0JywgYXJyYXkoJ293bmVyX2NvbW1pdCcgPT4gJHJl cXVpcmVkX293bmVyX2NvbW1pdCwgJ293bmVkX2NvbW1pdCcgPT4gJG93bmVkX2NvbW1pdCkpOwot ICAgICAgICB9CiAgICAgICAgIGFycmF5X3B1c2goJGNvbW1pdF9zZXRfbGlzdCwgYXJyYXkoJ3Jl cG9zaXRvcnlfZ3JvdXAnID0+ICRyZXBvc2l0b3J5X2dyb3VwX2lkLCAnc2V0JyA9PiAkY29tbWl0 X3NldCkpOwogICAgIH0KIApkaWZmIC0tZ2l0IGEvV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL3Nl cnZlci10ZXN0cy9wcml2aWxlZ2VkLWFwaS1jcmVhdGUtdGVzdC1ncm91cC10ZXN0cy5qcyBiL1dl YnNpdGVzL3BlcmYud2Via2l0Lm9yZy9zZXJ2ZXItdGVzdHMvcHJpdmlsZWdlZC1hcGktY3JlYXRl LXRlc3QtZ3JvdXAtdGVzdHMuanMKaW5kZXggOTUwNDQyMTA3N2M4N2E2NmNiZjZmZTE2NDE1Y2Y4 MzRmODNlNzkxNC4uYjFiZDE2ZTRjMWZkMjFmZjg1ZWEyOWFjMWRmZjQwMTcxMDdjMjUwMCAxMDA2 NDQKLS0tIGEvV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL3NlcnZlci10ZXN0cy9wcml2aWxlZ2Vk LWFwaS1jcmVhdGUtdGVzdC1ncm91cC10ZXN0cy5qcworKysgYi9XZWJzaXRlcy9wZXJmLndlYmtp dC5vcmcvc2VydmVyLXRlc3RzL3ByaXZpbGVnZWQtYXBpLWNyZWF0ZS10ZXN0LWdyb3VwLXRlc3Rz LmpzCkBAIC0zODIsMzggKzM4Miw2IEBAIGRlc2NyaWJlKCcvcHJpdmlsZWdlZC1hcGkvY3JlYXRl LXRlc3QtZ3JvdXAnLCBmdW5jdGlvbiAoKSB7CiAgICAgICAgIH0pOwogICAgIH0pOwogCi0gICAg aXQoJ3Nob3VsZCByZXR1cm4gIkNvbW1pdE93bmVyTXVzdEV4aXN0SW5Db21taXRTZXQiIHdoZW4g b3duZXIgb2YgYSBjb21taXQgaXMgbWlzc2luZyBpbiB0aGUgY29tbWl0IHNldCcsICgpID0+IHsK LSAgICAgICAgbGV0IHRhc2tJZDsKLSAgICAgICAgcmV0dXJuIGFkZFRyaWdnZXJhYmxlQW5kQ3Jl YXRlVGFzaygnc29tZSB0YXNrJykudGhlbigoaWQpID0+IHRhc2tJZCA9IGlkKS50aGVuKCgpID0+ IHsKLSAgICAgICAgICAgIGNvbnN0IHdlYmtpdCA9IFJlcG9zaXRvcnkuYWxsKCkuZmlsdGVyKChy ZXBvc2l0b3J5KSA9PiByZXBvc2l0b3J5Lm5hbWUoKSA9PSAnV2ViS2l0JylbMF07Ci0gICAgICAg ICAgICBjb25zdCBtYWNvcyA9IFJlcG9zaXRvcnkuYWxsKCkuZmlsdGVyKChyZXBvc2l0b3J5KSA9 PiByZXBvc2l0b3J5Lm5hbWUoKSA9PSAnbWFjT1MnKVswXTsKLSAgICAgICAgICAgIGNvbnN0IGpz YyA9IFJlcG9zaXRvcnkuYWxsKCkuZmlsdGVyKChyZXBvc2l0b3J5KSA9PiByZXBvc2l0b3J5Lm5h bWUoKSA9PSAnSmF2YVNjcmlwdENvcmUnKVswXTsKLSAgICAgICAgICAgIGNvbnN0IHJldmlzaW9u U2V0cyA9IFt7W3dlYmtpdC5pZCgpXToge3JldmlzaW9uOiAnMTkxNjIyJ30sIFttYWNvcy5pZCgp XToge3JldmlzaW9uOiAnMTVBMjg0J30sIFtqc2MuaWQoKV06IHtyZXZpc2lvbjogJ293bmVkLWpz Yy02MTYxJywgb3duZXJSZXZpc2lvbjogJzE5MTYyMid9fSwKLSAgICAgICAgICAgICAgICB7W3dl YmtpdC5pZCgpXToge3JldmlzaW9uOiAnMTkxNjIyJ30sIFttYWNvcy5pZCgpXToge3JldmlzaW9u OiAnMTVBMjg0J30sIFtqc2MuaWQoKV06IHtyZXZpc2lvbjogJ293bmVkLWpzYy05MTkxJywgb3du ZXJSZXZpc2lvbjogJzE5MjczNid9fV07Ci0gICAgICAgICAgICByZXR1cm4gUHJpdmlsZWdlZEFQ SS5zZW5kUmVxdWVzdCgnY3JlYXRlLXRlc3QtZ3JvdXAnLCB7bmFtZTogJ3Rlc3QnLCB0YXNrOiB0 YXNrSWQsIHJlcGV0aXRpb25Db3VudDogMiwgcmV2aXNpb25TZXRzfSk7Ci0gICAgICAgIH0pLnRo ZW4oKCkgPT4gewotICAgICAgICAgICAgYXNzZXJ0KGZhbHNlLCAnc2hvdWxkIG5ldmVyIGJlIHJl YWNoZWQnKTsKLSAgICAgICAgfSwgKGVycm9yKSA9PiB7Ci0gICAgICAgICAgICBhc3NlcnQuZXF1 YWwoZXJyb3IsICdDb21taXRPd25lck11c3RFeGlzdEluQ29tbWl0U2V0Jyk7Ci0gICAgICAgIH0p OwotICAgIH0pOwotCi0gICAgaXQoJ3Nob3VsZCByZXR1cm4gIkNvbW1pdE93bmVyTXVzdEV4aXN0 SW5Db21taXRTZXQiIHdoZW4gcmVwb3NpdG9yeSBvZiBvd25lciBjb21taXQgaXMgbm90IHNwZWNp ZmllZCBhdCBhbGwnLCAoKSA9PiB7Ci0gICAgICAgIGxldCB0YXNrSWQ7Ci0gICAgICAgIHJldHVy biBhZGRUcmlnZ2VyYWJsZUFuZENyZWF0ZVRhc2soJ3NvbWUgdGFzaycpLnRoZW4oKGlkKSA9PiB0 YXNrSWQgPSBpZCkudGhlbigoKSA9PiB7Ci0gICAgICAgICAgICBjb25zdCB3ZWJraXQgPSBSZXBv c2l0b3J5LmFsbCgpLmZpbHRlcigocmVwb3NpdG9yeSkgPT4gcmVwb3NpdG9yeS5uYW1lKCkgPT0g J1dlYktpdCcpWzBdOwotICAgICAgICAgICAgY29uc3QgbWFjb3MgPSBSZXBvc2l0b3J5LmFsbCgp LmZpbHRlcigocmVwb3NpdG9yeSkgPT4gcmVwb3NpdG9yeS5uYW1lKCkgPT0gJ21hY09TJylbMF07 Ci0gICAgICAgICAgICBjb25zdCBqc2MgPSBSZXBvc2l0b3J5LmFsbCgpLmZpbHRlcigocmVwb3Np dG9yeSkgPT4gcmVwb3NpdG9yeS5uYW1lKCkgPT0gJ0phdmFTY3JpcHRDb3JlJylbMF07Ci0gICAg ICAgICAgICBjb25zdCByZXZpc2lvblNldHMgPSBbe1t3ZWJraXQuaWQoKV06IHtyZXZpc2lvbjog JzE5MTYyMid9LCBbbWFjb3MuaWQoKV06IHtyZXZpc2lvbjogJzE1QTI4NCd9LCBbanNjLmlkKCld OiB7cmV2aXNpb246ICdvd25lZC1qc2MtNjE2MScsIG93bmVyUmV2aXNpb246ICcxOTE2MjInfX0s Ci0gICAgICAgICAgICAgICAge1ttYWNvcy5pZCgpXToge3JldmlzaW9uOiAnMTVBMjg0J30sIFtq c2MuaWQoKV06IHtyZXZpc2lvbjogJ293bmVkLWpzYy05MTkxJywgb3duZXJSZXZpc2lvbjogJzE5 MjczNid9fV07Ci0gICAgICAgICAgICByZXR1cm4gUHJpdmlsZWdlZEFQSS5zZW5kUmVxdWVzdCgn Y3JlYXRlLXRlc3QtZ3JvdXAnLCB7bmFtZTogJ3Rlc3QnLCB0YXNrOiB0YXNrSWQsIHJlcGV0aXRp b25Db3VudDogMiwgcmV2aXNpb25TZXRzfSk7Ci0gICAgICAgIH0pLnRoZW4oKCkgPT4gewotICAg ICAgICAgICAgYXNzZXJ0KGZhbHNlLCAnc2hvdWxkIG5ldmVyIGJlIHJlYWNoZWQnKTsKLSAgICAg ICAgfSwgKGVycm9yKSA9PiB7Ci0gICAgICAgICAgICBhc3NlcnQuZXF1YWwoZXJyb3IsICdDb21t aXRPd25lck11c3RFeGlzdEluQ29tbWl0U2V0Jyk7Ci0gICAgICAgIH0pOwotICAgIH0pOwotCiAg ICAgaXQoJ3Nob3VsZCBjcmVhdGUgYSB0ZXN0IGdyb3VwIGZyb20gY29tbWl0U2V0cyB3aXRoIHRo ZSByZXBldGl0aW9uIGNvdW50IG9mIG9uZSB3aGVuIHJlcGV0aXRpb25Db3VudCBpcyBvbWl0dGVk JywgKCkgPT4gewogICAgICAgICByZXR1cm4gYWRkVHJpZ2dlcmFibGVBbmRDcmVhdGVUYXNrKCdz b21lIHRhc2snKS50aGVuKCh0YXNrSWQpID0+IHsKICAgICAgICAgICAgIGxldCBpbnNlcnRlZEdy b3VwSWQ7Cg==