178759 2017-10-24 16:17:36 -0700 Test fast/writing-mode/english-bt-text-with-spelling-marker.html should wait for editing commands to complete 2017-11-15 12:48:30 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Local Build All All RESOLVED FIXED InRadar, LayoutTestFailure, MakingBotsRed P2 Normal --- 178671 1 dbates dbates lforschler rniwa webkit-bug-importer oldest_to_newest 1363988 0 dbates 2017-10-24 16:17:36 -0700 The test fast/writing-mode/english-bt-text-with-spelling-marker.html (added in bug #223845) should wait for editing commands to complete to ensure the spellcheck is triggered. 1363991 1 324747 dbates 2017-10-24 16:22:50 -0700 Created attachment 324747 Layout test 1363993 2 dbates 2017-10-24 16:24:42 -0700 (In reply to Daniel Bates from comment #0) > The test fast/writing-mode/english-bt-text-with-spelling-marker.html (added > in bug #223845) should wait for editing commands to complete to ensure the > spellcheck is triggered. *bug #178671 1363995 3 324747 rniwa 2017-10-24 16:25:44 -0700 Comment on attachment 324747 Layout test View in context: https://bugs.webkit.org/attachment.cgi?id=324747&action=review > LayoutTests/ChangeLog:9 > + character is typed before proceeding to type the next character. Should mention that we're inserting a delay instead of saying they're typed. > LayoutTests/fast/writing-mode/english-bt-text-with-spelling-marker-expected.html:32 > + for (var c of text) Use const? > LayoutTests/fast/writing-mode/english-bt-text-with-spelling-marker.html:36 > + for (var c of text) Ditto. 1363999 4 dbates 2017-10-24 16:31:31 -0700 (In reply to Ryosuke Niwa from comment #3) > Comment on attachment 324747 [details] > Layout test > > View in context: > https://bugs.webkit.org/attachment.cgi?id=324747&action=review > > > LayoutTests/ChangeLog:9 > > + character is typed before proceeding to type the next character. > > Should mention that we're inserting a delay instead of saying they're typed. > Will change the text in the ChangeLog to read: Make use of typeCharacterCommand() from (LayoutTests/editing/editing.js) to type each character with a delay and delay test completion until all characters have been typed. > > LayoutTests/fast/writing-mode/english-bt-text-with-spelling-marker-expected.html:32 > > + for (var c of text) > > Use const? > Will fix before landing. > > LayoutTests/fast/writing-mode/english-bt-text-with-spelling-marker.html:36 > > + for (var c of text) > > Ditto. Will fix before landing. 1364000 5 dbates 2017-10-24 16:33:12 -0700 Committed r223938: <https://trac.webkit.org/changeset/223938> 1364002 6 dbates 2017-10-24 16:34:36 -0700 For completeness, the test fast/writing-mode/english-bt-text-with-spelling-marker.html was seen as flaky on the Apple Sierra Release WK1 (Tests) bot: https://build.webkit.org/results/Apple%20Sierra%20Release%20WK1%20(Tests)/r223917%20(5549)/results.html https://build.webkit.org/builders/Apple%20Sierra%20Release%20WK1%20(Tests)/builds/5549 1364278 7 dbates 2017-10-25 10:28:04 -0700 The test is still flaky :( Apple El Capitan Release WK1 (Tests): https://build.webkit.org/results/Apple%20El%20Capitan%20Release%20WK1%20(Tests)/r223952%20(5724)/results.html 1364281 8 dbates 2017-10-25 10:28:21 -0700 (In reply to Daniel Bates from comment #7) > The test is still flaky :( > > Apple El Capitan Release WK1 (Tests): > https://build.webkit.org/results/ > Apple%20El%20Capitan%20Release%20WK1%20(Tests)/r223952%20(5724)/results.html Committed attempt to fix the flakiness in <https://trac.webkit.org/changeset/223959>. 1372256 9 webkit-bug-importer 2017-11-15 12:48:30 -0800 <rdar://problem/35568189> 324747 2017-10-24 16:22:50 -0700 2017-10-24 16:25:44 -0700 Layout test bug-178759-20171024162250.patch text/plain 2725 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjIzOTM2CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMjI3YTBmMzQ2M2FmZDk1NzQ3ZGIz ODc0YWIzNjVkZGU0NjMzZTMxNi4uMDQ4ODNkZjZhZWViMDIwOGVhN2VmNzkzNWFiZDMwMWEyNGM1 MWJlZiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE3LTEwLTI0ICBEYW5pZWwgQmF0ZXMgIDxk YWJhdGVzQGFwcGxlLmNvbT4KKworICAgICAgICBUZXN0IGZhc3Qvd3JpdGluZy1tb2RlL2VuZ2xp c2gtYnQtdGV4dC13aXRoLXNwZWxsaW5nLW1hcmtlci5odG1sIHNob3VsZCB3YWl0IGZvciBlZGl0 aW5nIGNvbW1hbmRzIHRvIGNvbXBsZXRlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNzg3NTkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBNYWtlIHVzZSBvZiB0eXBlQ2hhcmFjdGVyQ29tbWFuZCgpIGZyb20g KExheW91dFRlc3RzL2VkaXRpbmcvZWRpdGluZy5qcykgdG8gZW5zdXJlIHRoYXQgZWFjaAorICAg ICAgICBjaGFyYWN0ZXIgaXMgdHlwZWQgYmVmb3JlIHByb2NlZWRpbmcgdG8gdHlwZSB0aGUgbmV4 dCBjaGFyYWN0ZXIuCisKKyAgICAgICAgKiBmYXN0L3dyaXRpbmctbW9kZS9lbmdsaXNoLWJ0LXRl eHQtd2l0aC1zcGVsbGluZy1tYXJrZXItZXhwZWN0ZWQuaHRtbDoKKyAgICAgICAgKiBmYXN0L3dy aXRpbmctbW9kZS9lbmdsaXNoLWJ0LXRleHQtd2l0aC1zcGVsbGluZy1tYXJrZXIuaHRtbDoKKwog MjAxNy0xMC0yNCAgWW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAKICAgICAgICAg RW5hYmxlIHNlcnZpY2Ugd29ya2VyIHRvIHVzZSBjYWNoZSBzdG9yYWdlIGFwaQpkaWZmIC0tZ2l0 IGEvTGF5b3V0VGVzdHMvZmFzdC93cml0aW5nLW1vZGUvZW5nbGlzaC1idC10ZXh0LXdpdGgtc3Bl bGxpbmctbWFya2VyLWV4cGVjdGVkLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L3dyaXRpbmctbW9k ZS9lbmdsaXNoLWJ0LXRleHQtd2l0aC1zcGVsbGluZy1tYXJrZXItZXhwZWN0ZWQuaHRtbAppbmRl eCBjMGUxMzY0ODlkZDlkZTU4MDIzZGRmY2EzMTdhNjQyMWFhMjNjNTkzLi45Yzk3MGRjODFhNjU4 NDcwMGYwNzExYzc0YjliMWQ1ZWI2M2NiZGY0IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9mYXN0 L3dyaXRpbmctbW9kZS9lbmdsaXNoLWJ0LXRleHQtd2l0aC1zcGVsbGluZy1tYXJrZXItZXhwZWN0 ZWQuaHRtbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L3dyaXRpbmctbW9kZS9lbmdsaXNoLWJ0LXRl eHQtd2l0aC1zcGVsbGluZy1tYXJrZXItZXhwZWN0ZWQuaHRtbApAQCAtMSw2ICsxLDcgQEAKIDwh RE9DVFlQRSBodG1sPgogPGh0bWw+CiA8aGVhZD4KKzxzY3JpcHQgc3JjPSIuLi8uLi9lZGl0aW5n L2VkaXRpbmcuanMiPjwvc2NyaXB0PgogPHN0eWxlPgogQGZvbnQtZmFjZSB7CiAgICAgZm9udC1m YW1pbHk6IEFoZW07CkBAIC0yOCw4ICsyOSw4IEBAIHR5cGVUZXh0KCJtaXNwZWxsZWQgYSIsIGV4 cGVjdGVkKTsKIGZ1bmN0aW9uIHR5cGVUZXh0KHRleHQsIGVsZW1lbnQpCiB7CiAgICAgZWxlbWVu dC5mb2N1cygpOwotICAgIGZvciAodmFyIGkgPSAwOyBpIDwgdGV4dC5sZW5ndGg7ICsraSkKLSAg ICAgICAgZG9jdW1lbnQuZXhlY0NvbW1hbmQoIkluc2VydFRleHQiLCBmYWxzZSwgdGV4dFtpXSk7 CisgICAgZm9yICh2YXIgYyBvZiB0ZXh0KQorICAgICAgICB0eXBlQ2hhcmFjdGVyQ29tbWFuZChj KTsKICAgICBlbGVtZW50LmJsdXIoKTsKIH0KIDwvc2NyaXB0PgpkaWZmIC0tZ2l0IGEvTGF5b3V0 VGVzdHMvZmFzdC93cml0aW5nLW1vZGUvZW5nbGlzaC1idC10ZXh0LXdpdGgtc3BlbGxpbmctbWFy a2VyLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L3dyaXRpbmctbW9kZS9lbmdsaXNoLWJ0LXRleHQt d2l0aC1zcGVsbGluZy1tYXJrZXIuaHRtbAppbmRleCA2YjlkYTQ1MjE1MDk0MzBkZjE4NGExMDBh M2ZlZDQ5M2FhMGU0MzRjLi4xOGJmNzNlZDZhMWVjYzg4MGNjZThlZWIwNDAxYzQ4Yzg4M2Q2N2E4 IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9mYXN0L3dyaXRpbmctbW9kZS9lbmdsaXNoLWJ0LXRl eHQtd2l0aC1zcGVsbGluZy1tYXJrZXIuaHRtbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L3dyaXRp bmctbW9kZS9lbmdsaXNoLWJ0LXRleHQtd2l0aC1zcGVsbGluZy1tYXJrZXIuaHRtbApAQCAtMSw2 ICsxLDcgQEAKIDwhRE9DVFlQRSBodG1sPgogPGh0bWw+CiA8aGVhZD4KKzxzY3JpcHQgc3JjPSIu Li8uLi9lZGl0aW5nL2VkaXRpbmcuanMiPjwvc2NyaXB0PgogPHN0eWxlPgogQGZvbnQtZmFjZSB7 CiAgICAgZm9udC1mYW1pbHk6IEFoZW07CkBAIC0zMiw4ICszMyw4IEBAIHR5cGVUZXh0KCJhIG1p c3BlbGxlZCIsIHRlc3QpOwogZnVuY3Rpb24gdHlwZVRleHQodGV4dCwgZWxlbWVudCkKIHsKICAg ICBlbGVtZW50LmZvY3VzKCk7Ci0gICAgZm9yICh2YXIgaSA9IDA7IGkgPCB0ZXh0Lmxlbmd0aDsg KytpKQotICAgICAgICBkb2N1bWVudC5leGVjQ29tbWFuZCgiSW5zZXJ0VGV4dCIsIGZhbHNlLCB0 ZXh0W2ldKTsKKyAgICBmb3IgKHZhciBjIG9mIHRleHQpCisgICAgICAgIHR5cGVDaGFyYWN0ZXJD b21tYW5kKGMpOwogICAgIGVsZW1lbnQuYmx1cigpOwogfQogPC9zY3JpcHQ+Cg==