<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>178757</bug_id>
          
          <creation_ts>2017-10-24 15:45:23 -0700</creation_ts>
          <short_desc>[Win] Update ruby JSC test writer for gigacage changes</short_desc>
          <delta_ts>2017-11-20 13:21:25 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Stephan Szabo">stephan.szabo</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>don.olmstead</cc>
    
    <cc>fpizlo</cc>
    
    <cc>jfbastien</cc>
    
    <cc>keith_miller</cc>
    
    <cc>lforschler</cc>
    
    <cc>mark.lam</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>ysuzuki</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1363971</commentid>
    <comment_count>0</comment_count>
    <who name="Stephan Szabo">stephan.szabo</who>
    <bug_when>2017-10-24 15:45:23 -0700</bug_when>
    <thetext>The gigacage changes added things to Plan in the default test writer. Make necessary changes in the ruby writer to get the extra environment for running the tests from Windows command prompt.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1364287</commentid>
    <comment_count>1</comment_count>
      <attachid>324844</attachid>
    <who name="Stephan Szabo">stephan.szabo</who>
    <bug_when>2017-10-25 10:30:13 -0700</bug_when>
    <thetext>Created attachment 324844
Add additionalEnv to ruby test writer&apos;s Plan</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1373817</commentid>
    <comment_count>2</comment_count>
      <attachid>324844</attachid>
    <who name="Keith Miller">keith_miller</who>
    <bug_when>2017-11-20 13:00:33 -0800</bug_when>
    <thetext>Comment on attachment 324844
Add additionalEnv to ruby test writer&apos;s Plan

r=me.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1373820</commentid>
    <comment_count>3</comment_count>
      <attachid>324844</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2017-11-20 13:20:19 -0800</bug_when>
    <thetext>Comment on attachment 324844
Add additionalEnv to ruby test writer&apos;s Plan

Clearing flags on attachment: 324844

Committed r225053: &lt;https://trac.webkit.org/changeset/225053&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1373821</commentid>
    <comment_count>4</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2017-11-20 13:20:20 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1373822</commentid>
    <comment_count>5</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2017-11-20 13:21:25 -0800</bug_when>
    <thetext>&lt;rdar://problem/35648938&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>324844</attachid>
            <date>2017-10-25 10:30:13 -0700</date>
            <delta_ts>2017-11-20 13:20:19 -0800</delta_ts>
            <desc>Add additionalEnv to ruby test writer&apos;s Plan</desc>
            <filename>178757-2.diff</filename>
            <type>text/plain</type>
            <size>1877</size>
            <attacher name="Stephan Szabo">stephan.szabo</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBhZGIy
NmFiOWIxYS4uNjE4ZWUwNDc2YjQgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9U
b29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxNy0xMC0yNSAgU3RlcGhhbiBTemFi
byAgPHN0ZXBoYW4uc3phYm9Ac29ueS5jb20+CisKKyAgICAgICAgW1dpbl0gVXBkYXRlIHJ1Ynkg
SlNDIHRlc3Qgd3JpdGVyIGZvciBnaWdhY2FnZSBjaGFuZ2VzCisgICAgICAgIGh0dHBzOi8vYnVn
cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzg3NTcKKworICAgICAgICBSZXZpZXdlZCBi
eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cnVieS9qc2Mtc3Ry
ZXNzLXRlc3Qtd3JpdGVyLXJ1YnkucmI6CisgICAgICAgIEFkZCBhZGRpdGlvbmFsRW52IHRvIHJ1
YnkgdGVzdCB3cml0ZXIgUGxhbgorCiAyMDE3LTEwLTI0ICBFcmljIENhcmxzb24gIDxlcmljLmNh
cmxzb25AYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IEVuYWJsZSBXZWJLaXQg
bG9nZ2luZyBjb25maWd1cmF0aW9uIGFuZCBkaXNwbGF5CmRpZmYgLS1naXQgYS9Ub29scy9TY3Jp
cHRzL3dlYmtpdHJ1YnkvanNjLXN0cmVzcy10ZXN0LXdyaXRlci1ydWJ5LnJiIGIvVG9vbHMvU2Ny
aXB0cy93ZWJraXRydWJ5L2pzYy1zdHJlc3MtdGVzdC13cml0ZXItcnVieS5yYgppbmRleCBkZDZj
YjAwNDFkZi4uMTdiZmY4N2IxNjEgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cnVi
eS9qc2Mtc3RyZXNzLXRlc3Qtd3JpdGVyLXJ1YnkucmIKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJr
aXRydWJ5L2pzYy1zdHJlc3MtdGVzdC13cml0ZXItcnVieS5yYgpAQCAtMjYxLDcgKzI2MSw3IEBA
IGRlZiBjaGFrcmFQYXNzRmFpbEVycm9ySGFuZGxlcgogZW5kCiAKIGNsYXNzIFBsYW4KLSAgICBh
dHRyX3JlYWRlciA6ZGlyZWN0b3J5LCA6YXJndW1lbnRzLCA6ZmFtaWx5LCA6bmFtZSwgOm91dHB1
dEhhbmRsZXIsIDplcnJvckhhbmRsZXIKKyAgICBhdHRyX3JlYWRlciA6ZGlyZWN0b3J5LCA6YXJn
dW1lbnRzLCA6ZmFtaWx5LCA6bmFtZSwgOm91dHB1dEhhbmRsZXIsIDplcnJvckhhbmRsZXIsIDph
ZGRpdGlvbmFsRW52CiAgICAgYXR0cl9hY2Nlc3NvciA6aW5kZXgKICAgICAKICAgICBkZWYgaW5p
dGlhbGl6ZShkaXJlY3RvcnksIGFyZ3VtZW50cywgZmFtaWx5LCBuYW1lLCBvdXRwdXRIYW5kbGVy
LCBlcnJvckhhbmRsZXIpCkBAIC0yNzIsNiArMjcyLDcgQEAgY2xhc3MgUGxhbgogICAgICAgICBA
b3V0cHV0SGFuZGxlciA9IG91dHB1dEhhbmRsZXIKICAgICAgICAgQGVycm9ySGFuZGxlciA9IGVy
cm9ySGFuZGxlcgogICAgICAgICBAaXNTbG93ID0gISEkcnVuQ29tbWFuZE9wdGlvbnNbOmlzU2xv
d10KKyAgICAgICAgQGFkZGl0aW9uYWxFbnYgPSBbXQogICAgIGVuZAogICAgIAogICAgIGRlZiBz
aGVsbENvbW1hbmQgCkBAIC0yODAsNyArMjgxLDcgQEAgY2xhc3MgUGxhbgogICAgICAgICBzY3Jp
cHQgKz0gInN0YXR1cyA9IG5pbFxuIgogICAgICAgICBzY3JpcHQgKz0gIkRpci5jaGRpcihcIi4u
LyN7U2hlbGx3b3Jkcy5zaGVsbGVzY2FwZShAZGlyZWN0b3J5LnRvX3MpfVwiKSBkb1xuIgogICAg
ICAgICBzY3JpcHQgKz0gIiAgZW52ID0ge31cbiIKLSAgICAgICAgJGVudlZhcnMuZWFjaCB7Cisg
ICAgICAgICgkZW52VmFycyArIGFkZGl0aW9uYWxFbnYpLmVhY2ggewogICAgICAgICAgICAgfHZh
cnwgCiAgICAgICAgICAgICAoa2V5LCB2YWx1ZSkgPSB2YXIuc3BsaXQoLz0vLCAyKQogICAgICAg
ICAgICAgc2NyaXB0ICs9ICIgIGVudltcIiN7a2V5fVwiXSA9IFwiI3t2YWx1ZX1cIlxuIgo=
</data>

          </attachment>
      

    </bug>

</bugzilla>