178753 2017-10-24 15:04:23 -0700 Web Inspector: Console Drawer resizing doesn't match cursor position 2017-10-24 15:12:39 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1363937 0 joepeck 2017-10-24 15:04:23 -0700 Console Drawer resizing doesn't match cursor position. Resizing the console drawer doesn't actually match the cursor. Even though we set the height to a fixed value (like 600px) the content area's height: 100% proportions the drawer's height, so it might only end up like 345px. 1363938 1 webkit-bug-importer 2017-10-24 15:04:51 -0700 <rdar://problem/35160484> 1363941 2 324731 joepeck 2017-10-24 15:06:29 -0700 Created attachment 324731 [PATCH] Proposed Fix 1363943 3 324731 joepeck 2017-10-24 15:08:06 -0700 Comment on attachment 324731 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=324731&action=review > Source/WebInspectorUI/ChangeLog:16 > + already was but now it does not affect the size of the fixed with sibling. "fixed with" => "fixed height" oop. 1363944 4 324731 bburg 2017-10-24 15:08:50 -0700 Comment on attachment 324731 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=324731&action=review r=me > Source/WebInspectorUI/ChangeLog:16 > + already was but now it does not affect the size of the fixed with sibling. Nit: was, but Nit: fixed-width 1363946 5 324733 joepeck 2017-10-24 15:08:58 -0700 Created attachment 324733 [PATCH] Proposed Fix 1363947 6 bburg 2017-10-24 15:09:20 -0700 (In reply to Brian Burg from comment #4) > Comment on attachment 324731 [details] > [PATCH] Proposed Fix > > View in context: > https://bugs.webkit.org/attachment.cgi?id=324731&action=review > > r=me > > > Source/WebInspectorUI/ChangeLog:16 > > + already was but now it does not affect the size of the fixed with sibling. > > Nit: was, but > Nit: fixed-width But really, fixed-height =) 1363950 7 joepeck 2017-10-24 15:12:39 -0700 <https://trac.webkit.org/r223931> 324731 2017-10-24 15:06:29 -0700 2017-10-24 15:08:58 -0700 [PATCH] Proposed Fix console-resize-1.patch text/plain 2624 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDlmZDQzMTQ3MGY4Li5kZDIzNzk2Y2YyYyAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjIgQEAKIDIwMTctMTAtMjQgIEpvc2Vw aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAorICAgICAgICBXZWIgSW5zcGVjdG9y OiBDb25zb2xlIERyYXdlciByZXNpemluZyBkb2Vzbid0IG1hdGNoIGN1cnNvciBwb3NpdGlvbgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc4NzUzCisg ICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zNTE2MDQ4ND4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvQ29uc29sZURy YXdlci5qczoKKyAgICAgICAgKFdJLkNvbnNvbGVEcmF3ZXIucHJvdG90eXBlLl91cGRhdGVEcmF3 ZXJIZWlnaHQpOgorICAgICAgICBEcml2ZS1ieSBmaXggYW4gZWFybHkgcmV0dXJuIHRoYXQgd291 bGQgbmV2ZXIgaGF2ZSB3b3JrZWQuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL01h aW4uY3NzOgorICAgICAgICAoI2NvbnRlbnQpOgorICAgICAgICBHaXZlIHRoZSAjY29udGVudCBh IGZsZXggZ3JvdyBvZiAxLiBUaGlzIGNhdXNlcyB0aGUgc3BhY2UgdG8gZ3JvdyBhcyBpdAorICAg ICAgICBhbHJlYWR5IHdhcyBidXQgbm93IGl0IGRvZXMgbm90IGFmZmVjdCB0aGUgc2l6ZSBvZiB0 aGUgZml4ZWQgd2l0aCBzaWJsaW5nLgorCisyMDE3LTEwLTI0ICBKb3NlcGggUGVjb3Jhcm8gIDxw ZWNvcmFyb0BhcHBsZS5jb20+CisKICAgICAgICAgVW5jYXVnaHQgRXhjZXB0aW9uOiBUeXBlRXJy b3I6IG51bGwgaXMgbm90IGFuIG9iamVjdCAoZXZhbHVhdGluZyAndGhpcy50cmVlT3V0bGluZS5p c1hNTE1pbWVUeXBlJykKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE3ODc0NQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlcklu dGVyZmFjZS9WaWV3cy9Db25zb2xlRHJhd2VyLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1Vz ZXJJbnRlcmZhY2UvVmlld3MvQ29uc29sZURyYXdlci5qcwppbmRleCBlOWUxYzI2MTkzNC4uOGZi MWIzMGE5MDcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNl L1ZpZXdzL0NvbnNvbGVEcmF3ZXIuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJ bnRlcmZhY2UvVmlld3MvQ29uc29sZURyYXdlci5qcwpAQCAtMTQ3LDExICsxNDcsMTEgQEAgV0ku Q29uc29sZURyYXdlciA9IGNsYXNzIENvbnNvbGVEcmF3ZXIgZXh0ZW5kcyBXSS5Db250ZW50QnJv d3NlcgogICAgICAgICBjb25zdCBtaW5pbXVtSGVpZ2h0ID0gNjQ7CiAgICAgICAgIGNvbnN0IG1h eGltdW1IZWlnaHQgPSB0aGlzLmVsZW1lbnQucGFyZW50Tm9kZS5vZmZzZXRIZWlnaHQgLSAxMDA7 CiAKLSAgICAgICAgaGVpZ2h0ID0gTnVtYmVyLmNvbnN0cmFpbihoZWlnaHQsIG1pbmltdW1IZWln aHQsIG1heGltdW1IZWlnaHQpOwotICAgICAgICBpZiAoaGVpZ2h0ID09PSB0aGlzLmVsZW1lbnQu c3R5bGUuaGVpZ2h0KQorICAgICAgICBsZXQgaGVpZ2h0Q1NTVmFsdWUgPSBOdW1iZXIuY29uc3Ry YWluKGhlaWdodCwgbWluaW11bUhlaWdodCwgbWF4aW11bUhlaWdodCkgKyAicHgiOworICAgICAg ICBpZiAodGhpcy5lbGVtZW50LnN0eWxlLmhlaWdodCA9PT0gaGVpZ2h0Q1NTVmFsdWUpCiAgICAg ICAgICAgICByZXR1cm47CiAKLSAgICAgICAgdGhpcy5lbGVtZW50LnN0eWxlLmhlaWdodCA9IGhl aWdodCArICJweCI7CisgICAgICAgIHRoaXMuZWxlbWVudC5zdHlsZS5oZWlnaHQgPSBoZWlnaHRD U1NWYWx1ZTsKIAogICAgICAgICB0aGlzLmRpc3BhdGNoRXZlbnRUb0xpc3RlbmVycyhXSS5Db25z b2xlRHJhd2VyLkV2ZW50LlJlc2l6ZWQpOwogICAgIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL01haW4uY3NzIGIvU291cmNlL1dlYkluc3Bl Y3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvTWFpbi5jc3MKaW5kZXggOTAyODgxZTRjOWUuLjYx YWIzMDJlYmE4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFj ZS9WaWV3cy9NYWluLmNzcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFj ZS9WaWV3cy9NYWluLmNzcwpAQCAtMTUxLDYgKzE1MSw3IEBAIGJvZHkuZG9ja2VkOm1hdGNoZXMo LnJpZ2h0LCAubGVmdCkgI25hdmlnYXRpb24tc2lkZWJhci5jb2xsYXBzZWQgPiAucmVzaXplciB7 CiAjY29udGVudCB7CiAgICAgZGlzcGxheTogZmxleDsKICAgICBoZWlnaHQ6IDEwMCU7IC8qIFRo aXMgcmVkdWNlcyBwYWludCBhcmVhcyB3aGVuIHR5cGluZyBpbiB0aGUgY29uc29sZS4gaHR0cDov L3dlYmtpdC5vcmcvYi8xNDUzMjQgKi8KKyAgICBmbGV4OiAxOwogfQogCiAjdGFiLWJyb3dzZXIg ewo= 324733 2017-10-24 15:08:58 -0700 2017-10-24 15:10:18 -0700 [PATCH] Proposed Fix console-drawer-2.patch text/plain 2626 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDlmZDQzMTQ3MGY4Li40Mzc5MjliMWNkMyAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjIgQEAKIDIwMTctMTAtMjQgIEpvc2Vw aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAorICAgICAgICBXZWIgSW5zcGVjdG9y OiBDb25zb2xlIERyYXdlciByZXNpemluZyBkb2Vzbid0IG1hdGNoIGN1cnNvciBwb3NpdGlvbgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc4NzUzCisg ICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zNTE2MDQ4ND4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvQ29uc29sZURy YXdlci5qczoKKyAgICAgICAgKFdJLkNvbnNvbGVEcmF3ZXIucHJvdG90eXBlLl91cGRhdGVEcmF3 ZXJIZWlnaHQpOgorICAgICAgICBEcml2ZS1ieSBmaXggYW4gZWFybHkgcmV0dXJuIHRoYXQgd291 bGQgbmV2ZXIgaGF2ZSB3b3JrZWQuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL01h aW4uY3NzOgorICAgICAgICAoI2NvbnRlbnQpOgorICAgICAgICBHaXZlIHRoZSAjY29udGVudCBh IGZsZXggZ3JvdyBvZiAxLiBUaGlzIGNhdXNlcyB0aGUgc3BhY2UgdG8gZ3JvdyBhcyBpdAorICAg ICAgICBhbHJlYWR5IHdhcyBidXQgbm93IGl0IGRvZXMgbm90IGFmZmVjdCB0aGUgc2l6ZSBvZiB0 aGUgZml4ZWQgaGVpZ2h0IHNpYmxpbmcuCisKKzIwMTctMTAtMjQgIEpvc2VwaCBQZWNvcmFybyAg PHBlY29yYXJvQGFwcGxlLmNvbT4KKwogICAgICAgICBVbmNhdWdodCBFeGNlcHRpb246IFR5cGVF cnJvcjogbnVsbCBpcyBub3QgYW4gb2JqZWN0IChldmFsdWF0aW5nICd0aGlzLnRyZWVPdXRsaW5l LmlzWE1MTWltZVR5cGUnKQogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTc4NzQ1CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2Vy SW50ZXJmYWNlL1ZpZXdzL0NvbnNvbGVEcmF3ZXIuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkv VXNlckludGVyZmFjZS9WaWV3cy9Db25zb2xlRHJhd2VyLmpzCmluZGV4IGU5ZTFjMjYxOTM0Li44 ZmIxYjMwYTkwNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZh Y2UvVmlld3MvQ29uc29sZURyYXdlci5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNl ckludGVyZmFjZS9WaWV3cy9Db25zb2xlRHJhd2VyLmpzCkBAIC0xNDcsMTEgKzE0NywxMSBAQCBX SS5Db25zb2xlRHJhd2VyID0gY2xhc3MgQ29uc29sZURyYXdlciBleHRlbmRzIFdJLkNvbnRlbnRC cm93c2VyCiAgICAgICAgIGNvbnN0IG1pbmltdW1IZWlnaHQgPSA2NDsKICAgICAgICAgY29uc3Qg bWF4aW11bUhlaWdodCA9IHRoaXMuZWxlbWVudC5wYXJlbnROb2RlLm9mZnNldEhlaWdodCAtIDEw MDsKIAotICAgICAgICBoZWlnaHQgPSBOdW1iZXIuY29uc3RyYWluKGhlaWdodCwgbWluaW11bUhl aWdodCwgbWF4aW11bUhlaWdodCk7Ci0gICAgICAgIGlmIChoZWlnaHQgPT09IHRoaXMuZWxlbWVu dC5zdHlsZS5oZWlnaHQpCisgICAgICAgIGxldCBoZWlnaHRDU1NWYWx1ZSA9IE51bWJlci5jb25z dHJhaW4oaGVpZ2h0LCBtaW5pbXVtSGVpZ2h0LCBtYXhpbXVtSGVpZ2h0KSArICJweCI7CisgICAg ICAgIGlmICh0aGlzLmVsZW1lbnQuc3R5bGUuaGVpZ2h0ID09PSBoZWlnaHRDU1NWYWx1ZSkKICAg ICAgICAgICAgIHJldHVybjsKIAotICAgICAgICB0aGlzLmVsZW1lbnQuc3R5bGUuaGVpZ2h0ID0g aGVpZ2h0ICsgInB4IjsKKyAgICAgICAgdGhpcy5lbGVtZW50LnN0eWxlLmhlaWdodCA9IGhlaWdo dENTU1ZhbHVlOwogCiAgICAgICAgIHRoaXMuZGlzcGF0Y2hFdmVudFRvTGlzdGVuZXJzKFdJLkNv bnNvbGVEcmF3ZXIuRXZlbnQuUmVzaXplZCk7CiAgICAgfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dl Ykluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvTWFpbi5jc3MgYi9Tb3VyY2UvV2ViSW5z cGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9NYWluLmNzcwppbmRleCA5MDI4ODFlNGM5ZS4u NjFhYjMwMmViYTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJm YWNlL1ZpZXdzL01haW4uY3NzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJm YWNlL1ZpZXdzL01haW4uY3NzCkBAIC0xNTEsNiArMTUxLDcgQEAgYm9keS5kb2NrZWQ6bWF0Y2hl cygucmlnaHQsIC5sZWZ0KSAjbmF2aWdhdGlvbi1zaWRlYmFyLmNvbGxhcHNlZCA+IC5yZXNpemVy IHsKICNjb250ZW50IHsKICAgICBkaXNwbGF5OiBmbGV4OwogICAgIGhlaWdodDogMTAwJTsgLyog VGhpcyByZWR1Y2VzIHBhaW50IGFyZWFzIHdoZW4gdHlwaW5nIGluIHRoZSBjb25zb2xlLiBodHRw Oi8vd2Via2l0Lm9yZy9iLzE0NTMyNCAqLworICAgIGZsZXg6IDE7CiB9CiAKICN0YWItYnJvd3Nl ciB7Cg==