178748 2017-10-24 14:02:34 -0700 Allow OjbC Weak References when building TestAPI 2017-10-24 15:59:56 -0700 1 1 1 Unclassified WebKit JavaScriptCore Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 msaboff msaboff buildbot commit-queue keith_miller mark.lam mitz saam thorton webkit-bug-importer oldest_to_newest 1363879 0 msaboff 2017-10-24 14:02:34 -0700 TestAPI is built using manual reference counting. Some version of the compiler will complain when building with default build flags. 1363880 1 webkit-bug-importer 2017-10-24 14:03:44 -0700 <rdar://problem/35158752> 1363890 2 324718 msaboff 2017-10-24 14:12:01 -0700 Created attachment 324718 Patch 1363910 3 324718 commit-queue 2017-10-24 14:31:05 -0700 Comment on attachment 324718 Patch Clearing flags on attachment: 324718 Committed r223923: <https://trac.webkit.org/changeset/223923> 1363911 4 commit-queue 2017-10-24 14:31:06 -0700 All reviewed patches have been landed. Closing bug. 1363927 5 324718 mitz 2017-10-24 14:55:40 -0700 Comment on attachment 324718 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=324718&action=review > Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj:10386 > + CLANG_ENABLE_OBJC_WEAK = YES; We shouldn’t specify build settings in the project file. This can probably go in ToolExecutable.xcconfig or if, for some reason, it can’t apply to all tools, in a new .xcconfig file. 1363939 6 msaboff 2017-10-24 15:05:20 -0700 (In reply to mitz from comment #5) > Comment on attachment 324718 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=324718&action=review > > > Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj:10386 > > + CLANG_ENABLE_OBJC_WEAK = YES; > > We shouldn’t specify build settings in the project file. This can probably > go in ToolExecutable.xcconfig or if, for some reason, it can’t apply to all > tools, in a new .xcconfig file. Reopening this bug to move the build setting. 1363959 7 324737 msaboff 2017-10-24 15:21:59 -0700 Created attachment 324737 Updated Patch 1363975 8 324737 commit-queue 2017-10-24 15:59:54 -0700 Comment on attachment 324737 Updated Patch Clearing flags on attachment: 324737 Committed r223937: <https://trac.webkit.org/changeset/223937> 1363976 9 commit-queue 2017-10-24 15:59:56 -0700 All reviewed patches have been landed. Closing bug. 324718 2017-10-24 14:12:01 -0700 2017-10-24 15:21:59 -0700 Patch 178748.patch text/plain 1915 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjIzOTE5KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBA CisyMDE3LTEwLTI0ICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIEFsbG93IE9qYkMgV2VhayBSZWZlcmVuY2VzIHdoZW4gYnVpbGRpbmcgVGVzdEFQSQorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc4NzQ4CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU2V0IFRlc3RBUEkg YnVpbGQgZmxhZyBXZWFrIFJlZmVyZW5jZXMgaW4gTWFudWFsIFJldGFpbiBSZWxlYXNlIHRvIHRy dWUuCisKKyAgICAgICAgKiBKYXZhU2NyaXB0Q29yZS54Y29kZXByb2ovcHJvamVjdC5wYnhwcm9q OgorCiAyMDE3LTEwLTI0ICBZdXN1a2UgU3V6dWtpICA8dXRhdGFuZS50ZWFAZ21haWwuY29tPgog CiAgICAgICAgIFtGVExdIFN1cHBvcnQgTmV3U3RyaW5nT2JqZWN0CkluZGV4OiBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvSmF2YVNjcmlwdENvcmUueGNvZGVwcm9qL3Byb2plY3QucGJ4cHJvago9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvSmF2YVNjcmlwdENvcmUueGNvZGVwcm9q L3Byb2plY3QucGJ4cHJvagkocmV2aXNpb24gMjIzODk2KQorKysgU291cmNlL0phdmFTY3JpcHRD b3JlL0phdmFTY3JpcHRDb3JlLnhjb2RlcHJvai9wcm9qZWN0LnBieHByb2oJKHdvcmtpbmcgY29w eSkKQEAgLTEwMzgzLDYgKzEwMzgzLDcgQEAKIAkJCWlzYSA9IFhDQnVpbGRDb25maWd1cmF0aW9u OwogCQkJYmFzZUNvbmZpZ3VyYXRpb25SZWZlcmVuY2UgPSBCQzAyMUJGMjEzNjkwMEMzMDBGQzU0 NjcgLyogVG9vbEV4ZWN1dGFibGUueGNjb25maWcgKi87CiAJCQlidWlsZFNldHRpbmdzID0gewor CQkJCUNMQU5HX0VOQUJMRV9PQkpDX1dFQUsgPSBZRVM7CiAJCQl9OwogCQkJbmFtZSA9IERlYnVn OwogCQl9OwpAQCAtMTAzOTAsNiArMTAzOTEsNyBAQAogCQkJaXNhID0gWENCdWlsZENvbmZpZ3Vy YXRpb247CiAJCQliYXNlQ29uZmlndXJhdGlvblJlZmVyZW5jZSA9IEJDMDIxQkYyMTM2OTAwQzMw MEZDNTQ2NyAvKiBUb29sRXhlY3V0YWJsZS54Y2NvbmZpZyAqLzsKIAkJCWJ1aWxkU2V0dGluZ3Mg PSB7CisJCQkJQ0xBTkdfRU5BQkxFX09CSkNfV0VBSyA9IFlFUzsKIAkJCX07CiAJCQluYW1lID0g UmVsZWFzZTsKIAkJfTsKQEAgLTEwMzk3LDYgKzEwMzk5LDcgQEAKIAkJCWlzYSA9IFhDQnVpbGRD b25maWd1cmF0aW9uOwogCQkJYmFzZUNvbmZpZ3VyYXRpb25SZWZlcmVuY2UgPSBCQzAyMUJGMjEz NjkwMEMzMDBGQzU0NjcgLyogVG9vbEV4ZWN1dGFibGUueGNjb25maWcgKi87CiAJCQlidWlsZFNl dHRpbmdzID0geworCQkJCUNMQU5HX0VOQUJMRV9PQkpDX1dFQUsgPSBZRVM7CiAJCQl9OwogCQkJ bmFtZSA9IFByb2R1Y3Rpb247CiAJCX07CkBAIC0xMDU4NSw2ICsxMDU4OCw3IEBACiAJCQlpc2Eg PSBYQ0J1aWxkQ29uZmlndXJhdGlvbjsKIAkJCWJhc2VDb25maWd1cmF0aW9uUmVmZXJlbmNlID0g QkMwMjFCRjIxMzY5MDBDMzAwRkM1NDY3IC8qIFRvb2xFeGVjdXRhYmxlLnhjY29uZmlnICovOwog CQkJYnVpbGRTZXR0aW5ncyA9IHsKKwkJCQlDTEFOR19FTkFCTEVfT0JKQ19XRUFLID0gWUVTOwog CQkJfTsKIAkJCW5hbWUgPSBQcm9maWxpbmc7CiAJCX07Cg== 324737 2017-10-24 15:21:59 -0700 2017-10-24 15:59:54 -0700 Updated Patch 178748-2.patch text/plain 2594 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjIzOTMxKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBA CisyMDE3LTEwLTI0ICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIEFsbG93IE9qYkMgV2VhayBSZWZlcmVuY2VzIHdoZW4gYnVpbGRpbmcgVGVzdEFQSQorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc4NzQ4CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU2V0IFRlc3RBUEkg YnVpbGQgZmxhZyBXZWFrIFJlZmVyZW5jZXMgaW4gTWFudWFsIFJldGFpbiBSZWxlYXNlIHRvIHRy dWUuCisKKyAgICAgICAgKiBKYXZhU2NyaXB0Q29yZS54Y29kZXByb2ovcHJvamVjdC5wYnhwcm9q OiBSZXZlcnRlZC4KKyAgICAgICAgKiBDb25maWd1cmF0aW9ucy9Ub29sRXhlY3V0YWJsZS54Y2Nv bmZpZzogQ2hhbmdlZCB0aGUgZmxhZyBoZXJlIGluc3RlYWQuCisKIDIwMTctMTAtMjQgIEVyaWMg Q2FybHNvbiAgPGVyaWMuY2FybHNvbkBhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3Rv cjogRW5hYmxlIFdlYktpdCBsb2dnaW5nIGNvbmZpZ3VyYXRpb24gYW5kIGRpc3BsYXkKSW5kZXg6 IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9Db25maWd1cmF0aW9ucy9Ub29sRXhlY3V0YWJsZS54Y2Nv bmZpZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ29uZmlndXJhdGlvbnMv VG9vbEV4ZWN1dGFibGUueGNjb25maWcJKHJldmlzaW9uIDIyMzkzMSkKKysrIFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9Db25maWd1cmF0aW9ucy9Ub29sRXhlY3V0YWJsZS54Y2NvbmZpZwkod29ya2lu ZyBjb3B5KQpAQCAtNTEsNiArNTEsOCBAQCBDTEFOR19FTkFCTEVfT0JKQ19BUkNfYXJtdjdzID0g WUVTOwogQ0xBTkdfRU5BQkxFX09CSkNfQVJDX2FybTY0ID0gWUVTOwogQ0xBTkdfRU5BQkxFX09C SkNfQVJDX2FybTY0ZSA9IFlFUzsKIAorQ0xBTkdfRU5BQkxFX09CSkNfV0VBSyA9IFlFUzsKKwog T1RIRVJfQ0ZMQUdTID0gJChBU0FOX09USEVSX0NGTEFHUykgLWlzeXN0ZW0gaWN1OwogT1RIRVJf TERGTEFHUyA9ICQoQVNBTl9PVEhFUl9MREZMQUdTKTsKIApJbmRleDogU291cmNlL0phdmFTY3Jp cHRDb3JlL0phdmFTY3JpcHRDb3JlLnhjb2RlcHJvai9wcm9qZWN0LnBieHByb2oKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL0phdmFTY3JpcHRDb3JlLnhjb2RlcHJvai9wcm9q ZWN0LnBieHByb2oJKHJldmlzaW9uIDIyMzkzMSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9K YXZhU2NyaXB0Q29yZS54Y29kZXByb2ovcHJvamVjdC5wYnhwcm9qCSh3b3JraW5nIGNvcHkpCkBA IC0xMDM4Myw3ICsxMDM4Myw2IEBACiAJCQlpc2EgPSBYQ0J1aWxkQ29uZmlndXJhdGlvbjsKIAkJ CWJhc2VDb25maWd1cmF0aW9uUmVmZXJlbmNlID0gQkMwMjFCRjIxMzY5MDBDMzAwRkM1NDY3IC8q IFRvb2xFeGVjdXRhYmxlLnhjY29uZmlnICovOwogCQkJYnVpbGRTZXR0aW5ncyA9IHsKLQkJCQlD TEFOR19FTkFCTEVfT0JKQ19XRUFLID0gWUVTOwogCQkJfTsKIAkJCW5hbWUgPSBEZWJ1ZzsKIAkJ fTsKQEAgLTEwMzkxLDcgKzEwMzkwLDYgQEAKIAkJCWlzYSA9IFhDQnVpbGRDb25maWd1cmF0aW9u OwogCQkJYmFzZUNvbmZpZ3VyYXRpb25SZWZlcmVuY2UgPSBCQzAyMUJGMjEzNjkwMEMzMDBGQzU0 NjcgLyogVG9vbEV4ZWN1dGFibGUueGNjb25maWcgKi87CiAJCQlidWlsZFNldHRpbmdzID0gewot CQkJCUNMQU5HX0VOQUJMRV9PQkpDX1dFQUsgPSBZRVM7CiAJCQl9OwogCQkJbmFtZSA9IFJlbGVh c2U7CiAJCX07CkBAIC0xMDM5OSw3ICsxMDM5Nyw2IEBACiAJCQlpc2EgPSBYQ0J1aWxkQ29uZmln dXJhdGlvbjsKIAkJCWJhc2VDb25maWd1cmF0aW9uUmVmZXJlbmNlID0gQkMwMjFCRjIxMzY5MDBD MzAwRkM1NDY3IC8qIFRvb2xFeGVjdXRhYmxlLnhjY29uZmlnICovOwogCQkJYnVpbGRTZXR0aW5n cyA9IHsKLQkJCQlDTEFOR19FTkFCTEVfT0JKQ19XRUFLID0gWUVTOwogCQkJfTsKIAkJCW5hbWUg PSBQcm9kdWN0aW9uOwogCQl9OwpAQCAtMTA1ODgsNyArMTA1ODUsNiBAQAogCQkJaXNhID0gWENC dWlsZENvbmZpZ3VyYXRpb247CiAJCQliYXNlQ29uZmlndXJhdGlvblJlZmVyZW5jZSA9IEJDMDIx QkYyMTM2OTAwQzMwMEZDNTQ2NyAvKiBUb29sRXhlY3V0YWJsZS54Y2NvbmZpZyAqLzsKIAkJCWJ1 aWxkU2V0dGluZ3MgPSB7Ci0JCQkJQ0xBTkdfRU5BQkxFX09CSkNfV0VBSyA9IFlFUzsKIAkJCX07 CiAJCQluYW1lID0gUHJvZmlsaW5nOwogCQl9Owo=