178721 2017-10-24 03:06:52 -0700 Clean up gcc build warnings about reaching the end of a non void function for webrtc classes 2017-11-15 12:49:56 -0800 1 1 1 Unclassified WebKit WebRTC WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 alex alex commit-queue webkit-bug-importer youennf oldest_to_newest 1363653 0 alex 2017-10-24 03:06:52 -0700 Add asserts and fake returns to avoid the compiler warnings in those situations. 1363655 1 324666 alex 2017-10-24 03:15:26 -0700 Created attachment 324666 Patch 1364115 2 324666 commit-queue 2017-10-24 23:27:02 -0700 Comment on attachment 324666 Patch Clearing flags on attachment: 324666 Committed r223949: <https://trac.webkit.org/changeset/223949> 1364116 3 commit-queue 2017-10-24 23:27:03 -0700 All reviewed patches have been landed. Closing bug. 1372265 4 webkit-bug-importer 2017-11-15 12:49:56 -0800 <rdar://problem/35568235> 324666 2017-10-24 03:15:26 -0700 2017-10-24 23:27:02 -0700 Patch bug-178721-20171024121525.patch text/plain 4181 alex U3VidmVyc2lvbiBSZXZpc2lvbjogMjIzODg2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWFiNzE1MjY0ODRkYjVh MzlkMjk0YjVmZmZiMGM5NzI5MmE0OTdmMS4uZDYzZmMyNzhiODk2MDIxOTE5Nzk2MzhkZGJkY2Rl MDUxN2JlNzhiMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE3LTEwLTI0ICBBbGVq YW5kcm8gRy4gQ2FzdHJvICA8YWxleEBpZ2FsaWEuY29tPgorCisgICAgICAgIENsZWFuIHVwIGdj YyBidWlsZCB3YXJuaW5ncyBhYm91dCByZWFjaGluZyB0aGUgZW5kIG9mIGEgbm9uIHZvaWQgZnVu Y3Rpb24gZm9yIHdlYnJ0YyBjbGFzc2VzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNzg3MjEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBBc3NlcnQgd2hlbiB3ZSByZWFjaCB0aG9zZSBzaXR1YXRpb25zIGFu ZCByZXR1cm4gc29tZSB2YWx1ZSBhZnRlciB0aGF0IHRvIGF2b2lkIHdhcm5pbmcuCisKKyAgICAg ICAgTm8gbmV3IHRlc3RzLCB0aGlzIGlzIGEgY2xlYW4gdXAuCisKKyAgICAgICAgKiBNb2R1bGVz L21lZGlhc3RyZWFtL2xpYndlYnJ0Yy9MaWJXZWJSVENNZWRpYUVuZHBvaW50LmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OnNlc3Npb25EZXNjcmlwdGlvblR5cGUpOgorICAgICAgICAoV2ViQ29yZTo6 c2lnbmFsaW5nU3RhdGUpOgorICAgICAgICAoV2ViQ29yZTo6dG9SVENJY2VDb25uZWN0aW9uU3Rh dGUpOgorICAgICAgICAqIE1vZHVsZXMvbWVkaWFzdHJlYW0vbGlid2VicnRjL0xpYldlYlJUQ1Bl ZXJDb25uZWN0aW9uQmFja2VuZC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpidW5kbGVQb2xpY3lm cm9tQ29uZmlndXJhdGlvbik6CisgICAgICAgIChXZWJDb3JlOjppY2VUcmFuc3BvcnRQb2xpY3lm cm9tQ29uZmlndXJhdGlvbik6CisKIDIwMTctMTAtMjQgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdl YmtpdC5vcmc+CiAKICAgICAgICAgRG9jdW1lbnRPcmRlcmVkTWFwOjphZGQgc2hvdWxkIHJlbGVh c2UgYXNzZXJ0IHRoYXQgdHJlZSBzY29wZXMgbWF0Y2gKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL01vZHVsZXMvbWVkaWFzdHJlYW0vbGlid2VicnRjL0xpYldlYlJUQ01lZGlhRW5kcG9pbnQu Y3BwIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXN0cmVhbS9saWJ3ZWJydGMvTGliV2Vi UlRDTWVkaWFFbmRwb2ludC5jcHAKaW5kZXggNTRlYWQwMWYwNWIzNThhMDgwN2MzMjkwZTViNWM3 MjhmNWY1ZjZlYS4uM2JjMTRhZDk5MWNjOTNlOTRiYTIzZjZkNjUwOTAzYzQ2NGQ3ZDlkOCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXN0cmVhbS9saWJ3ZWJydGMvTGli V2ViUlRDTWVkaWFFbmRwb2ludC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRp YXN0cmVhbS9saWJ3ZWJydGMvTGliV2ViUlRDTWVkaWFFbmRwb2ludC5jcHAKQEAgLTkzLDYgKzkz LDkgQEAgc3RhdGljIGlubGluZSBjb25zdCBjaGFyKiBzZXNzaW9uRGVzY3JpcHRpb25UeXBlKFJU Q1NkcFR5cGUgc2RwVHlwZSkKICAgICBjYXNlIFJUQ1NkcFR5cGU6OlJvbGxiYWNrOgogICAgICAg ICByZXR1cm4gInJvbGxiYWNrIjsKICAgICB9CisKKyAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsK KyAgICByZXR1cm4gIiI7CiB9CiAKIHN0YXRpYyBpbmxpbmUgUlRDU2RwVHlwZSBmcm9tU2Vzc2lv bkRlc2NyaXB0aW9uVHlwZShjb25zdCB3ZWJydGM6OlNlc3Npb25EZXNjcmlwdGlvbkludGVyZmFj ZSYgZGVzY3JpcHRpb24pCkBAIC02MDAsNiArNjAzLDkgQEAgc3RhdGljIFJUQ1NpZ25hbGluZ1N0 YXRlIHNpZ25hbGluZ1N0YXRlKHdlYnJ0Yzo6UGVlckNvbm5lY3Rpb25JbnRlcmZhY2U6OlNpZ25h bGkKICAgICBjYXNlIHdlYnJ0Yzo6UGVlckNvbm5lY3Rpb25JbnRlcmZhY2U6OmtDbG9zZWQ6CiAg ICAgICAgIHJldHVybiBSVENTaWduYWxpbmdTdGF0ZTo6U3RhYmxlOwogICAgIH0KKworICAgIEFT U0VSVF9OT1RfUkVBQ0hFRCgpOworICAgIHJldHVybiBSVENTaWduYWxpbmdTdGF0ZTo6U3RhYmxl OwogfQogCiB2b2lkIExpYldlYlJUQ01lZGlhRW5kcG9pbnQ6Ok9uU2lnbmFsaW5nQ2hhbmdlKHdl YnJ0Yzo6UGVlckNvbm5lY3Rpb25JbnRlcmZhY2U6OlNpZ25hbGluZ1N0YXRlIHJ0Y1N0YXRlKQpA QCAtODMwLDkgKzgzNiwxMSBAQCBzdGF0aWMgaW5saW5lIFJUQ0ljZUNvbm5lY3Rpb25TdGF0ZSB0 b1JUQ0ljZUNvbm5lY3Rpb25TdGF0ZSh3ZWJydGM6OlBlZXJDb25uZWN0aQogICAgIGNhc2Ugd2Vi cnRjOjpQZWVyQ29ubmVjdGlvbkludGVyZmFjZTo6a0ljZUNvbm5lY3Rpb25DbG9zZWQ6CiAgICAg ICAgIHJldHVybiBSVENJY2VDb25uZWN0aW9uU3RhdGU6OkNsb3NlZDsKICAgICBjYXNlIHdlYnJ0 Yzo6UGVlckNvbm5lY3Rpb25JbnRlcmZhY2U6OmtJY2VDb25uZWN0aW9uTWF4OgotICAgICAgICBB U1NFUlRfTk9UX1JFQUNIRUQoKTsKLSAgICAgICAgcmV0dXJuIFJUQ0ljZUNvbm5lY3Rpb25TdGF0 ZTo6TmV3OworICAgICAgICBicmVhazsKICAgICB9CisKKyAgICBBU1NFUlRfTk9UX1JFQUNIRUQo KTsKKyAgICByZXR1cm4gUlRDSWNlQ29ubmVjdGlvblN0YXRlOjpOZXc7CiB9CiAKIHZvaWQgTGli V2ViUlRDTWVkaWFFbmRwb2ludDo6T25JY2VDb25uZWN0aW9uQ2hhbmdlKHdlYnJ0Yzo6UGVlckNv bm5lY3Rpb25JbnRlcmZhY2U6OkljZUNvbm5lY3Rpb25TdGF0ZSBzdGF0ZSkKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzdHJlYW0vbGlid2VicnRjL0xpYldlYlJUQ1Bl ZXJDb25uZWN0aW9uQmFja2VuZC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc3Ry ZWFtL2xpYndlYnJ0Yy9MaWJXZWJSVENQZWVyQ29ubmVjdGlvbkJhY2tlbmQuY3BwCmluZGV4IDA1 MzI1NjUwODJhMDM5YzEzMDZiMmI3MDhlY2I3OTY4MTVhODc4M2IuLjM0NjhmYzRhNDIxYmU2ZDcy MWE4MzUwY2QxODVmYWU4ZDc0YjllZGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVs ZXMvbWVkaWFzdHJlYW0vbGlid2VicnRjL0xpYldlYlJUQ1BlZXJDb25uZWN0aW9uQmFja2VuZC5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXN0cmVhbS9saWJ3ZWJydGMvTGli V2ViUlRDUGVlckNvbm5lY3Rpb25CYWNrZW5kLmNwcApAQCAtNzcsNiArNzcsOSBAQCBzdGF0aWMg aW5saW5lIHdlYnJ0Yzo6UGVlckNvbm5lY3Rpb25JbnRlcmZhY2U6OkJ1bmRsZVBvbGljeSBidW5k bGVQb2xpY3lmcm9tQ29uZgogICAgIGNhc2UgUlRDQnVuZGxlUG9saWN5OjpCYWxhbmNlZDoKICAg ICAgICAgcmV0dXJuIHdlYnJ0Yzo6UGVlckNvbm5lY3Rpb25JbnRlcmZhY2U6OmtCdW5kbGVQb2xp Y3lCYWxhbmNlZDsKICAgICB9CisKKyAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKKyAgICByZXR1 cm4gd2VicnRjOjpQZWVyQ29ubmVjdGlvbkludGVyZmFjZTo6a0J1bmRsZVBvbGljeU1heENvbXBh dDsKIH0KIAogc3RhdGljIGlubGluZSB3ZWJydGM6OlBlZXJDb25uZWN0aW9uSW50ZXJmYWNlOjpJ Y2VUcmFuc3BvcnRzVHlwZSBpY2VUcmFuc3BvcnRQb2xpY3lmcm9tQ29uZmlndXJhdGlvbihjb25z dCBNZWRpYUVuZHBvaW50Q29uZmlndXJhdGlvbiYgY29uZmlndXJhdGlvbikKQEAgLTg3LDYgKzkw LDkgQEAgc3RhdGljIGlubGluZSB3ZWJydGM6OlBlZXJDb25uZWN0aW9uSW50ZXJmYWNlOjpJY2VU cmFuc3BvcnRzVHlwZSBpY2VUcmFuc3BvcnRQb2wKICAgICBjYXNlIFJUQ0ljZVRyYW5zcG9ydFBv bGljeTo6QWxsOgogICAgICAgICByZXR1cm4gd2VicnRjOjpQZWVyQ29ubmVjdGlvbkludGVyZmFj ZTo6a0FsbDsKICAgICB9CisKKyAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKKyAgICByZXR1cm4g d2VicnRjOjpQZWVyQ29ubmVjdGlvbkludGVyZmFjZTo6a05vbmU7CiB9CiAKIHN0YXRpYyB3ZWJy dGM6OlBlZXJDb25uZWN0aW9uSW50ZXJmYWNlOjpSVENDb25maWd1cmF0aW9uIGNvbmZpZ3VyYXRp b25Gcm9tTWVkaWFFbmRwb2ludENvbmZpZ3VyYXRpb24oTWVkaWFFbmRwb2ludENvbmZpZ3VyYXRp b24mJiBjb25maWd1cmF0aW9uKQo=