178713 2017-10-23 23:48:55 -0700 [iOS] MediaPlayer::isAvailable() takes ~150 ms during web process initialization 2017-10-24 10:38:49 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 wenson_hsieh wenson_hsieh commit-queue eric.carlson jer.noble thorton oldest_to_newest 1363597 0 wenson_hsieh 2017-10-23 23:48:55 -0700 <rdar://problem/35115906> 1363601 1 324651 wenson_hsieh 2017-10-23 23:56:08 -0700 Created attachment 324651 Patch 1363685 2 324651 eric.carlson 2017-10-24 08:51:17 -0700 Comment on attachment 324651 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=324651&action=review > Source/WebCore/platform/graphics/MediaPlayer.cpp:961 > +#if USE(AVFOUNDATION) > + if (DeprecatedGlobalSettings::isAVFoundationEnabled()) > + return true; > +#endif The AVFoundation and CoreMedia frameworks are not installed on a recovery partition, so this will cause HTMLMediaElement to be in the DOM but MediaPlayerPrivateAVFoundationObjC::registerMediaEngine will fail so <audio> and <video> elements won't work. You might make MediaPlayerPrivateAVFoundationObjC::isAvailable() public and call it here instead. 1363687 3 wenson_hsieh 2017-10-24 09:01:08 -0700 (In reply to Eric Carlson from comment #2) > Comment on attachment 324651 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=324651&action=review > > > Source/WebCore/platform/graphics/MediaPlayer.cpp:961 > > +#if USE(AVFOUNDATION) > > + if (DeprecatedGlobalSettings::isAVFoundationEnabled()) > > + return true; > > +#endif > > The AVFoundation and CoreMedia frameworks are not installed on a recovery > partition, so this will cause HTMLMediaElement to be in the DOM but > MediaPlayerPrivateAVFoundationObjC::registerMediaEngine will fail so <audio> > and <video> elements won't work. You might make > MediaPlayerPrivateAVFoundationObjC::isAvailable() public and call it here > instead. Ah, ok...I suspected there might be a case where this would fail :/ My goal is to avoid invoking MediaPlayerPrivateAVFoundationObjC::isAvailable() altogether, since that tries to dlopen() AVFoundation...I'll see if there's another way to address this. Thanks! 1363706 4 wenson_hsieh 2017-10-24 09:42:35 -0700 (In reply to Wenson Hsieh from comment #3) > (In reply to Eric Carlson from comment #2) > > Comment on attachment 324651 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=324651&action=review > > > > > Source/WebCore/platform/graphics/MediaPlayer.cpp:961 > > > +#if USE(AVFOUNDATION) > > > + if (DeprecatedGlobalSettings::isAVFoundationEnabled()) > > > + return true; > > > +#endif > > > > The AVFoundation and CoreMedia frameworks are not installed on a recovery > > partition, so this will cause HTMLMediaElement to be in the DOM but > > MediaPlayerPrivateAVFoundationObjC::registerMediaEngine will fail so <audio> > > and <video> elements won't work. You might make > > MediaPlayerPrivateAVFoundationObjC::isAvailable() public and call it here > > instead. > > Ah, ok...I suspected there might be a case where this would fail :/ > > My goal is to avoid invoking > MediaPlayerPrivateAVFoundationObjC::isAvailable() altogether, since that > tries to dlopen() AVFoundation...I'll see if there's another way to address > this. Thanks! Spoke to Eric in person -- while AVFoundation and CoreMedia may not exist in recovery partitions, this is only the case on Mac. On iOS, it is generally safe to assume that AVFoundation and CoreMedia exist (otherwise, many other system apps and frameworks would fail anyways). Since this early return is desired for improving performance on iOS-based platforms in the first place, we can just guard it with PLATFORM(IOS). 1363707 5 324679 wenson_hsieh 2017-10-24 09:48:41 -0700 Created attachment 324679 Patch 1363735 6 324679 commit-queue 2017-10-24 10:38:48 -0700 Comment on attachment 324679 Patch Clearing flags on attachment: 324679 Committed r223897: <https://trac.webkit.org/changeset/223897> 1363736 7 commit-queue 2017-10-24 10:38:49 -0700 All reviewed patches have been landed. Closing bug. 324651 2017-10-23 23:56:08 -0700 2017-10-24 09:01:33 -0700 Patch bug-178713-20171023235607.patch text/plain 1834 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjIzODYyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDhhZDgzNmZiNzg3NjBl MTFkY2ZlZTVmZmUzN2ZmZjcwYjY4MzBhNi4uNTNiMmEyYzE2Y2E2MzY2ZTM2OTE1NWIyYzBjMDNi N2ZmZGRjMTFkNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIwIEBACiAyMDE3LTEwLTIzICBXZW5z b24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgogCisgICAgICAgIFtpT1NdIE1lZGlh UGxheWVyOjppc0F2YWlsYWJsZSgpIHRha2VzIH4xNTAgbXMgZHVyaW5nIHdlYiBwcm9jZXNzIGlu aXRpYWxpemF0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xNzg3MTMKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzM1MTE1OTA2PgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIExvYWRpbmcgQVZGb3VuZGF0 aW9uIHNob3VsZCBub3QgYmUgcmVxdWlyZWQgdG8gYW5zd2VyIHRoZSBxdWVzdGlvbiBvZiBNZWRp YVBsYXllcjo6aXNBdmFpbGFibGUoKS4gT24gYWxsIGNsaWVudHMKKyAgICAgICAgb2YgQVZGb3Vu ZGF0aW9uLCB0aGlzIGFwcGVhcnMgdG8gcmV0dXJuIHRydWUsIHNpbmNlIEFWRm91bmRhdGlvbiBh bmQgQ29yZU1lZGlhIHNob3VsZCBhbHdheXMgZXhpc3QsIHNvIGF0IHRoZQorICAgICAgICBtaW5p bXVtLCBNZWRpYVBsYXllclByaXZhdGVBVkZvdW5kYXRpb25PYmpDIChvciwgb24gV2luZG93cywg TWVkaWFQbGF5ZXJQcml2YXRlQVZGb3VuZGF0aW9uQ0YpIHNob3VsZCBiZSBhdmFpbGFibGUuCisK KyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9NZWRpYVBsYXllci5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpNZWRpYVBsYXllcjo6aXNBdmFpbGFibGUpOgorCisyMDE3LTEwLTIzICBXZW5zb24g SHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgorCiAgICAgICAgIFVucmV2aWV3ZWQsIGZp eCB0aGUgV2luZG93cyBidWlsZCBhZnRlciByMjIzODYwCiAKICAgICAgICAgVVRJVXRpbGl0aWVz IG9ubHkgZXhpc3RzIG9uIENvY29hIHBsYXRmb3Jtcywgc28gd2UgbmVlZCB0byBndWFyZCBpdCBh Y2NvcmRpbmdseS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L01lZGlhUGxheWVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL01lZGlh UGxheWVyLmNwcAppbmRleCBhYzU1NzUyMTAxOGVlZjU5NDBmNDExZGZjN2ZmYjM1OWZkZGFmNWU4 Li4wNDhiODhhZTFlYmE5NTkxMDAxMTEwNGZkMjNjNmZlYzgwNGYxYWU0IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9NZWRpYVBsYXllci5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvTWVkaWFQbGF5ZXIuY3BwCkBAIC05NTUsNiAr OTU1LDEwIEBAIHZvaWQgTWVkaWFQbGF5ZXI6OmdldFN1cHBvcnRlZFR5cGVzKEhhc2hTZXQ8U3Ry aW5nLCBBU0NJSUNhc2VJbnNlbnNpdGl2ZUhhc2g+JiB0CiAKIGJvb2wgTWVkaWFQbGF5ZXI6Omlz QXZhaWxhYmxlKCkKIHsKKyNpZiBVU0UoQVZGT1VOREFUSU9OKQorICAgIGlmIChEZXByZWNhdGVk R2xvYmFsU2V0dGluZ3M6OmlzQVZGb3VuZGF0aW9uRW5hYmxlZCgpKQorICAgICAgICByZXR1cm4g dHJ1ZTsKKyNlbmRpZgogICAgIHJldHVybiAhaW5zdGFsbGVkTWVkaWFFbmdpbmVzKCkuaXNFbXB0 eSgpOwogfQogCg== 324679 2017-10-24 09:48:41 -0700 2017-10-24 10:38:48 -0700 Patch bug-178713-20171024094840.patch text/plain 1773 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjIzODYyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDhhZDgzNmZiNzg3NjBl MTFkY2ZlZTVmZmUzN2ZmZjcwYjY4MzBhNi4uMzNiN2MxYjcyNTJkNTkzYTczZGRiZjZjOWJhOTI5 ZDY5NTllYTE1NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIwIEBACiAyMDE3LTEwLTIzICBXZW5z b24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgogCisgICAgICAgIFtpT1NdIE1lZGlh UGxheWVyOjppc0F2YWlsYWJsZSgpIHRha2VzIH4xNTAgbXMgZHVyaW5nIHdlYiBwcm9jZXNzIGlu aXRpYWxpemF0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xNzg3MTMKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzM1MTE1OTA2PgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIExvYWRpbmcgQVZGb3VuZGF0 aW9uIHNob3VsZCBub3QgYmUgcmVxdWlyZWQgdG8gYW5zd2VyIHRoZSBxdWVzdGlvbiBvZiBNZWRp YVBsYXllcjo6aXNBdmFpbGFibGUoKSBvbiBpT1MsIHdoZXJlCisgICAgICAgIGJvdGggQVZGb3Vu ZGF0aW9uIGFuZCBDb3JlTWVkaWEgZnJhbWV3b3JrcyBzaG91bGQgYWx3YXlzIGV4aXN0LiBBcyBz dWNoLCB3ZSBjYW4gYmFpbCBlYXJseSBhbmQgcmV0dXJuIHRydWUgdG8KKyAgICAgICAgYXZvaWQg YWx3YXlzIGR5bmFtaWNhbGx5IGxvYWRpbmcgQVZGb3VuZGF0aW9uIGFuZCBDb3JlTWVkaWEuCisK KyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9NZWRpYVBsYXllci5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpNZWRpYVBsYXllcjo6aXNBdmFpbGFibGUpOgorCisyMDE3LTEwLTIzICBXZW5zb24g SHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgorCiAgICAgICAgIFVucmV2aWV3ZWQsIGZp eCB0aGUgV2luZG93cyBidWlsZCBhZnRlciByMjIzODYwCiAKICAgICAgICAgVVRJVXRpbGl0aWVz IG9ubHkgZXhpc3RzIG9uIENvY29hIHBsYXRmb3Jtcywgc28gd2UgbmVlZCB0byBndWFyZCBpdCBh Y2NvcmRpbmdseS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L01lZGlhUGxheWVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL01lZGlh UGxheWVyLmNwcAppbmRleCBhYzU1NzUyMTAxOGVlZjU5NDBmNDExZGZjN2ZmYjM1OWZkZGFmNWU4 Li44OTVlMTNmYTQ4NjNhYjQ5MWNhMzUwMmEwZTA3ZWE2MTc1ZjdkZWEzIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9NZWRpYVBsYXllci5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvTWVkaWFQbGF5ZXIuY3BwCkBAIC05NTUsNiAr OTU1LDEwIEBAIHZvaWQgTWVkaWFQbGF5ZXI6OmdldFN1cHBvcnRlZFR5cGVzKEhhc2hTZXQ8U3Ry aW5nLCBBU0NJSUNhc2VJbnNlbnNpdGl2ZUhhc2g+JiB0CiAKIGJvb2wgTWVkaWFQbGF5ZXI6Omlz QXZhaWxhYmxlKCkKIHsKKyNpZiBQTEFURk9STShJT1MpCisgICAgaWYgKERlcHJlY2F0ZWRHbG9i YWxTZXR0aW5nczo6aXNBVkZvdW5kYXRpb25FbmFibGVkKCkpCisgICAgICAgIHJldHVybiB0cnVl OworI2VuZGlmCiAgICAgcmV0dXJuICFpbnN0YWxsZWRNZWRpYUVuZ2luZXMoKS5pc0VtcHR5KCk7 CiB9CiAK