178698 2017-10-23 19:27:34 -0700 -Wsubobject-linkage warning in InspectorIndexedDBAgent.cpp 2017-11-15 13:01:46 -0800 1 1 1 Unclassified WebKit Web Inspector Other PC Linux RESOLVED FIXED InRadar P2 Normal --- 1 mcatanzaro mcatanzaro commit-queue inspector-bugzilla-changes joepeck mcatanzaro webkit-bug-importer oldest_to_newest 1363521 0 mcatanzaro 2017-10-23 19:27:34 -0700 Let's fix this: [2219/3619] Building CXX object Source...unified-sources/UnifiedSource260.cpp.o In file included from DerivedSources/WebCore/unified-sources/UnifiedSource260.cpp:1:0: ../../Source/WebCore/inspector/InspectorIndexedDBAgent.cpp:664:7: warning: ‘WebCore::ClearObjectStore’ has a field ‘WebCore::ClearObjectStore::<anonymous>’ whose type uses the anonymous namespace [-Wsubobject-linkage] class ClearObjectStore final : public ExecutableWithDatabase { ^~~~~~~~~~~~~~~~ ../../Source/WebCore/inspector/InspectorIndexedDBAgent.cpp:664:7: warning: ‘WebCore::ClearObjectStore’ has a base ‘WebCore::{anonymous}::ExecutableWithDatabase’ whose type uses the anonymous namespace [-Wsubobject-linkage] 1363555 1 324635 mcatanzaro 2017-10-23 21:13:58 -0700 Created attachment 324635 Patch 1363557 2 324635 joepeck 2017-10-23 21:16:09 -0700 Comment on attachment 324635 Patch Interesting. Should we put this in the same anonymous namespace as the stuff at the top of the file? If this is enough though, r=me 1363564 3 mcatanzaro 2017-10-23 21:33:05 -0700 There's only one anonymous namespace per translation unit (normally that's one file, but for us now that's a unified source bundle). So it doesn't matter where it goes. Up to you; I figured the class is in its current location for a reason. 1363633 4 324635 commit-queue 2017-10-24 01:38:32 -0700 Comment on attachment 324635 Patch Clearing flags on attachment: 324635 Committed r223885: <https://trac.webkit.org/changeset/223885> 1363634 5 commit-queue 2017-10-24 01:38:33 -0700 All reviewed patches have been landed. Closing bug. 1372315 6 webkit-bug-importer 2017-11-15 13:01:46 -0800 <rdar://problem/35568516> 324635 2017-10-23 21:13:58 -0700 2017-10-24 01:38:32 -0700 Patch bug-178698-20171023231357.patch text/plain 1722 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjIzODc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTViYjQ4Y2Y0MzFjNDNj YmYwMmUyZmZlMWNkY2NjODUzNWE3NzI2Mi4uYjk1NzliZmVjNjA1MWE1NDI4NThjMTAwYTk3Mjk1 YjM4MDJkZjJlZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE3LTEwLTIzICBNaWNo YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KKworICAgICAgICAtV3N1Ym9i amVjdC1saW5rYWdlIHdhcm5pbmcgaW4gSW5zcGVjdG9ySW5kZXhlZERCQWdlbnQuY3BwCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzg2OTgKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGluc3BlY3Rvci9J bnNwZWN0b3JJbmRleGVkREJBZ2VudC5jcHA6CisKIDIwMTctMTAtMjMgIENvbW1pdCBRdWV1ZSAg PGNvbW1pdC1xdWV1ZUB3ZWJraXQub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcg b3V0IHIyMjM4NzAgYW5kIHIyMjM4NzEuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNw ZWN0b3IvSW5zcGVjdG9ySW5kZXhlZERCQWdlbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvaW5zcGVj dG9yL0luc3BlY3RvckluZGV4ZWREQkFnZW50LmNwcAppbmRleCA0NGExMjM4ZTgzYTFhZTVkNzgy NTk3MGJmZjRlOGQ0NjBlNGZiMjIzLi4yNjRlZDBlNWYyM2Y2OWUwZTY2ZWE4YjJiZDg3NGYzNGZh MmIwNzhhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9ySW5k ZXhlZERCQWdlbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JJ bmRleGVkREJBZ2VudC5jcHAKQEAgLTYyNSw2ICs2MjUsOCBAQCB2b2lkIEluc3BlY3RvckluZGV4 ZWREQkFnZW50OjpyZXF1ZXN0RGF0YShFcnJvclN0cmluZyYgZXJyb3JTdHJpbmcsIGNvbnN0IFN0 cmluZwogICAgIGRhdGFMb2FkZXItPnN0YXJ0KGlkYkZhY3RvcnksICZkb2N1bWVudC0+c2VjdXJp dHlPcmlnaW4oKSwgZGF0YWJhc2VOYW1lKTsKIH0KIAorbmFtZXNwYWNlIHsKKwogY2xhc3MgQ2xl YXJPYmplY3RTdG9yZUxpc3RlbmVyIGZpbmFsIDogcHVibGljIEV2ZW50TGlzdGVuZXIgewogICAg IFdURl9NQUtFX05PTkNPUFlBQkxFKENsZWFyT2JqZWN0U3RvcmVMaXN0ZW5lcik7CiBwdWJsaWM6 CkBAIC03MTMsNiArNzE1LDggQEAgcHJpdmF0ZToKICAgICBSZWY8Q2xlYXJPYmplY3RTdG9yZUNh bGxiYWNrPiBtX3JlcXVlc3RDYWxsYmFjazsKIH07CiAKK30gLy8gYW5vbnltb3VzIG5hbWVzcGFj ZQorCiB2b2lkIEluc3BlY3RvckluZGV4ZWREQkFnZW50OjpjbGVhck9iamVjdFN0b3JlKEVycm9y U3RyaW5nJiBlcnJvclN0cmluZywgY29uc3QgU3RyaW5nJiBzZWN1cml0eU9yaWdpbiwgY29uc3Qg U3RyaW5nJiBkYXRhYmFzZU5hbWUsIGNvbnN0IFN0cmluZyYgb2JqZWN0U3RvcmVOYW1lLCBSZWY8 Q2xlYXJPYmplY3RTdG9yZUNhbGxiYWNrPiYmIHJlcXVlc3RDYWxsYmFjaykKIHsKICAgICBGcmFt ZSogZnJhbWUgPSBtX3BhZ2VBZ2VudC0+ZmluZEZyYW1lV2l0aFNlY3VyaXR5T3JpZ2luKHNlY3Vy aXR5T3JpZ2luKTsK