178652 2017-10-22 22:24:02 -0700 [Curl] Fix authentication related bugs 2017-11-15 12:59:10 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 basuke basuke achristensen basuke buildbot commit-queue don.olmstead galpeter pvollan rniwa webkit-bug-importer oldest_to_newest 1363212 0 basuke 2017-10-22 22:24:02 -0700 After bug 175148, WinCairo fails basic/digest authentication because credential does not set correctly. 1363217 1 basuke 2017-10-22 22:43:50 -0700 Also realm handling was bad. Completely wrong. 1363225 2 324547 basuke 2017-10-22 23:41:23 -0700 Created attachment 324547 fix 1363314 3 324547 commit-queue 2017-10-23 10:21:11 -0700 Comment on attachment 324547 fix Clearing flags on attachment: 324547 Committed r223838: <https://trac.webkit.org/changeset/223838> 1363315 4 commit-queue 2017-10-23 10:21:13 -0700 All reviewed patches have been landed. Closing bug. 1372296 5 webkit-bug-importer 2017-11-15 12:59:10 -0800 <rdar://problem/35568543> 324547 2017-10-22 23:41:23 -0700 2017-10-23 10:21:11 -0700 fix 178652-1.diff text/plain 6104 basuke ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBhMzVlNmJiZWQxMC4uNjY1YTdlZTdkYmEgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMCBAQAorMjAxNy0xMC0yMiAgQmFzdWtlIFN1enVraSAgPEJhc3VrZS5TdXp1a2lAc29u eS5jb20+CisKKyAgICAgICAgW0N1cmxdIEZpeCBhdXRoZW50aWNhdGlvbiByZWxhdGVkIGJ1Z3MK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3ODY1Mgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZv cm0vbmV0d29yay9jdXJsL0F1dGhlbnRpY2F0aW9uQ2hhbGxlbmdlQ3VybC5jcHA6CisgICAgICAg IChXZWJDb3JlOjpBdXRoZW50aWNhdGlvbkNoYWxsZW5nZTo6cHJvdGVjdGlvblNwYWNlRnJvbUhh bmRsZSk6CisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9jdXJsL0N1cmxDb250ZXh0LmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OkN1cmxIYW5kbGU6OnNldEh0dHBBdXRoVXNlclBhc3MpOgorICAg ICAgICAqIHBsYXRmb3JtL25ldHdvcmsvY3VybC9DdXJsUmVxdWVzdC5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpDdXJsUmVxdWVzdDo6c2V0VXNlclBhc3MpOgorICAgICAgICAoV2ViQ29yZTo6Q3Vy bFJlcXVlc3Q6OnNldHVwVHJhbnNmZXIpOgorICAgICAgICAoV2ViQ29yZTo6Q3VybFJlcXVlc3Q6 OmRpZFJlY2VpdmVIZWFkZXIpOgorICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvY3VybC9DdXJs UmVxdWVzdC5oOgorCiAyMDE3LTEwLTE5ICBEYW5pZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNv bT4KIAogICAgICAgICBVc2UgIj0gZGVmYXVsdCIgdG8gZGVub3RlIGRlZmF1bHQgY29uc3RydWN0 b3Igb3IgZGVzdHJ1Y3RvcgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0 d29yay9jdXJsL0F1dGhlbnRpY2F0aW9uQ2hhbGxlbmdlQ3VybC5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9uZXR3b3JrL2N1cmwvQXV0aGVudGljYXRpb25DaGFsbGVuZ2VDdXJsLmNwcApp bmRleCA5MDExZmIxNTlmMy4uNTc1NzgyNmVmYjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL25ldHdvcmsvY3VybC9BdXRoZW50aWNhdGlvbkNoYWxsZW5nZUN1cmwuY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY3VybC9BdXRoZW50aWNhdGlvbkNo YWxsZW5nZUN1cmwuY3BwCkBAIC02OCw4ICs2OCw4IEBAIFByb3RlY3Rpb25TcGFjZSBBdXRoZW50 aWNhdGlvbkNoYWxsZW5nZTo6cHJvdGVjdGlvblNwYWNlRnJvbUhhbmRsZShjb25zdCBDdXJsUmVz CiAKICAgICBTdHJpbmcgcmVhbG07CiAgICAgY29uc3QgU3RyaW5nIHJlYWxtU3RyaW5nKCJyZWFs bT0iKTsKLSAgICBhdXRvIGF1dGhIZWFkZXIgPSByZXNwb25zZS5odHRwSGVhZGVyRmllbGQoSFRU UEhlYWRlck5hbWU6OkF1dGhvcml6YXRpb24pOwotICAgIGF1dG8gcmVhbG1Qb3MgPSBhdXRoSGVh ZGVyLmZpbmQocmVhbG1TdHJpbmcpOworICAgIGF1dG8gYXV0aEhlYWRlciA9IHJlc3BvbnNlLmh0 dHBIZWFkZXJGaWVsZChTdHJpbmcoInd3dy1hdXRoZW50aWNhdGUiKSk7CisgICAgYXV0byByZWFs bVBvcyA9IGF1dGhIZWFkZXIuZmluZElnbm9yaW5nQ2FzZShyZWFsbVN0cmluZyk7CiAgICAgaWYg KHJlYWxtUG9zICE9IG5vdEZvdW5kKSB7CiAgICAgICAgIHJlYWxtID0gYXV0aEhlYWRlci5zdWJz dHJpbmcocmVhbG1Qb3MgKyByZWFsbVN0cmluZy5sZW5ndGgoKSk7CiAgICAgICAgIHJlYWxtID0g cmVhbG0ubGVmdChyZWFsbS5maW5kKCcsJykpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vbmV0d29yay9jdXJsL0N1cmxDb250ZXh0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL25ldHdvcmsvY3VybC9DdXJsQ29udGV4dC5jcHAKaW5kZXggMzU4YmFlNzg5ZmUuLmVj YTIyNjAzYjFhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2N1 cmwvQ3VybENvbnRleHQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsv Y3VybC9DdXJsQ29udGV4dC5jcHAKQEAgLTQyMywxMiArNDIzLDggQEAgdm9pZCBDdXJsSGFuZGxl OjplbmFibGVIdHRwQXV0aGVudGljYXRpb24obG9uZyBvcHRpb24pCiAKIHZvaWQgQ3VybEhhbmRs ZTo6c2V0SHR0cEF1dGhVc2VyUGFzcyhjb25zdCBTdHJpbmcmIHVzZXIsIGNvbnN0IFN0cmluZyYg cGFzc3dvcmQpCiB7Ci0gICAgU3RyaW5nIHVzZXJwYXNzID0gZW1wdHlTdHJpbmcoKTsKLQotICAg IGlmICghdXNlci5pc0VtcHR5KCkgfHwgIXBhc3N3b3JkLmlzRW1wdHkoKSkKLSAgICAgICAgdXNl cnBhc3MgPSB1c2VyICsgIjoiICsgcGFzc3dvcmQ7Ci0KLSAgICBjdXJsX2Vhc3lfc2V0b3B0KG1f aGFuZGxlLCBDVVJMT1BUX1VTRVJQV0QsIHVzZXJwYXNzLnV0ZjgoKS5kYXRhKCkpOworICAgIGN1 cmxfZWFzeV9zZXRvcHQobV9oYW5kbGUsIENVUkxPUFRfVVNFUk5BTUUsIHVzZXIudXRmOCgpLmRh dGEoKSk7CisgICAgY3VybF9lYXN5X3NldG9wdChtX2hhbmRsZSwgQ1VSTE9QVF9QQVNTV09SRCwg cGFzc3dvcmQudXRmOCgpLmRhdGEoKSk7CiB9CiAKIHZvaWQgQ3VybEhhbmRsZTo6c2V0Q0FDZXJ0 UGF0aChjb25zdCBjaGFyKiBwYXRoKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vbmV0d29yay9jdXJsL0N1cmxSZXF1ZXN0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L25ldHdvcmsvY3VybC9DdXJsUmVxdWVzdC5jcHAKaW5kZXggOTFlYmQ4ZGJkZjkuLjMyY2RmYzRj ZDcxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2N1cmwvQ3Vy bFJlcXVlc3QuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY3VybC9D dXJsUmVxdWVzdC5jcHAKQEAgLTUxLDcgKzUxLDcgQEAgdm9pZCBDdXJsUmVxdWVzdDo6c2V0VXNl clBhc3MoY29uc3QgU3RyaW5nJiB1c2VyLCBjb25zdCBTdHJpbmcmIHBhc3N3b3JkKQogICAgIEFT U0VSVChpc01haW5UaHJlYWQoKSk7CiAKICAgICBtX3VzZXIgPSB1c2VyLmlzb2xhdGVkQ29weSgp OwotICAgIG1fcGFzc3dvcmQgPSB1c2VyLmlzb2xhdGVkQ29weSgpOworICAgIG1fcGFzc3dvcmQg PSBwYXNzd29yZC5pc29sYXRlZENvcHkoKTsKIH0KIAogdm9pZCBDdXJsUmVxdWVzdDo6c3RhcnQo Ym9vbCBpc1N5bmNSZXF1ZXN0KQpAQCAtMTY4LDcgKzE2OCw3IEBAIENVUkwqIEN1cmxSZXF1ZXN0 OjpzZXR1cFRyYW5zZmVyKCkKIAogICAgIGlmICghbV91c2VyLmlzRW1wdHkoKSB8fCAhbV9wYXNz d29yZC5pc0VtcHR5KCkpIHsKICAgICAgICAgbV9jdXJsSGFuZGxlLT5lbmFibGVIdHRwQXV0aGVu dGljYXRpb24oQ1VSTEFVVEhfQU5ZKTsKLSAgICAgICAgbV9jdXJsSGFuZGxlLT5zZXRIdHRwQXV0 aFVzZXJQYXNzKG1fdXNlci5sYXRpbjEoKS5kYXRhKCksIG1fcGFzc3dvcmQubGF0aW4xKCkuZGF0 YSgpKTsKKyAgICAgICAgbV9jdXJsSGFuZGxlLT5zZXRIdHRwQXV0aFVzZXJQYXNzKG1fdXNlciwg bV9wYXNzd29yZCk7CiAgICAgfQogCiAgICAgbV9jdXJsSGFuZGxlLT5zZXRIZWFkZXJDYWxsYmFj a0Z1bmN0aW9uKGRpZFJlY2VpdmVIZWFkZXJDYWxsYmFjaywgdGhpcyk7CkBAIC0yNTQsNiArMjU0 LDE2IEBAIHNpemVfdCBDdXJsUmVxdWVzdDo6ZGlkUmVjZWl2ZUhlYWRlcihTdHJpbmcmJiBoZWFk ZXIpCiAgICAgaWYgKG1fY2FuY2VsbGVkKQogICAgICAgICByZXR1cm4gMDsKIAorICAgIC8vIGxp YmN1cmwgc2VuZHMgYWxsIGhlYWRlcnMgdGhhdCBsaWJjdXJsIHJlY2VpdmVkIHRvIGFwcGxpY2F0 aW9uLgorICAgIC8vIFNvLCBpbiBkaWdlc3QgYXV0aGVudGljYXRpb24sIGEgYmxvY2sgb2YgcmVz cG9uc2UgaGVhZGVycyBhcmUgcmVjZWl2ZWQgdHdpY2UgY29uc2VjdXRpdmVseSBmcm9tIGxpYmN1 cmwuCisgICAgLy8gRm9yIGV4YW1wbGUsIHdoZW4gYXV0aGVudGljYXRpb24gc3VjY2VlZHMsIHRo ZSBmaXJzdCBibG9jayBpcyAiNDAxIEF1dGhvcml6YXRpb24iLCBhbmQgdGhlIHNlY29uZCBibG9j ayBpcyAiMjAwIE9LIi4KKyAgICAvLyBBbHNvLCAiMTAwIENvbnRpbnVlIiBhbmQgIjIwMCBDb25u ZWN0aW9uIEVzdGFibGlzaGVkIiBkbyB0aGUgc2FtZSBiZWhhdmlvci4KKyAgICAvLyBJbiB0aGlz IHByb2Nlc3MsIGRlbGV0ZXMgdGhlIGZpcnN0IGJsb2NrIHRvIHNlbmQgYSBjb3JyZWN0IGhlYWRl cnMgdG8gV2ViQ29yZS4KKyAgICBpZiAobV9kaWRSZWNlaXZlUmVzcG9uc2UpIHsKKyAgICAgICAg bV9kaWRSZWNlaXZlUmVzcG9uc2UgPSBmYWxzZTsKKyAgICAgICAgbV9yZXNwb25zZSA9IEN1cmxS ZXNwb25zZSB7IH07CisgICAgfQorCiAgICAgYXV0byByZWNlaXZlQnl0ZXMgPSBzdGF0aWNfY2Fz dDxzaXplX3Q+KGhlYWRlci5sZW5ndGgoKSk7CiAKICAgICAvLyBUaGUgSFRUUCBzdGFuZGFyZCBy ZXF1aXJlcyB0byB1c2UgXHJcbiBidXQgZm9yIGNvbXBhdGliaWxpdHkgaXQgcmVjb21tZW5kcyB0 byBhY2NlcHQgYWxzbyBcbi4KQEAgLTI3MCwxOCArMjgwLDcgQEAgc2l6ZV90IEN1cmxSZXF1ZXN0 OjpkaWRSZWNlaXZlSGVhZGVyKFN0cmluZyYmIGhlYWRlcikKICAgICBpZiAoYXV0byBjb2RlID0g bV9jdXJsSGFuZGxlLT5nZXRIdHRwQ29ubmVjdENvZGUoKSkKICAgICAgICAgaHR0cENvbm5lY3RD b2RlID0gKmNvZGU7CiAKLSAgICBpZiAoKDEwMCA8PSBzdGF0dXNDb2RlKSAmJiAoc3RhdHVzQ29k ZSA8IDIwMCkpIHsKLSAgICAgICAgLy8gSnVzdCByZXR1cm4gd2hlbiByZWNlaXZpbmcgaHR0cCBp bmZvLCBlLmcuIEhUVFAvMS4xIDEwMCBDb250aW51ZS4KLSAgICAgICAgLy8gSWYgbm90LCB0aGUg cmVxdWVzdCBtaWdodCBiZSBjYW5jZWxsZWQsIGJlY2F1c2UgdGhlIE1JTUUgdHlwZSB3aWxsIGJl IGVtcHR5IGZvciB0aGlzIHJlc3BvbnNlLgotICAgICAgICBtX3Jlc3BvbnNlID0gQ3VybFJlc3Bv bnNlIHsgfTsKLSAgICAgICAgcmV0dXJuIHJlY2VpdmVCeXRlczsKLSAgICB9Ci0KLSAgICBpZiAo IXN0YXR1c0NvZGUgJiYgKGh0dHBDb25uZWN0Q29kZSA9PSAyMDApKSB7Ci0gICAgICAgIC8vIENv bWVzIGhlcmUgd2hlbiByZWNlaXZpbmcgMjAwIENvbm5lY3Rpb24gRXN0YWJsaXNoZWQuIEp1c3Qg cmV0dXJuLgotICAgICAgICBtX3Jlc3BvbnNlID0gQ3VybFJlc3BvbnNlIHsgfTsKLSAgICAgICAg cmV0dXJuIHJlY2VpdmVCeXRlczsKLSAgICB9CisgICAgbV9kaWRSZWNlaXZlUmVzcG9uc2UgPSB0 cnVlOwogCiAgICAgbV9yZXNwb25zZS51cmwgPSBtX3JlcXVlc3QudXJsKCk7CiAgICAgbV9yZXNw b25zZS5zdGF0dXNDb2RlID0gc3RhdHVzQ29kZTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL25ldHdvcmsvY3VybC9DdXJsUmVxdWVzdC5oIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vbmV0d29yay9jdXJsL0N1cmxSZXF1ZXN0LmgKaW5kZXggNTVkMDdiMmM4NzYuLmEzOTg4 MWFjMmVlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2N1cmwv Q3VybFJlcXVlc3QuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2N1cmwv Q3VybFJlcXVlc3QuaApAQCAtMTM5LDggKzEzOSw5IEBAIHByaXZhdGU6CiAgICAgc3RkOjp1bmlx dWVfcHRyPEZvcm1EYXRhU3RyZWFtPiBtX2Zvcm1EYXRhU3RyZWFtOwogICAgIFZlY3RvcjxjaGFy PiBtX3Bvc3RCdWZmZXI7CiAgICAgQ3VybFNTTFZlcmlmaWVyIG1fc3NsVmVyaWZpZXI7Ci0gICAg Q3VybFJlc3BvbnNlIG1fcmVzcG9uc2U7CiAKKyAgICBDdXJsUmVzcG9uc2UgbV9yZXNwb25zZTsK KyAgICBib29sIG1fZGlkUmVjZWl2ZVJlc3BvbnNlIHsgZmFsc2UgfTsKICAgICBib29sIG1fZGlk Tm90aWZ5UmVzcG9uc2UgeyBmYWxzZSB9OwogICAgIGJvb2wgbV9kaWRSZXR1cm5Gcm9tTm90aWZ5 IHsgZmFsc2UgfTsKICAgICBBY3Rpb24gbV9hY3Rpb25BZnRlckludm9rZSB7IEFjdGlvbjo6Tm9u ZSB9Owo=