178651 2017-10-22 19:43:59 -0700 Call FrameView::scheduleSelectionUpdate when selection needs repainting after layout instead of setting the RenderView dirty. 2017-10-23 10:14:16 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham commit-queue darin dbates koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1363196 0 zalan 2017-10-22 19:43:59 -0700 In https://trac.webkit.org/r167845 (bug 132172), the renderView->setNeedsLayout() call was introduced to trigger selection update. However this is problematic in a couple of different ways. 1. marking the root renderer dirty does not trigger layout (this is very specific to the root, other renderers do trigger layout) -so this works as long as someone else schedules a layout. 2. when a subtree layout is already scheduled and we mark the root renderer dirty, the root gets stuck with the dirty flag (since the entry point for the subsequent layout is a descendant of the root and not the root itself). -this got revealed with bug 178621. 1363198 1 webkit-bug-importer 2017-10-22 19:51:05 -0700 <rdar://problem/35117448> 1363203 2 324539 zalan 2017-10-22 20:16:43 -0700 Created attachment 324539 Patch 1363291 3 324539 commit-queue 2017-10-23 08:57:55 -0700 Comment on attachment 324539 Patch Clearing flags on attachment: 324539 Committed r223835: <https://trac.webkit.org/changeset/223835> 1363292 4 commit-queue 2017-10-23 08:57:56 -0700 All reviewed patches have been landed. Closing bug. 1363310 5 324539 simon.fraser 2017-10-23 10:13:10 -0700 Comment on attachment 324539 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=324539&action=review > Source/WebCore/page/FrameView.cpp:3192 > + // However we can't tell at this point if the tree is stable yet, so let's just schedule a root only layout for now. "root only" sounds weird. 1363311 6 simon.fraser 2017-10-23 10:14:16 -0700 You didn't undo the TestExpectation changes in https://bugs.webkit.org/attachment.cgi?id=324541 ? 324539 2017-10-22 20:16:43 -0700 2017-10-23 08:57:55 -0700 Patch bug-178651-20171022201642.patch text/plain 3786 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjIzODIxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2JmMTY0MDVkMjE3Zjkw NTc5ZDVlYzg5NTFiMTlhNDJmODNhNDhkMC4uYThhMDRjMWMyMjJmMDJlZjk2YjViOWRmZDhjYWJi MGZmYWE1YjQ5MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI3IEBACisyMDE3LTEwLTIyICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgQ2FsbCBGcmFtZVZpZXc6OnNj aGVkdWxlU2VsZWN0aW9uVXBkYXRlIHdoZW4gc2VsZWN0aW9uIG5lZWRzIHJlcGFpbnRpbmcgYWZ0 ZXIgbGF5b3V0IGluc3RlYWQgb2Ygc2V0dGluZyB0aGUgUmVuZGVyVmlldyBkaXJ0eS4KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3ODY1MQorICAgICAg ICA8cmRhcjovL3Byb2JsZW0vMzUxMTc0NDg+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgQ2FsbGluZyBzZXROZWVkc0xheW91dCgpIG9uIHRoZSBSZW5k ZXJWaWV3IHRvIHRyaWdnZXIgc2VsZWN0aW9uIHVwZGF0ZSBpcyBwcm9ibGVtYXRpYyBpbiAyIGRp ZmZlcmVudCB3YXlzOgorICAgICAgICAxLiBtYXJraW5nIHRoZSByb290IHJlbmRlcmVyIGRpcnR5 IGRvZXMgbm90IHRyaWdnZXIgbGF5b3V0ICh0aGlzIGlzIHZlcnkgc3BlY2lmaWMgdG8gdGhlIHJv b3QsCisgICAgICAgIG90aGVyIHJlbmRlcmVycyBkbyB0cmlnZ2VyIGxheW91dCkuIEl0IG1lYW5z IHRoYXQgaXQgd29ya3MgYXMgbG9uZyBhcyBzb21lb25lIGVsc2Ugc2NoZWR1bGVzIGEgbGF5b3V0 LgorICAgICAgICAyLiB3aGVuIGEgc3VidHJlZSBsYXlvdXQgaXMgYWxyZWFkeSBzY2hlZHVsZWQg YW5kIHdlIG1hcmsgdGhlIHJvb3QgcmVuZGVyZXIgZGlydHksIHRoZSByb290IGdldHMgc3R1Y2sg d2l0aAorICAgICAgICB0aGUgZGlydHkgZmxhZyAoc2luY2UgdGhlIGVudHJ5IHBvaW50IGZvciB0 aGUgc3Vic2VxdWVudCBsYXlvdXQgaXMgYSBkZXNjZW5kYW50IG9mIHRoZSByb290IGFuZCBub3Qg dGhlIHJvb3QgaXRzZWxmKS4KKworICAgICAgICBUaGlzIHBhdGNoIGFkZHJlc3NlcyB0aGVzZSBp c3N1ZXMgYnkgc2NoZWR1bGluZy9jb252ZXJ0aW5nIHN1YnRyZWUgbGF5b3V0IHdoZW4gbmVlZGVk LiAgCisKKyAgICAgICAgQ292ZXJlZCBieSBmYXN0L2R5bmFtaWMvcmVtb3ZlLWludmlzaWJsZS1u b2RlLWluc2lkZS1zZWxlY3Rpb24uaHRtbC9yZW1vdmUtbm9kZS1pbnNpZGUtc2VsZWN0aW9uLmh0 bWwKKworICAgICAgICAqIGVkaXRpbmcvRnJhbWVTZWxlY3Rpb24uY3BwOgorICAgICAgICAoV2Vi Q29yZTo6RnJhbWVTZWxlY3Rpb246OnJlc3BvbmRUb05vZGVNb2RpZmljYXRpb24pOgorICAgICAg ICAqIHBhZ2UvRnJhbWVWaWV3LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZyYW1lVmlldzo6c2No ZWR1bGVTZWxlY3Rpb25VcGRhdGUpOgorICAgICAgICAqIHBhZ2UvRnJhbWVWaWV3Lmg6CisKIDIw MTctMTAtMjEgIFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBbRnJh bWVWaWV3OjpsYXlvdXQgY2xlYW51cF0gRHJvcCBhbGxvd1N1YnRyZWUgcGFyYW1ldGVyCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0ZyYW1lU2VsZWN0aW9uLmNwcCBiL1NvdXJj ZS9XZWJDb3JlL2VkaXRpbmcvRnJhbWVTZWxlY3Rpb24uY3BwCmluZGV4IGMwMzYzZGM0YTZmMTVh MGU3N2VkZjEzYTZmYTA1NmYxNTVkNjg3NzEuLjQ0YTFlODg0MzEwMjlhN2IxNDJmMzFkOTg0OTFh YTk5ZWNhYTY1NWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvRnJhbWVTZWxl Y3Rpb24uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvRnJhbWVTZWxlY3Rpb24uY3Bw CkBAIC01MTAsNyArNTEwLDcgQEAgdm9pZCBGcmFtZVNlbGVjdGlvbjo6cmVzcG9uZFRvTm9kZU1v ZGlmaWNhdGlvbihOb2RlJiBub2RlLCBib29sIGJhc2VSZW1vdmVkLCBib28KIAogICAgICAgICAg ICAgLy8gVHJpZ2dlciBhIHNlbGVjdGlvbiB1cGRhdGUgc28gdGhlIHNlbGVjdGlvbiB3aWxsIGJl IHNldCBhZ2Fpbi4KICAgICAgICAgICAgIG1fcGVuZGluZ1NlbGVjdGlvblVwZGF0ZSA9IHRydWU7 Ci0gICAgICAgICAgICByZW5kZXJWaWV3LT5zZXROZWVkc0xheW91dCgpOworICAgICAgICAgICAg cmVuZGVyVmlldy0+ZnJhbWVWaWV3KCkuc2NoZWR1bGVTZWxlY3Rpb25VcGRhdGUoKTsKICAgICAg ICAgfQogICAgIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcu Y3BwIGIvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuY3BwCmluZGV4IDUyYmUwYzJmMmVk ZDk1OTU5NTRjZDU0OTdmNGJhN2I1ZGIzMmRlZmIuLmIwM2I5ZTQ5OTQxNmIzMTA3OTBkYjI5ZGI3 NmZkNDAyNzg3NjExYmMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3 LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5jcHAKQEAgLTMxODQsNiAr MzE4NCwxNiBAQCB2b2lkIEZyYW1lVmlldzo6dW5zY2hlZHVsZVJlbGF5b3V0KCkKICAgICBtX2Rl bGF5ZWRMYXlvdXQgPSBmYWxzZTsKIH0KIAordm9pZCBGcmFtZVZpZXc6OnNjaGVkdWxlU2VsZWN0 aW9uVXBkYXRlKCkKK3sKKyAgICBpZiAobmVlZHNMYXlvdXQoKSkKKyAgICAgICAgcmV0dXJuOwor ICAgIC8vIEZJWE1FOiBXZSBzaG91bGQgbm90IG5lZWQgdG8gZ28gdGhyb3VnaCB0aGUgbGF5b3V0 IHByb2Nlc3Mgc2luY2Ugc2VsZWN0aW9uIHVwZGF0ZSBkb2VzIG5vdCBjaGFuZ2UgZGltZW5zaW9u L2dlb21ldHJ5LgorICAgIC8vIEhvd2V2ZXIgd2UgY2FuJ3QgdGVsbCBhdCB0aGlzIHBvaW50IGlm IHRoZSB0cmVlIGlzIHN0YWJsZSB5ZXQsIHNvIGxldCdzIGp1c3Qgc2NoZWR1bGUgYSByb290IG9u bHkgbGF5b3V0IGZvciBub3cuCisgICAgc2V0TmVlZHNMYXlvdXQoKTsKKyAgICBzY2hlZHVsZVJl bGF5b3V0KCk7Cit9CisKIHZvaWQgRnJhbWVWaWV3OjpzZXJ2aWNlU2NyaXB0ZWRBbmltYXRpb25z KCkKIHsKICAgICBmb3IgKGF1dG8qIGZyYW1lID0gbV9mcmFtZS5wdHIoKTsgZnJhbWU7IGZyYW1l ID0gZnJhbWUtPnRyZWUoKS50cmF2ZXJzZU5leHQoKSkgewpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvcGFnZS9GcmFtZVZpZXcuaCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmgK aW5kZXggYzExZDlmYjFkMjRmMzZlMjRjMjYwZjMwZjc2NWNiOTU2M2Q0Y2NhMC4uY2VmYTNjOWVh OGYzZWIzZGFhZGQ3ZjBhMzU3NWJjOTIzMzAxYzM1ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvcGFnZS9GcmFtZVZpZXcuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5o CkBAIC0xMjgsNiArMTI4LDggQEAgcHVibGljOgogCiAgICAgV0VCQ09SRV9FWFBPUlQgYm9vbCBy ZW5kZXJlZENoYXJhY3RlcnNFeGNlZWQodW5zaWduZWQgdGhyZXNob2xkKTsKIAorICAgIHZvaWQg c2NoZWR1bGVTZWxlY3Rpb25VcGRhdGUoKTsKKwogI2lmIFBMQVRGT1JNKElPUykKICAgICBib29s IHVzZUN1c3RvbUZpeGVkUG9zaXRpb25MYXlvdXRSZWN0KCkgY29uc3Q7CiAgICAgSW50UmVjdCBj dXN0b21GaXhlZFBvc2l0aW9uTGF5b3V0UmVjdCgpIGNvbnN0IHsgcmV0dXJuIG1fY3VzdG9tRml4 ZWRQb3NpdGlvbkxheW91dFJlY3Q7IH0K