17865 2008-03-15 12:22:48 -0700 [Gtk] Improve detection jpeglib 2008-07-26 23:01:39 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC All RESOLVED FIXED Gtk P2 Normal --- 1 jmalonzo webkit-unassigned alp mrowe uws+webkit oldest_to_newest 73831 0 jmalonzo 2008-03-15 12:22:48 -0700 The (attached) patch will throw an error if jpeglib and glib tools (glib-genmarshal and glib-mkenums) are not available. 73832 1 19782 jmalonzo 2008-03-15 12:23:28 -0700 Created attachment 19782 improve detection of jpeglib and glib tools 77219 2 mrowe 2008-04-10 17:41:26 -0700 *** Bug 18396 has been marked as a duplicate of this bug. *** 77961 3 19782 alp 2008-04-17 12:22:26 -0700 Comment on attachment 19782 improve detection of jpeglib and glib tools r=me, will clear up the grammar a bit before landing. 77962 4 alp 2008-04-17 12:24:00 -0700 Landed in r32008. 78013 5 alp 2008-04-17 16:01:57 -0700 This worked on my system but failed on the build bot, so backing out the jpeg check. checking pthread.h usability... yes checking pthread.h presence... yes checking for pthread.h... yes checking jpeglib.h usability... no checking jpeglib.h presence... no checking for jpeglib.h... no configure: error: libjpeg is required to build WebKit 78045 6 jmalonzo 2008-04-17 19:50:34 -0700 Hi Alp Is jpeglib installed in a non-standard location? 78283 7 19782 mrowe 2008-04-19 19:48:33 -0700 Comment on attachment 19782 improve detection of jpeglib and glib tools Clearing review flag as this was rolled out. 85940 8 uws+webkit 2008-07-15 05:45:03 -0700 Perhaps something like AC_CHECK_LIB(jpeg, jpeg_destroy_decompress, ...) makes more sense? That's what GTK+ checks for by default as well, afaics. 86989 9 22493 jmalonzo 2008-07-25 20:10:45 -0700 Created attachment 22493 updated: copy the way gtk detects jpeglib 87025 10 22493 mrowe 2008-07-26 21:46:02 -0700 Comment on attachment 22493 updated: copy the way gtk detects jpeglib r=me 87051 11 jmalonzo 2008-07-26 23:01:39 -0700 landed in r35398 19782 2008-03-15 12:23:28 -0700 2008-07-25 20:10:45 -0700 improve detection of jpeglib and glib tools webkit-autoconf-improved-dep-checking.patch text/plain 1310 jmalonzo ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCA5MjMwOTFhLi4yNzk1N2Y2 IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAK KzIwMDgtMDMtMTUgIEphbiBNaWNoYWVsIEFsb256byAgPGptYWxvbnpvQHVucGx1Z2dhYmxlLmNv bT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbXBy b3ZlIGRldGVjdGlvbmcganBlZ2xpYiBhbmQgZ2xpYiB0b29scworCisgICAgICAgICogY29uZmln dXJlLmFjOiBUaHJvdyBhbiBlcnJvciBpZiB0aGUgZGVwZW5kZW5jaWVzIGFib3ZlIGFyZQorICAg ICAgICBjdXJyZW50bHkgbm90IGluc3RhbGxlZAorCiAyMDA4LTAzLTEyICBYYW4gTG9wZXogIDx4 YW5AZ25vbWUub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFscCBUb2tlci4KZGlmZiAtLWdp dCBhL2NvbmZpZ3VyZS5hYyBiL2NvbmZpZ3VyZS5hYwppbmRleCA2NGYzMmRjLi40OWEwNjY1IDEw MDY0NAotLS0gYS9jb25maWd1cmUuYWMKKysrIGIvY29uZmlndXJlLmFjCkBAIC05Nyw2ICs5Nyw5 IEBAIGZpCiAjIENoZWNrIGZvciBnbGliLWdlbm1hcnNoYWwgYW5kIGdsaWItbWtlbnVtcwogQUNf UEFUSF9QUk9HKFtHTElCX0dFTk1BUlNIQUxdLCBbZ2xpYi1nZW5tYXJzaGFsXSkKIEFDX1BBVEhf UFJPRyhbR0xJQl9NS0VOVU1TXSxbZ2xpYi1ta2VudW1zXSkKK2lmIHRlc3QgLXogIiRHTElCX0dF Tk1BUlNIQUwiIHx8IHRlc3QgLXogIiRHTElCX01LRU5VTVMiOyB0aGVuCisgICBBQ19NU0dfRVJS T1IoW1lvdSBuZWVkIHRoZSBkZXYgcGFja2FnZSBvZiBHTGliIHRvIGNvbXBpbGUgV2ViS2l0XSkK K2ZpCiAKICMgQ2hlY2sgd2hldGhlciBhIEMrKyB3YXMgZm91bmQgKEFDX1BST0dfQ1hYIHNldHMg JENYWCB0byAiZysrIiBldmVuIHdoZW4gaXQKICMgZG9lc24ndCBleGlzdCkKQEAgLTEyMSw3ICsx MjQsOSBAQCBBQ19DSEVDS19IRUFERVJTKFtwdGhyZWFkLmhdLAogZmkKIAogIyBsaWJqcGVnIGhl YWRlcnMKLUFDX0NIRUNLX0hFQURFUlMoW2pwZWdsaWIuaF0pCitBQ19DSEVDS19IRUFERVJTKFtq cGVnbGliLmhdLAorICAgICAgICAgICAgICAgICBBQ19ERUZJTkUoW0hBVkVfSlBFR0xJQl9IXSxb MV0sW0RlZmluZSBpZiBsaWJqcGVnIGV4aXN0XSksCisgICAgICAgICAgICAgICAgIEFDX01TR19F UlJPUihbbGlianBlZyBpcyByZXF1aXJlZCB0byBidWlsZCBXZWJLaXRdKSkKIAogIyBjaGVjayBm b3IgcGtnLWNvbmZpZwogQUNfUEFUSF9QUk9HKFBLR19DT05GSUcsIHBrZy1jb25maWcsIG5vKQo= 22493 2008-07-25 20:10:45 -0700 2008-07-26 21:46:02 -0700 updated: copy the way gtk detects jpeglib webkitgtk-jpeglib-autoconf.patch text/plain 1892 jmalonzo ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCBhOWY1OTc0Li41OGM0Mjhl IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAK KzIwMDgtMDctMjUgIEphbiBNaWNoYWVsIEFsb256byAgPGptYWxvbnpvQHdlYmtpdC5vcmc+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ29weSB0aGUg d2F5IEd0ayBkZXRlY3RzIGpwZWdsaWIuIEhpbnRlZCBieSBXb3V0ZXIgQm9sc3RlcmxlZS4KKwor ICAgICAgICBbR3RrXSBJbXByb3ZlIGRldGVjdGlvbiBqcGVnbGliCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzg2NQorCisgICAgICAgICogR05VbWFr ZWZpbGUuYW06CisgICAgICAgICogY29uZmlndXJlLmFjOgorCiAyMDA4LTA3LTI1ICBTaW1vbiBI YXVzbWFubiAgPGhhdXNtYW5uQHdlYmtpdC5vcmc+CiAKICAgICAgICAgRGlzY3Vzc2VkIHdpdGgg YW5kIHJ1YmJlci1zdGFtcGVkIGJ5IExhcnMuCmRpZmYgLS1naXQgYS9HTlVtYWtlZmlsZS5hbSBi L0dOVW1ha2VmaWxlLmFtCmluZGV4IGE2YWUyOTkuLmM1ZWRjYzAgMTAwNjQ0Ci0tLSBhL0dOVW1h a2VmaWxlLmFtCisrKyBiL0dOVW1ha2VmaWxlLmFtCkBAIC0yMTYsOCArMjE2LDggQEAgbGliV2Vi Q29yZV9sYV9MSUJBREQgPSBcCiAJJChHU1RSRUFNRVJfTElCUykgXAogCSQoTElCWFNMVF9MSUJT KSBcCiAJJChISUxET05fTElCUykgXAotCS1scHRocmVhZCBcCi0JLWxqcGVnCisJJChKUEVHX0xJ QlMpIFwKKwktbHB0aHJlYWQKIAogIyBXZWJLaXQKIHdlYmtpdGd0a19oX2FwaSA6PQpkaWZmIC0t Z2l0IGEvY29uZmlndXJlLmFjIGIvY29uZmlndXJlLmFjCmluZGV4IGQwYWE3YzguLjc2OGFlOWYg MTAwNjQ0Ci0tLSBhL2NvbmZpZ3VyZS5hYworKysgYi9jb25maWd1cmUuYWMKQEAgLTEzNyw4ICsx MzcsMjkgQEAgQUNfQ0hFQ0tfSEVBREVSUyhbcHRocmVhZC5oXSwKICAgICAgICAgICAgICAgICAg QUNfTVNHX0VSUk9SKFtwdGhyZWFkIHN1cHBvcnQgaXMgcmVxdWlyZWQgdG8gYnVpbGQgV2ViS2l0 XSkpCiBmaQogCi0jIGxpYmpwZWcgaGVhZGVycwotQUNfQ0hFQ0tfSEVBREVSUyhbanBlZ2xpYi5o XSkKKyMgY2hlY2sgZm9yIGxpYmpwZWcgdGhlIHdheSBHdGsgZG9lcyBpdC4KK0FDX0NIRUNLX0xJ QihqcGVnLCBqcGVnX2Rlc3Ryb3lfZGVjb21wcmVzcywKKyAgICAgICAgICAgICAgICAgICBqcGVn X29rPXllcywganBlZ19vaz1ubworICAgICAgICAgICAgICAgICAgIEFDX01TR19FUlJPUihbSlBF RyBsaWJyYXJ5IChsaWJqcGVnKSBub3QgZm91bmRdKSkKK2lmIHRlc3QgIiRqcGVnX29rIiA9IHll czsgdGhlbgorICAgQUNfTVNHX0NIRUNLSU5HKFtmb3IganBlZ2xpYl0pCisgICBBQ19UUllfQ1BQ KAorWyNpbmNsdWRlIDxzdGRpby5oPgorI3VuZGVmIFBBQ0tBR0UKKyN1bmRlZiBWRVJTSU9OCisj dW5kZWYgSEFWRV9TVERMSUJfSAorI2luY2x1ZGUgPGpwZWdsaWIuaD5dLAorICAgICAgICAganBl Z19vaz15ZXMsCisgICAgICAgICBqcGVnX29rPW5vKQorICAgQUNfTVNHX1JFU1VMVCgkanBlZ19v aykKKyAgIGlmIHRlc3QgIiRqcGVnX29rIiA9IHllczsgdGhlbgorICAgICAgSlBFR19MSUJTPSIt bGpwZWciCisgICAgICAjIHNob3VsZCB3ZSBjaGVjayBmb3IgcHJvZ3Jlc3NpdmUgSlBFRyBsaWtl IEdUSysgYXMgd2VsbD8KKyAgIGVsc2UKKyAgICAgIEFDX01TR19FUlJPUihbSlBFRyBsaWJyYXJ5 IChsaWJqcGVnKSBub3QgZm91bmRdKQorICAgZmkKK2ZpCitBQ19TVUJTVChbSlBFR19MSUJTXSkK IAogIyBjaGVjayBmb3IgcGtnLWNvbmZpZwogQUNfUEFUSF9QUk9HKFBLR19DT05GSUcsIHBrZy1j b25maWcsIG5vKQo=