178648 2017-10-22 14:11:30 -0700 [JSC] Drop ArityCheckData 2017-11-15 12:57:38 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ysuzuki ysuzuki buildbot darin fpizlo ggaren keith_miller mark.lam msaboff saam sam webkit-bug-importer oldest_to_newest 1363167 0 ysuzuki 2017-10-22 14:11:30 -0700 [JSC] Drop ArityCheckData 1363169 1 324532 ysuzuki 2017-10-22 14:14:36 -0700 Created attachment 324532 Patch 1363697 2 324532 mark.lam 2017-10-24 09:28:02 -0700 Comment on attachment 324532 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=324532&action=review r=me > Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm:582 > + move r1, t1 nit: would be nice to add a comment # r1 contains slotsToAdd. > Source/JavaScriptCore/llint/LowLevelInterpreter64.asm:517 > + move r1, t1 ditto for adding a comment about r1. 1363701 3 324532 ysuzuki 2017-10-24 09:35:55 -0700 Comment on attachment 324532 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=324532&action=review Thank you for your review >> Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm:582 >> + move r1, t1 > > nit: would be nice to add a comment # r1 contains slotsToAdd. Sounds nice, fixed. >> Source/JavaScriptCore/llint/LowLevelInterpreter64.asm:517 >> + move r1, t1 > > ditto for adding a comment about r1. Ditto. 1363703 4 ysuzuki 2017-10-24 09:36:46 -0700 Committed r223891: <https://trac.webkit.org/changeset/223891> 1372280 5 webkit-bug-importer 2017-11-15 12:57:38 -0800 <rdar://problem/35568480> 324532 2017-10-22 14:14:36 -0700 2017-10-24 09:28:02 -0700 Patch bug-178648-20171023061435.patch text/plain 6794 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjIzODI0CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA4 MzU5YzY0YjA4ODYyZGJlNjVlNjhlZjg5MzlkMTQ3ZjMwYzhhMGQ0Li4yZjRjNDVhZTliMjk5Njll NmUxNDU3NDdmMGIyMGEwNmNiYzk4YjFhIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs NSArMSwyOCBAQAogMjAxNy0xMC0yMiAgWXVzdWtlIFN1enVraSAgPHV0YXRhbmUudGVhQGdtYWls LmNvbT4KIAorICAgICAgICBbSlNDXSBEcm9wIEFyaXR5Q2hlY2tEYXRhCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzg2NDgKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBcml0eUNoZWNrRGF0YSBpcyB1c2Vk IHRvIHJldHVybiBhIHBhaXIgb2YgYHNsb3RzVG9BZGRgIGFuZCBgdGh1bmtUb0NhbGxgLgorICAg ICAgICBIb3dldmVyLCB1c2Ugb2YgYHRodW5rVG9DYWxsYCBpcyByZW1vdmVkIGluIDY0Yml0IGVu dmlyb25tZW50IGF0IHIxODk1NzUuCisKKyAgICAgICAgV2UgcmVtb3ZlIGB0aHVua1RvQ2FsbGAg YW5kIGFsaWduIDMyYml0IGltcGxlbWVudGF0aW9uIHRvIDY0Yml0IGltcGxlbWVudGF0aW9uLgor ICAgICAgICBTaW5jZSB3ZSBubyBsb25nZXIgbmVlZCB0byBoYXZlIHRoZSBhYm92ZSBwYWlyLCB3 ZSBjYW4gcmVtb3ZlIEFyaXR5Q2hlY2tEYXRhIHRvby4KKworICAgICAgICAqIGxsaW50L0xvd0xl dmVsSW50ZXJwcmV0ZXIzMl82NC5hc206CisgICAgICAgICogbGxpbnQvTG93TGV2ZWxJbnRlcnBy ZXRlcjY0LmFzbToKKyAgICAgICAgKiBydW50aW1lL0NvbW1vblNsb3dQYXRocy5jcHA6CisgICAg ICAgIChKU0M6OlNMT1dfUEFUSF9ERUNMKToKKyAgICAgICAgKEpTQzo6c2V0dXBBcml0eUNoZWNr RGF0YSk6IERlbGV0ZWQuCisgICAgICAgICogcnVudGltZS9Db21tb25TbG93UGF0aHMuaDoKKyAg ICAgICAgKiBydW50aW1lL1ZNLmNwcDoKKyAgICAgICAgKEpTQzo6Vk06OlZNKToKKyAgICAgICAg KiBydW50aW1lL1ZNLmg6CisKKzIwMTctMTAtMjIgIFl1c3VrZSBTdXp1a2kgIDx1dGF0YW5lLnRl YUBnbWFpbC5jb20+CisKICAgICAgICAgW0pTQ11bQmFzZWxpbmVdIFVzZSBsaW5rQWxsU2xvd0Nh c2VzRm9yQnl0ZWNvZGVPZmZzZXQgYXMgbXVjaCBhcyBwb3NzaWJsZSB0byBzaW1wbGlmeSBzbG93 IGNhc2VzIGhhbmRsaW5nCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xNzg2NDcKIApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50 L0xvd0xldmVsSW50ZXJwcmV0ZXIzMl82NC5hc20gYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvbGxp bnQvTG93TGV2ZWxJbnRlcnByZXRlcjMyXzY0LmFzbQppbmRleCAwZTcxMmI2NzlkNmFiMTIwM2Ji NmM2Y2M1NjJhYjAyYTY3OTE2ZWM5Li4yZWFmZDA0YTZmZjA1OWUzNTM4Yzk4YmNhMWNhNTMzOWNh YjJmNDIzIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvbGxpbnQvTG93TGV2ZWxJ bnRlcnByZXRlcjMyXzY0LmFzbQorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvbGxpbnQvTG93 TGV2ZWxJbnRlcnByZXRlcjMyXzY0LmFzbQpAQCAtNTc5LDIwICs1NzksNyBAQCBtYWNybyBmdW5j dGlvbkFyaXR5Q2hlY2soZG9uZUxhYmVsLCBzbG93UGF0aCkKICAgICBqbXAgX2xsaW50X3Rocm93 X2Zyb21fc2xvd19wYXRoX3RyYW1wb2xpbmUKIAogLm5vRXJyb3I6Ci0gICAgIyByMSBwb2ludHMg dG8gQXJpdHlDaGVja0RhdGEuCi0gICAgbG9hZHAgQ29tbW9uU2xvd1BhdGhzOjpBcml0eUNoZWNr RGF0YTo6dGh1bmtUb0NhbGxbcjFdLCB0MwotICAgIGJ0cHogdDMsIC5wcm9jZWVkSW5saW5lCi0g ICAgCi0gICAgbG9hZHAgQ29tbW9uU2xvd1BhdGhzOjpBcml0eUNoZWNrRGF0YTo6cGFkZGVkU3Rh Y2tTcGFjZVtyMV0sIGEwCi0gICAgY2FsbCB0MwotICAgIGlmIEFTU0VSVF9FTkFCTEVECi0gICAg ICAgIGxvYWRwIFJldHVyblBDW2Nmcl0sIHQwCi0gICAgICAgIGxvYWRwIFt0MF0sIHQwCi0gICAg ZW5kCi0gICAgam1wIC5jb250aW51ZQotCi0ucHJvY2VlZElubGluZToKLSAgICBsb2FkaSBDb21t b25TbG93UGF0aHM6OkFyaXR5Q2hlY2tEYXRhOjpwYWRkZWRTdGFja1NwYWNlW3IxXSwgdDEKKyAg ICBtb3ZlIHIxLCB0MQogICAgIGJ0aXogdDEsIC5jb250aW51ZQogICAgIGxvYWRpIFBheWxvYWRP ZmZzZXQgKyBBcmd1bWVudENvdW50W2Nmcl0sIHQyCiAgICAgYWRkaSBDYWxsRnJhbWVIZWFkZXJT bG90cywgdDIKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9sbGludC9Mb3dMZXZl bEludGVycHJldGVyNjQuYXNtIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50L0xvd0xldmVs SW50ZXJwcmV0ZXI2NC5hc20KaW5kZXggOTc3MTQwOTNlODM2ZDc5YmM2OGJlYzkyMmQ4MTdhMGVm OGFlN2ExNC4uNTczYjk5N2NmYzQwZWZkMDQ5NmZjOGQ5MzJmZmI3ZDJlNzIyMDUxZCAxMDA2NDQK LS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXI2NC5h c20KKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXI2 NC5hc20KQEAgLTUxNCw3ICs1MTQsNyBAQCBtYWNybyBmdW5jdGlvbkFyaXR5Q2hlY2soZG9uZUxh YmVsLCBzbG93UGF0aCkKICAgICBqbXAgX2xsaW50X3Rocm93X2Zyb21fc2xvd19wYXRoX3RyYW1w b2xpbmUKIAogLm5vRXJyb3I6Ci0gICAgbG9hZGkgQ29tbW9uU2xvd1BhdGhzOjpBcml0eUNoZWNr RGF0YTo6cGFkZGVkU3RhY2tTcGFjZVtyMV0sIHQxCisgICAgbW92ZSByMSwgdDEKICAgICBidGl6 IHQxLCAuY29udGludWUKICAgICBsb2FkaSBQYXlsb2FkT2Zmc2V0ICsgQXJndW1lbnRDb3VudFtj ZnJdLCB0MgogICAgIGFkZGkgQ2FsbEZyYW1lSGVhZGVyU2xvdHMsIHQyCmRpZmYgLS1naXQgYS9T b3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9Db21tb25TbG93UGF0aHMuY3BwIGIvU291cmNl L0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvQ29tbW9uU2xvd1BhdGhzLmNwcAppbmRleCA0ZDU0NDFk ZTlkZDYyNTc3OWI3MzkxMWEzZmEzYWVjYjFlMTlmYjQ2Li5iMTAxODJiYWI4YjkzYjZlZmQ5NTg0 NjZiYTA1ZTI0MzhkNmNmNzZjIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVu dGltZS9Db21tb25TbG93UGF0aHMuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50 aW1lL0NvbW1vblNsb3dQYXRocy5jcHAKQEAgLTE2NywxOSArMTY3LDYgQEAgbmFtZXNwYWNlIEpT QyB7CiAgICAgICAgIENBTExfRU5EX0lNUEwoY3JFeGVjLCBjckNhbGxUYXJnZXQpOyAgICAgICAg ICAgICAgICBcCiAgICAgfSB3aGlsZSAoZmFsc2UpCiAKLXN0YXRpYyBDb21tb25TbG93UGF0aHM6 OkFyaXR5Q2hlY2tEYXRhKiBzZXR1cEFyaXR5Q2hlY2tEYXRhKFZNJiB2bSwgaW50IHNsb3RzVG9B ZGQpCi17Ci0gICAgQ29tbW9uU2xvd1BhdGhzOjpBcml0eUNoZWNrRGF0YSogcmVzdWx0ID0gdm0u YXJpdHlDaGVja0RhdGEuZ2V0KCk7Ci0gICAgcmVzdWx0LT5wYWRkZWRTdGFja1NwYWNlID0gc2xv dHNUb0FkZDsKLSNpZiBFTkFCTEUoSklUKQotICAgIGlmICh2bS5jYW5Vc2VKSVQoKSkKLSAgICAg ICAgcmVzdWx0LT50aHVua1RvQ2FsbCA9IHZtLmdldENUSVN0dWIoYXJpdHlGaXh1cEdlbmVyYXRv cikuY29kZSgpLmV4ZWN1dGFibGVBZGRyZXNzKCk7Ci0gICAgZWxzZQotI2VuZGlmCi0gICAgICAg IHJlc3VsdC0+dGh1bmtUb0NhbGwgPSAwOwotICAgIHJldHVybiByZXN1bHQ7Ci19Ci0KIFNMT1df UEFUSF9ERUNMKHNsb3dfcGF0aF9jYWxsX2FyaXR5Q2hlY2spCiB7CiAgICAgQkVHSU4oKTsKQEAg LTE5Miw3ICsxNzksNyBAQCBTTE9XX1BBVEhfREVDTChzbG93X3BhdGhfY2FsbF9hcml0eUNoZWNr KQogICAgICAgICBDb21tb25TbG93UGF0aHM6OmludGVycHJldGVyVGhyb3dJbkNhbGxlcihleGVj LCBjcmVhdGVTdGFja092ZXJmbG93RXJyb3IoZXhlYykpOwogICAgICAgICBSRVRVUk5fVFdPKGJp dHdpc2VfY2FzdDx2b2lkKj4oc3RhdGljX2Nhc3Q8dWludHB0cl90PigxKSksIGV4ZWMpOwogICAg IH0KLSAgICBSRVRVUk5fVFdPKDAsIHNldHVwQXJpdHlDaGVja0RhdGEodm0sIHNsb3RzVG9BZGQp KTsKKyAgICBSRVRVUk5fVFdPKDAsIGJpdHdpc2VfY2FzdDx2b2lkKj4oc3RhdGljX2Nhc3Q8dWlu dHB0cl90PihzbG90c1RvQWRkKSkpOwogfQogCiBTTE9XX1BBVEhfREVDTChzbG93X3BhdGhfY29u c3RydWN0X2FyaXR5Q2hlY2spCkBAIC0yMDYsNyArMTkzLDcgQEAgU0xPV19QQVRIX0RFQ0woc2xv d19wYXRoX2NvbnN0cnVjdF9hcml0eUNoZWNrKQogICAgICAgICBDb21tb25TbG93UGF0aHM6Omlu dGVycHJldGVyVGhyb3dJbkNhbGxlcihleGVjLCBjcmVhdGVTdGFja092ZXJmbG93RXJyb3IoZXhl YykpOwogICAgICAgICBSRVRVUk5fVFdPKGJpdHdpc2VfY2FzdDx2b2lkKj4oc3RhdGljX2Nhc3Q8 dWludHB0cl90PigxKSksIGV4ZWMpOwogICAgIH0KLSAgICBSRVRVUk5fVFdPKDAsIHNldHVwQXJp dHlDaGVja0RhdGEodm0sIHNsb3RzVG9BZGQpKTsKKyAgICBSRVRVUk5fVFdPKDAsIGJpdHdpc2Vf Y2FzdDx2b2lkKj4oc3RhdGljX2Nhc3Q8dWludHB0cl90PihzbG90c1RvQWRkKSkpOwogfQogCiBT TE9XX1BBVEhfREVDTChzbG93X3BhdGhfY3JlYXRlX2RpcmVjdF9hcmd1bWVudHMpCmRpZmYgLS1n aXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9Db21tb25TbG93UGF0aHMuaCBiL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0NvbW1vblNsb3dQYXRocy5oCmluZGV4IGY0ZDZl YmU3Mzc1ZjdhZTdhYjNjZGUwYTIwYmUzMDI3ZDdlZDgwYjAuLjk4YjYxMjJlMGVhODg4YjgyZGEy N2UwMTY0MTIwZTE2ZjE5MmJmYzcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9y dW50aW1lL0NvbW1vblNsb3dQYXRocy5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50 aW1lL0NvbW1vblNsb3dQYXRocy5oCkBAIC00NSwxMSArNDUsNiBAQCBuYW1lc3BhY2UgSlNDIHsK IAogbmFtZXNwYWNlIENvbW1vblNsb3dQYXRocyB7CiAKLXN0cnVjdCBBcml0eUNoZWNrRGF0YSB7 Ci0gICAgdW5zaWduZWQgcGFkZGVkU3RhY2tTcGFjZTsKLSAgICB2b2lkKiB0aHVua1RvQ2FsbDsK LX07Ci0KIEFMV0FZU19JTkxJTkUgaW50IG51bWJlck9mRXh0cmFTbG90cyhpbnQgYXJndW1lbnRD b3VudEluY2x1ZGluZ1RoaXMpCiB7CiAgICAgaW50IGZyYW1lU2l6ZSA9IGFyZ3VtZW50Q291bnRJ bmNsdWRpbmdUaGlzICsgQ2FsbEZyYW1lOjpoZWFkZXJTaXplSW5SZWdpc3RlcnM7CmRpZmYgLS1n aXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9WTS5jcHAgYi9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvcnVudGltZS9WTS5jcHAKaW5kZXggZGNkNGU5NDVhYTk1YWFmZGY1MWEzZDBlZGUw YmY4MTNmNDU1NjA4Zi4uNzA1ODFlNjkwOTg5NDhmZTRhNDIzNzVlYzNhZjRhMTRhNDZmOGQ4ZSAx MDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvVk0uY3BwCisrKyBiL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1ZNLmNwcApAQCAtMjkyLDcgKzI5Miw2IEBAIFZN OjpWTShWTVR5cGUgdm1UeXBlLCBIZWFwVHlwZSBoZWFwVHlwZSkKICNpZiBFTkFCTEUoSklUKQog ICAgIGppdFN0dWJzID0gc3RkOjptYWtlX3VuaXF1ZTxKSVRUaHVua3M+KCk7CiAjZW5kaWYKLSAg ICBhcml0eUNoZWNrRGF0YSA9IHN0ZDo6bWFrZV91bmlxdWU8Q29tbW9uU2xvd1BhdGhzOjpBcml0 eUNoZWNrRGF0YT4oKTsKIAogI2lmIEVOQUJMRShGVExfSklUKQogICAgIGZ0bFRodW5rcyA9IHN0 ZDo6bWFrZV91bmlxdWU8RlRMOjpUaHVua3M+KCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvcnVudGltZS9WTS5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvVk0u aAppbmRleCAyZjc5OTY4ODAxMzcxMTkwNzkwYjQ4OTkxYWYzMDM4ODA1ZTI0ZDI5Li42NGYyZTAy YzEzODYxNGRhM2RlZWQ1NWY1YzNjOWFlYWVmZjU1MGJjIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvcnVudGltZS9WTS5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50 aW1lL1ZNLmgKQEAgLTE0Nyw5ICsxNDcsNiBAQCBuYW1lc3BhY2UgRlRMIHsKIGNsYXNzIFRodW5r czsKIH0KICNlbmRpZiAvLyBFTkFCTEUoRlRMX0pJVCkKLW5hbWVzcGFjZSBDb21tb25TbG93UGF0 aHMgewotc3RydWN0IEFyaXR5Q2hlY2tEYXRhOwotfQogbmFtZXNwYWNlIFByb2ZpbGVyIHsKIGNs YXNzIERhdGFiYXNlOwogfQpAQCAtNDgyLDcgKzQ3OSw2IEBAIGNsYXNzIFZNIDogcHVibGljIFRo cmVhZFNhZmVSZWZDb3VudGVkPFZNPiwgcHVibGljIERvdWJseUxpbmtlZExpc3ROb2RlPFZNPiB7 CiAgICAgc3RhdGljIFJlZ2lzdGVyQXRPZmZzZXRMaXN0KiBnZXRBbGxDYWxsZWVTYXZlUmVnaXN0 ZXJPZmZzZXRzKCk7CiAKICNlbmRpZiAvLyBFTkFCTEUoSklUKQotICAgIHN0ZDo6dW5pcXVlX3B0 cjxDb21tb25TbG93UGF0aHM6OkFyaXR5Q2hlY2tEYXRhPiBhcml0eUNoZWNrRGF0YTsKICNpZiBF TkFCTEUoRlRMX0pJVCkKICAgICBzdGQ6OnVuaXF1ZV9wdHI8RlRMOjpUaHVua3M+IGZ0bFRodW5r czsKICNlbmRpZgo=