178637 2017-10-21 16:12:43 -0700 [Settings] It should be easier to add settings to WebCore/WebKit 2024-11-20 18:47:32 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 178634 178656 178823 178945 1 sam sam oldest_to_newest 1363089 0 sam 2017-10-21 16:12:43 -0700 It should be easier to add settings to WebCore and WebKit. Currently, there is quite a bit of plumbing you have to do, to surface a setting as an API preference, and it's easy to get wrong. 1363091 1 sam 2017-10-21 16:16:30 -0700 I'm not sure on the exact balance yet, but I leaning toward a system where to expose a setting via WebKit SPI you need to edit two configuration files (API will require something hand written on top of those edits): the Settings configuration file in WebCore, and Preferences configuration file in WebKit. We could conceivably get away with just the one in WebCore, but that feels like too great a layering violation, and would make it too easy to accidentally expose something as SPI that was only meant for testing. 1363092 2 sam 2017-10-21 16:19:04 -0700 With 178634, WebCore will be converted to a YAML based configuration for Settings. I think adding a similar file for WebKit, where you can both declare a WebCore setting that should re-exported via WebKit, and add new WebKit layer only settings. 2076579 3 sam 2024-11-20 18:47:32 -0800 Marking complete. This has been done for some time now.