178623 2017-10-21 10:10:14 -0700 [FrameView::layout cleanup] Drop allowSubtree parameter 2017-10-21 19:05:23 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham commit-queue koivisto sam simon.fraser webkit-bug-importer zalan oldest_to_newest 1363043 0 zalan 2017-10-21 10:10:14 -0700 It is only set by ::forceLayout(). Just convert the subtree layout to full right before calling layout. 1363044 1 webkit-bug-importer 2017-10-21 10:10:48 -0700 <rdar://problem/35111012> 1363045 2 324502 zalan 2017-10-21 10:15:11 -0700 Created attachment 324502 Patch 1363112 3 324502 commit-queue 2017-10-21 19:05:21 -0700 Comment on attachment 324502 Patch Clearing flags on attachment: 324502 Committed r223821: <https://trac.webkit.org/changeset/223821> 1363113 4 commit-queue 2017-10-21 19:05:23 -0700 All reviewed patches have been landed. Closing bug. 324502 2017-10-21 10:15:11 -0700 2017-10-21 19:05:21 -0700 Patch bug-178623-20171021101510.patch text/plain 6429 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjIzODA1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjVlYjVjMzUyY2M5NTJh MmZkY2ZmNTA5MzAzODU4ZGEwYzhhNDcyOC4uMTE1NjRkMGQ3NWNmYWNkODI5NTUwZDViMTFjNGIx NGM3MWNhM2M5MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE3LTEwLTIxICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0ZyYW1lVmlldzo6bGF5b3V0 IGNsZWFudXBdIERyb3AgYWxsb3dTdWJ0cmVlIHBhcmFtZXRlcgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc4NjIzCisgICAgICAgIDxyZGFyOi8vcHJv YmxlbS8zNTExMTAxMj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBUaGlzIGZsYWcgaXMgb25seSBzZXQgdGhyb3VnaCA6OmZvcmNlTGF5b3V0KCkuIExl dCdzIGp1c3QgY29udmVydCB0aGUgc3VidHJlZSBsYXlvdXQKKyAgICAgICAgdG8gZnVsbCBsYXlv dXQgcmlnaHQgYmVmb3JlIGNhbGxpbmcgOjpsYXlvdXQoKS4KKworICAgICAgICBObyBjaGFuZ2Ug aW4gZnVuY3Rpb25hbGl0eS4KKworICAgICAgICAqIHBhZ2UvRnJhbWVWaWV3LmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OkZyYW1lVmlldzo6aGFuZGxlTGF5b3V0V2l0aEZyYW1lRmxhdHRlbmluZ0lm TmVlZGVkKToKKyAgICAgICAgKFdlYkNvcmU6OkZyYW1lVmlldzo6bGF5b3V0KToKKyAgICAgICAg KFdlYkNvcmU6OkZyYW1lVmlldzo6c3RhcnRMYXlvdXRBdE1haW5GcmFtZVZpZXdJZk5lZWRlZCk6 CisgICAgICAgIChXZWJDb3JlOjpGcmFtZVZpZXc6OmZvcmNlTGF5b3V0KToKKyAgICAgICAgKiBw YWdlL0ZyYW1lVmlldy5oOgorCiAyMDE3LTEwLTIwICBaYWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBs ZS5jb20+CiAKICAgICAgICAgW0ZyYW1lVmlldzo6bGF5b3V0IGNsZWFudXBdIFVzZSBTZXRGb3JT Y29wZSB0byBlbnN1cmUgbGF5b3V0IHN0YXRlIGNvcnJlY3RuZXNzCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1l Vmlldy5jcHAKaW5kZXggOTU2MDQ1OGQyMzk0MDQ0MjBhNjM2ZTQzNDZhYjA2NTFkZDkyOTYzOC4u NTJiZTBjMmYyZWRkOTU5NTk1NGNkNTQ5N2Y0YmE3YjVkYjMyZGVmYiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2Uv RnJhbWVWaWV3LmNwcApAQCAtMTMxNCw3ICsxMzE0LDcgQEAgc3RhdGljIHZvaWQgYXBwbHlUZXh0 U2l6aW5nSWZOZWVkZWQoUmVuZGVyRWxlbWVudCYgbGF5b3V0Um9vdCkKIH0KICNlbmRpZgogCi1i b29sIEZyYW1lVmlldzo6aGFuZGxlTGF5b3V0V2l0aEZyYW1lRmxhdHRlbmluZ0lmTmVlZGVkKGJv b2wgYWxsb3dTdWJ0cmVlTGF5b3V0KQorYm9vbCBGcmFtZVZpZXc6OmhhbmRsZUxheW91dFdpdGhG cmFtZUZsYXR0ZW5pbmdJZk5lZWRlZCgpCiB7CiAgICAgaWYgKCFpc0luQ2hpbGRGcmFtZVdpdGhG cmFtZUZsYXR0ZW5pbmcoKSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwpAQCAtMTMyMyw3ICsxMzIz LDcgQEAgYm9vbCBGcmFtZVZpZXc6OmhhbmRsZUxheW91dFdpdGhGcmFtZUZsYXR0ZW5pbmdJZk5l ZWRlZChib29sIGFsbG93U3VidHJlZUxheW91dCkKICAgICAgICAgTE9HX1dJVEhfU1RSRUFNKE1l ZGlhUXVlcmllcywgc3RyZWFtIDw8ICJGcmFtZVZpZXcgIiA8PCB0aGlzIDw8ICIgc25hcHNob3R0 aW5nIHNpemUgIiA8PCAgU2Nyb2xsVmlldzo6bGF5b3V0U2l6ZSgpIDw8ICIgZm9yIG1lZGlhIHF1 ZXJpZXMiKTsKICAgICAgICAgbV9mcmFtZUZsYXR0ZW5pbmdWaWV3U2l6ZUZvck1lZGlhUXVlcnkg PSBTY3JvbGxWaWV3OjpsYXlvdXRTaXplKCk7CiAgICAgfQotICAgIHN0YXJ0TGF5b3V0QXRNYWlu RnJhbWVWaWV3SWZOZWVkZWQoYWxsb3dTdWJ0cmVlTGF5b3V0KTsKKyAgICBzdGFydExheW91dEF0 TWFpbkZyYW1lVmlld0lmTmVlZGVkKCk7CiAgICAgYXV0byogbGF5b3V0Um9vdCA9IG1fc3VidHJl ZUxheW91dFJvb3QgPyBtX3N1YnRyZWVMYXlvdXRSb290IDogZnJhbWUoKS5kb2N1bWVudCgpLT5y ZW5kZXJWaWV3KCk7CiAgICAgcmV0dXJuICFsYXlvdXRSb290IHx8ICFsYXlvdXRSb290LT5uZWVk c0xheW91dCgpOwogfQpAQCAtMTM5OSw3ICsxMzk5LDcgQEAgYm9vbCBGcmFtZVZpZXc6OmNhblBl cmZvcm1MYXlvdXQoKSBjb25zdAogICAgIHJldHVybiB0cnVlOwogfQogCi12b2lkIEZyYW1lVmll dzo6bGF5b3V0KGJvb2wgYWxsb3dTdWJ0cmVlTGF5b3V0KQordm9pZCBGcmFtZVZpZXc6OmxheW91 dCgpCiB7CiAgICAgUkVMRUFTRV9BU1NFUlRfV0lUSF9TRUNVUklUWV9JTVBMSUNBVElPTighZnJh bWUoKS5kb2N1bWVudCgpLT5pblJlbmRlclRyZWVVcGRhdGUoKSk7CiAgICAgQVNTRVJUKCFpc1Bh aW50aW5nKCkpOwpAQCAtMTQyNSwxNCArMTQyNSwxMiBAQCB2b2lkIEZyYW1lVmlldzo6bGF5b3V0 KGJvb2wgYWxsb3dTdWJ0cmVlTGF5b3V0KQogICAgIG1fbGF5b3V0VGltZXIuc3RvcCgpOwogICAg IG1fZGVsYXllZExheW91dCA9IGZhbHNlOwogICAgIG1fc2V0TmVlZHNMYXlvdXRXYXNEZWZlcnJl ZCA9IGZhbHNlOwotICAgIGlmICghYWxsb3dTdWJ0cmVlTGF5b3V0ICYmIG1fc3VidHJlZUxheW91 dFJvb3QpCi0gICAgICAgIGNvbnZlcnRTdWJ0cmVlTGF5b3V0VG9GdWxsTGF5b3V0KCk7CiAjaWYg UExBVEZPUk0oSU9TKQotICAgIGlmICh1cGRhdGVGaXhlZFBvc2l0aW9uTGF5b3V0UmVjdCgpKQot ICAgICAgICBhbGxvd1N1YnRyZWVMYXlvdXQgPSBmYWxzZTsKKyAgICBpZiAodXBkYXRlRml4ZWRQ b3NpdGlvbkxheW91dFJlY3QoKSAmJiBzdWJ0cmVlTGF5b3V0Um9vdCgpKQorICAgICAgICBjb252 ZXJ0U3VidHJlZUxheW91dFRvRnVsbExheW91dCgpOwogI2VuZGlmCiAKLSAgICBpZiAoaGFuZGxl TGF5b3V0V2l0aEZyYW1lRmxhdHRlbmluZ0lmTmVlZGVkKGFsbG93U3VidHJlZUxheW91dCkpCisg ICAgaWYgKGhhbmRsZUxheW91dFdpdGhGcmFtZUZsYXR0ZW5pbmdJZk5lZWRlZCgpKQogICAgICAg ICByZXR1cm47CiAKICAgICBEb2N1bWVudCYgZG9jdW1lbnQgPSAqZnJhbWUoKS5kb2N1bWVudCgp OwpAQCAtMTQ4NCw3ICsxNDgyLDYgQEAgdm9pZCBGcmFtZVZpZXc6OmxheW91dChib29sIGFsbG93 U3VidHJlZUxheW91dCkKICAgICAgICAgICAgIG1fZmlyc3RMYXlvdXQgPSBmYWxzZTsKICAgICAg ICAgfQogCi0gICAgICAgIEFTU0VSVChhbGxvd1N1YnRyZWVMYXlvdXQgfHwgIWlzU3VidHJlZUxh eW91dCk7CiAgICAgICAgIEFTU0VSVChtX2xheW91dFBoYXNlID09IEluUHJlTGF5b3V0KTsKICAg ICAgICAgZm9yY2VMYXlvdXRQYXJlbnRWaWV3SWZOZWVkZWQoKTsKICAgICB9CkBAIC00Mjg1LDcg KzQyODIsNyBAQCBib29sIEZyYW1lVmlldzo6aXNJbkNoaWxkRnJhbWVXaXRoRnJhbWVGbGF0dGVu aW5nKCkgY29uc3QKICAgICByZXR1cm4gZmFsc2U7CiB9CiAKLXZvaWQgRnJhbWVWaWV3OjpzdGFy dExheW91dEF0TWFpbkZyYW1lVmlld0lmTmVlZGVkKGJvb2wgYWxsb3dTdWJ0cmVlTGF5b3V0KQor dm9pZCBGcmFtZVZpZXc6OnN0YXJ0TGF5b3V0QXRNYWluRnJhbWVWaWV3SWZOZWVkZWQoKQogewog ICAgIC8vIFdoZW4gd2Ugc3RhcnQgYSBsYXlvdXQgYXQgdGhlIGNoaWxkIGxldmVsIGFzIG9wcG9z ZWQgdG8gdGhlIHRvcG1vc3QgZnJhbWUgdmlldyBhbmQgdGhpcyBjaGlsZAogICAgIC8vIGZyYW1l IHJlcXVpcmVzIGZsYXR0ZW5pbmcsIHdlIG5lZWQgdG8gcmUtaW5pdGlhdGUgdGhlIGxheW91dCBh dCB0aGUgdG9wbW9zdCB2aWV3LiBMYXlvdXQKQEAgLTQzMDYsNyArNDMwMyw3IEBAIHZvaWQgRnJh bWVWaWV3OjpzdGFydExheW91dEF0TWFpbkZyYW1lVmlld0lmTmVlZGVkKGJvb2wgYWxsb3dTdWJ0 cmVlTGF5b3V0KQogICAgICAgICBwYXJlbnRWaWV3ID0gcGFyZW50Vmlldy0+cGFyZW50RnJhbWVW aWV3KCk7CiAKICAgICBMT0coTGF5b3V0LCAiICBmcmFtZSBmbGF0dGVuaW5nLCBzdGFydGluZyBm cm9tIHJvb3QiKTsKLSAgICBwYXJlbnRWaWV3LT5sYXlvdXQoYWxsb3dTdWJ0cmVlTGF5b3V0KTsK KyAgICBwYXJlbnRWaWV3LT5sYXlvdXQoKTsKIH0KIAogdm9pZCBGcmFtZVZpZXc6OnVwZGF0ZUNv bnRyb2xUaW50cygpCkBAIC00NzA1LDkgKzQ3MDIsMTEgQEAgdm9pZCBGcmFtZVZpZXc6OmVuYWJs ZUF1dG9TaXplTW9kZShib29sIGVuYWJsZSwgY29uc3QgSW50U2l6ZSYgbWluU2l6ZSwgY29uc3Qg SW4KICAgICBzZXRTY3JvbGxiYXJNb2RlcyhTY3JvbGxiYXJBdXRvLCBTY3JvbGxiYXJBdXRvKTsK IH0KIAotdm9pZCBGcmFtZVZpZXc6OmZvcmNlTGF5b3V0KGJvb2wgYWxsb3dTdWJ0cmVlKQordm9p ZCBGcmFtZVZpZXc6OmZvcmNlTGF5b3V0KGJvb2wgYWxsb3dTdWJ0cmVlTGF5b3V0KQogewotICAg IGxheW91dChhbGxvd1N1YnRyZWUpOworICAgIGlmICghYWxsb3dTdWJ0cmVlTGF5b3V0ICYmIHN1 YnRyZWVMYXlvdXRSb290KCkpCisgICAgICAgIGNvbnZlcnRTdWJ0cmVlTGF5b3V0VG9GdWxsTGF5 b3V0KCk7CisgICAgbGF5b3V0KCk7CiB9CiAKIHZvaWQgRnJhbWVWaWV3Ojpmb3JjZUxheW91dEZv clBhZ2luYXRpb24oY29uc3QgRmxvYXRTaXplJiBwYWdlU2l6ZSwgY29uc3QgRmxvYXRTaXplJiBv cmlnaW5hbFBhZ2VTaXplLCBmbG9hdCBtYXhpbXVtU2hyaW5rRmFjdG9yLCBBZGp1c3RWaWV3U2l6 ZU9yTm90IHNob3VsZEFkanVzdFZpZXdTaXplKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv cGFnZS9GcmFtZVZpZXcuaCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmgKaW5kZXgg YzAxZjA4ODExMDAzYmJjMWJkMzEwZWExZDMwOTMxZjBmNDAxNDE3Ny4uYzExZDlmYjFkMjRmMzZl MjRjMjYwZjMwZjc2NWNiOTU2M2Q0Y2NhMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFn ZS9GcmFtZVZpZXcuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5oCkBAIC0x MDQsNyArMTA0LDcgQEAgcHVibGljOgogICAgIHZvaWQgc2V0Q29udGVudHNTaXplKGNvbnN0IElu dFNpemUmKSBmaW5hbDsKICAgICB2b2lkIHVwZGF0ZUNvbnRlbnRzU2l6ZSgpIGZpbmFsOwogCi0g ICAgdm9pZCBsYXlvdXQoYm9vbCBhbGxvd1N1YnRyZWUgPSB0cnVlKTsKKyAgICB2b2lkIGxheW91 dCgpOwogICAgIFdFQkNPUkVfRVhQT1JUIGJvb2wgZGlkRmlyc3RMYXlvdXQoKSBjb25zdDsKICAg ICB2b2lkIGxheW91dFRpbWVyRmlyZWQoKTsKICAgICB2b2lkIHNjaGVkdWxlUmVsYXlvdXQoKTsK QEAgLTQwMiw3ICs0MDIsNyBAQCBwdWJsaWM6CiAgICAgV0VCQ09SRV9FWFBPUlQgdm9pZCBzZXRB dXRvU2l6ZUZpeGVkTWluaW11bUhlaWdodChpbnQpOwogICAgIEludFNpemUgYXV0b1NpemluZ0lu dHJpbnNpY0NvbnRlbnRTaXplKCkgY29uc3QgeyByZXR1cm4gbV9hdXRvU2l6ZUNvbnRlbnRTaXpl OyB9CiAKLSAgICBXRUJDT1JFX0VYUE9SVCB2b2lkIGZvcmNlTGF5b3V0KGJvb2wgYWxsb3dTdWJ0 cmVlID0gZmFsc2UpOworICAgIFdFQkNPUkVfRVhQT1JUIHZvaWQgZm9yY2VMYXlvdXQoYm9vbCBh bGxvd1N1YnRyZWVMYXlvdXQgPSBmYWxzZSk7CiAgICAgV0VCQ09SRV9FWFBPUlQgdm9pZCBmb3Jj ZUxheW91dEZvclBhZ2luYXRpb24oY29uc3QgRmxvYXRTaXplJiBwYWdlU2l6ZSwgY29uc3QgRmxv YXRTaXplJiBvcmlnaW5hbFBhZ2VTaXplLCBmbG9hdCBtYXhpbXVtU2hyaW5rRmFjdG9yLCBBZGp1 c3RWaWV3U2l6ZU9yTm90KTsKIAogICAgIC8vIEZJWE1FOiBUaGlzIG1ldGhvZCBpcyByZXRhaW5l ZCBiZWNhdXNlIG9mIGVtYmVkZGVkIFdlYlZpZXdzIGluIEFwcEtpdC4gIFdoZW4gYSBXZWJWaWV3 IGlzIGVtYmVkZGVkIGluc2lkZQpAQCAtNzYyLDggKzc2Miw4IEBAIHByaXZhdGU6CiAKICAgICBG cmFtZVZpZXcqIHBhcmVudEZyYW1lVmlldygpIGNvbnN0OwogCi0gICAgYm9vbCBoYW5kbGVMYXlv dXRXaXRoRnJhbWVGbGF0dGVuaW5nSWZOZWVkZWQoYm9vbCBhbGxvd1N1YnRyZWVMYXlvdXQpOwot ICAgIHZvaWQgc3RhcnRMYXlvdXRBdE1haW5GcmFtZVZpZXdJZk5lZWRlZChib29sIGFsbG93U3Vi dHJlZUxheW91dCk7CisgICAgYm9vbCBoYW5kbGVMYXlvdXRXaXRoRnJhbWVGbGF0dGVuaW5nSWZO ZWVkZWQoKTsKKyAgICB2b2lkIHN0YXJ0TGF5b3V0QXRNYWluRnJhbWVWaWV3SWZOZWVkZWQoKTsK ICAgICBib29sIGZyYW1lRmxhdHRlbmluZ0VuYWJsZWQoKSBjb25zdDsKICAgICBib29sIGlzRnJh bWVGbGF0dGVuaW5nVmFsaWRGb3JUaGlzRnJhbWUoKSBjb25zdDsKICAgICAK