178608 2017-10-20 16:31:39 -0700 Cleanup unnecessary code to run JavaScriptCore tests 2017-11-17 12:16:05 -0800 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED WORKSFORME P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap buildbot dbates glenn lforschler oldest_to_newest 1362908 0 aakash_jain 2017-10-20 16:31:39 -0700 We now have a separate JavaScriptCore test EWS which run JavaScriptCore tests on every patch (as appropriate). There seems to be unnecessary code in runtests.py to run JavaScriptCore tests which is enabled only when --non-interactive mode is not passed. All of the EWSes seems to pass --non-interactive (in patchanalysistask.py base class _test() method). So this seems unnecessary code. 1362909 1 324465 aakash_jain 2017-10-20 16:36:22 -0700 Created attachment 324465 Proposed patch 1362970 2 dbates 2017-10-20 20:21:58 -0700 (In reply to Aakash Jain from comment #0) > We now have a separate JavaScriptCore test EWS which run JavaScriptCore > tests on every patch (as appropriate). > > There seems to be unnecessary code in runtests.py to run JavaScriptCore > tests which is enabled only when --non-interactive mode is not passed. This is incorrect. We run these test when running webkit-patch interactively by <https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/tool/steps/runtests.py?rev=223796#L94> > All of the EWSes seems to pass --non-interactive (in patchanalysistask.py base > class _test() method). So this seems unnecessary code. 1362971 3 324465 dbates 2017-10-20 20:23:23 -0700 Comment on attachment 324465 Proposed patch This will make "webkit-patch build-and-test" and "webkit-patch build-and-test-attachment " no longer run the JavaScriptCore tests. 1363164 4 ap 2017-10-22 13:11:13 -0700 Who uses webkit-patch like this? This particular tiny test suite is not very valuable to run for each and every patch locally, and thus I find it unlikely that anyone manually uses the command that forces it. 1373204 5 aakash_jain 2017-11-17 12:15:38 -0800 This portion of code does not affect EWS since EWS pass the option --non-interactive. We can keep this code as it would be executed when someone manually executes "webkit-patch build-and-test". 324465 2017-10-20 16:36:22 -0700 2017-11-17 12:16:05 -0800 Proposed patch jsc_runtests_remove_dead_code text/plain 6529 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIyMzc5OCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE2IEBACisyMDE3LTEwLTIwICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBDbGVhbnVwIHVubmVjZXNzYXJ5IGNvZGUgdG8gcnVuIEphdmFTY3JpcHRD b3JlIHRlc3RzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNzg2MDgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIFNjcmlwdHMvd2Via2l0cHkvdG9vbC9zdGVwcy9ydW50ZXN0cy5weToKKyAgICAgICAgKFJ1 blRlc3RzLnJ1bik6IFdlIGhhdmUgYSBzZXBhcmF0ZSBFV1MgdG8gcnVuIEphdmFTY3JpcHRDb3Jl IHRlc3RzLiBBbHNvIHRoaXMgY29kZQorICAgICAgICBpcyBub3QgdXNlZCBieSBFV1NlcyBhcyB0 aGV5IHBhc3MgLS1ub24taW50ZXJhY3RpdmUgYXJndW1lbnQuCisgICAgICAgICogU2NyaXB0cy93 ZWJraXRweS90b29sL3N0ZXBzL3N0ZXBzX3VuaXR0ZXN0LnB5OiBVcGRhdGVkIHVuaXQtdGVzdHMu CisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL2Rvd25sb2FkX3VuaXR0 ZXN0LnB5OiBEaXR0by4KKwogMjAxNy0xMC0yMCAgQWFrYXNoIEphaW4gIDxhYWthc2hfamFpbkBh cHBsZS5jb20+CiAKICAgICAgICAgRG8gbm90IHJ1biBiaW5kaW5nIHRlc3RzIG9uIG11bHRpcGxl IEVXU2VzCkluZGV4OiBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvZG93bmxv YWRfdW5pdHRlc3QucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29s L2NvbW1hbmRzL2Rvd25sb2FkX3VuaXR0ZXN0LnB5CShyZXZpc2lvbiAyMjM3OTgpCisrKyBUb29s cy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvZG93bmxvYWRfdW5pdHRlc3QucHkJKHdv cmtpbmcgY29weSkKQEAgLTEwMiw3ICsxMDIsNiBAQCBjbGFzcyBEb3dubG9hZENvbW1hbmRzVGVz dChDb21tYW5kc1Rlc3QpCiBCdWlsZGluZyBXZWJLaXQKIFJ1bm5pbmcgUHl0aG9uIHVuaXQgdGVz dHMKIFJ1bm5pbmcgUGVybCB1bml0IHRlc3RzCi1SdW5uaW5nIEphdmFTY3JpcHRDb3JlIHRlc3Rz CiBSdW5uaW5nIHJ1bi13ZWJraXQtdGVzdHMKICIiIgogICAgICAgICBzZWxmLmFzc2VydF9leGVj dXRlX291dHB1dHMoQnVpbGRBbmRUZXN0KCksIFtdLCBvcHRpb25zPXNlbGYuX2RlZmF1bHRfb3B0 aW9ucygpLCBleHBlY3RlZF9sb2dzPWV4cGVjdGVkX2xvZ3MpCkBAIC0xNDIsNyArMTQxLDYgQEAg TWVzc2FnZTIuIgogICAgICAgICBleHBlY3RlZF9sb2dzID0gIiIiQnVpbGRpbmcgV2ViS2l0CiBS dW5uaW5nIFB5dGhvbiB1bml0IHRlc3RzCiBSdW5uaW5nIFBlcmwgdW5pdCB0ZXN0cwotUnVubmlu ZyBKYXZhU2NyaXB0Q29yZSB0ZXN0cwogUnVubmluZyBydW4td2Via2l0LXRlc3RzCiBDb21taXR0 ZWQgcjQ5ODI0OiA8aHR0cHM6Ly90cmFjLndlYmtpdC5vcmcvY2hhbmdlc2V0LzQ5ODI0PgogVXBk YXRpbmcgYnVnIDUwMDAwCkBAIC0xNjcsOCArMTY1LDYgQEAgUnVubmluZyBQeXRob24gdW5pdCB0 ZXN0cwogTU9DSyBydW5fYW5kX3Rocm93X2lmX2ZhaWw6IFsnbW9jay10ZXN0LXdlYmtpdHB5J10s IGN3ZD0vbW9jay1jaGVja291dAogUnVubmluZyBQZXJsIHVuaXQgdGVzdHMKIE1PQ0sgcnVuX2Fu ZF90aHJvd19pZl9mYWlsOiBbJ21vY2stdGVzdC13ZWJraXRwZXJsJ10sIGN3ZD0vbW9jay1jaGVj a291dAotUnVubmluZyBKYXZhU2NyaXB0Q29yZSB0ZXN0cwotTU9DSyBydW5fYW5kX3Rocm93X2lm X2ZhaWw6IFsnbW9jay1ydW4tamF2YWNyaXB0Y29yZS10ZXN0cyddLCBjd2Q9L21vY2stY2hlY2tv dXQKIFJ1bm5pbmcgcnVuLXdlYmtpdC10ZXN0cwogTU9DSyBydW5fYW5kX3Rocm93X2lmX2ZhaWw6 IFsnbW9jay1ydW4td2Via2l0LXRlc3RzJywgJy0tcXVpZXQnXSwgY3dkPS9tb2NrLWNoZWNrb3V0 CiBDb21taXR0ZWQgcjQ5ODI0OiA8aHR0cHM6Ly90cmFjLndlYmtpdC5vcmcvY2hhbmdlc2V0LzQ5 ODI0PgpAQCAtMTg1LDcgKzE4MSw2IEBAIE5vIGJ1ZyBpZCBwcm92aWRlZC4KICAgICAgICAgZXhw ZWN0ZWRfbG9ncyA9ICIiIkJ1aWxkaW5nIFdlYktpdAogUnVubmluZyBQeXRob24gdW5pdCB0ZXN0 cwogUnVubmluZyBQZXJsIHVuaXQgdGVzdHMKLVJ1bm5pbmcgSmF2YVNjcmlwdENvcmUgdGVzdHMK IFJ1bm5pbmcgcnVuLXdlYmtpdC10ZXN0cwogQ29tbWl0dGVkIHI0OTgyNDogPGh0dHBzOi8vdHJh Yy53ZWJraXQub3JnL2NoYW5nZXNldC80OTgyND4KIFVwZGF0aW5nIGJ1ZyA1MDAwMApAQCAtMjE1 LDcgKzIxMCw2IEBAIFByb2Nlc3NpbmcgcGF0Y2ggMTAwMDAgZnJvbSBidWcgNTAwMDAuCiBCdWls ZGluZyBXZWJLaXQKIFJ1bm5pbmcgUHl0aG9uIHVuaXQgdGVzdHMKIFJ1bm5pbmcgUGVybCB1bml0 IHRlc3RzCi1SdW5uaW5nIEphdmFTY3JpcHRDb3JlIHRlc3RzCiBSdW5uaW5nIHJ1bi13ZWJraXQt dGVzdHMKIENvbW1pdHRlZCByNDk4MjQ6IDxodHRwczovL3RyYWMud2Via2l0Lm9yZy9jaGFuZ2Vz ZXQvNDk4MjQ+CiBOb3QgY2xvc2luZyBidWcgNTAwMDAgYXMgYXR0YWNobWVudCAxMDAwMCBoYXMg cmV2aWV3PSsuICBBc3N1bWluZyB0aGVyZSBhcmUgbW9yZSBwYXRjaGVzIHRvIGxhbmQgZnJvbSB0 aGlzIGJ1Zy4KQEAgLTIzMSw3ICsyMjUsNiBAQCBQcm9jZXNzaW5nIHBhdGNoIDEwMDAwIGZyb20g YnVnIDUwMDAwLgogQnVpbGRpbmcgV2ViS2l0CiBSdW5uaW5nIFB5dGhvbiB1bml0IHRlc3RzCiBS dW5uaW5nIFBlcmwgdW5pdCB0ZXN0cwotUnVubmluZyBKYXZhU2NyaXB0Q29yZSB0ZXN0cwogUnVu bmluZyBydW4td2Via2l0LXRlc3RzCiBDb21taXR0ZWQgcjQ5ODI0OiA8aHR0cHM6Ly90cmFjLndl YmtpdC5vcmcvY2hhbmdlc2V0LzQ5ODI0PgogTm90IGNsb3NpbmcgYnVnIDUwMDAwIGFzIGF0dGFj aG1lbnQgMTAwMDAgaGFzIHJldmlldz0rLiAgQXNzdW1pbmcgdGhlcmUgYXJlIG1vcmUgcGF0Y2hl cyB0byBsYW5kIGZyb20gdGhpcyBidWcuCkBAIC0yNDAsNyArMjMzLDYgQEAgUHJvY2Vzc2luZyBw YXRjaCAxMDAwMSBmcm9tIGJ1ZyA1MDAwMC4KIEJ1aWxkaW5nIFdlYktpdAogUnVubmluZyBQeXRo b24gdW5pdCB0ZXN0cwogUnVubmluZyBQZXJsIHVuaXQgdGVzdHMKLVJ1bm5pbmcgSmF2YVNjcmlw dENvcmUgdGVzdHMKIFJ1bm5pbmcgcnVuLXdlYmtpdC10ZXN0cwogQ29tbWl0dGVkIHI0OTgyNDog PGh0dHBzOi8vdHJhYy53ZWJraXQub3JnL2NoYW5nZXNldC80OTgyND4KIE5vdCBjbG9zaW5nIGJ1 ZyA1MDAwMCBhcyBhdHRhY2htZW50IDEwMDAwIGhhcyByZXZpZXc9Ky4gIEFzc3VtaW5nIHRoZXJl IGFyZSBtb3JlIHBhdGNoZXMgdG8gbGFuZCBmcm9tIHRoaXMgYnVnLgpAQCAtMjU2LDcgKzI0OCw2 IEBAIFByb2Nlc3NpbmcgcGF0Y2ggMTAwMDAgZnJvbSBidWcgNTAwMDAuCiBCdWlsZGluZyBXZWJL aXQKIFJ1bm5pbmcgUHl0aG9uIHVuaXQgdGVzdHMKIFJ1bm5pbmcgUGVybCB1bml0IHRlc3RzCi1S dW5uaW5nIEphdmFTY3JpcHRDb3JlIHRlc3RzCiBSdW5uaW5nIHJ1bi13ZWJraXQtdGVzdHMKIENv bW1pdHRlZCByNDk4MjQ6IDxodHRwczovL3RyYWMud2Via2l0Lm9yZy9jaGFuZ2VzZXQvNDk4MjQ+ CiBOb3QgY2xvc2luZyBidWcgNTAwMDAgYXMgYXR0YWNobWVudCAxMDAwMCBoYXMgcmV2aWV3PSsu ICBBc3N1bWluZyB0aGVyZSBhcmUgbW9yZSBwYXRjaGVzIHRvIGxhbmQgZnJvbSB0aGlzIGJ1Zy4K QEAgLTI2NSw3ICsyNTYsNiBAQCBQcm9jZXNzaW5nIHBhdGNoIDEwMDAxIGZyb20gYnVnIDUwMDAw LgogQnVpbGRpbmcgV2ViS2l0CiBSdW5uaW5nIFB5dGhvbiB1bml0IHRlc3RzCiBSdW5uaW5nIFBl cmwgdW5pdCB0ZXN0cwotUnVubmluZyBKYXZhU2NyaXB0Q29yZSB0ZXN0cwogUnVubmluZyBydW4t d2Via2l0LXRlc3RzCiBDb21taXR0ZWQgcjQ5ODI0OiA8aHR0cHM6Ly90cmFjLndlYmtpdC5vcmcv Y2hhbmdlc2V0LzQ5ODI0PgogTm90IGNsb3NpbmcgYnVnIDUwMDAwIGFzIGF0dGFjaG1lbnQgMTAw MDAgaGFzIHJldmlldz0rLiAgQXNzdW1pbmcgdGhlcmUgYXJlIG1vcmUgcGF0Y2hlcyB0byBsYW5k IGZyb20gdGhpcyBidWcuCkluZGV4OiBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvc3RlcHMv cnVudGVzdHMucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL3N0 ZXBzL3J1bnRlc3RzLnB5CShyZXZpc2lvbiAyMjM3OTgpCisrKyBUb29scy9TY3JpcHRzL3dlYmtp dHB5L3Rvb2wvc3RlcHMvcnVudGVzdHMucHkJKHdvcmtpbmcgY29weSkKQEAgLTk5LDExICs5OSw2 IEBAIGNsYXNzIFJ1blRlc3RzKEFic3RyYWN0U3RlcCk6CiAgICAgICAgICAgICAgICAgX2xvZy5p bmZvKCJSdW5uaW5nIFBlcmwgdW5pdCB0ZXN0cyIpCiAgICAgICAgICAgICAgICAgc2VsZi5fdG9v bC5leGVjdXRpdmUucnVuX2FuZF90aHJvd19pZl9mYWlsKHBlcmxfdW5pdHRlc3RzX2NvbW1hbmQs IGN3ZD1zZWxmLl90b29sLnNjbSgpLmNoZWNrb3V0X3Jvb3QpCiAKLSAgICAgICAgICAgIGphdmFz Y3JpcHRjb3JlX3Rlc3RzX2NvbW1hbmQgPSBzZWxmLl90b29sLmRlcHJlY2F0ZWRfcG9ydCgpLnJ1 bl9qYXZhc2NyaXB0Y29yZV90ZXN0c19jb21tYW5kKCkKLSAgICAgICAgICAgIGlmIGphdmFzY3Jp cHRjb3JlX3Rlc3RzX2NvbW1hbmQ6Ci0gICAgICAgICAgICAgICAgX2xvZy5pbmZvKCJSdW5uaW5n IEphdmFTY3JpcHRDb3JlIHRlc3RzIikKLSAgICAgICAgICAgICAgICBzZWxmLl90b29sLmV4ZWN1 dGl2ZS5ydW5fYW5kX3Rocm93X2lmX2ZhaWwoamF2YXNjcmlwdGNvcmVfdGVzdHNfY29tbWFuZCwg cXVpZXQ9VHJ1ZSwgY3dkPXNlbGYuX3Rvb2wuc2NtKCkuY2hlY2tvdXRfcm9vdCkKLQogICAgICAg ICBfbG9nLmluZm8oIlJ1bm5pbmcgcnVuLXdlYmtpdC10ZXN0cyIpCiAgICAgICAgIHNlbGYuX3J1 bl93ZWJraXRfdGVzdHMoKQogCkluZGV4OiBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvc3Rl cHMvc3RlcHNfdW5pdHRlc3QucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy93ZWJraXRw eS90b29sL3N0ZXBzL3N0ZXBzX3VuaXR0ZXN0LnB5CShyZXZpc2lvbiAyMjM3OTgpCisrKyBUb29s cy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvc3RlcHMvc3RlcHNfdW5pdHRlc3QucHkJKHdvcmtpbmcg Y29weSkKQEAgLTEyMiw4ICsxMjIsNiBAQCBjbGFzcyBTdGVwc1Rlc3QodW5pdHRlc3QuVGVzdENh c2UpOgogTU9DSyBydW5fYW5kX3Rocm93X2lmX2ZhaWw6IFsnVG9vbHMvU2NyaXB0cy90ZXN0LXdl YmtpdHB5J10sIGN3ZD0vbW9jay1jaGVja291dAogUnVubmluZyBQZXJsIHVuaXQgdGVzdHMKIE1P Q0sgcnVuX2FuZF90aHJvd19pZl9mYWlsOiBbJ1Rvb2xzL1NjcmlwdHMvdGVzdC13ZWJraXRwZXJs J10sIGN3ZD0vbW9jay1jaGVja291dAotUnVubmluZyBKYXZhU2NyaXB0Q29yZSB0ZXN0cwotTU9D SyBydW5fYW5kX3Rocm93X2lmX2ZhaWw6IFsnVG9vbHMvU2NyaXB0cy9ydW4tamF2YXNjcmlwdGNv cmUtdGVzdHMnLCAnLS1uby1mYWlsLWZhc3QnXSwgY3dkPS9tb2NrLWNoZWNrb3V0CiBSdW5uaW5n IHJ1bi13ZWJraXQtdGVzdHMKIE1PQ0sgcnVuX2FuZF90aHJvd19pZl9mYWlsOiBbJ1Rvb2xzL1Nj cmlwdHMvcnVuLXdlYmtpdC10ZXN0cycsICctLXJlbGVhc2UnLCAnLS1xdWlldCddLCBjd2Q9L21v Y2stY2hlY2tvdXQKICIiIgpAQCAtMTQyLDggKzE0MCw2IEBAIE1PQ0sgcnVuX2FuZF90aHJvd19p Zl9mYWlsOiBbJ1Rvb2xzL1NjcmkKIE1PQ0sgcnVuX2FuZF90aHJvd19pZl9mYWlsOiBbJ1Rvb2xz L1NjcmlwdHMvdGVzdC13ZWJraXRweSddLCBjd2Q9L21vY2stY2hlY2tvdXQKIFJ1bm5pbmcgUGVy bCB1bml0IHRlc3RzCiBNT0NLIHJ1bl9hbmRfdGhyb3dfaWZfZmFpbDogWydUb29scy9TY3JpcHRz L3Rlc3Qtd2Via2l0cGVybCddLCBjd2Q9L21vY2stY2hlY2tvdXQKLVJ1bm5pbmcgSmF2YVNjcmlw dENvcmUgdGVzdHMKLU1PQ0sgcnVuX2FuZF90aHJvd19pZl9mYWlsOiBbJ1Rvb2xzL1NjcmlwdHMv cnVuLWphdmFzY3JpcHRjb3JlLXRlc3RzJywgJy0tbm8tZmFpbC1mYXN0J10sIGN3ZD0vbW9jay1j aGVja291dAogUnVubmluZyBydW4td2Via2l0LXRlc3RzCiBNT0NLIHJ1bl9hbmRfdGhyb3dfaWZf ZmFpbDogWydUb29scy9TY3JpcHRzL3J1bi13ZWJraXQtdGVzdHMnLCAnLS1kZWJ1ZycsICctLXF1 aWV0J10sIGN3ZD0vbW9jay1jaGVja291dAogIiIiCg==