178586 2017-10-20 08:04:28 -0700 ASSERTION FAILED: !m_serviceWorkerManager in WebProcess::getWorkerContextConnection() on API tests 2017-10-24 09:33:21 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf youennf ap beidson cdumez commit-queue jlewis3 ryanhaddad webkit-bug-importer oldest_to_newest 1362694 0 youennf 2017-10-20 08:04:28 -0700 Log is: ASSERTION FAILED: !m_serviceWorkerManager /Volumes/Data/slave/highsierra-debug/build/Source/WebKit/WebProcess/WebProcess.cpp(1636) : void WebKit::WebProcess::getWorkerContextConnection() 1 0x5c6cd745d WTFCrash 2 0x107b45590 WebKit::WebProcess::getWorkerContextConnection() 3 0x107b8e0ae void IPC::callMemberFunctionImpl<WebKit::WebProcess, void (WebKit::WebProcess::*)(), std::__1::tuple<> >(WebKit::WebProcess*, void (WebKit::WebProcess::*)(), std::__1::tuple<>&&, std::__1::integer_sequence<unsigned long>) 4 0x107b8e020 void IPC::callMemberFunction<WebKit::WebProcess, void (WebKit::WebProcess::*)(), std::__1::tuple<>, std::__1::integer_sequence<unsigned long> >(std::__1::tuple<>&&, WebKit::WebProcess*, void (WebKit::WebProcess::*)()) 5 0x107b8c86d void IPC::handleMessage<Messages::WebProcess::GetWorkerContextConnection, WebKit::WebProcess, void (WebKit::WebProcess::*)()>(IPC::Decoder&, WebKit::WebProcess*, void (WebKit::WebProcess::*)()) 6 0x107b88334 WebKit::WebProcess::didReceiveWebProcessMessage(IPC::Connection&, IPC::Decoder&) 7 0x107b3b1cb WebKit::WebProcess::didReceiveMessage(IPC::Connection&, IPC::Decoder&) 8 0x10706d643 IPC::Connection::dispatchMessage(IPC::Decoder&) 9 0x107062c28 IPC::Connection::dispatchMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >) 10 0x10706dc4a IPC::Connection::dispatchOneMessage() 11 0x107085f2d IPC::Connection::enqueueIncomingMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >)::$_14::operator()() 12 0x107085e89 WTF::Function<void ()>::CallableWrapper<IPC::Connection::enqueueIncomingMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >)::$_14>::call() 13 0x5c6d0cdeb WTF::Function<void ()>::operator()() const 14 0x5c6d2d423 WTF::RunLoop::performWork() 15 0x5c6d2dca4 WTF::RunLoop::performWork(void*) 16 0x7fff414d4941 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ 17 0x7fff4158c33c __CFRunLoopDoSource0 18 0x7fff414b7930 __CFRunLoopDoSources0 19 0x7fff414b6dad __CFRunLoopRun 20 0x7fff414b6607 CFRunLoopRunSpecific 21 0x7fff407cb866 RunCurrentEventLoopInMode 22 0x7fff407cb5d6 ReceiveNextEventCommon 23 0x7fff407cb354 _BlockUntilNextEventMatchingListInModeWithFilter 24 0x7fff3eac944f _DPSNextEvent 25 0x7fff3f25e508 -[NSApplication(NSEvent) _nextEventMatchingEventMask:untilDate:inMode:dequeue:] 26 0x7fff3eabe25d -[NSApplication run] 27 0x7fff3ea8d3fe NSApplicationMain 28 0x7fff68d8af33 _xpc_objc_main 29 0x7fff68d89b86 xpc_main 30 0x106f2012b main 1362695 1 youennf 2017-10-20 08:05:21 -0700 Looking at WebProcessPool::getWorkerContextProcessConnection, we can send several times Messages::WebProcess::GetWorkerContextConnection, which does not seem expected in WebProcess::getWorkerContextConnection if the connection is already made. 1363166 2 webkit-bug-importer 2017-10-22 13:37:19 -0700 <rdar://problem/35115902> 1363341 3 324570 youennf 2017-10-23 11:16:39 -0700 Created attachment 324570 Patch 1363699 4 324570 commit-queue 2017-10-24 09:33:19 -0700 Comment on attachment 324570 Patch Clearing flags on attachment: 324570 Committed r223890: <https://trac.webkit.org/changeset/223890> 1363700 5 commit-queue 2017-10-24 09:33:21 -0700 All reviewed patches have been landed. Closing bug. 324570 2017-10-23 11:16:39 -0700 2017-10-24 09:33:19 -0700 Patch bug-178586-20171023111638.patch text/plain 2184 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjIzODM1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDkwZWVkZjFmNzc1NDE2ZjNh ZDNiNGIwZWE1MjgzYjVlODg2ZDM4NDMuLmI2OWFmMDI5NTVmZWIzNjJiYjA5ODA5MGY3YjgyZThl MmRhZTVkN2MgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTggQEAKIDIwMTctMTAtMjMgIFlvdWVubiBG YWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgogCisgICAgICAgIEFTU0VSVElPTiBGQUlMRUQ6ICFt X3NlcnZpY2VXb3JrZXJNYW5hZ2VyIGluIFdlYlByb2Nlc3M6OmdldFdvcmtlckNvbnRleHRDb25u ZWN0aW9uKCkgb24gQVBJIHRlc3RzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNzg1ODYKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzM1MTE1OTAyPgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgQ292ZXJlZCBi eSBBUEkgdGVzdHMgbm8gbG9uZ2VyIGNyYXNoaW5nLgorCisgICAgICAgICogVUlQcm9jZXNzL1dl YlByb2Nlc3NQb29sLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViUHJvY2Vzc1Bvb2w6OmdldFdv cmtlckNvbnRleHRQcm9jZXNzQ29ubmVjdGlvbik6IFNlbmRpbmcgYSB3b3JrZXIgY29udGV4dCBw cm9jZXNzIGNvbm5lY3Rpb24gbWVzc2FnZSBvbmx5IGF0IGNyZWF0aW9uIG9mIHRoZSBzZXJ2aWNl IHdvcmtlciBwcm9jZXNzLgorCisyMDE3LTEwLTIzICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFw cGxlLmNvbT4KKwogICAgICAgICBUZXN0Q29udHJvbGxlciBzaG91bGQgY2xlYXIgYWxsIGZldGNo IGNhY2hlcyB3aGVuIHJlc2V0dGluZyBpdHMgc3RhdGUKICAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3ODQ4NgogICAgICAgICA8cmRhcjovL3Byb2JsZW0v MzUwNjYzMDU+CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQcm9jZXNz UG9vbC5jcHAgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQcm9jZXNzUG9vbC5jcHAKaW5k ZXggMTBmODY5OTZlZmIzNmIwNjlhYzE2NGY3MDA1YzBhMDdjZmM5ZmI1NS4uMzNiNzQ5MzZkZDlh NGNmYjRhZmNjYTdhMTIxNGRhMTNlYWJkYTY1YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9V SVByb2Nlc3MvV2ViUHJvY2Vzc1Bvb2wuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNz L1dlYlByb2Nlc3NQb29sLmNwcApAQCAtNTg5LDEzICs1ODksMTMgQEAgdm9pZCBXZWJQcm9jZXNz UG9vbDo6Z2V0V29ya2VyQ29udGV4dFByb2Nlc3NDb25uZWN0aW9uKFN0b3JhZ2VQcm9jZXNzUHJv eHkmIHByb3gKIHsKICAgICBBU1NFUlRfVU5VU0VEKHByb3h5LCAmcHJveHkgPT0gbV9zdG9yYWdl UHJvY2Vzcyk7CiAgICAgCi0gICAgaWYgKCFtX3dvcmtlckNvbnRleHRQcm9jZXNzKSB7Ci0gICAg ICAgIGlmICghbV93ZWJzaXRlRGF0YVN0b3JlKQotICAgICAgICAgICAgbV93ZWJzaXRlRGF0YVN0 b3JlID0gQVBJOjpXZWJzaXRlRGF0YVN0b3JlOjpkZWZhdWx0RGF0YVN0b3JlKCkucHRyKCk7Ci0g ICAgICAgIGF1dG8mIG5ld1Byb2Nlc3MgPSBjcmVhdGVOZXdXZWJQcm9jZXNzKG1fd2Vic2l0ZURh dGFTdG9yZS0+d2Vic2l0ZURhdGFTdG9yZSgpKTsKLSAgICAgICAgbV93b3JrZXJDb250ZXh0UHJv Y2VzcyA9ICZuZXdQcm9jZXNzOwotICAgIH0KLSAgICAKKyAgICBpZiAobV93b3JrZXJDb250ZXh0 UHJvY2VzcykKKyAgICAgICAgcmV0dXJuOworCisgICAgaWYgKCFtX3dlYnNpdGVEYXRhU3RvcmUp CisgICAgICAgIG1fd2Vic2l0ZURhdGFTdG9yZSA9IEFQSTo6V2Vic2l0ZURhdGFTdG9yZTo6ZGVm YXVsdERhdGFTdG9yZSgpLnB0cigpOworICAgIGF1dG8mIG5ld1Byb2Nlc3MgPSBjcmVhdGVOZXdX ZWJQcm9jZXNzKG1fd2Vic2l0ZURhdGFTdG9yZS0+d2Vic2l0ZURhdGFTdG9yZSgpKTsKKyAgICBt X3dvcmtlckNvbnRleHRQcm9jZXNzID0gJm5ld1Byb2Nlc3M7CiAgICAgbV93b3JrZXJDb250ZXh0 UHJvY2Vzcy0+c2VuZChNZXNzYWdlczo6V2ViUHJvY2Vzczo6R2V0V29ya2VyQ29udGV4dENvbm5l Y3Rpb24oKSwgMCk7CiB9CiAK