178558 2017-10-19 19:19:22 -0700 [FrameView::layout cleanup] Move style update related logic to a separate function 2017-10-19 21:52:11 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham commit-queue koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1362506 0 zalan 2017-10-19 19:19:22 -0700 ssia 1362507 1 webkit-bug-importer 2017-10-19 19:19:49 -0700 <rdar://problem/35088218> 1362510 2 324333 zalan 2017-10-19 19:28:07 -0700 Created attachment 324333 Patch 1362531 3 324333 simon.fraser 2017-10-19 20:25:27 -0700 Comment on attachment 324333 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=324333&action=review > Source/WebCore/page/FrameView.cpp:1365 > +void FrameView::ensureStyleIsUpToDateForLayout() Maybe just updateStyleForLayout or updateStyleBeforeLayout ? 1362550 4 324348 zalan 2017-10-19 21:22:43 -0700 Created attachment 324348 Patch 1362552 5 324348 commit-queue 2017-10-19 21:52:10 -0700 Comment on attachment 324348 Patch Clearing flags on attachment: 324348 Committed r223742: <https://trac.webkit.org/changeset/223742> 1362553 6 commit-queue 2017-10-19 21:52:11 -0700 All reviewed patches have been landed. Closing bug. 324333 2017-10-19 19:28:07 -0700 2017-10-19 21:22:41 -0700 Patch bug-178558-20171019192806.patch text/plain 4725 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjIzNzE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjczMWFhMjE5OWM0NDEx NjNmMjY2Njc0MDg1YmIzZGZhNWMyYWM3MC4uODdkOGNmNDlmOTdiZjg1NzBkMGQxZGI1MGVkNTFh MWY4ZmY4MDg0NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIwIEBACiAyMDE3LTEwLTE5ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CiAKKyAgICAgICAgW0ZyYW1lVmlldzo6bGF5b3V0 IGNsZWFudXBdIE1vdmUgc3R5bGUgdXBkYXRlIHJlbGF0ZWQgbG9naWMgdG8gYSBzZXBhcmF0ZSBm dW5jdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTc4NTU4CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zNTA4ODIxOD4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBjaGFuZ2UgaW4gZnVuY3Rpb25h bGl0eS4KKworICAgICAgICAqIHBhZ2UvRnJhbWVWaWV3LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OkZyYW1lVmlldzo6ZW5zdXJlU3R5bGVJc1VwVG9EYXRlRm9yTGF5b3V0KToKKyAgICAgICAgKFdl YkNvcmU6OkZyYW1lVmlldzo6bGF5b3V0KToKKyAgICAgICAgKiBwYWdlL0ZyYW1lVmlldy5oOgor CisyMDE3LTEwLTE5ICBaYWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKICAgICAgICAg W0ZyYW1lVmlldzo6bGF5b3V0IGNsZWFudXBdIE1vdmUgcG9zdCBsYXlvdXQgdGFzayBzY2hlZHVs aW5nIGxvZ2ljIHRvIGEgc2VwYXJhdGUgZnVuY3Rpb24KICAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3ODUzOAogICAgICAgICA8cmRhcjovL3Byb2JsZW0v MzUwODA3NDM+CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5jcHAKaW5kZXggYmU0ZDRiYzk0NjM2Nzk5 YmYzZTJhMjY5NmZkMmJlOWU2YWQ4MzA2ZC4uNTNiZmNlOWMwYzVlNDY1N2ZlYWFlMTE2OGNlNzJj Y2I5ZDdhNDljMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmNwcApAQCAtMTM2Miw2ICsxMzYy LDI2IEBAIHZvaWQgRnJhbWVWaWV3OjphZGp1c3RTY3JvbGxiYXJzRm9yTGF5b3V0KGJvb2wgaXNG aXJzdExheW91dCkKICAgICAgICAgc2V0U2Nyb2xsYmFyTW9kZXMoaE1vZGUsIHZNb2RlKTsKIH0K IAordm9pZCBGcmFtZVZpZXc6OmVuc3VyZVN0eWxlSXNVcFRvRGF0ZUZvckxheW91dCgpCit7Cisg ICAgRG9jdW1lbnQmIGRvY3VtZW50ID0gKmZyYW1lKCkuZG9jdW1lbnQoKTsKKyAgICAvLyBWaWV3 cG9ydC1kZXBlbmRlbnQgbWVkaWEgcXVlcmllcyBtYXkgY2F1c2UgdXMgdG8gbmVlZCBjb21wbGV0 ZWx5IGRpZmZlcmVudCBzdHlsZSBpbmZvcm1hdGlvbi4KKyAgICBhdXRvKiBzdHlsZVJlc29sdmVy ID0gZG9jdW1lbnQuc3R5bGVTY29wZSgpLnJlc29sdmVySWZFeGlzdHMoKTsKKyAgICBpZiAoIXN0 eWxlUmVzb2x2ZXIgfHwgc3R5bGVSZXNvbHZlci0+aGFzTWVkaWFRdWVyaWVzQWZmZWN0ZWRCeVZp ZXdwb3J0Q2hhbmdlKCkpIHsKKyAgICAgICAgTE9HKExheW91dCwgIiAgaGFzTWVkaWFRdWVyaWVz QWZmZWN0ZWRCeVZpZXdwb3J0Q2hhbmdlLCBlbnF1ZXVlaW5nIHN0eWxlIHJlY2FsYyIpOworICAg ICAgICBkb2N1bWVudC5zdHlsZVNjb3BlKCkuZGlkQ2hhbmdlU3R5bGVTaGVldEVudmlyb25tZW50 KCk7CisgICAgICAgIC8vIEZJWE1FOiBUaGlzIGluc3RydW1lbnRhdGlvbiBldmVudCBpcyBub3Qg c3RyaWN0bHkgYWNjdXJhdGUgc2luY2UgY2FjaGVkIG1lZGlhIHF1ZXJ5IHJlc3VsdHMgZG8gbm90 IHBlcnNpc3QgYWNyb3NzIFN0eWxlUmVzb2x2ZXIgcmVidWlsZHMuCisgICAgICAgIEluc3BlY3Rv ckluc3RydW1lbnRhdGlvbjo6bWVkaWFRdWVyeVJlc3VsdENoYW5nZWQoZG9jdW1lbnQpOworICAg IH0KKyAgICBkb2N1bWVudC5ldmFsdWF0ZU1lZGlhUXVlcnlMaXN0KCk7CisgICAgLy8gSWYgdGhl cmUgaXMgYW55IHBhZ2luYXRpb24gdG8gYXBwbHksIGl0IHdpbGwgYWZmZWN0IHRoZSBSZW5kZXJW aWV3J3Mgc3R5bGUsIHNvIHdlIHNob3VsZAorICAgIC8vIHRha2UgY2FyZSBvZiB0aGF0IG5vdy4K KyAgICBhcHBseVBhZ2luYXRpb25Ub1ZpZXdwb3J0KCk7CisgICAgLy8gQWx3YXlzIGVuc3VyZSBv dXIgc3R5bGUgaW5mbyBpcyB1cC10by1kYXRlLiBUaGlzIGNhbiBoYXBwZW4gaW4gc2l0dWF0aW9u cyB3aGVyZQorICAgIC8vIHRoZSBsYXlvdXQgYmVhdHMgYW55IHNvcnQgb2Ygc3R5bGUgcmVjYWxj IHVwZGF0ZSB0aGF0IG5lZWRzIHRvIG9jY3VyLgorICAgIGRvY3VtZW50LnVwZGF0ZVN0eWxlSWZO ZWVkZWQoKTsKK30KKwogdm9pZCBGcmFtZVZpZXc6OmxheW91dChib29sIGFsbG93U3VidHJlZUxh eW91dCkKIHsKICAgICBBU1NFUlRfV0lUSF9TRUNVUklUWV9JTVBMSUNBVElPTighZnJhbWUoKS5k b2N1bWVudCgpLT5pblJlbmRlclRyZWVVcGRhdGUoKSk7CkBAIC0xNDE5LDIzICsxNDM5LDcgQEAg dm9pZCBGcmFtZVZpZXc6OmxheW91dChib29sIGFsbG93U3VidHJlZUxheW91dCkKICAgICAgICAg aWYgKCFpc0xheW91dE5lc3RlZCgpICYmIG1fcG9zdExheW91dFRhc2tzVGltZXIuaXNBY3RpdmUo KSAmJiAhaXNJbkNoaWxkRnJhbWVXaXRoRnJhbWVGbGF0dGVuaW5nKCkpCiAgICAgICAgICAgICBw ZXJmb3JtUG9zdExheW91dFRhc2tzKCk7CiAKLSAgICAgICAgLy8gVmlld3BvcnQtZGVwZW5kZW50 IG1lZGlhIHF1ZXJpZXMgbWF5IGNhdXNlIHVzIHRvIG5lZWQgY29tcGxldGVseSBkaWZmZXJlbnQg c3R5bGUgaW5mb3JtYXRpb24uCi0gICAgICAgIGF1dG8qIHN0eWxlUmVzb2x2ZXIgPSBkb2N1bWVu dC5zdHlsZVNjb3BlKCkucmVzb2x2ZXJJZkV4aXN0cygpOwotICAgICAgICBpZiAoIXN0eWxlUmVz b2x2ZXIgfHwgc3R5bGVSZXNvbHZlci0+aGFzTWVkaWFRdWVyaWVzQWZmZWN0ZWRCeVZpZXdwb3J0 Q2hhbmdlKCkpIHsKLSAgICAgICAgICAgIExPRyhMYXlvdXQsICIgIGhhc01lZGlhUXVlcmllc0Fm ZmVjdGVkQnlWaWV3cG9ydENoYW5nZSwgZW5xdWV1ZWluZyBzdHlsZSByZWNhbGMiKTsKLSAgICAg ICAgICAgIGRvY3VtZW50LnN0eWxlU2NvcGUoKS5kaWRDaGFuZ2VTdHlsZVNoZWV0RW52aXJvbm1l bnQoKTsKLSAgICAgICAgICAgIC8vIEZJWE1FOiBUaGlzIGluc3RydW1lbnRhdGlvbiBldmVudCBp cyBub3Qgc3RyaWN0bHkgYWNjdXJhdGUgc2luY2UgY2FjaGVkIG1lZGlhIHF1ZXJ5IHJlc3VsdHMg ZG8gbm90IHBlcnNpc3QgYWNyb3NzIFN0eWxlUmVzb2x2ZXIgcmVidWlsZHMuCi0gICAgICAgICAg ICBJbnNwZWN0b3JJbnN0cnVtZW50YXRpb246Om1lZGlhUXVlcnlSZXN1bHRDaGFuZ2VkKGRvY3Vt ZW50KTsKLSAgICAgICAgfQotICAgICAgICBkb2N1bWVudC5ldmFsdWF0ZU1lZGlhUXVlcnlMaXN0 KCk7Ci0gICAgICAgIC8vIElmIHRoZXJlIGlzIGFueSBwYWdpbmF0aW9uIHRvIGFwcGx5LCBpdCB3 aWxsIGFmZmVjdCB0aGUgUmVuZGVyVmlldydzIHN0eWxlLCBzbyB3ZSBzaG91bGQKLSAgICAgICAg Ly8gdGFrZSBjYXJlIG9mIHRoYXQgbm93LgotICAgICAgICBhcHBseVBhZ2luYXRpb25Ub1ZpZXdw b3J0KCk7Ci0gICAgICAgIC8vIEFsd2F5cyBlbnN1cmUgb3VyIHN0eWxlIGluZm8gaXMgdXAtdG8t ZGF0ZS4gVGhpcyBjYW4gaGFwcGVuIGluIHNpdHVhdGlvbnMgd2hlcmUKLSAgICAgICAgLy8gdGhl IGxheW91dCBiZWF0cyBhbnkgc29ydCBvZiBzdHlsZSByZWNhbGMgdXBkYXRlIHRoYXQgbmVlZHMg dG8gb2NjdXIuCi0gICAgICAgIGRvY3VtZW50LnVwZGF0ZVN0eWxlSWZOZWVkZWQoKTsKLSAgICAg ICAgLy8gSWYgdGhlcmUgaXMgb25seSBvbmUgcmVmIHRvIHRoaXMgdmlldyBsZWZ0LCB0aGVuIGl0 cyBnb2luZyB0byBiZSBkZXN0cm95ZWQgYXMgc29vbiBhcyB3ZSBleGl0LAotICAgICAgICAvLyBz byB0aGVyZSdzIG5vIHBvaW50IHRvIGNvbnRpbnVpbmcgdG8gbGF5b3V0CisgICAgICAgIGVuc3Vy ZVN0eWxlSXNVcFRvRGF0ZUZvckxheW91dCgpOwogICAgICAgICBpZiAoaGFzT25lUmVmKCkpCiAg ICAgICAgICAgICByZXR1cm47CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJh bWVWaWV3LmggYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5oCmluZGV4IDIyYmNhNjUx ZmFiMjJiMDI1ZGQ0Mjc4YjIwMWFjNDVmMjAwN2JiMTguLmIzNjU0ODRlZDE2ZjMyNmM2MDI5OTA4 M2ZlZDBiOTlkOWQwM2IwYTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVW aWV3LmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuaApAQCAtNzM3LDYgKzcz Nyw3IEBAIHByaXZhdGU6CiAgICAgdm9pZCBzZW5kUmVzaXplRXZlbnRJZk5lZWRlZCgpOwogCiAg ICAgdm9pZCBhZGp1c3RTY3JvbGxiYXJzRm9yTGF5b3V0KGJvb2wgZmlyc3RMYXlvdXQpOworICAg IHZvaWQgZW5zdXJlU3R5bGVJc1VwVG9EYXRlRm9yTGF5b3V0KCk7CiAKICAgICB2b2lkIGhhbmRs ZURlZmVycmVkU2Nyb2xsYmFyc1VwZGF0ZUFmdGVyRGlyZWN0aW9uQ2hhbmdlKCk7CiAK 324348 2017-10-19 21:22:43 -0700 2017-10-19 21:52:10 -0700 Patch bug-178558-20171019212242.patch text/plain 4573 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjIzNzQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTI0ODY3YTBhZDlmYjU2 NTZlYTY5NTBmMTE5NmZkZjcxZWMyZWJkYS4uZTI4NDg0ZjRkMzljN2Y0N2NjODBiMTRmYjQ0NGQ2 YjM4OTU4ZDNjNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE3LTEwLTE5ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0ZyYW1lVmlldzo6bGF5b3V0 IGNsZWFudXBdIE1vdmUgc3R5bGUgdXBkYXRlIHJlbGF0ZWQgbG9naWMgdG8gYSBzZXBhcmF0ZSBm dW5jdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTc4NTU4CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zNTA4ODIxOD4KKworICAgICAgICBSZXZp ZXdlZCBieSBTaW1vbiBGcmFzZXIuCisKKyAgICAgICAgTm8gY2hhbmdlIGluIGZ1bmN0aW9uYWxp dHkuCisKKyAgICAgICAgKiBwYWdlL0ZyYW1lVmlldy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpG cmFtZVZpZXc6OmVuc3VyZVN0eWxlSXNVcFRvRGF0ZUZvckxheW91dCk6CisgICAgICAgIChXZWJD b3JlOjpGcmFtZVZpZXc6OmxheW91dCk6CisgICAgICAgICogcGFnZS9GcmFtZVZpZXcuaDoKKwog MjAxNy0xMC0xOSAgSkYgQmFzdGllbiAgPGpmYmFzdGllbkBhcHBsZS5jb20+CiAKICAgICAgICAg V2ViQXNzZW1ibHk6IG5vIFZNIC8gSlMgdmVyc2lvbiBvZiBldmVyeXRoaW5nIGJ1dCBJbnN0YW5j ZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuY3BwIGIvU291cmNl L1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuY3BwCmluZGV4IGE0NmRmNjM3NzY1ZTU1NzVhYmVlNjM5 MDFlZDA5YzE5MTM0ODBmZTkuLmRkYjQ1N2I3OWVkN2M0OWY0ODVhOWUwMzM5YzZlZjlhYjNjM2Zl ODMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5jcHAKQEAgLTEzNjMsNiArMTM2MywyNiBAQCB2 b2lkIEZyYW1lVmlldzo6YWRqdXN0U2Nyb2xsYmFyc0ZvckxheW91dChib29sIGlzRmlyc3RMYXlv dXQpCiAgICAgICAgIHNldFNjcm9sbGJhck1vZGVzKGhNb2RlLCB2TW9kZSk7CiB9CiAKK3ZvaWQg RnJhbWVWaWV3Ojp1cGRhdGVTdHlsZUZvckxheW91dCgpCit7CisgICAgRG9jdW1lbnQmIGRvY3Vt ZW50ID0gKmZyYW1lKCkuZG9jdW1lbnQoKTsKKyAgICAvLyBWaWV3cG9ydC1kZXBlbmRlbnQgbWVk aWEgcXVlcmllcyBtYXkgY2F1c2UgdXMgdG8gbmVlZCBjb21wbGV0ZWx5IGRpZmZlcmVudCBzdHls ZSBpbmZvcm1hdGlvbi4KKyAgICBhdXRvKiBzdHlsZVJlc29sdmVyID0gZG9jdW1lbnQuc3R5bGVT Y29wZSgpLnJlc29sdmVySWZFeGlzdHMoKTsKKyAgICBpZiAoIXN0eWxlUmVzb2x2ZXIgfHwgc3R5 bGVSZXNvbHZlci0+aGFzTWVkaWFRdWVyaWVzQWZmZWN0ZWRCeVZpZXdwb3J0Q2hhbmdlKCkpIHsK KyAgICAgICAgTE9HKExheW91dCwgIiAgaGFzTWVkaWFRdWVyaWVzQWZmZWN0ZWRCeVZpZXdwb3J0 Q2hhbmdlLCBlbnF1ZXVlaW5nIHN0eWxlIHJlY2FsYyIpOworICAgICAgICBkb2N1bWVudC5zdHls ZVNjb3BlKCkuZGlkQ2hhbmdlU3R5bGVTaGVldEVudmlyb25tZW50KCk7CisgICAgICAgIC8vIEZJ WE1FOiBUaGlzIGluc3RydW1lbnRhdGlvbiBldmVudCBpcyBub3Qgc3RyaWN0bHkgYWNjdXJhdGUg c2luY2UgY2FjaGVkIG1lZGlhIHF1ZXJ5IHJlc3VsdHMgZG8gbm90IHBlcnNpc3QgYWNyb3NzIFN0 eWxlUmVzb2x2ZXIgcmVidWlsZHMuCisgICAgICAgIEluc3BlY3Rvckluc3RydW1lbnRhdGlvbjo6 bWVkaWFRdWVyeVJlc3VsdENoYW5nZWQoZG9jdW1lbnQpOworICAgIH0KKyAgICBkb2N1bWVudC5l dmFsdWF0ZU1lZGlhUXVlcnlMaXN0KCk7CisgICAgLy8gSWYgdGhlcmUgaXMgYW55IHBhZ2luYXRp b24gdG8gYXBwbHksIGl0IHdpbGwgYWZmZWN0IHRoZSBSZW5kZXJWaWV3J3Mgc3R5bGUsIHNvIHdl IHNob3VsZAorICAgIC8vIHRha2UgY2FyZSBvZiB0aGF0IG5vdy4KKyAgICBhcHBseVBhZ2luYXRp b25Ub1ZpZXdwb3J0KCk7CisgICAgLy8gQWx3YXlzIGVuc3VyZSBvdXIgc3R5bGUgaW5mbyBpcyB1 cC10by1kYXRlLiBUaGlzIGNhbiBoYXBwZW4gaW4gc2l0dWF0aW9ucyB3aGVyZQorICAgIC8vIHRo ZSBsYXlvdXQgYmVhdHMgYW55IHNvcnQgb2Ygc3R5bGUgcmVjYWxjIHVwZGF0ZSB0aGF0IG5lZWRz IHRvIG9jY3VyLgorICAgIGRvY3VtZW50LnVwZGF0ZVN0eWxlSWZOZWVkZWQoKTsKK30KKwogdm9p ZCBGcmFtZVZpZXc6OmxheW91dChib29sIGFsbG93U3VidHJlZUxheW91dCkKIHsKICAgICBBU1NF UlRfV0lUSF9TRUNVUklUWV9JTVBMSUNBVElPTighZnJhbWUoKS5kb2N1bWVudCgpLT5pblJlbmRl clRyZWVVcGRhdGUoKSk7CkBAIC0xNDIwLDIzICsxNDQwLDcgQEAgdm9pZCBGcmFtZVZpZXc6Omxh eW91dChib29sIGFsbG93U3VidHJlZUxheW91dCkKICAgICAgICAgaWYgKCFpc0xheW91dE5lc3Rl ZCgpICYmIG1fcG9zdExheW91dFRhc2tzVGltZXIuaXNBY3RpdmUoKSAmJiAhaXNJbkNoaWxkRnJh bWVXaXRoRnJhbWVGbGF0dGVuaW5nKCkpCiAgICAgICAgICAgICBwZXJmb3JtUG9zdExheW91dFRh c2tzKCk7CiAKLSAgICAgICAgLy8gVmlld3BvcnQtZGVwZW5kZW50IG1lZGlhIHF1ZXJpZXMgbWF5 IGNhdXNlIHVzIHRvIG5lZWQgY29tcGxldGVseSBkaWZmZXJlbnQgc3R5bGUgaW5mb3JtYXRpb24u Ci0gICAgICAgIGF1dG8qIHN0eWxlUmVzb2x2ZXIgPSBkb2N1bWVudC5zdHlsZVNjb3BlKCkucmVz b2x2ZXJJZkV4aXN0cygpOwotICAgICAgICBpZiAoIXN0eWxlUmVzb2x2ZXIgfHwgc3R5bGVSZXNv bHZlci0+aGFzTWVkaWFRdWVyaWVzQWZmZWN0ZWRCeVZpZXdwb3J0Q2hhbmdlKCkpIHsKLSAgICAg ICAgICAgIExPRyhMYXlvdXQsICIgIGhhc01lZGlhUXVlcmllc0FmZmVjdGVkQnlWaWV3cG9ydENo YW5nZSwgZW5xdWV1ZWluZyBzdHlsZSByZWNhbGMiKTsKLSAgICAgICAgICAgIGRvY3VtZW50LnN0 eWxlU2NvcGUoKS5kaWRDaGFuZ2VTdHlsZVNoZWV0RW52aXJvbm1lbnQoKTsKLSAgICAgICAgICAg IC8vIEZJWE1FOiBUaGlzIGluc3RydW1lbnRhdGlvbiBldmVudCBpcyBub3Qgc3RyaWN0bHkgYWNj dXJhdGUgc2luY2UgY2FjaGVkIG1lZGlhIHF1ZXJ5IHJlc3VsdHMgZG8gbm90IHBlcnNpc3QgYWNy b3NzIFN0eWxlUmVzb2x2ZXIgcmVidWlsZHMuCi0gICAgICAgICAgICBJbnNwZWN0b3JJbnN0cnVt ZW50YXRpb246Om1lZGlhUXVlcnlSZXN1bHRDaGFuZ2VkKGRvY3VtZW50KTsKLSAgICAgICAgfQot ICAgICAgICBkb2N1bWVudC5ldmFsdWF0ZU1lZGlhUXVlcnlMaXN0KCk7Ci0gICAgICAgIC8vIElm IHRoZXJlIGlzIGFueSBwYWdpbmF0aW9uIHRvIGFwcGx5LCBpdCB3aWxsIGFmZmVjdCB0aGUgUmVu ZGVyVmlldydzIHN0eWxlLCBzbyB3ZSBzaG91bGQKLSAgICAgICAgLy8gdGFrZSBjYXJlIG9mIHRo YXQgbm93LgotICAgICAgICBhcHBseVBhZ2luYXRpb25Ub1ZpZXdwb3J0KCk7Ci0gICAgICAgIC8v IEFsd2F5cyBlbnN1cmUgb3VyIHN0eWxlIGluZm8gaXMgdXAtdG8tZGF0ZS4gVGhpcyBjYW4gaGFw cGVuIGluIHNpdHVhdGlvbnMgd2hlcmUKLSAgICAgICAgLy8gdGhlIGxheW91dCBiZWF0cyBhbnkg c29ydCBvZiBzdHlsZSByZWNhbGMgdXBkYXRlIHRoYXQgbmVlZHMgdG8gb2NjdXIuCi0gICAgICAg IGRvY3VtZW50LnVwZGF0ZVN0eWxlSWZOZWVkZWQoKTsKLSAgICAgICAgLy8gSWYgdGhlcmUgaXMg b25seSBvbmUgcmVmIHRvIHRoaXMgdmlldyBsZWZ0LCB0aGVuIGl0cyBnb2luZyB0byBiZSBkZXN0 cm95ZWQgYXMgc29vbiBhcyB3ZSBleGl0LAotICAgICAgICAvLyBzbyB0aGVyZSdzIG5vIHBvaW50 IHRvIGNvbnRpbnVpbmcgdG8gbGF5b3V0CisgICAgICAgIHVwZGF0ZVN0eWxlRm9yTGF5b3V0KCk7 CiAgICAgICAgIGlmIChoYXNPbmVSZWYoKSkKICAgICAgICAgICAgIHJldHVybjsKIApkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuaCBiL1NvdXJjZS9XZWJDb3JlL3Bh Z2UvRnJhbWVWaWV3LmgKaW5kZXggMjJiY2E2NTFmYWIyMmIwMjVkZDQyNzhiMjAxYWM0NWYyMDA3 YmIxOC4uY2Y2YzEzYzFlNzNhOGZmYWU2ZGM5YjdmY2UwMDcwZjg2OWYwZWIzMiAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9w YWdlL0ZyYW1lVmlldy5oCkBAIC03MzcsNiArNzM3LDcgQEAgcHJpdmF0ZToKICAgICB2b2lkIHNl bmRSZXNpemVFdmVudElmTmVlZGVkKCk7CiAKICAgICB2b2lkIGFkanVzdFNjcm9sbGJhcnNGb3JM YXlvdXQoYm9vbCBmaXJzdExheW91dCk7CisgICAgdm9pZCB1cGRhdGVTdHlsZUZvckxheW91dCgp OwogCiAgICAgdm9pZCBoYW5kbGVEZWZlcnJlZFNjcm9sbGJhcnNVcGRhdGVBZnRlckRpcmVjdGlv bkNoYW5nZSgpOwogCg==