178544 2017-10-19 14:20:40 -0700 -Wsign-compare triggered by MallocBench 2017-11-15 13:01:39 -0800 1 1 1 Unclassified WebKit Tools / Tests Other PC Linux RESOLVED FIXED InRadar P2 Normal --- 1 mcatanzaro mcatanzaro buildbot cdumez commit-queue lforschler mcatanzaro rniwa webkit-bug-importer ysuzuki oldest_to_newest 1362327 0 mcatanzaro 2017-10-19 14:20:40 -0700 I see a warning now that MallocBench is enabled for Linux: In file included from ../../PerformanceTests/MallocBench/MallocBench/Interpreter.cpp:28:0: ../../PerformanceTests/MallocBench/MallocBench/Interpreter.cpp: In constructor ‘Interpreter::Interpreter(const char*, bool, bool)’: ../../PerformanceTests/MallocBench/MallocBench/Interpreter.cpp:64:35: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] assert(m_opCount * sizeof(Op) == buf.st_size); ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~ buf.st_size is an off_t, which is signed, so I think we should do static_cast<size_t>(buf.st_size). 1362330 1 324284 mcatanzaro 2017-10-19 14:22:55 -0700 Created attachment 324284 Patch 1362485 2 324284 commit-queue 2017-10-19 18:48:00 -0700 Comment on attachment 324284 Patch Clearing flags on attachment: 324284 Committed r223733: <https://trac.webkit.org/changeset/223733> 1362486 3 commit-queue 2017-10-19 18:48:02 -0700 All reviewed patches have been landed. Closing bug. 1372313 4 webkit-bug-importer 2017-11-15 13:01:39 -0800 <rdar://problem/35568633> 324284 2017-10-19 14:22:55 -0700 2017-10-19 18:48:00 -0700 Patch bug-178544-20171019162254.patch text/plain 1360 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjIzNjk5CmRpZmYgLS1naXQgYS9QZXJmb3JtYW5jZVRlc3Rz L0NoYW5nZUxvZyBiL1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCmluZGV4IDNmM2MzY2UwNDcz YTMxMDA1YmZkMmEzMDczYWJlZTg2ODE2ZWM5ZmQuLjJjZWRjMDgyYTg0NjlhOTdkZGMwODAwMDNh ZWE2MWEyY2I1NzRlYzMgMTAwNjQ0Ci0tLSBhL1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCisr KyBiL1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTctMTAt MTkgIE1pY2hhZWwgQ2F0YW56YXJvICA8bWNhdGFuemFyb0BpZ2FsaWEuY29tPgorCisgICAgICAg IC1Xc2lnbi1jb21wYXJlIHRyaWdnZXJlZCBieSBNYWxsb2NCZW5jaAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc4NTQ0CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBNYWxsb2NCZW5jaC9NYWxsb2NCZW5j aC9JbnRlcnByZXRlci5jcHA6CisgICAgICAgIChJbnRlcnByZXRlcjo6SW50ZXJwcmV0ZXIpOgor CiAyMDE3LTEwLTA3ICBZdXN1a2UgU3V6dWtpICA8dXRhdGFuZS50ZWFAZ21haWwuY29tPgogCiAg ICAgICAgIFVucmV2aWV3ZWQsIGJ1aWxkIGZpeCBmb3IgTWFsbG9jQmVuY2ggaW4gTGludXggMzJi aXQKZGlmZiAtLWdpdCBhL1BlcmZvcm1hbmNlVGVzdHMvTWFsbG9jQmVuY2gvTWFsbG9jQmVuY2gv SW50ZXJwcmV0ZXIuY3BwIGIvUGVyZm9ybWFuY2VUZXN0cy9NYWxsb2NCZW5jaC9NYWxsb2NCZW5j aC9JbnRlcnByZXRlci5jcHAKaW5kZXggNTg1ZDUyZjJjNGRhNzMyMDY2NzdlM2I1ZWYwMzg0Mzhh MTk0NWMzYS4uNTZlZjgyMjUwMzBjZjI1MzFmMWU2NTk1MTBiNWRiMDUwYWUxZWFkMiAxMDA2NDQK LS0tIGEvUGVyZm9ybWFuY2VUZXN0cy9NYWxsb2NCZW5jaC9NYWxsb2NCZW5jaC9JbnRlcnByZXRl ci5jcHAKKysrIGIvUGVyZm9ybWFuY2VUZXN0cy9NYWxsb2NCZW5jaC9NYWxsb2NCZW5jaC9JbnRl cnByZXRlci5jcHAKQEAgLTYxLDcgKzYxLDcgQEAgSW50ZXJwcmV0ZXI6OkludGVycHJldGVyKGNv bnN0IGNoYXIqIGZpbGVOYW1lLCBib29sIHNob3VsZEZyZWVBbGxPYmplY3RzLCBib29sIHUKICAg ICBmc3RhdChtX2ZkLCAmYnVmKTsKIAogICAgIG1fb3BDb3VudCA9IGJ1Zi5zdF9zaXplIC8gc2l6 ZW9mKE9wKTsKLSAgICBhc3NlcnQobV9vcENvdW50ICogc2l6ZW9mKE9wKSA9PSBidWYuc3Rfc2l6 ZSk7CisgICAgYXNzZXJ0KG1fb3BDb3VudCAqIHNpemVvZihPcCkgPT0gc3RhdGljX2Nhc3Q8c2l6 ZV90PihidWYuc3Rfc2l6ZSkpOwogCiAgICAgc2l6ZV90IG1heFNsb3QgPSAwOwogCg==