178529 2017-10-19 12:08:27 -0700 Turn various poly proto RELEASE_ASSERTs into ASSERTs because they're on the hot path in speedometer 2017-11-15 13:02:52 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 saam saam benjamin commit-queue fpizlo ggaren gskachkov jfbastien keith_miller mark.lam msaboff rmorisset ticaiolima webkit-bug-importer ysuzuki oldest_to_newest 1362242 0 saam 2017-10-19 12:08:27 -0700 ... 1362246 1 324260 saam 2017-10-19 12:12:59 -0700 Created attachment 324260 patch 1362249 2 324260 mark.lam 2017-10-19 12:13:57 -0700 Comment on attachment 324260 patch r=me 1362306 3 324260 commit-queue 2017-10-19 13:45:58 -0700 Comment on attachment 324260 patch Clearing flags on attachment: 324260 Committed r223709: <https://trac.webkit.org/changeset/223709> 1362307 4 commit-queue 2017-10-19 13:45:59 -0700 All reviewed patches have been landed. Closing bug. 1372331 5 webkit-bug-importer 2017-11-15 13:02:52 -0800 <rdar://problem/35568679> 324260 2017-10-19 12:12:59 -0700 2017-10-19 13:45:58 -0700 patch c-backup.diff text/plain 4967 saam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjIzNjk5KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBA CisyMDE3LTEwLTE5ICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAg IFR1cm4gdmFyaW91cyBwb2x5IHByb3RvIFJFTEVBU0VfQVNTRVJUcyBpbnRvIEFTU0VSVHMgYmVj YXVzZSB0aGV5J3JlIG9uIHRoZSBob3QgcGF0aCBpbiBzcGVlZG9tZXRlcgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc4NTI5CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBydW50aW1lL1N0cnVjdHVyZS5o OgorICAgICAgICAqIHJ1bnRpbWUvU3RydWN0dXJlSW5saW5lcy5oOgorICAgICAgICAoSlNDOjpT dHJ1Y3R1cmU6OnN0b3JlZFByb3RvdHlwZU9iamVjdCBjb25zdCk6CisgICAgICAgIChKU0M6OlN0 cnVjdHVyZTo6c3RvcmVkUHJvdG90eXBlU3RydWN0dXJlIGNvbnN0KToKKyAgICAgICAgKEpTQzo6 U3RydWN0dXJlOjpzdG9yZWRQcm90b3R5cGUgY29uc3QpOgorICAgICAgICAoSlNDOjpTdHJ1Y3R1 cmU6OnByb3RvdHlwZUZvckxvb2t1cCBjb25zdCk6CisgICAgICAgIChKU0M6OlN0cnVjdHVyZTo6 cHJvdG90eXBlQ2hhaW4gY29uc3QpOgorCiAyMDE3LTEwLTE5ICBSb2JpbiBNb3Jpc3NldCAgPHJt b3Jpc3NldEBhcHBsZS5jb20+CiAKICAgICAgICAgVHVybiByZWN1cnNpdmUgdGFpbCBjYWxscyBp bnRvIGxvb3BzCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9TdHJ1Y3R1cmUu aAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9TdHJ1Y3R1cmUu aAkocmV2aXNpb24gMjIzNjkzKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvU3Ry dWN0dXJlLmgJKHdvcmtpbmcgY29weSkKQEAgLTI2MiwyMiArMjYyLDIyIEBAIHB1YmxpYzoKICAg ICAvLyBvYmplY3Qgb2YgYSBzdHJ1Y3R1cmUgaXMgcHJlc3VtZWQgdG8gYmUgaW1tdXRhYmxlIGlu IGEgYnVuY2ggb2YgcGxhY2VzLgogICAgIHZvaWQgc2V0R2xvYmFsT2JqZWN0KFZNJiB2bSwgSlNH bG9iYWxPYmplY3QqIGdsb2JhbE9iamVjdCkgeyBtX2dsb2JhbE9iamVjdC5zZXQodm0sIHRoaXMs IGdsb2JhbE9iamVjdCk7IH0KIAotICAgIGJvb2wgaGFzTW9ub1Byb3RvKCkgY29uc3QKKyAgICBB TFdBWVNfSU5MSU5FIGJvb2wgaGFzTW9ub1Byb3RvKCkgY29uc3QKICAgICB7CiAgICAgICAgIHJl dHVybiAhbV9wcm90b3R5cGUuZ2V0KCkuaXNJbnQzMigpOwogICAgIH0KLSAgICBib29sIGhhc1Bv bHlQcm90bygpIGNvbnN0CisgICAgQUxXQVlTX0lOTElORSBib29sIGhhc1BvbHlQcm90bygpIGNv bnN0CiAgICAgewogICAgICAgICByZXR1cm4gIWhhc01vbm9Qcm90bygpOwogICAgIH0KLSAgICBK U1ZhbHVlIHN0b3JlZFByb3RvdHlwZSgpIGNvbnN0CisgICAgQUxXQVlTX0lOTElORSBKU1ZhbHVl IHN0b3JlZFByb3RvdHlwZSgpIGNvbnN0CiAgICAgewotICAgICAgICBSRUxFQVNFX0FTU0VSVCho YXNNb25vUHJvdG8oKSk7CisgICAgICAgIEFTU0VSVChoYXNNb25vUHJvdG8oKSk7CiAgICAgICAg IHJldHVybiBtX3Byb3RvdHlwZS5nZXQoKTsKICAgICB9Ci0gICAgUHJvcGVydHlPZmZzZXQgcG9s eVByb3RvT2Zmc2V0KCkgY29uc3QKKyAgICBBTFdBWVNfSU5MSU5FIFByb3BlcnR5T2Zmc2V0IHBv bHlQcm90b09mZnNldCgpIGNvbnN0CiAgICAgewotICAgICAgICBSRUxFQVNFX0FTU0VSVChoYXNQ b2x5UHJvdG8oKSk7CisgICAgICAgIEFTU0VSVChoYXNQb2x5UHJvdG8oKSk7CiAgICAgICAgIHJl dHVybiBtX3Byb3RvdHlwZS5nZXQoKS5hc0ludDMyKCk7CiAgICAgfQogICAgIEpTVmFsdWUgc3Rv cmVkUHJvdG90eXBlKGNvbnN0IEpTT2JqZWN0KikgY29uc3Q7CkluZGV4OiBTb3VyY2UvSmF2YVNj cmlwdENvcmUvcnVudGltZS9TdHJ1Y3R1cmVJbmxpbmVzLmgKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvU3RydWN0dXJlSW5saW5lcy5oCShyZXZpc2lvbiAyMjM2 OTMpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9TdHJ1Y3R1cmVJbmxpbmVzLmgJ KHdvcmtpbmcgY29weSkKQEAgLTYxLDcgKzYxLDcgQEAgaW5saW5lIFN0cnVjdHVyZSogU3RydWN0 dXJlOjpjcmVhdGUoVk0mIAogCiBpbmxpbmUgSlNPYmplY3QqIFN0cnVjdHVyZTo6c3RvcmVkUHJv dG90eXBlT2JqZWN0KCkgY29uc3QKIHsKLSAgICBSRUxFQVNFX0FTU0VSVChoYXNNb25vUHJvdG8o KSk7CisgICAgQVNTRVJUKGhhc01vbm9Qcm90bygpKTsKICAgICBKU1ZhbHVlIHZhbHVlID0gbV9w cm90b3R5cGUuZ2V0KCk7CiAgICAgaWYgKHZhbHVlLmlzTnVsbCgpKQogICAgICAgICByZXR1cm4g bnVsbHB0cjsKQEAgLTcwLDcgKzcwLDcgQEAgaW5saW5lIEpTT2JqZWN0KiBTdHJ1Y3R1cmU6OnN0 b3JlZFByb3RvdAogCiBpbmxpbmUgU3RydWN0dXJlKiBTdHJ1Y3R1cmU6OnN0b3JlZFByb3RvdHlw ZVN0cnVjdHVyZSgpIGNvbnN0CiB7Ci0gICAgUkVMRUFTRV9BU1NFUlQoaGFzTW9ub1Byb3RvKCkp OworICAgIEFTU0VSVChoYXNNb25vUHJvdG8oKSk7CiAgICAgSlNPYmplY3QqIG9iamVjdCA9IHN0 b3JlZFByb3RvdHlwZU9iamVjdCgpOwogICAgIGlmICghb2JqZWN0KQogICAgICAgICByZXR1cm4g bnVsbHB0cjsKQEAgLTc5LDE3ICs3OSwxNyBAQCBpbmxpbmUgU3RydWN0dXJlKiBTdHJ1Y3R1cmU6 OnN0b3JlZFByb3RvCiAKIEFMV0FZU19JTkxJTkUgSlNWYWx1ZSBTdHJ1Y3R1cmU6OnN0b3JlZFBy b3RvdHlwZShjb25zdCBKU09iamVjdCogb2JqZWN0KSBjb25zdAogewotICAgIFJFTEVBU0VfQVNT RVJUKG9iamVjdC0+c3RydWN0dXJlKCkgPT0gdGhpcyk7CisgICAgQVNTRVJUKG9iamVjdC0+c3Ry dWN0dXJlKCkgPT0gdGhpcyk7CiAgICAgaWYgKGhhc01vbm9Qcm90bygpKQogICAgICAgICByZXR1 cm4gc3RvcmVkUHJvdG90eXBlKCk7Ci0gICAgUkVMRUFTRV9BU1NFUlQobV9wcm90b3R5cGUuZ2V0 KCkuaXNJbnQzMigpKTsKKyAgICBBU1NFUlQobV9wcm90b3R5cGUuZ2V0KCkuaXNJbnQzMigpKTsK ICAgICBQcm9wZXJ0eU9mZnNldCBvZmZzZXQgPSBtX3Byb3RvdHlwZS5nZXQoKS5hc0ludDMyKCk7 CiAgICAgcmV0dXJuIG9iamVjdC0+Z2V0RGlyZWN0KG9mZnNldCk7CiB9CiAKIEFMV0FZU19JTkxJ TkUgSlNPYmplY3QqIFN0cnVjdHVyZTo6c3RvcmVkUHJvdG90eXBlT2JqZWN0KGNvbnN0IEpTT2Jq ZWN0KiBvYmplY3QpIGNvbnN0CiB7Ci0gICAgUkVMRUFTRV9BU1NFUlQob2JqZWN0LT5zdHJ1Y3R1 cmUoKSA9PSB0aGlzKTsKKyAgICBBU1NFUlQob2JqZWN0LT5zdHJ1Y3R1cmUoKSA9PSB0aGlzKTsK ICAgICBpZiAoaGFzTW9ub1Byb3RvKCkpCiAgICAgICAgIHJldHVybiBzdG9yZWRQcm90b3R5cGVP YmplY3QoKTsKICAgICBKU1ZhbHVlIHByb3RvID0gb2JqZWN0LT5nZXREaXJlY3QocG9seVByb3Rv T2Zmc2V0KCkpOwpAQCAtMjEwLDcgKzIxMCw3IEBAIEFMV0FZU19JTkxJTkUgSlNWYWx1ZSBwcm90 b3R5cGVGb3JMb29rdXAKIAogaW5saW5lIEpTVmFsdWUgU3RydWN0dXJlOjpwcm90b3R5cGVGb3JM b29rdXAoSlNHbG9iYWxPYmplY3QqIGdsb2JhbE9iamVjdCkgY29uc3QKIHsKLSAgICBSRUxFQVNF X0FTU0VSVChoYXNNb25vUHJvdG8oKSk7CisgICAgQVNTRVJUKGhhc01vbm9Qcm90bygpKTsKICAg ICBpZiAoaXNPYmplY3QoKSkKICAgICAgICAgcmV0dXJuIHN0b3JlZFByb3RvdHlwZSgpOwogICAg IHJldHVybiBwcm90b3R5cGVGb3JMb29rdXBQcmltaXRpdmVJbXBsKGdsb2JhbE9iamVjdCwgdGhp cyk7CkBAIC0yMTgsNyArMjE4LDcgQEAgaW5saW5lIEpTVmFsdWUgU3RydWN0dXJlOjpwcm90b3R5 cGVGb3JMbwogCiBpbmxpbmUgSlNWYWx1ZSBTdHJ1Y3R1cmU6OnByb3RvdHlwZUZvckxvb2t1cChK U0dsb2JhbE9iamVjdCogZ2xvYmFsT2JqZWN0LCBKU0NlbGwqIGJhc2UpIGNvbnN0CiB7Ci0gICAg UkVMRUFTRV9BU1NFUlQoYmFzZS0+c3RydWN0dXJlKCkgPT0gdGhpcyk7CisgICAgQVNTRVJUKGJh c2UtPnN0cnVjdHVyZSgpID09IHRoaXMpOwogICAgIGlmIChpc09iamVjdCgpKQogICAgICAgICBy ZXR1cm4gc3RvcmVkUHJvdG90eXBlKGFzT2JqZWN0KGJhc2UpKTsKICAgICByZXR1cm4gcHJvdG90 eXBlRm9yTG9va3VwUHJpbWl0aXZlSW1wbChnbG9iYWxPYmplY3QsIHRoaXMpOwpAQCAtMjI2LDcg KzIyNiw3IEBAIGlubGluZSBKU1ZhbHVlIFN0cnVjdHVyZTo6cHJvdG90eXBlRm9yTG8KIAogaW5s aW5lIFN0cnVjdHVyZUNoYWluKiBTdHJ1Y3R1cmU6OnByb3RvdHlwZUNoYWluKFZNJiB2bSwgSlNH bG9iYWxPYmplY3QqIGdsb2JhbE9iamVjdCwgSlNPYmplY3QqIGJhc2UpIGNvbnN0CiB7Ci0gICAg UkVMRUFTRV9BU1NFUlQoYmFzZS0+c3RydWN0dXJlKHZtKSA9PSB0aGlzKTsKKyAgICBBU1NFUlQo YmFzZS0+c3RydWN0dXJlKHZtKSA9PSB0aGlzKTsKICAgICAvLyBXZSBjYWNoZSBvdXIgcHJvdG90 eXBlIGNoYWluIHNvIG91ciBjbGllbnRzIGNhbiBzaGFyZSBpdC4KICAgICBpZiAoIWlzVmFsaWQo Z2xvYmFsT2JqZWN0LCBtX2NhY2hlZFByb3RvdHlwZUNoYWluLmdldCgpLCBiYXNlKSkgewogICAg ICAgICBKU1ZhbHVlIHByb3RvdHlwZSA9IHByb3RvdHlwZUZvckxvb2t1cChnbG9iYWxPYmplY3Qs IGJhc2UpOwo=