178518 2017-10-19 09:34:57 -0700 [FrameView::layout cleanup] Do not reenter FrameView::performPostLayoutTasks 2017-10-19 11:39:44 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham commit-queue koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1362172 0 zalan 2017-10-19 09:34:57 -0700 We already do it in a less strict way. 1362173 1 webkit-bug-importer 2017-10-19 09:37:04 -0700 <rdar://problem/35075409> 1362177 2 324242 zalan 2017-10-19 09:42:18 -0700 Created attachment 324242 Patch 1362219 3 324242 commit-queue 2017-10-19 11:39:43 -0700 Comment on attachment 324242 Patch Clearing flags on attachment: 324242 Committed r223696: <https://trac.webkit.org/changeset/223696> 1362220 4 commit-queue 2017-10-19 11:39:44 -0700 All reviewed patches have been landed. Closing bug. 324242 2017-10-19 09:42:18 -0700 2017-10-19 11:39:43 -0700 Patch bug-178518-20171019094217.patch text/plain 5301 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjIzNjg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjkyODdkNTg1ZDZlNDY5 YjIxNjJhMzdkZTk4YTI2ZDE1Yzc3NWJhMi4uNzg0NzI1MTI2YWFjNDZhM2M3MDAxZDk2ZTgyNWMz ODUzZjM0MzdkMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI0IEBACiAyMDE3LTEwLTE5ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CiAKKyAgICAgICAgW0ZyYW1lVmlldzo6bGF5b3V0 IGNsZWFudXBdIERvIG5vdCByZWVudGVyIEZyYW1lVmlldzo6cGVyZm9ybVBvc3RMYXlvdXRUYXNr cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc4NTE4 CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zNTA3NTQwOT4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIHBhdGNoIHRpZ2h0ZW5zIGV4aXN0aW5n IHJlZW50cmFuY3kgcG9saWN5IG9uIHBlcmZvcm1Qb3N0TGF5b3V0VGFza3MuCisKKyAgICAgICAg Q292ZXJlZCBieSBleGlzdGluZyB0ZXN0IGNhc2VzLgorCisgICAgICAgICogcGFnZS9GcmFtZVZp ZXcuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RnJhbWVWaWV3OjpGcmFtZVZpZXcpOgorICAgICAg ICAoV2ViQ29yZTo6RnJhbWVWaWV3OjpyZXNldCk6CisgICAgICAgIChXZWJDb3JlOjpGcmFtZVZp ZXc6OmxheW91dCk6CisgICAgICAgIChXZWJDb3JlOjpGcmFtZVZpZXc6OnBlcmZvcm1Qb3N0TGF5 b3V0VGFza3MpOgorICAgICAgICAqIHBhZ2UvRnJhbWVWaWV3Lmg6CisKKzIwMTctMTAtMTkgIFph bGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KKwogICAgICAgICBbRnJhbWVWaWV3OjpsYXlv dXQgY2xlYW51cF0gUmVwbGFjZSBtX25lc3RlZExheW91dENvdW50IHdpdGggaXNMYXlvdXROZXN0 ZWQoKQogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc4 NTAzCiAgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zNTA2NjU2MT4KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVW aWV3LmNwcAppbmRleCBkODlkODk4MTEyZWNkYjk1ZjFjYTkzOGUzZTBmNDVjYWQ0YTdjODM1Li44 ODM5YTNlODc0MWEyOTFiYjRkYjZhY2E0ZDc4NmE2NzVlMmI3NWM4IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9G cmFtZVZpZXcuY3BwCkBAIC0yNDIsNyArMjQyLDYgQEAgRnJhbWVWaWV3OjpGcmFtZVZpZXcoRnJh bWUmIGZyYW1lKQogICAgICwgbV9jYW5IYXZlU2Nyb2xsYmFycyh0cnVlKQogICAgICwgbV9sYXlv dXRUaW1lcigqdGhpcywgJkZyYW1lVmlldzo6bGF5b3V0VGltZXJGaXJlZCkKICAgICAsIG1fbGF5 b3V0UGhhc2UoT3V0c2lkZUxheW91dCkKLSAgICAsIG1faW5TeW5jaHJvbm91c1Bvc3RMYXlvdXQo ZmFsc2UpCiAgICAgLCBtX3Bvc3RMYXlvdXRUYXNrc1RpbWVyKCp0aGlzLCAmRnJhbWVWaWV3Ojpw ZXJmb3JtUG9zdExheW91dFRhc2tzKQogICAgICwgbV91cGRhdGVFbWJlZGRlZE9iamVjdHNUaW1l cigqdGhpcywgJkZyYW1lVmlldzo6dXBkYXRlRW1iZWRkZWRPYmplY3RzVGltZXJGaXJlZCkKICAg ICAsIG1faXNUcmFuc3BhcmVudChmYWxzZSkKQEAgLTM0MSw3ICszNDAsNiBAQCB2b2lkIEZyYW1l Vmlldzo6cmVzZXQoKQogICAgIG1fbmVlZHNGdWxsUmVwYWludCA9IHRydWU7CiAgICAgbV9sYXlv dXRTY2hlZHVsaW5nRW5hYmxlZCA9IHRydWU7CiAgICAgbV9sYXlvdXRQaGFzZSA9IE91dHNpZGVM YXlvdXQ7Ci0gICAgbV9pblN5bmNocm9ub3VzUG9zdExheW91dCA9IGZhbHNlOwogICAgIG1fbGF5 b3V0Q291bnQgPSAwOwogICAgIG1fcG9zdExheW91dFRhc2tzVGltZXIuc3RvcCgpOwogICAgIG1f dXBkYXRlRW1iZWRkZWRPYmplY3RzVGltZXIuc3RvcCgpOwpAQCAtMTM5NSwxMyArMTM5Myw5IEBA IHZvaWQgRnJhbWVWaWV3OjpsYXlvdXQoYm9vbCBhbGxvd1N1YnRyZWVMYXlvdXQpCiAgICAgYm9v bCBpc1N1YnRyZWVMYXlvdXQgPSBmYWxzZTsKICAgICB7CiAgICAgICAgIFNldEZvclNjb3BlPGJv b2w+IGNoYW5nZVNjaGVkdWxpbmdFbmFibGVkKG1fbGF5b3V0U2NoZWR1bGluZ0VuYWJsZWQsIGZh bHNlKTsKLQotICAgICAgICBpZiAoIWlzTGF5b3V0TmVzdGVkKCkgJiYgIW1faW5TeW5jaHJvbm91 c1Bvc3RMYXlvdXQgJiYgbV9wb3N0TGF5b3V0VGFza3NUaW1lci5pc0FjdGl2ZSgpICYmICFpc0lu Q2hpbGRGcmFtZVdpdGhGcmFtZUZsYXR0ZW5pbmcoKSkgewotICAgICAgICAgICAgLy8gVGhpcyBp cyBhIG5ldyB0b3AtbGV2ZWwgbGF5b3V0LiBJZiB0aGVyZSBhcmUgYW55IHJlbWFpbmluZyB0YXNr cyBmcm9tIHRoZSBwcmV2aW91cwotICAgICAgICAgICAgLy8gbGF5b3V0LCBmaW5pc2ggdGhlbSBu b3cuCi0gICAgICAgICAgICBTZXRGb3JTY29wZTxib29sPiBpblN5bmNocm9ub3VzUG9zdExheW91 dENoYW5nZShtX2luU3luY2hyb25vdXNQb3N0TGF5b3V0LCB0cnVlKTsKKyAgICAgICAgLy8gSWYg dGhpcyBpcyBhIG5ldyB0b3AtbGV2ZWwgbGF5b3V0IGFuZCB0aGVyZSBhcmUgYW55IHJlbWFpbmlu ZyB0YXNrcyBmcm9tIHRoZSBwcmV2aW91cyBsYXlvdXQsIGZpbmlzaCB0aGVtIG5vdy4KKyAgICAg ICAgaWYgKCFpc0xheW91dE5lc3RlZCgpICYmIG1fcG9zdExheW91dFRhc2tzVGltZXIuaXNBY3Rp dmUoKSAmJiAhaXNJbkNoaWxkRnJhbWVXaXRoRnJhbWVGbGF0dGVuaW5nKCkpCiAgICAgICAgICAg ICBwZXJmb3JtUG9zdExheW91dFRhc2tzKCk7Ci0gICAgICAgIH0KIAogICAgICAgICAvLyBWaWV3 cG9ydC1kZXBlbmRlbnQgbWVkaWEgcXVlcmllcyBtYXkgY2F1c2UgdXMgdG8gbmVlZCBjb21wbGV0 ZWx5IGRpZmZlcmVudCBzdHlsZSBpbmZvcm1hdGlvbi4KICAgICAgICAgYXV0byogc3R5bGVSZXNv bHZlciA9IGRvY3VtZW50LnN0eWxlU2NvcGUoKS5yZXNvbHZlcklmRXhpc3RzKCk7CkBAIC0xNTUz LDE2ICsxNTQ3LDE0IEBAIHZvaWQgRnJhbWVWaWV3OjpsYXlvdXQoYm9vbCBhbGxvd1N1YnRyZWVM YXlvdXQpCiAgICAgZnJhbWUoKS5kb2N1bWVudCgpLT5tYXJrZXJzKCkuaW52YWxpZGF0ZVJlY3Rz Rm9yQWxsTWFya2VycygpOwogCiAgICAgaWYgKCFtX3Bvc3RMYXlvdXRUYXNrc1RpbWVyLmlzQWN0 aXZlKCkpIHsKLSAgICAgICAgaWYgKCFtX2luU3luY2hyb25vdXNQb3N0TGF5b3V0KSB7CisgICAg ICAgIGlmICghbV9pblBlcmZvcm1Qb3N0TGF5b3V0VGFza3MpIHsKICAgICAgICAgICAgIGlmIChp c0luQ2hpbGRGcmFtZVdpdGhGcmFtZUZsYXR0ZW5pbmcoKSkKICAgICAgICAgICAgICAgICB1cGRh dGVXaWRnZXRQb3NpdGlvbnMoKTsKLSAgICAgICAgICAgIGVsc2UgewotICAgICAgICAgICAgICAg IFNldEZvclNjb3BlPGJvb2w+IGluU3luY2hyb25vdXNQb3N0TGF5b3V0Q2hhbmdlKG1faW5TeW5j aHJvbm91c1Bvc3RMYXlvdXQsIHRydWUpOworICAgICAgICAgICAgZWxzZQogICAgICAgICAgICAg ICAgIHBlcmZvcm1Qb3N0TGF5b3V0VGFza3MoKTsgLy8gQ2FsbHMgcmVzdW1lU2NoZWR1bGVkRXZl bnRzKCkuCi0gICAgICAgICAgICB9CiAgICAgICAgIH0KIAotICAgICAgICBpZiAoIW1fcG9zdExh eW91dFRhc2tzVGltZXIuaXNBY3RpdmUoKSAmJiAobmVlZHNMYXlvdXQoKSB8fCBtX2luU3luY2hy b25vdXNQb3N0TGF5b3V0IHx8IGlzSW5DaGlsZEZyYW1lV2l0aEZyYW1lRmxhdHRlbmluZygpKSkg eworICAgICAgICBpZiAoIW1fcG9zdExheW91dFRhc2tzVGltZXIuaXNBY3RpdmUoKSAmJiAobmVl ZHNMYXlvdXQoKSB8fCBtX2luUGVyZm9ybVBvc3RMYXlvdXRUYXNrcyB8fCBpc0luQ2hpbGRGcmFt ZVdpdGhGcmFtZUZsYXR0ZW5pbmcoKSkpIHsKICAgICAgICAgICAgIC8vIElmIHdlIG5lZWQgbGF5 b3V0IG9yIGFyZSBhbHJlYWR5IGluIGEgc3luY2hyb25vdXMgY2FsbCB0byBwb3N0TGF5b3V0VGFz a3MoKSwgCiAgICAgICAgICAgICAvLyBkZWZlciB3aWRnZXQgdXBkYXRlcyBhbmQgZXZlbnQgZGlz cGF0Y2ggdW50aWwgYWZ0ZXIgd2UgcmV0dXJuLiBwb3N0TGF5b3V0VGFza3MoKQogICAgICAgICAg ICAgLy8gY2FuIG1ha2UgdXMgbmVlZCB0byB1cGRhdGUgYWdhaW4sIGFuZCB3ZSBjYW4gZ2V0IHN0 dWNrIGluIGEgbmFzdHkgY3ljbGUgdW5sZXNzCkBAIC0zNTAxLDYgKzM0OTMsMTAgQEAgdm9pZCBG cmFtZVZpZXc6OmZsdXNoUG9zdExheW91dFRhc2tzUXVldWUoKQogCiB2b2lkIEZyYW1lVmlldzo6 cGVyZm9ybVBvc3RMYXlvdXRUYXNrcygpCiB7CisgICAgaWYgKG1faW5QZXJmb3JtUG9zdExheW91 dFRhc2tzKQorICAgICAgICByZXR1cm47CisKKyAgICBTZXRGb3JTY29wZTxib29sPiBpblBlcmZv cm1Qb3N0TGF5b3V0VGFza3MobV9pblBlcmZvcm1Qb3N0TGF5b3V0VGFza3MsIHRydWUpOwogICAg IC8vIEZJWE1FOiBXZSBzaG91bGQgbm90IHJ1biBhbnkgSmF2YVNjcmlwdCBjb2RlIGluIHRoaXMg ZnVuY3Rpb24uCiAgICAgTE9HKExheW91dCwgIkZyYW1lVmlldyAlcCBwZXJmb3JtUG9zdExheW91 dFRhc2tzIiwgdGhpcyk7CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVW aWV3LmggYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5oCmluZGV4IDJiOGQ2ZGU5MDhk MGY2ZmUxOTdkMTJmZDlmOWYzMjViNjY3ZmE3N2YuLjhhYzBlNWYyYTM4YThkYmIwNjk0ODhmYjY5 NmIzNzcwZDQ2YzY5MWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3 LmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuaApAQCAtODA1LDcgKzgwNSw3 IEBAIHByaXZhdGU6CiAKICAgICBMYXlvdXRQaGFzZSBtX2xheW91dFBoYXNlOwogICAgIGJvb2wg bV9sYXlvdXRTY2hlZHVsaW5nRW5hYmxlZDsKLSAgICBib29sIG1faW5TeW5jaHJvbm91c1Bvc3RM YXlvdXQ7CisgICAgYm9vbCBtX2luUGVyZm9ybVBvc3RMYXlvdXRUYXNrcyB7IGZhbHNlIH07CiAg ICAgaW50IG1fbGF5b3V0Q291bnQ7CiAgICAgZW51bSBjbGFzcyBMYXlvdXROZXN0ZWRTdGF0ZSB7 IE5vdEluTGF5b3V0LCBOb3ROZXN0ZWQsIE5lc3RlZCB9OwogICAgIExheW91dE5lc3RlZFN0YXRl IG1fbGF5b3V0TmVzdGVkU3RhdGUgeyBMYXlvdXROZXN0ZWRTdGF0ZTo6Tm90SW5MYXlvdXQgfTsK