178517 2017-10-19 08:40:10 -0700 [Win] The number of webkit-patch iterations on EWS should be configurable. 2017-12-06 16:47:08 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pvollan pvollan achristensen ap bfulgham commit-queue darin lforschler webkit-bug-importer oldest_to_newest 1362151 0 pvollan 2017-10-19 08:40:10 -0700 Currently, it is set to 10. 1362155 1 324239 pvollan 2017-10-19 08:45:39 -0700 Created attachment 324239 Patch 1362164 2 ap 2017-10-19 09:15:36 -0700 Why is this desirable? With this change, we'll need to manually change each bot in order to change the count, which will be more work and more error prone than how it works now. 1362178 3 pvollan 2017-10-19 09:44:45 -0700 (In reply to Alexey Proskuryakov from comment #2) > Why is this desirable? With this change, we'll need to manually change each > bot in order to change the count, which will be more work and more error > prone than how it works now. I have seen the webkit-patch script get stuck on EWS a couple of times, so this is an attempt to avoid that by setting the webkit-patch iteration to a lower value than what it currently is. Alternatively, we could just set it to 1. What do you think? 1362180 4 ap 2017-10-19 09:52:40 -0700 This count just affects how frequently EWS updates its code, and re-runs webkitpy tests. I don't think that it's likely that changing the number will help with bots getting stuck. Perhaps you are seeing rdar://problem/35074576? 1362183 5 pvollan 2017-10-19 09:58:56 -0700 (In reply to Alexey Proskuryakov from comment #4) > This count just affects how frequently EWS updates its code, and re-runs > webkitpy tests. I don't think that it's likely that changing the number will > help with bots getting stuck. > > Perhaps you are seeing rdar://problem/35074576? That could very well be the case. I also found this python crash log on one of the stuck EWS bots: SIGTERM signal receivedTraceback(most recent call last): File "/home/buildbot/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 456, in <module> sys.exit(main(sys.argv[1:], sys.stdout, sys.stderr)) File "/home/buildbot/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 89, in main run_details = run(port, options, args, stderr) File "/home/buildbot/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 449, in run run_details = manager.run(args) File "/home/buildbot/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py", line 249, in run initial_results, retry_results, enabled_pixel_tests_in_retry = self._run_test_subset(default_device_tests, tests_to_skip) File "/home/buildbot/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py", line 273, in _run_test_subset initial_results = self._run_tests(tests_to_run, tests_to_skip, self._options.repeat_each, self._options.iterations, int(self._options.child_processes), retrying=False) File "/home/buildbot/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py", line 330, in _run_tests return self._runner.run_tests(self._expectations, test_inputs, tests_to_skip, num_workers, retrying) File "/home/buildbot/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py", line 123, in run_tests pool.run(('test_list', shard.name, shard.test_inputs) for shard in all_shards) File "/home/buildbot/WebKit/Tools/Scripts/webkitpy/common/message_pool.py", line 97, in run self.wait() File "/home/buildbot/WebKit/Tools/Scripts/webkitpy/common/message_pool.py", line 127, in wait self._start_workers() File "/home/buildbot/WebKit/Tools/Scripts/webkitpy/common/message_pool.py", line 109, in _start_workers worker.start() File "/home/buildbot/WebKit/Tools/Scripts/webkitpy/common/message_pool.py", line 239, in start super(_Worker, self).start() File "/usr/lib/python2.7/multiprocessing/process.py", line 130, in start self._popen = Popen(self) File "/usr/lib/python2.7/multiprocessing/forking.py", line 126, in __init__ code = process_obj._bootstrap() File "/usr/lib/python2.7/multiprocessing/process.py", line 258, in _bootstrap self.run() File "/home/buildbot/WebKit/Tools/Scripts/webkitpy/common/message_pool.py", line 257, in run worker.handle(message.name, message.src, *message.args) File "/home/buildbot/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py", line 261, in handle self._run_test(test_input, test_list_name) File "/home/buildbot/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py", line 285, in _run_test result = self._run_test_with_or_without_timeout(test_input, test_timeout_sec, stop_when_done) File "/home/buildbot/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py", line 328, in _run_test_with_or_without_timeout return self._run_test_in_this_thread(test_input, stop_when_done) File "/home/buildbot/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py", line 409, in _run_test_in_this_thread return self._run_single_test(self._driver, test_input, stop_when_done) File "/home/buildbot/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py", line 413, in _run_single_test self._name, driver, test_input, stop_when_done) File "/home/buildbot/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py", line 46, in run_single_test return runner.run() File "/home/buildbot/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py", line 105, in run return self._run_compare_test() File "/home/buildbot/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py", line 108, in _run_compare_test driver_output = self._driver.run_test(self._driver_input(), self._stop_when_done) File "/home/buildbot/WebKit/Tools/Scripts/webkitpy/port/driver.py", line 693, in run_test return self._driver.run_test(driver_input, stop_when_done) File "/home/buildbot/WebKit/Tools/Scripts/webkitpy/port/driver.py", line 228, in run_test self.error_from_test, crash_log = self._get_crash_log(text, self.error_from_test, newer_than=start_time) File "/home/buildbot/WebKit/Tools/Scripts/webkitpy/port/driver.py", line 245, in _get_crash_log return self._port._get_crash_log(self._crashed_process_name, self._crashed_pid, stdout, stderr, newer_than, target_host=self._target_host) File "/home/buildbot/WebKit/Tools/Scripts/webkitpy/port/win.py", line 396, in _get_crash_log crash_log = crash_logs.find_newest_log(name, system_pid, include_errors=True, newer_than=newer_than) File "/home/buildbot/WebKit/Tools/Scripts/webkitpy/common/system/crashlogs.py", line 53, in find_newest_log return self._find_newest_log_win(process_name, pid, include_errors, newer_than) File "/home/buildbot/WebKit/Tools/Scripts/webkitpy/common/system/crashlogs.py", line 106, in _find_newest_log_win logs = self._host.filesystem.files_under(self._crash_log_directory, file_filter=is_crash_log) File "/home/buildbot/WebKit/Tools/Scripts/webkitpy/common/system/filesystem.py", line 132, in files_under for (dirpath, dirnames, filenames) in os.walk(path): File "/usr/lib/python2.7/os.py", line 296, in walk for x in walk(new_path, topdown, onerror, followlinks): File "/usr/lib/python2.7/os.py", line 278, in walk names = listdir(top) File "/usr/lib/python2.7/encodings/utf_8.py", line 15, in decode def decode(input, errors='strict'): 1374938 6 324239 pvollan 2017-11-27 08:33:14 -0800 Comment on attachment 324239 Patch Thanks for reviewing! 1374940 7 324239 commit-queue 2017-11-27 08:34:23 -0800 Comment on attachment 324239 Patch Rejecting attachment 324239 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 324239, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: '--force', '--reviewer', u'Darin Adler']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Parsed 2 diffs from patch file(s). patching file Tools/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Tools/EWSTools/start-queue-win.sh Hunk #2 FAILED at 62. 1 out of 2 hunks FAILED -- saving rejects to file Tools/EWSTools/start-queue-win.sh.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Darin Adler']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/5375340 1374969 8 pvollan 2017-11-27 09:44:29 -0800 Committed r225178: <https://trac.webkit.org/changeset/225178/webkit>. 1378917 9 webkit-bug-importer 2017-12-06 16:47:08 -0800 <rdar://problem/35896588> 324239 2017-10-19 08:45:39 -0700 2017-11-27 08:34:23 -0800 Patch bug-178517-20171019084534.patch text/plain 1713 pvollan SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIyMzY4OCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDE3LTEwLTE5ICBQZXIgQXJuZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNv bT4KKworICAgICAgICBbV2luXSBUaGUgbnVtYmVyIG9mIHdlYmtpdC1wYXRjaCBpdGVyYXRpb25z IG9uIEVXUyBzaG91bGQgYmUgY29uZmlndXJhYmxlLgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc4NTE3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIGEgbmV3IFJFU0VUX0FGVEVSX0lURVJBVElPTiBh cmd1bWVudCB0byB0aGUgRVdTIHNoZWxsIHNjcmlwdC4KKworICAgICAgICAqIEVXU1Rvb2xzL3N0 YXJ0LXF1ZXVlLXdpbi5zaDoKKwogMjAxNy0xMC0xOCAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Vi a2l0Lm9yZz4KIAogICAgICAgICBEb24ndCBleHBvc2UgcmF3IEhUTUwgaW4gcGFzdGVib2FyZCB0 byB0aGUgd2ViIGNvbnRlbnQKSW5kZXg6IFRvb2xzL0VXU1Rvb2xzL3N0YXJ0LXF1ZXVlLXdpbi5z aAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBUb29scy9FV1NUb29scy9zdGFydC1xdWV1ZS13aW4uc2gJKHJldmlz aW9uIDIyMzU4MSkKKysrIFRvb2xzL0VXU1Rvb2xzL3N0YXJ0LXF1ZXVlLXdpbi5zaAkod29ya2lu ZyBjb3B5KQpAQCAtMSw3ICsxLDE0IEBACiAjIS9iaW4vc2gKKworaWYgW1sgJCMgLWx0IDQgXV07 IHRoZW4KK2VjaG8gIlVzYWdlOiBzdGFydC1xdWV1ZS13aW4uc2ggV0VCS0lUX0JVR1pJTExBX1VT RVJOQU1FIFdFQktJVF9CVUdaSUxMQV9QQVNTV09SRCBCT1RfSUQgUkVTRVRfQUZURVJfSVRFUkFU SU9OIgorZXhpdCAxCitmaQorCiBleHBvcnQgV0VCS0lUX0JVR1pJTExBX1VTRVJOQU1FPSQxCiBl eHBvcnQgV0VCS0lUX0JVR1pJTExBX1BBU1NXT1JEPSQyCiBleHBvcnQgQk9UX0lEPSQzCitleHBv cnQgUkVTRVRfQUZURVJfSVRFUkFUSU9OPSQ0CiAKIGZ1bmN0aW9uIGVycm9yX2hhbmRsZXIoKQog ewpAQCAtNTUsNyArNjIsNyBAQCBmdW5jdGlvbiBzdGFydF9ld3MoKQogICAgICAgICBlY2hvICJU QVNLOiB0ZXN0LXdlYmtpdHB5IgogICAgICAgICB+L1dlYktpdC9Ub29scy9TY3JpcHRzL3Rlc3Qt d2Via2l0cHkKICAgICAgICAgZWNobyAiVEFTSzogd2Via2l0LXBhdGNoIHdpbi1ld3MiCi0gICAg ICAgIH4vV2ViS2l0L1Rvb2xzL1NjcmlwdHMvd2Via2l0LXBhdGNoIHdpbi1ld3MgLS1ib3QtaWQ9 JEJPVF9JRCAtLW5vLWNvbmZpcm0gLS1leGl0LWFmdGVyLWl0ZXJhdGlvbiAxMAorICAgICAgICB+ L1dlYktpdC9Ub29scy9TY3JpcHRzL3dlYmtpdC1wYXRjaCB3aW4tZXdzIC0tYm90LWlkPSRCT1Rf SUQgLS1uby1jb25maXJtIC0tZXhpdC1hZnRlci1pdGVyYXRpb24gJFJFU0VUX0FGVEVSX0lURVJB VElPTgogICAgICAgICBlY2hvICJUQVNLOiBraWxsIG9sZCBwcm9jZXNzZXMiCiAgICAgICAgIH4v V2ViS2l0L1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2tpbGwtb2xkLXByb2Nlc3NlcwogICAgIGRv bmUK