178481 2017-10-18 12:48:53 -0700 webkitpy tests should have --json-output option 2017-10-18 14:55:46 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap buildbot commit-queue glenn lforschler webkit-bug-importer oldest_to_newest 1361850 0 aakash_jain 2017-10-18 12:48:53 -0700 webkitpy tests should have --json-output option which would write the json results to a json output file. This would help in developing an EWS which would run webkitpy tests and parse the output from json output file. Many other scripts like "run-api-tests", "run-bindings-tests", "run-javascriptcore-tests" have "json-output" parameter which is used by corresponding EWSes. 1361855 1 324152 aakash_jain 2017-10-18 12:56:58 -0700 Created attachment 324152 Proposed patch 1361860 2 324152 ap 2017-10-18 13:00:06 -0700 Comment on attachment 324152 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=324152&action=review > Tools/Scripts/webkitpy/test/main.py:123 > parser.add_option('--json', action='store_true', default=False, > help='write JSON formatted test results to stdout') > + parser.add_option('--json-output', action='store', type='string', dest='json_file_name', > + help='Create a file at specified path, listing test results in JSON format.') I think that we need at least a fixme to clean this up. Standard output is just a kind of file, so having two options is unnecessary and highly unusual. Better yet, mark the old one as deprecated, and better yet, remove it. 1361868 3 324160 aakash_jain 2017-10-18 13:14:40 -0700 Created attachment 324160 Patch for landing 1361901 4 324160 commit-queue 2017-10-18 14:52:57 -0700 Comment on attachment 324160 Patch for landing Rejecting attachment 324160 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 324160, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Parsed 2 diffs from patch file(s). patching file Tools/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Tools/Scripts/webkitpy/test/main.py Hunk #1 FAILED at 117. Hunk #2 succeeded at 187 with fuzz 2 (offset 8 lines). 1 out of 2 hunks FAILED -- saving rejects to file Tools/Scripts/webkitpy/test/main.py.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/4908490 1361904 5 aakash_jain 2017-10-18 14:55:16 -0700 Committed r223630: <https://trac.webkit.org/changeset/223630> 1361905 6 webkit-bug-importer 2017-10-18 14:55:46 -0700 <rdar://problem/35061458> 324152 2017-10-18 12:56:58 -0700 2017-10-18 13:14:40 -0700 Proposed patch patch_webkitpy_json_output text/plain 2285 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIyMzYyMykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDE3LTEwLTE4ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICB3ZWJraXRweSB0ZXN0cyBzaG91bGQgaGF2ZSAtLWpzb24tb3V0cHV0IG9w dGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc4 NDgxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBT Y3JpcHRzL3dlYmtpdHB5L3Rlc3QvbWFpbi5weToKKyAgICAgICAgKFRlc3Rlci5fcGFyc2VfYXJn cyk6IEFkZGVkIGpzb24tb3V0cHV0IGFyZ3VtZW50LgorICAgICAgICAoVGVzdGVyLl9ydW5fdGVz dHMpOiBXcml0ZSBvdXRwdXQgdG8ganNvbiBmaWxlLgorCiAyMDE3LTEwLTE4ICBDaHJpcyBEdW1l eiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgQWRkIGFuIGVmZmljaWVudCBkYXRhIHN0 cnVjdHVyZSBmb3IgV2ViQ29yZSB0byBxdWVyeSBpZiB0aGVyZSBpcyBhIFNlcnZpY2UgV29ya2Vy IHJlZ2lzdGVyZWQgZm9yIGEgZ2l2ZW4gb3JpZ2luCkluZGV4OiBUb29scy9TY3JpcHRzL3dlYmtp dHB5L3Rlc3QvbWFpbi5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rl c3QvbWFpbi5weQkocmV2aXNpb24gMjIzNjIzKQorKysgVG9vbHMvU2NyaXB0cy93ZWJraXRweS90 ZXN0L21haW4ucHkJKHdvcmtpbmcgY29weSkKQEAgLTExOSw2ICsxMTksOCBAQCBjbGFzcyBUZXN0 ZXIob2JqZWN0KToKICAgICAgICAgICAgICAgICAgICAgICAgICAgaGVscD0ndmVyYm9zZSBvdXRw dXQgKHNwZWNpZnkgb25jZSBmb3IgaW5kaXZpZHVhbCB0ZXN0IHJlc3VsdHMsIHR3aWNlIGZvciBk ZWJ1ZyBtZXNzYWdlcyknKQogICAgICAgICBwYXJzZXIuYWRkX29wdGlvbignLS1qc29uJywgYWN0 aW9uPSdzdG9yZV90cnVlJywgZGVmYXVsdD1GYWxzZSwKICAgICAgICAgICAgICAgICAgICAgICAg ICAgaGVscD0nd3JpdGUgSlNPTiBmb3JtYXR0ZWQgdGVzdCByZXN1bHRzIHRvIHN0ZG91dCcpCisg ICAgICAgIHBhcnNlci5hZGRfb3B0aW9uKCctLWpzb24tb3V0cHV0JywgYWN0aW9uPSdzdG9yZScs IHR5cGU9J3N0cmluZycsIGRlc3Q9J2pzb25fZmlsZV9uYW1lJywKKyAgICAgICAgICAgICAgICAg ICAgICAgICAgaGVscD0nQ3JlYXRlIGEgZmlsZSBhdCBzcGVjaWZpZWQgcGF0aCwgbGlzdGluZyB0 ZXN0IHJlc3VsdHMgaW4gSlNPTiBmb3JtYXQuJykKIAogICAgICAgICBwYXJzZXIuZXBpbG9nID0g KCdbYXJncy4uLl0gaXMgYW4gb3B0aW9uYWwgbGlzdCBvZiBtb2R1bGVzLCB0ZXN0X2NsYXNzZXMs IG9yIGluZGl2aWR1YWwgdGVzdHMuICcKICAgICAgICAgICAgICAgICAgICAgICAgICAnSWYgbm8g YXJncyBhcmUgZ2l2ZW4sIGFsbCB0aGUgdGVzdHMgd2lsbCBiZSBydW4uJykKQEAgLTE3Niw2ICsx NzgsMTEgQEAgY2xhc3MgVGVzdGVyKG9iamVjdCk6CiAgICAgICAgIGlmIHNlbGYuX29wdGlvbnMu anNvbjoKICAgICAgICAgICAgIF9wcmludF9yZXN1bHRzX2FzX2pzb24oc3lzLnN0ZG91dCwgaXRl cnRvb2xzLmNoYWluKHBhcmFsbGVsX3Rlc3RzLCBzZXJpYWxfdGVzdHMpLCB0ZXN0X3J1bm5lci5m YWlsdXJlcywgdGVzdF9ydW5uZXIuZXJyb3JzKQogCisgICAgICAgIGlmIHNlbGYuX29wdGlvbnMu anNvbl9maWxlX25hbWU6CisgICAgICAgICAgICBzZWxmLl9vcHRpb25zLmpzb25fZmlsZV9uYW1l ID0gb3MucGF0aC5hYnNwYXRoKHNlbGYuX29wdGlvbnMuanNvbl9maWxlX25hbWUpCisgICAgICAg ICAgICB3aXRoIG9wZW4oc2VsZi5fb3B0aW9ucy5qc29uX2ZpbGVfbmFtZSwgJ3cnKSBhcyBqc29u X2ZpbGU6CisgICAgICAgICAgICAgICAgX3ByaW50X3Jlc3VsdHNfYXNfanNvbihqc29uX2ZpbGUs IGl0ZXJ0b29scy5jaGFpbihwYXJhbGxlbF90ZXN0cywgc2VyaWFsX3Rlc3RzKSwgdGVzdF9ydW5u ZXIuZmFpbHVyZXMsIHRlc3RfcnVubmVyLmVycm9ycykKKwogICAgICAgICBpZiBzZWxmLl9vcHRp b25zLmNvdmVyYWdlOgogICAgICAgICAgICAgY292LnN0b3AoKQogICAgICAgICAgICAgY292LnNh dmUoKQo= 324160 2017-10-18 13:14:40 -0700 2017-10-18 14:54:36 -0700 Patch for landing patch_webkitpy_json_output_v2 text/plain 2495 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIyMzYyMykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDE3LTEwLTE4ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICB3ZWJraXRweSB0ZXN0cyBzaG91bGQgaGF2ZSAtLWpzb24tb3V0cHV0IG9w dGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc4 NDgxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgQWxleGV5IFByb3NrdXJ5YWtvdi4KKworICAgICAg ICAqIFNjcmlwdHMvd2Via2l0cHkvdGVzdC9tYWluLnB5OgorICAgICAgICAoVGVzdGVyLl9wYXJz ZV9hcmdzKTogQWRkZWQganNvbi1vdXRwdXQgYXJndW1lbnQuCisgICAgICAgIChUZXN0ZXIuX3J1 bl90ZXN0cyk6IFdyaXRlIG91dHB1dCB0byBqc29uIGZpbGUuCisKIDIwMTctMTAtMTggIENocmlz IER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQgYW4gZWZmaWNpZW50IGRh dGEgc3RydWN0dXJlIGZvciBXZWJDb3JlIHRvIHF1ZXJ5IGlmIHRoZXJlIGlzIGEgU2VydmljZSBX b3JrZXIgcmVnaXN0ZXJlZCBmb3IgYSBnaXZlbiBvcmlnaW4KSW5kZXg6IFRvb2xzL1NjcmlwdHMv d2Via2l0cHkvdGVzdC9tYWluLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0 cHkvdGVzdC9tYWluLnB5CShyZXZpc2lvbiAyMjM2MjMpCisrKyBUb29scy9TY3JpcHRzL3dlYmtp dHB5L3Rlc3QvbWFpbi5weQkod29ya2luZyBjb3B5KQpAQCAtMTE3LDggKzExNywxMSBAQCBjbGFz cyBUZXN0ZXIob2JqZWN0KToKICAgICAgICAgICAgICAgICAgICAgICAgICAgaGVscD0nZGlzcGxh eSBwZXItdGVzdCBleGVjdXRpb24gdGltZSAoaW1wbGllcyAtLXZlcmJvc2UpJykKICAgICAgICAg cGFyc2VyLmFkZF9vcHRpb24oJy12JywgJy0tdmVyYm9zZScsIGFjdGlvbj0nY291bnQnLCBkZWZh dWx0PTAsCiAgICAgICAgICAgICAgICAgICAgICAgICAgIGhlbHA9J3ZlcmJvc2Ugb3V0cHV0IChz cGVjaWZ5IG9uY2UgZm9yIGluZGl2aWR1YWwgdGVzdCByZXN1bHRzLCB0d2ljZSBmb3IgZGVidWcg bWVzc2FnZXMpJykKKyAgICAgICAgIyBGSVhNRTogUmVtb3ZlICctLWpzb24nIGFyZ3VtZW50Lgog ICAgICAgICBwYXJzZXIuYWRkX29wdGlvbignLS1qc29uJywgYWN0aW9uPSdzdG9yZV90cnVlJywg ZGVmYXVsdD1GYWxzZSwKICAgICAgICAgICAgICAgICAgICAgICAgICAgaGVscD0nd3JpdGUgSlNP TiBmb3JtYXR0ZWQgdGVzdCByZXN1bHRzIHRvIHN0ZG91dCcpCisgICAgICAgIHBhcnNlci5hZGRf b3B0aW9uKCctLWpzb24tb3V0cHV0JywgYWN0aW9uPSdzdG9yZScsIHR5cGU9J3N0cmluZycsIGRl c3Q9J2pzb25fZmlsZV9uYW1lJywKKyAgICAgICAgICAgICAgICAgICAgICAgICAgaGVscD0nQ3Jl YXRlIGEgZmlsZSBhdCBzcGVjaWZpZWQgcGF0aCwgbGlzdGluZyB0ZXN0IHJlc3VsdHMgaW4gSlNP TiBmb3JtYXQuJykKIAogICAgICAgICBwYXJzZXIuZXBpbG9nID0gKCdbYXJncy4uLl0gaXMgYW4g b3B0aW9uYWwgbGlzdCBvZiBtb2R1bGVzLCB0ZXN0X2NsYXNzZXMsIG9yIGluZGl2aWR1YWwgdGVz dHMuICcKICAgICAgICAgICAgICAgICAgICAgICAgICAnSWYgbm8gYXJncyBhcmUgZ2l2ZW4sIGFs bCB0aGUgdGVzdHMgd2lsbCBiZSBydW4uJykKQEAgLTE3Niw2ICsxNzksMTEgQEAgY2xhc3MgVGVz dGVyKG9iamVjdCk6CiAgICAgICAgIGlmIHNlbGYuX29wdGlvbnMuanNvbjoKICAgICAgICAgICAg IF9wcmludF9yZXN1bHRzX2FzX2pzb24oc3lzLnN0ZG91dCwgaXRlcnRvb2xzLmNoYWluKHBhcmFs bGVsX3Rlc3RzLCBzZXJpYWxfdGVzdHMpLCB0ZXN0X3J1bm5lci5mYWlsdXJlcywgdGVzdF9ydW5u ZXIuZXJyb3JzKQogCisgICAgICAgIGlmIHNlbGYuX29wdGlvbnMuanNvbl9maWxlX25hbWU6Cisg ICAgICAgICAgICBzZWxmLl9vcHRpb25zLmpzb25fZmlsZV9uYW1lID0gb3MucGF0aC5hYnNwYXRo KHNlbGYuX29wdGlvbnMuanNvbl9maWxlX25hbWUpCisgICAgICAgICAgICB3aXRoIG9wZW4oc2Vs Zi5fb3B0aW9ucy5qc29uX2ZpbGVfbmFtZSwgJ3cnKSBhcyBqc29uX2ZpbGU6CisgICAgICAgICAg ICAgICAgX3ByaW50X3Jlc3VsdHNfYXNfanNvbihqc29uX2ZpbGUsIGl0ZXJ0b29scy5jaGFpbihw YXJhbGxlbF90ZXN0cywgc2VyaWFsX3Rlc3RzKSwgdGVzdF9ydW5uZXIuZmFpbHVyZXMsIHRlc3Rf cnVubmVyLmVycm9ycykKKwogICAgICAgICBpZiBzZWxmLl9vcHRpb25zLmNvdmVyYWdlOgogICAg ICAgICAgICAgY292LnN0b3AoKQogICAgICAgICAgICAgY292LnNhdmUoKQo=