178479 2017-10-18 11:49:14 -0700 [FrameView::layout cleanup] Use SetForScope to protect m_needsFullRepaint's value on reentrancy 2017-10-18 15:28:01 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham commit-queue koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1361820 0 zalan 2017-10-18 11:49:14 -0700 ssia. 1361821 1 webkit-bug-importer 2017-10-18 11:49:39 -0700 <rdar://problem/35056950> 1361824 2 324144 zalan 2017-10-18 11:52:41 -0700 Created attachment 324144 Patch 1361851 3 324144 simon.fraser 2017-10-18 12:55:26 -0700 Comment on attachment 324144 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=324144&action=review > Source/WebCore/page/FrameView.cpp:1527 > + SetForScope<bool> needsFullRepaint(m_needsFullRepaint); > + if (!isSubtreeLayout && !downcast<RenderView>(*layoutRoot).printing()) { Can't you just move the scope inside the if () condition, rather than adding an extra set of braces? 1361859 4 324155 zalan 2017-10-18 13:00:05 -0700 Created attachment 324155 Patch 1361925 5 324155 commit-queue 2017-10-18 15:27:59 -0700 Comment on attachment 324155 Patch Clearing flags on attachment: 324155 Committed r223633: <https://trac.webkit.org/changeset/223633> 1361926 6 commit-queue 2017-10-18 15:28:01 -0700 All reviewed patches have been landed. Closing bug. 324144 2017-10-18 11:52:41 -0700 2017-10-18 13:00:03 -0700 Patch bug-178479-20171018115241.patch text/plain 2567 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjIzNjA3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGZhODU4OWY1MzEwNTc2 ODg0NDQwNzVkODdhM2YzMGU3MGVmMjBhYi4uMWQwOWNlMzA0NmM1YzNiNzNkNjdhMzU3ZmQzYjFi ODI3NGJkMzlmZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE3LTEwLTE4ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0ZyYW1lVmlldzo6bGF5b3V0 IGNsZWFudXBdIFVzZSBTZXRGb3JTY29wZSB0byBwcm90ZWN0IG1fbmVlZHNGdWxsUmVwYWludCdz IHZhbHVlIG9uIHJlZW50cmFuY3kKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE3ODQ3OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzUwNTY5NTA+CisKKyAgICAgICAgTm8gY2hhbmdl IGluIGZ1bmN0aW9uYWxpdHkuCisKKyAgICAgICAgKiBwYWdlL0ZyYW1lVmlldy5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpGcmFtZVZpZXc6OmxheW91dCk6CisKIDIwMTctMTAtMTggIFNhbSBXZWlu aWcgIDxzYW1Ad2Via2l0Lm9yZz4KIAogICAgICAgICBbU2V0dGluZ3NdIFJlcGxhY2UgbWFjcm9z IGluIFNldHRpbmdzLmgvY3BwIHdpdGggZ2VuZXJhdGVkIGNvZGUKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVW aWV3LmNwcAppbmRleCBiZDc2MTc0OTU2MDFhNDAyNzljYzIxOGU2YWM4YzFlOTljZmVhNTNhLi5k N2Q1ZDE0NmFkZWY5ZDczOWNiMTA4ZmZlNjFiYzUyMTM1MjgwY2M2IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9G cmFtZVZpZXcuY3BwCkBAIC0xNTIxLDIzICsxNTIxLDE5IEBAIHZvaWQgRnJhbWVWaWV3OjpsYXlv dXQoYm9vbCBhbGxvd1N1YnRyZWVMYXlvdXQpCiAgICAgICAgIG1fc3VidHJlZUxheW91dFJvb3Qg PSBudWxscHRyOwogICAgICAgICAvLyBDbG9zZSBibG9jayBoZXJlIHRvIGVuZCB0aGUgc2NvcGUg b2YgY2hhbmdlU2NoZWR1bGluZ0VuYWJsZWQgYW5kIFN1YnRyZWVMYXlvdXRTdGF0ZU1haW50YWlu ZXIuCiAgICAgfQotCi0gICAgbV9sYXlvdXRQaGFzZSA9IEluVmlld1NpemVBZGp1c3Q7Ci0KLSAg ICBib29sIG5lZWRlZEZ1bGxSZXBhaW50ID0gbV9uZWVkc0Z1bGxSZXBhaW50OwotCi0gICAgaWYg KCFpc1N1YnRyZWVMYXlvdXQgJiYgIWRvd25jYXN0PFJlbmRlclZpZXc+KCpsYXlvdXRSb290KS5w cmludGluZygpKSB7Ci0gICAgICAgIGFkanVzdFZpZXdTaXplKCk7Ci0gICAgICAgIC8vIEZJWE1F OiBGaXJpbmcgbWVkaWEgcXVlcnkgY2FsbGJhY2tzIHN5bmNocm9ub3VzbHkgb24gbmVzdGVkIGZy YW1lcyBjb3VsZCBwcm9kdWNlZCBhIGRldGFjaGVkIEZyYW1lVmlldyBoZXJlIGJ5Ci0gICAgICAg IC8vIG5hdmlnYXRpbmcgYXdheSBmcm9tIHRoZSBjdXJyZW50IGRvY3VtZW50IChzZWUgd2Via2l0 Lm9yZy9iLzE3MzMyOSkuCi0gICAgICAgIGlmIChoYXNPbmVSZWYoKSkKLSAgICAgICAgICAgIHJl dHVybjsKKyAgICB7CisgICAgICAgIC8vIFRoaXMgaXMgdG8gcHJvdGVjdCBtX25lZWRzRnVsbFJl cGFpbnQncyB2YWx1ZSB3aGVuIGxheW91dCgpIGlzIGdldHRpbmcgcmUtZW50ZXJlZCB0aHJvdWdo IGFkanVzdFZpZXdTaXplKCkuCisgICAgICAgIFNldEZvclNjb3BlPGJvb2w+IG5lZWRzRnVsbFJl cGFpbnQobV9uZWVkc0Z1bGxSZXBhaW50KTsKKyAgICAgICAgaWYgKCFpc1N1YnRyZWVMYXlvdXQg JiYgIWRvd25jYXN0PFJlbmRlclZpZXc+KCpsYXlvdXRSb290KS5wcmludGluZygpKSB7CisgICAg ICAgICAgICBtX2xheW91dFBoYXNlID0gSW5WaWV3U2l6ZUFkanVzdDsKKyAgICAgICAgICAgIGFk anVzdFZpZXdTaXplKCk7CisgICAgICAgICAgICAvLyBGSVhNRTogRmlyaW5nIG1lZGlhIHF1ZXJ5 IGNhbGxiYWNrcyBzeW5jaHJvbm91c2x5IG9uIG5lc3RlZCBmcmFtZXMgY291bGQgcHJvZHVjZWQg YSBkZXRhY2hlZCBGcmFtZVZpZXcgaGVyZSBieQorICAgICAgICAgICAgLy8gbmF2aWdhdGluZyBh d2F5IGZyb20gdGhlIGN1cnJlbnQgZG9jdW1lbnQgKHNlZSB3ZWJraXQub3JnL2IvMTczMzI5KS4K KyAgICAgICAgICAgIGlmIChoYXNPbmVSZWYoKSkKKyAgICAgICAgICAgICAgICByZXR1cm47Cisg ICAgICAgIH0KICAgICB9Ci0KICAgICBtX2xheW91dFBoYXNlID0gSW5Qb3N0TGF5b3V0OwotCi0g ICAgbV9uZWVkc0Z1bGxSZXBhaW50ID0gbmVlZGVkRnVsbFJlcGFpbnQ7Ci0KICAgICAvLyBOb3cg dXBkYXRlIHRoZSBwb3NpdGlvbnMgb2YgYWxsIGxheWVycy4KICAgICBpZiAobV9uZWVkc0Z1bGxS ZXBhaW50KQogICAgICAgICBsYXlvdXRSb290LT52aWV3KCkucmVwYWludFJvb3RDb250ZW50cygp Owo= 324155 2017-10-18 13:00:05 -0700 2017-10-18 15:27:59 -0700 Patch bug-178479-20171018130004.patch text/plain 2279 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjIzNjIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTU1OWY2YmQzMWMwM2U5 MTQ5MWYxZWQ2M2NmMzYxMmE3ODQxMzMzYi4uNjU3MjUyNTdkYmY5ZjVjYTQyM2IxOTYzNmU5MTA5 YjJhZWE0NGQ2MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE4IEBACiAyMDE3LTEwLTE4ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CiAKKyAgICAgICAgW0ZyYW1lVmlldzo6bGF5b3V0 IGNsZWFudXBdIFVzZSBTZXRGb3JTY29wZSB0byBwcm90ZWN0IG1fbmVlZHNGdWxsUmVwYWludCdz IHZhbHVlIG9uIHJlZW50cmFuY3kKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE3ODQ3OQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzUwNTY5NTA+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgU2ltb24gRnJhc2VyLgorCisgICAgICAgIE5vIGNoYW5nZSBp biBmdW5jdGlvbmFsaXR5LgorCisgICAgICAgICogcGFnZS9GcmFtZVZpZXcuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6RnJhbWVWaWV3OjpsYXlvdXQpOgorCisyMDE3LTEwLTE4ICBaYWxhbiBCdWp0 YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKICAgICAgICAgW0ZyYW1lVmlldzo6bGF5b3V0IGNsZWFu dXBdIE1vdmUgcm9vdC9ib2R5IG1hcmtpbmcgZGlydHkgbG9naWMgdG8gYSBzZXBhcmF0ZSBmdW5j dGlvbgogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc4 NDc3CiAgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zNTA1NjQ3OD4KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVW aWV3LmNwcAppbmRleCBjNTE1NjBkYzAxZGM3NTAzNTFjNTJjMTlmYzNlZjE5OThiZDgxM2I1Li45 ZTRiMzY0Mjg5MTMyZDM0MmY1MDI1Njg3ODBiMTgyN2Q4YTVhMTI5IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9G cmFtZVZpZXcuY3BwCkBAIC0xNTI0LDIzICsxNTI0LDE3IEBAIHZvaWQgRnJhbWVWaWV3OjpsYXlv dXQoYm9vbCBhbGxvd1N1YnRyZWVMYXlvdXQpCiAgICAgICAgIG1fc3VidHJlZUxheW91dFJvb3Qg PSBudWxscHRyOwogICAgICAgICAvLyBDbG9zZSBibG9jayBoZXJlIHRvIGVuZCB0aGUgc2NvcGUg b2YgY2hhbmdlU2NoZWR1bGluZ0VuYWJsZWQgYW5kIFN1YnRyZWVMYXlvdXRTdGF0ZU1haW50YWlu ZXIuCiAgICAgfQotCi0gICAgbV9sYXlvdXRQaGFzZSA9IEluVmlld1NpemVBZGp1c3Q7Ci0KLSAg ICBib29sIG5lZWRlZEZ1bGxSZXBhaW50ID0gbV9uZWVkc0Z1bGxSZXBhaW50OwotCiAgICAgaWYg KCFpc1N1YnRyZWVMYXlvdXQgJiYgIWRvd25jYXN0PFJlbmRlclZpZXc+KCpsYXlvdXRSb290KS5w cmludGluZygpKSB7CisgICAgICAgIC8vIFRoaXMgaXMgdG8gcHJvdGVjdCBtX25lZWRzRnVsbFJl cGFpbnQncyB2YWx1ZSB3aGVuIGxheW91dCgpIGlzIGdldHRpbmcgcmUtZW50ZXJlZCB0aHJvdWdo IGFkanVzdFZpZXdTaXplKCkuCisgICAgICAgIFNldEZvclNjb3BlPGJvb2w+IG5lZWRzRnVsbFJl cGFpbnQobV9uZWVkc0Z1bGxSZXBhaW50KTsKKyAgICAgICAgbV9sYXlvdXRQaGFzZSA9IEluVmll d1NpemVBZGp1c3Q7CiAgICAgICAgIGFkanVzdFZpZXdTaXplKCk7CiAgICAgICAgIC8vIEZJWE1F OiBGaXJpbmcgbWVkaWEgcXVlcnkgY2FsbGJhY2tzIHN5bmNocm9ub3VzbHkgb24gbmVzdGVkIGZy YW1lcyBjb3VsZCBwcm9kdWNlZCBhIGRldGFjaGVkIEZyYW1lVmlldyBoZXJlIGJ5CiAgICAgICAg IC8vIG5hdmlnYXRpbmcgYXdheSBmcm9tIHRoZSBjdXJyZW50IGRvY3VtZW50IChzZWUgd2Via2l0 Lm9yZy9iLzE3MzMyOSkuCiAgICAgICAgIGlmIChoYXNPbmVSZWYoKSkKICAgICAgICAgICAgIHJl dHVybjsKICAgICB9Ci0KICAgICBtX2xheW91dFBoYXNlID0gSW5Qb3N0TGF5b3V0OwotCi0gICAg bV9uZWVkc0Z1bGxSZXBhaW50ID0gbmVlZGVkRnVsbFJlcGFpbnQ7Ci0KICAgICAvLyBOb3cgdXBk YXRlIHRoZSBwb3NpdGlvbnMgb2YgYWxsIGxheWVycy4KICAgICBpZiAobV9uZWVkc0Z1bGxSZXBh aW50KQogICAgICAgICBsYXlvdXRSb290LT52aWV3KCkucmVwYWludFJvb3RDb250ZW50cygpOwo=