178470 2017-10-18 10:00:58 -0700 Check notifyPagesWhenTelemetryWasCaptured before notifying pages if there is no WebPageProxy 2017-10-18 11:21:21 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 wilander wilander bburg commit-queue webkit-bug-importer wilander oldest_to_newest 1361746 0 wilander 2017-10-18 10:00:58 -0700 There's a missing check of the test setting notifyPagesWhenTelemetryWasCaptured when there's no WebPageProxy and we notify pages of a zero result. 1361747 1 wilander 2017-10-18 10:01:16 -0700 <rdar://problem/34417518> 1361749 2 324126 wilander 2017-10-18 10:04:31 -0700 Created attachment 324126 Patch 1361753 3 324127 wilander 2017-10-18 10:08:22 -0700 Created attachment 324127 Patch 1361780 4 324127 bburg 2017-10-18 10:51:33 -0700 Comment on attachment 324127 Patch r=me 1361782 5 324127 wilander 2017-10-18 10:54:24 -0700 Comment on attachment 324127 Patch Thanks, Brian! 1361797 6 324127 commit-queue 2017-10-18 11:21:19 -0700 Comment on attachment 324127 Patch Clearing flags on attachment: 324127 Committed r223616: <https://trac.webkit.org/changeset/223616> 1361798 7 commit-queue 2017-10-18 11:21:21 -0700 All reviewed patches have been landed. Closing bug. 324126 2017-10-18 10:04:31 -0700 2017-10-18 10:08:21 -0700 Patch bug-178470-20171018100430.patch text/plain 1458 wilander SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMjM2MTEpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE3LTEwLTE4ICBKb2huIFdpbGFu ZGVyICA8d2lsYW5kZXJAYXBwbGUuY29tPgorCisgICAgICAgIENoZWNrIG5vdGlmeVBhZ2VzV2hl blRlbGVtZXRyeVdhc0NhcHR1cmVkIGJlZm9yZSBub3RpZnlpbmcgcGFnZXMgaWYgdGhlcmUgaXMg bm8gV2ViUGFnZVByb3h5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xNzg0NzAKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzM0NDE3NTE4PgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL1dl YlJlc291cmNlTG9hZFN0YXRpc3RpY3NUZWxlbWV0cnkuY3BwOgorICAgICAgICAoV2ViS2l0OjpX ZWJSZXNvdXJjZUxvYWRTdGF0aXN0aWNzVGVsZW1ldHJ5OjpjYWxjdWxhdGVBbmRTdWJtaXQpOgor ICAgICAgICAgICAgQWRkIGEgbWlzc2luZyBjaGVjayBvZiBub3RpZnlQYWdlc1doZW5UZWxlbWV0 cnlXYXNDYXB0dXJlZC4KKyAgICAgICAgICAgIFRoZSBwYWdlIG5vdGlmaWNhdGlvbiBpcyBvbmx5 IGZvciB0ZXN0aW5nIHB1cnBvc2VzLgorCiAyMDE3LTEwLTE4ICBDaHJpcyBEdW1leiAgPGNkdW1l ekBhcHBsZS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgZml4IGJ1aWxkIGVycm9yIGFmdGVy IHIyMjM2MDggd2l0aCBzb21lIFNES3MuCkluZGV4OiBTb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9X ZWJSZXNvdXJjZUxvYWRTdGF0aXN0aWNzVGVsZW1ldHJ5LmNwcAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJSZXNvdXJjZUxvYWRTdGF0aXN0aWNzVGVsZW1ldHJ5LmNw cAkocmV2aXNpb24gMjIzNTcxKQorKysgU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUmVzb3Vy Y2VMb2FkU3RhdGlzdGljc1RlbGVtZXRyeS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTI0Nyw3ICsy NDcsNyBAQCB2b2lkIFdlYlJlc291cmNlTG9hZFN0YXRpc3RpY3NUZWxlbWV0cnk6CiAgICAgfQog ICAgIAogICAgIGF1dG8gd2ViUGFnZVByb3h5ID0gbm9uRXBoZW1lcmFsV2ViUGFnZVByb3h5KCk7 Ci0gICAgaWYgKCF3ZWJQYWdlUHJveHkpIHsKKyAgICBpZiAobm90aWZ5UGFnZXNXaGVuVGVsZW1l dHJ5V2FzQ2FwdHVyZWQgJiYgIXdlYlBhZ2VQcm94eSkgewogICAgICAgICBub3RpZnlQYWdlcygw LCAwLCAwKTsKICAgICAgICAgcmV0dXJuOwogICAgIH0K 324127 2017-10-18 10:08:22 -0700 2017-10-18 11:21:19 -0700 Patch bug-178470-20171018100821.patch text/plain 1477 wilander SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMjM2MTEpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE3LTEwLTE4ICBKb2huIFdpbGFu ZGVyICA8d2lsYW5kZXJAYXBwbGUuY29tPgorCisgICAgICAgIENoZWNrIG5vdGlmeVBhZ2VzV2hl blRlbGVtZXRyeVdhc0NhcHR1cmVkIGJlZm9yZSBub3RpZnlpbmcgcGFnZXMgaWYgdGhlcmUgaXMg bm8gV2ViUGFnZVByb3h5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xNzg0NzAKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzM0NDE3NTE4PgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL1dl YlJlc291cmNlTG9hZFN0YXRpc3RpY3NUZWxlbWV0cnkuY3BwOgorICAgICAgICAoV2ViS2l0OjpX ZWJSZXNvdXJjZUxvYWRTdGF0aXN0aWNzVGVsZW1ldHJ5OjpjYWxjdWxhdGVBbmRTdWJtaXQpOgor ICAgICAgICAgICAgQWRkIGEgbWlzc2luZyBjaGVjayBvZiBub3RpZnlQYWdlc1doZW5UZWxlbWV0 cnlXYXNDYXB0dXJlZC4KKyAgICAgICAgICAgIFRoZSBwYWdlIG5vdGlmaWNhdGlvbiBpcyBvbmx5 IGZvciB0ZXN0aW5nIHB1cnBvc2VzLgorCiAyMDE3LTEwLTE4ICBDaHJpcyBEdW1leiAgPGNkdW1l ekBhcHBsZS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgZml4IGJ1aWxkIGVycm9yIGFmdGVy IHIyMjM2MDggd2l0aCBzb21lIFNES3MuCkluZGV4OiBTb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9X ZWJSZXNvdXJjZUxvYWRTdGF0aXN0aWNzVGVsZW1ldHJ5LmNwcAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJSZXNvdXJjZUxvYWRTdGF0aXN0aWNzVGVsZW1ldHJ5LmNw cAkocmV2aXNpb24gMjIzNTcxKQorKysgU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUmVzb3Vy Y2VMb2FkU3RhdGlzdGljc1RlbGVtZXRyeS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTI0OCw3ICsy NDgsOCBAQCB2b2lkIFdlYlJlc291cmNlTG9hZFN0YXRpc3RpY3NUZWxlbWV0cnk6CiAgICAgCiAg ICAgYXV0byB3ZWJQYWdlUHJveHkgPSBub25FcGhlbWVyYWxXZWJQYWdlUHJveHkoKTsKICAgICBp ZiAoIXdlYlBhZ2VQcm94eSkgewotICAgICAgICBub3RpZnlQYWdlcygwLCAwLCAwKTsKKyAgICAg ICAgaWYgKG5vdGlmeVBhZ2VzV2hlblRlbGVtZXRyeVdhc0NhcHR1cmVkKQorICAgICAgICAgICAg bm90aWZ5UGFnZXMoMCwgMCwgMCk7CiAgICAgICAgIHJldHVybjsKICAgICB9CiAgICAgCg==