17845 2008-03-14 05:59:06 -0700 [GTK] combo box menu displayed in the wrong position 2008-03-24 10:18:15 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) All Linux RESOLVED FIXED P3 Enhancement --- 1 marco.barisione webkit-unassigned alp pierre-luc.beaudoin oldest_to_newest 73726 0 marco.barisione 2008-03-14 05:59:06 -0700 The popup menu used for combo boxes is displayed under the widget, but it should be displayed with the active item over it. 73732 1 19761 marco.barisione 2008-03-14 08:18:15 -0700 Created attachment 19761 Show the popup in the right position and using the "push in" style to look like a normal combo box popup 74980 2 alp 2008-03-24 09:45:31 -0700 So, I tried this patch. Good idea, but the behaviour is a bit off in some cases. Trying the first few menu lists at: http://www.google.pt/advanced_search?hl=pt-PT .. half the menu is unpainted (ie. gray with no decorations) If you can't reproduce this issue, let me know and I'll describe the symptoms in more detail. I'm curious, are you using the same technique used within GTK+ internally to achieve this effect? 74984 3 pierre-luc.beaudoin 2008-03-24 10:01:37 -0700 Alp, Very funny: I did the same test on that patch! It happens that Gtk+ behaves that way: it leaves half the menu unpainted if the first element is selected when drawing the menu. I based my Gtk+ observations on the gnome-language-selector using a faily small (800x600) resolution. Try for yourself :) In my opinion, this patch is behaving correctly. 74987 4 19761 alp 2008-03-24 10:16:59 -0700 Comment on attachment 19761 Show the popup in the right position and using the "push in" style to look like a normal combo box popup Thanks for checking that Pierre-Luc. r=me 74988 5 alp 2008-03-24 10:18:15 -0700 Landed in r31244. 19761 2008-03-14 08:18:15 -0700 2008-03-24 10:16:59 -0700 Show the popup in the right position and using the "push in" style to look like a normal combo box popup gtk-like-combo-popup.patch text/plain 2628 marco.barisione SW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vZ3RrL1BvcHVwTWVudUd0ay5jcHAKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gV2ViQ29yZS9wbGF0Zm9ybS9ndGsvUG9wdXBNZW51R3RrLmNwcAkocmV2aXNpb25lIDMxMDU1 KQorKysgV2ViQ29yZS9wbGF0Zm9ybS9ndGsvUG9wdXBNZW51R3RrLmNwcAkoY29waWEgbG9jYWxl KQpAQCAtMyw2ICszLDcgQEAKICAqCiAgKiBDb3B5cmlnaHQgKEMpIDIwMDYsIDIwMDcgQXBwbGUg SW5jLgogICogQ29weXJpZ2h0IChDKSAyMDA2IE1pY2hhZWwgRW1tZWwgbWlrZS5lbW1lbEBnbWFp bC5jb20KKyAqIENvcHlyaWdodCAoQykgMjAwOCBDb2xsYWJvcmEgTHRkLgogICoKICAqIFRoaXMg bGlicmFyeSBpcyBmcmVlIHNvZnR3YXJlOyB5b3UgY2FuIHJlZGlzdHJpYnV0ZSBpdCBhbmQvb3IK ICAqIG1vZGlmeSBpdCB1bmRlciB0aGUgdGVybXMgb2YgdGhlIEdOVSBMaWJyYXJ5IEdlbmVyYWwg UHVibGljCkBAIC05Miw2ICs5MywyNCBAQAogICAgIGd0a193aWRnZXRfc2V0X3NpemVfcmVxdWVz dChHVEtfV0lER0VUKG1fcG9wdXApLCAtMSwgLTEpOwogICAgIGd0a193aWRnZXRfc2l6ZV9yZXF1 ZXN0KEdUS19XSURHRVQobV9wb3B1cCksICZyZXF1aXNpdGlvbik7CiAgICAgZ3RrX3dpZGdldF9z ZXRfc2l6ZV9yZXF1ZXN0KEdUS19XSURHRVQobV9wb3B1cCksIE1BWChyZWN0LndpZHRoKCksIHJl cXVpc2l0aW9uLndpZHRoKSwgLTEpOworCisgICAgR0xpc3QqIGNoaWxkcmVuID0gR1RLX01FTlVf U0hFTEwobV9wb3B1cCktPmNoaWxkcmVuOworICAgIGlmIChzaXplKQorICAgICAgICBmb3IgKGlu dCBpID0gMDsgaSA8IHNpemU7IGkrKykgeworICAgICAgICAgICAgaWYgKGkgPiBpbmRleCkKKyAg ICAgICAgICAgICAgYnJlYWs7CisKKyAgICAgICAgICAgIEd0a1dpZGdldCogaXRlbSA9IHJlaW50 ZXJwcmV0X2Nhc3Q8R3RrV2lkZ2V0Kj4oY2hpbGRyZW4tPmRhdGEpOworICAgICAgICAgICAgR3Rr UmVxdWlzaXRpb24gaXRlbVJlcXVpc2l0aW9uOworICAgICAgICAgICAgZ3RrX3dpZGdldF9nZXRf Y2hpbGRfcmVxdWlzaXRpb24oaXRlbSwgJml0ZW1SZXF1aXNpdGlvbik7CisgICAgICAgICAgICBt X21lbnVQb3NpdGlvbi5zZXRZKG1fbWVudVBvc2l0aW9uLnkoKSAtIGl0ZW1SZXF1aXNpdGlvbi5o ZWlnaHQpOworCisgICAgICAgICAgICBjaGlsZHJlbiA9IGdfbGlzdF9uZXh0KGNoaWxkcmVuKTsK KyAgICAgICAgfQorICAgIGVsc2UKKyAgICAgICAgLy8gQ2VudGVyIHZlcnRpY2FsbHkgdGhlIGVt cHR5IHBvcHVwIGluIHRoZSBjb21ibyBib3ggYXJlYQorICAgICAgICBtX21lbnVQb3NpdGlvbi5z ZXRZKG1fbWVudVBvc2l0aW9uLnkoKSAtIHJlY3QuaGVpZ2h0KCkgLyAyKTsKKwogICAgIGd0a19t ZW51X3BvcHVwKG1fcG9wdXAsIE5VTEwsIE5VTEwsIHJlaW50ZXJwcmV0X2Nhc3Q8R3RrTWVudVBv c2l0aW9uRnVuYz4obWVudVBvc2l0aW9uRnVuY3Rpb24pLCB0aGlzLCAwLCBndGtfZ2V0X2N1cnJl bnRfZXZlbnRfdGltZSgpKTsKIH0KIApAQCAtMTI4LDcgKzE0Nyw3IEBACiB7CiAgICAgKnggPSB0 aGF0LT5tX21lbnVQb3NpdGlvbi54KCk7CiAgICAgKnkgPSB0aGF0LT5tX21lbnVQb3NpdGlvbi55 KCk7Ci0gICAgcHVzaEluID0gZmFsc2U7CisgICAgKnB1c2hJbiA9IHRydWU7CiB9CiAKIHZvaWQg UG9wdXBNZW51OjptZW51UmVtb3ZlSXRlbShHdGtXaWRnZXQqIHdpZGdldCwgUG9wdXBNZW51KiB0 aGF0KQpJbmRleDogV2ViQ29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9DaGFu Z2VMb2cJKHJldmlzaW9uZSAzMTA1NSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCShjb3BpYSBsb2Nh bGUpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMDgtMDMtMTQgIE1hcmNvIEJhcmlzaW9uZSAgPG1hcmNv LmJhcmlzaW9uZUBjb2xsYWJvcmEuY28udWs+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgaHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTc4NDUKKyAgICAgICAgW0dUS10gY29tYm8gYm94IG1lbnUgZGlzcGxheWVkIGluIHRoZSB3 cm9uZyBwb3NpdGlvbgorCisgICAgICAgICogcGxhdGZvcm0vZ3RrL1BvcHVwTWVudUd0ay5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpQb3B1cE1lbnU6OnNob3cpOiBDaGFuZ2UgdGhlIHBvcHVwIG1l bnUgdmVydGljYWwgcG9zaXRpb24gc28KKyAgICAgICAgdGhhdCB0aGUgYWN0aXZlIGl0ZW0gaXMg b3ZlciB0aGUgY29tYm8gYm94LgorICAgICAgICAoV2ViQ29yZTo6UG9wdXBNZW51OjptZW51UG9z aXRpb25GdW5jdGlvbik6IHVzZSB0aGUgInB1c2ggaW4iIHN0eWxlCisgICAgICAgIGxpa2UgbmF0 aXZlIEdUSysgY29tYm8gYm94ZXMgdG8gaGFuZGxlIG1lbnVzIHRoYXQgZG9uJ3QgZml0IGluIHRo ZQorICAgICAgICBzY3JlZW4uCisKIDIwMDgtMDMtMTMgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBw bGUuY29tPgogCiAgICAgICAgICogaHRtbC9QcmVsb2FkU2Nhbm5lci5oOiBDb3JyZWN0ZWQgbGlj ZW5zZS4K