178424 2017-10-17 20:19:22 -0700 REGRESSION (r223476): WebCore exports symbols with names belonging to other frameworks 2017-10-20 06:35:52 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Local Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=178229 InRadar P1 Normal --- 1 mitz keith_miller benjamin buildbot cdumez cmarcelo commit-queue dbates ddkilzer keith_miller thorton webkit-bug-importer oldest_to_newest 1361555 0 mitz 2017-10-17 20:19:22 -0700 <https://trac.webkit.org/r223476>, the fix for bug 178229, made WebCore export symbols identical to the ones it’s “soft linking” using the SOFT_LINK_FUNCTION_FOR_SOURCE macro. For example, now WebCore exports a function called CMClockGetTime, which is different from the CMClockGetTime that the Core Media framework exports. WebCore’s exports should all be in WebCore’s C++ namespaces or have the Web or _Web prefix. 1361561 1 mitz 2017-10-17 20:27:00 -0700 <rdar://problem/35045237> 1362037 2 keith_miller 2017-10-18 19:43:07 -0700 *** Bug 178495 has been marked as a duplicate of this bug. *** 1362039 3 324202 keith_miller 2017-10-18 19:44:28 -0700 Created attachment 324202 Patch 1362041 4 keith_miller 2017-10-18 19:47:42 -0700 From nm WebCore.build/Objects-normal/x86_64/XSLTUnicodeSort.o (which calls a function, xsltEvalAttrValueTemplate, from libxslt): (__TEXT,__text) weak private external _xsltEvalAttrValueTemplate 1362179 5 324202 ddkilzer 2017-10-19 09:52:22 -0700 Comment on attachment 324202 Patch r=me. We should stop soft-linking libxslt as well, but that's a separate patch. 1362207 6 324202 commit-queue 2017-10-19 11:18:35 -0700 Comment on attachment 324202 Patch Clearing flags on attachment: 324202 Committed r223693: <https://trac.webkit.org/changeset/223693> 1362208 7 commit-queue 2017-10-19 11:18:37 -0700 All reviewed patches have been landed. Closing bug. 324202 2017-10-18 19:44:28 -0700 2017-10-19 11:18:35 -0700 Patch bug-178424-20171018194427.patch text/plain 2042 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjIzNjQzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDk2YjRkNmUzNzA0OTJlMWNjMzJlMmZm NjM1YTAyOGUxYTg0ZGY2N2IuLjZhNDQwNDgyZjc3N2E0NWJlYjQzNTI0YmY2ZDVjMThjMDhiM2E0 NDYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDUgKzEsMTggQEAKIDIwMTctMTAtMTggIEtlaXRoIE1pbGxlciAgPGtlaXRo X21pbGxlckBhcHBsZS5jb20+CiAKKyAgICAgICAgUkVHUkVTU0lPTiAocjIyMzQ3Nik6IFdlYkNv cmUgZXhwb3J0cyBzeW1ib2xzIHdpdGggbmFtZXMgYmVsb25naW5nIHRvIG90aGVyIGZyYW1ld29y a3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3ODQy NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMg cGF0Y2ggbW92ZXMgdGhlIHdyYXBwZXIgZnVuY3Rpb24gc2hhcmluZyB0aGUgbmFtZSBvZiB0aGUg ZXh0ZXJuZWQgZnVuY3Rpb24KKyAgICAgICAgdG8gdGhlIHNvdXJjZSBmaWxlIGFuZCBtYXJrcyBp dCBhcyBhbHdheXMgaW5saW5lLiBNYXJraW5nIGl0IGFzIGlubGluZSBwcmV2ZW50cworICAgICAg ICB0aGUgZnJhbWV3b3JrIGZyb20gZXhwb3J0aW5nIGl0LgorCisgICAgICAgICogd3RmL2NvY29h L1NvZnRMaW5raW5nLmg6CisKKzIwMTctMTAtMTggIEtlaXRoIE1pbGxlciAgPGtlaXRoX21pbGxl ckBhcHBsZS5jb20+CisKICAgICAgICAgU2V0dXAgV2ViQ29yZSBidWlsZCB0byBzdGFydCB1c2lu ZyB1bmlmaWVkIHNvdXJjZXMuCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xNzgzNjIKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvY29jb2EvU29m dExpbmtpbmcuaCBiL1NvdXJjZS9XVEYvd3RmL2NvY29hL1NvZnRMaW5raW5nLmgKaW5kZXggMWE1 MzJmMTkyZjdkMTEyODg1NDRhMWExYmZhYTE2YmVkMjExZWMyMy4uOGViYjNhMTJlMDU2ZjU4M2Rk NGMzNGYwMTBlMmVhNTBhOWU1N2Q4ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvY29jb2Ev U29mdExpbmtpbmcuaAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9jb2NvYS9Tb2Z0TGlua2luZy5oCkBA IC00NzYsNiArNDc2LDEwIEBACiAgICAgeyBcCiAgICAgICAgIHJldHVybiBzb2Z0TGluayMjZnJh bWV3b3JrIyNmdW5jdGlvbk5hbWUgcGFyYW1ldGVyTmFtZXM7IFwKICAgICB9IFwKKyAgICB9IFwK KyAgICBBTFdBWVNfSU5MSU5FIHJlc3VsdFR5cGUgZnVuY3Rpb25OYW1lIHBhcmFtZXRlckRlY2xh cmF0aW9ucyBcCisgICAge1wKKyAgICAgICAgcmV0dXJuIGZ1bmN0aW9uTmFtZXNwYWNlOjpzb2Z0 TGluayMjZnJhbWV3b3JrIyNmdW5jdGlvbk5hbWUgcGFyYW1ldGVyTmFtZXM7IFwKICAgICB9CiAK ICNkZWZpbmUgU09GVF9MSU5LX0ZVTkNUSU9OX0ZPUl9TT1VSQ0UoZnVuY3Rpb25OYW1lc3BhY2Us IGZyYW1ld29yaywgZnVuY3Rpb25OYW1lLCByZXN1bHRUeXBlLCBwYXJhbWV0ZXJEZWNsYXJhdGlv bnMsIHBhcmFtZXRlck5hbWVzKSBcCkBAIC00OTQsMTAgKzQ5OCw2IEBACiAgICAgICAgIH0pOyBc CiAgICAgICAgIHJldHVybiBzb2Z0TGluayMjZnJhbWV3b3JrIyNmdW5jdGlvbk5hbWUgcGFyYW1l dGVyTmFtZXM7IFwKICAgICB9IFwKLSAgICB9IFwKLSAgICByZXN1bHRUeXBlIGZ1bmN0aW9uTmFt ZSBwYXJhbWV0ZXJEZWNsYXJhdGlvbnMgXAotICAgIHtcCi0gICAgICAgIHJldHVybiBmdW5jdGlv bk5hbWVzcGFjZTo6c29mdExpbmsjI2ZyYW1ld29yayMjZnVuY3Rpb25OYW1lIHBhcmFtZXRlck5h bWVzOyBcCiAgICAgfQogCiAjZGVmaW5lIFNPRlRfTElOS19GVU5DVElPTl9NQVlfRkFJTF9GT1Jf SEVBREVSKGZ1bmN0aW9uTmFtZXNwYWNlLCBmcmFtZXdvcmssIGZ1bmN0aW9uTmFtZSwgcmVzdWx0 VHlwZSwgcGFyYW1ldGVyRGVjbGFyYXRpb25zLCBwYXJhbWV0ZXJOYW1lcykgXAo=