178417 2017-10-17 16:56:55 -0700 Some older hardware can't actually use renderbuffers at the size they advertise 2017-10-18 16:42:26 -0700 1 1 1 Unclassified WebKit WebGL WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dino dino ap buildbot dino graouts kondapallykalyan noam sam thorton webkit-bug-importer oldest_to_newest 1361483 0 dino 2017-10-17 16:56:55 -0700 This is failing, but only on older hardware (such as the test bots). Checking drawingBufferWidth/drawingBufferHeight PASS gl.drawingBufferWidth is gl.canvas.width PASS gl.drawingBufferHeight is gl.canvas.height PASS maxSize[0] > 0 is true PASS maxSize[1] > 0 is true MAX_VIEWPORT_DIMS = 16384x16384 canvas = 50x50 PASS gl.drawingBufferWidth > 0 is true PASS gl.drawingBufferHeight > 0 is true PASS gl.drawingBufferWidth <= maxSize[0] is true PASS gl.drawingBufferHeight <= maxSize[1] is true FAIL gl.getError() should be 0. Was 1286. Where 1286 is INVALID_FRAMEBUFFER_OPERATION I assume that trying to allocate such a huge backing store is sort-of working, but not really. I haven't been able to reproduce on newer hardware yet. 1361484 1 webkit-bug-importer 2017-10-17 16:57:55 -0700 <rdar://problem/35042291> 1361931 2 dino 2017-10-18 15:34:01 -0700 Was "webgl/1.0.2/conformance/canvas/drawingbuffer-static-canvas-test.html failing" 1361937 3 324176 dino 2017-10-18 15:39:31 -0700 Created attachment 324176 Patch 1361955 4 dino 2017-10-18 16:42:26 -0700 Committed r223640: <https://trac.webkit.org/changeset/223640> 324176 2017-10-18 15:39:31 -0700 2017-10-18 16:37:43 -0700 Patch bug-178417-20171019093929.patch text/plain 3768 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMjIzNTc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzVkOWNmOGQ0ZDI3MTlk NDg0MzVlNWU5NDJjYzcyMTg5ZDY4MzJhYS4uMjRiNWQwMTJkMDA4NjU2MDdiNGQ4MThmMmU1ZmM4 NDJlNGQzMmYyYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE3LTEwLTE4ICBEZWFu IEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KKworICAgICAgICBTb21lIG9sZGVyIGhhcmR3YXJl IGNhbid0IGFjdHVhbGx5IHVzZSByZW5kZXJidWZmZXJzIGF0IHRoZSBzaXplIHRoZXkgYWR2ZXJ0 aXNlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzg0 MTcKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzM1MDQyMjkxPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBjaGFuZ2UgaW4gcjIyMzU2NyBjYXVz ZWQgc29tZSBvbGRlciBoYXJkd2FyZSB0byBmYWlsLCBiZWNhdXNlIGV2ZW4gdGhvdWdoCisgICAg ICAgIHRoZXkgY2xhaW1lZCB0byBzdXBwb3J0IGEgbWF4aW11bSByZW5kZXJidWZmZXIgYW5kIHZp ZXdwb3J0IG9mIDE2SywgdGhleSB3ZXJlCisgICAgICAgIHVuYWJsZSB0byBhY3R1YWxseSBoYW5k bGUgb25lLiBSYXRoZXIgdGhhbiB0cnlpbmcgdG8gaWRlbnRpZnkgc3VjaCBoYXJkd2FyZSwKKyAg ICAgICAgY2xhbXAgYWxsIGJ1ZmZlcnMgdG8gYSBtYXhpbXVtIG9mIDgxOTIuIFRoaXMgaXMgYmln Z2VyIHRoYW4gdGhlIHByZXZpb3VzIHZhbHVlCisgICAgICAgIG9mIDQwOTYsIGFuZCBsYXJnZSBl bm91Z2ggdG8gaGF2ZSBhIGZ1bGwtc2NyZWVuIGJ1ZmZlciBvbiBhIFJldGluYSA1SyBpTWFjLgor CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mvb3BlbmdsL0dyYXBoaWNzQ29udGV4dDNET3Bl bkdMLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkdyYXBoaWNzQ29udGV4dDNEOjpnZXRJbnRlZ2Vy dik6CisKIDIwMTctMTAtMTYgIFNhbSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9yZz4KIAogICAgICAg ICBbU2V0dGluZ3NdIEdlbmVyYXRlIFNldHRpbmdzLmgvY3BwCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9vcGVuZ2wvR3JhcGhpY3NDb250ZXh0M0RPcGVuR0wu Y3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvb3BlbmdsL0dyYXBoaWNzQ29u dGV4dDNET3BlbkdMLmNwcAppbmRleCAzZGE3ZTE5YzMxMGI3N2I2NTIyNGVkMTBhMDQxNjJlZDU0 NDFmMDRlLi41YmQ3NTU5NDViNzQwNDVlMzQ5MTA3NTQ4M2EzODg3NjFmYWQ4MzExIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9vcGVuZ2wvR3JhcGhpY3NDb250 ZXh0M0RPcGVuR0wuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL29w ZW5nbC9HcmFwaGljc0NvbnRleHQzRE9wZW5HTC5jcHAKQEAgLTMzMyw2ICszMzMsMjAgQEAgdm9p ZCBHcmFwaGljc0NvbnRleHQzRDo6Z2V0SW50ZWdlcnYoR0MzRGVudW0gcG5hbWUsIEdDM0RpbnQq IHZhbHVlKQogICAgICAgICBpZiAoZ2V0RXh0ZW5zaW9ucygpLnJlcXVpcmVzUmVzdHJpY3RlZE1h eGltdW1UZXh0dXJlU2l6ZSgpKQogICAgICAgICAgICAgKnZhbHVlID0gc3RkOjptaW4oMTAyNCwg KnZhbHVlKTsKICAgICAgICAgYnJlYWs7CisjaWYgUExBVEZPUk0oTUFDKQorICAgIC8vIFNvbWUg b2xkZXIgaGFyZHdhcmUgYWR2ZXJ0aXNlcyBhIGxhcmdlciBtYXhpbXVtIHRoYW4gdGhleQorICAg IC8vIGNhbiBhY3R1YWxseSBoYW5kbGUuIFJhdGhlciB0aGFuIGRldGVjdGluZyBzdWNoIGRldmlj ZXMsIHNpbXBseQorICAgIC8vIGNsYW1wIHRoZSBtYXhpbXVtIHRvIDgxOTIsIHdoaWNoIGlzIGJp ZyBlbm91Z2ggZm9yIGEgNUsgZGlzcGxheS4KKyAgICBjYXNlIE1BWF9SRU5ERVJCVUZGRVJfU0la RToKKyAgICAgICAgOjpnbEdldEludGVnZXJ2KE1BWF9SRU5ERVJCVUZGRVJfU0laRSwgdmFsdWUp OworICAgICAgICAqdmFsdWUgPSBzdGQ6Om1pbig4MTkyLCAqdmFsdWUpOworICAgICAgICBicmVh azsKKyAgICBjYXNlIE1BWF9WSUVXUE9SVF9ESU1TOgorICAgICAgICA6OmdsR2V0SW50ZWdlcnYo TUFYX1ZJRVdQT1JUX0RJTVMsIHZhbHVlKTsKKyAgICAgICAgdmFsdWVbMF0gPSBzdGQ6Om1pbig4 MTkyLCB2YWx1ZVswXSk7CisgICAgICAgIHZhbHVlWzFdID0gc3RkOjptaW4oODE5MiwgdmFsdWVb MV0pOworICAgICAgICBicmVhazsKKyNlbmRpZgogICAgIGRlZmF1bHQ6CiAgICAgICAgIDo6Z2xH ZXRJbnRlZ2VydihwbmFtZSwgdmFsdWUpOwogICAgIH0KZGlmZiAtLWdpdCBhL0xheW91dFRlc3Rz L0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCAyNmNmMDE5MzViYWI3NDU4 MDMwYmFlN2Y4YmM3YTI4ZGU4ZGYwYzcxLi4xZDcwNmNiYjExNTFmZjUzMmEzODY0ZjJmOTkxODY2 ZGQxMTE3NDBjIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0 VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTctMTAtMTggIERlYW4gSmFja3Nv biAgPGRpbm9AYXBwbGUuY29tPgorCisgICAgICAgIFNvbWUgb2xkZXIgaGFyZHdhcmUgY2FuJ3Qg YWN0dWFsbHkgdXNlIHJlbmRlcmJ1ZmZlcnMgYXQgdGhlIHNpemUgdGhleSBhZHZlcnRpc2UKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3ODQxNworICAg ICAgICA8cmRhcjovL3Byb2JsZW0vMzUwNDIyOTE+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgVW5za2lwIHdlYmdsLzEuMC4yL2NvbmZvcm1hbmNlL2Nh bnZhcy9kcmF3aW5nYnVmZmVyLXN0YXRpYy1jYW52YXMtdGVzdC5odG1sLgorCisgICAgICAgICog VGVzdEV4cGVjdGF0aW9uczoKKwogMjAxNy0xMC0xNyAgRGVhbiBKYWNrc29uICA8ZGlub0BhcHBs ZS5jb20+CiAKICAgICAgICAgTWFrZSBmYWlsaW5nIFdlYkdMIHRlc3RzIHByb2R1Y2UgZGVidWcg b3V0cHV0CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9UZXN0RXhwZWN0YXRpb25zIGIvTGF5b3V0 VGVzdHMvVGVzdEV4cGVjdGF0aW9ucwppbmRleCBkZmZkZTZjNzljMjk3MDFkMDE2MGU5MjdlMjkw ZmM1ZjE5NDQzNzQwLi5jODc3ZjcwY2RhYjYxOTgwMDZmZjQ3OTdiNDI1MDQwMzI5MzQ3ZThjIDEw MDY0NAotLS0gYS9MYXlvdXRUZXN0cy9UZXN0RXhwZWN0YXRpb25zCisrKyBiL0xheW91dFRlc3Rz L1Rlc3RFeHBlY3RhdGlvbnMKQEAgLTE1MDksNCArMTUwOSwzIEBAIGltcG9ydGVkL3czYy93ZWIt cGxhdGZvcm0tdGVzdHMvY3NzL2Nzcy1wc2V1ZG8tNC9maXJzdC1sZXR0ZXItMDAzLmh0bWwgWyBJ bWFnZU9uCiB3ZWJraXQub3JnL2IvMTc3Nzk5IGFjY2Vzc2liaWxpdHkvdGFibGUtZGV0ZWN0aW9u Lmh0bWwgWyBQYXNzIEZhaWx1cmUgXQogCiB3ZWJraXQub3JnL2IvMTc3OTk3IHdlYmdsLzEuMC4y L2NvbmZvcm1hbmNlL3RleHR1cmVzL2NvcHktdGV4LWltYWdlLTJkLWZvcm1hdHMuaHRtbCBbIFBh c3MgRmFpbHVyZSBdCi13ZWJraXQub3JnL2IvMTc4NDE3IHdlYmdsLzEuMC4yL2NvbmZvcm1hbmNl L2NhbnZhcy9kcmF3aW5nYnVmZmVyLXN0YXRpYy1jYW52YXMtdGVzdC5odG1sIFsgUGFzcyBGYWls dXJlIF0K