178414 2017-10-17 16:01:44 -0700 [FrameView::layout cleanup] Remove redundant body->renderer()->setChildNeedsLayout call 2017-10-17 18:42:31 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham commit-queue simon.fraser webkit-bug-importer zalan oldest_to_newest 1361459 0 zalan 2017-10-17 16:01:44 -0700 it's not getting executed at all. 1361460 1 webkit-bug-importer 2017-10-17 16:02:03 -0700 <rdar://problem/35040876> 1361463 2 324067 zalan 2017-10-17 16:07:44 -0700 Created attachment 324067 Patch 1361481 3 324067 simon.fraser 2017-10-17 16:45:51 -0700 Comment on attachment 324067 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=324067&action=review > Source/WebCore/page/FrameView.cpp:-1444 > - if (!m_firstLayout && m_size.height() != layoutHeight() && body->renderer()->enclosingBox().stretchesToViewport()) > - body->renderer()->setChildNeedsLayout(); Does something else take care of the stretchesToViewport() case? 1361515 4 zalan 2017-10-17 18:14:33 -0700 (In reply to Simon Fraser (smfr) from comment #3) > Comment on attachment 324067 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=324067&action=review > > > Source/WebCore/page/FrameView.cpp:-1444 > > - if (!m_firstLayout && m_size.height() != layoutHeight() && body->renderer()->enclosingBox().stretchesToViewport()) > > - body->renderer()->setChildNeedsLayout(); > > Does something else take care of the stretchesToViewport() case? Yea, I tried to explain it in the Changelog entry. 1361522 5 324067 commit-queue 2017-10-17 18:42:29 -0700 Comment on attachment 324067 Patch Clearing flags on attachment: 324067 Committed r223590: <https://trac.webkit.org/changeset/223590> 1361523 6 commit-queue 2017-10-17 18:42:31 -0700 All reviewed patches have been landed. Closing bug. 324067 2017-10-17 16:07:44 -0700 2017-10-17 18:42:29 -0700 Patch bug-178414-20171017160743.patch text/plain 2907 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjIzNTcwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTU0ZGI3ZWQ1ZmExMTll MDM2OWRiMTYzNmZjYWRjOTMyN2QyNmQwZi4uNjBkMTMwYjI5MmM1NDAwMGYxNmJkNDZjMzczN2Q4 NTFmY2UyNzU0YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIyIEBACiAyMDE3LTEwLTE3ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CiAKKyAgICAgICAgW0ZyYW1lVmlldzo6bGF5b3V0 IGNsZWFudXBdIFJlbW92ZSByZWR1bmRhbnQgYm9keS0+cmVuZGVyZXIoKS0+c2V0Q2hpbGROZWVk c0xheW91dCgpIGNhbGwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE3ODQxNAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzUwNDA4NzY+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU2luY2UgbV9zaXplIGFs d2F5cyBlcXVhbHMgdG8gbGF5b3V0U2l6ZSgpIGF0IHRoaXMgcG9pbnQsIHdlIG5ldmVyIGNhbGwg c2V0Q2hpbGROZWVkc0xheW91dCgpIG9uIHRoZSBib2R5J3MgcmVuZGVyZXIuCisgICAgICAgIEhv d2V2ZXIgYSBmZXcgbGluZXMgYmVsb3csIHdoZW4gd2UgYWRqdXN0IHRoZSBmcmFtZSBzaXplIGFu ZCBjaGVjayBpZiBvbGRTaXplICE9IG1fc2l6ZSwgd2UgYWN0dWFsbHkKKyAgICAgICAgZGlydHkg dGhlIGJvZHkncyByZW5kZXJlci4KKworICAgICAgICBDb3ZlcmVkIGJ5IGV4aXN0aW5nIHRlc3Rz LgorCisgICAgICAgICogcGFnZS9GcmFtZVZpZXcuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RnJh bWVWaWV3OjpsYXlvdXQpOgorCisyMDE3LTEwLTE3ICBaYWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBs ZS5jb20+CisKICAgICAgICAgW0ZyYW1lVmlldzo6bGF5b3V0IGNsZWFudXBdIFN1YnRyZWUgc2hv dWxkIHJlYWQgc3VidHJlZUxheW91dC4KICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE3ODQwMQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdl L0ZyYW1lVmlldy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5jcHAKaW5kZXgg ODJkYmNjYjVkMzg4ZmY3MGQxM2EwMWM2MTQ5YzliMWE4ZTljYTE4Ni4uNmFkZTA1ZWM1OGZmZDVi MTA1NDI2MzRmYzNmZDFkNzBhYzQ0Nzc3OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFn ZS9GcmFtZVZpZXcuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmNwcApA QCAtMTQzMywyNyArMTQzMywxNyBAQCB2b2lkIEZyYW1lVmlldzo6bGF5b3V0KGJvb2wgYWxsb3dT dWJ0cmVlTGF5b3V0KQogICAgICAgICBpZiAoIWxheW91dFJvb3QpCiAgICAgICAgICAgICByZXR1 cm47CiAgICAgICAgIGlzU3VidHJlZUxheW91dCA9IG1fc3VidHJlZUxheW91dFJvb3Q7CisgICAg ICAgIG1fbmVlZHNGdWxsUmVwYWludCA9ICFpc1N1YnRyZWVMYXlvdXQgJiYgKG1fZmlyc3RMYXlv dXQgfHwgZG93bmNhc3Q8UmVuZGVyVmlldz4oKmxheW91dFJvb3QpLnByaW50aW5nKCkpOwogCiAg ICAgICAgIGlmICghaXNTdWJ0cmVlTGF5b3V0KSB7Ci0gICAgICAgICAgICBhdXRvKiBib2R5ID0g ZG9jdW1lbnQuYm9keU9yRnJhbWVzZXQoKTsKLSAgICAgICAgICAgIGlmIChib2R5ICYmIGJvZHkt PnJlbmRlcmVyKCkpIHsKLSAgICAgICAgICAgICAgICBpZiAoaXM8SFRNTEZyYW1lU2V0RWxlbWVu dD4oKmJvZHkpICYmICFmcmFtZUZsYXR0ZW5pbmdFbmFibGVkKCkpIHsKKyAgICAgICAgICAgIGlm IChhdXRvKiBib2R5ID0gZG9jdW1lbnQuYm9keU9yRnJhbWVzZXQoKSkgeworICAgICAgICAgICAg ICAgIGlmIChpczxIVE1MRnJhbWVTZXRFbGVtZW50PigqYm9keSkgJiYgIWZyYW1lRmxhdHRlbmlu Z0VuYWJsZWQoKSAmJiBib2R5LT5yZW5kZXJlcigpKQogICAgICAgICAgICAgICAgICAgICBib2R5 LT5yZW5kZXJlcigpLT5zZXRDaGlsZE5lZWRzTGF5b3V0KCk7Ci0gICAgICAgICAgICAgICAgfSBl bHNlIGlmIChpczxIVE1MQm9keUVsZW1lbnQ+KCpib2R5KSkgewotICAgICAgICAgICAgICAgICAg ICBpZiAoIW1fZmlyc3RMYXlvdXQgJiYgbV9zaXplLmhlaWdodCgpICE9IGxheW91dEhlaWdodCgp ICYmIGJvZHktPnJlbmRlcmVyKCktPmVuY2xvc2luZ0JveCgpLnN0cmV0Y2hlc1RvVmlld3BvcnQo KSkKLSAgICAgICAgICAgICAgICAgICAgICAgIGJvZHktPnJlbmRlcmVyKCktPnNldENoaWxkTmVl ZHNMYXlvdXQoKTsKLSAgICAgICAgICAgICAgICB9CiAgICAgICAgICAgICB9Ci0KICNpZiAhTE9H X0RJU0FCTEVECiAgICAgICAgICAgICBpZiAobV9maXJzdExheW91dCAmJiAhZnJhbWUoKS5vd25l ckVsZW1lbnQoKSkKICAgICAgICAgICAgICAgICBMT0coTGF5b3V0LCAiRnJhbWVWaWV3ICVwIGVs YXBzZWQgdGltZSBiZWZvcmUgZmlyc3QgbGF5b3V0OiAlLjNmc1xuIiwgdGhpcywgZG9jdW1lbnQu dGltZVNpbmNlRG9jdW1lbnRDcmVhdGlvbigpLnZhbHVlKCkpOwogI2VuZGlmCi0gICAgICAgIH0K LQotICAgICAgICBtX25lZWRzRnVsbFJlcGFpbnQgPSAhaXNTdWJ0cmVlTGF5b3V0ICYmIChtX2Zp cnN0TGF5b3V0IHx8IGRvd25jYXN0PFJlbmRlclZpZXc+KCpsYXlvdXRSb290KS5wcmludGluZygp KTsKLQotICAgICAgICBpZiAoIWlzU3VidHJlZUxheW91dCkgewogICAgICAgICAgICAgU2Nyb2xs YmFyTW9kZSBoTW9kZTsKICAgICAgICAgICAgIFNjcm9sbGJhck1vZGUgdk1vZGU7ICAgIAogICAg ICAgICAgICAgY2FsY3VsYXRlU2Nyb2xsYmFyTW9kZXNGb3JMYXlvdXQoaE1vZGUsIHZNb2RlKTsK