<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>178411</bug_id>
          
          <creation_ts>2017-10-17 15:42:03 -0700</creation_ts>
          <short_desc>[iOS] Don&apos;t turn fields yellow after filling credentials</short_desc>
          <delta_ts>2017-10-17 16:38:55 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>iPhone / iPad</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Chelsea Pugh">cpugh</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>cpugh</cc>
    
    <cc>rmondello</cc>
    
    <cc>thorton</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>wenson_hsieh</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1361447</commentid>
    <comment_count>0</comment_count>
    <who name="Chelsea Pugh">cpugh</who>
    <bug_when>2017-10-17 15:42:03 -0700</bug_when>
    <thetext>Don&apos;t turn fields yellow after filling credentials</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1361450</commentid>
    <comment_count>1</comment_count>
      <attachid>324066</attachid>
    <who name="Chelsea Pugh">cpugh</who>
    <bug_when>2017-10-17 15:45:58 -0700</bug_when>
    <thetext>Created attachment 324066
Patch for [iOS] Don&apos;t turn fields yellow after filling credentials</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1361465</commentid>
    <comment_count>2</comment_count>
      <attachid>324066</attachid>
    <who name="Wenson Hsieh">wenson_hsieh</who>
    <bug_when>2017-10-17 16:10:01 -0700</bug_when>
    <thetext>Comment on attachment 324066
Patch for [iOS] Don&apos;t turn fields yellow after filling credentials

rs=me.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1361467</commentid>
    <comment_count>3</comment_count>
      <attachid>324066</attachid>
    <who name="Tim Horton">thorton</who>
    <bug_when>2017-10-17 16:13:00 -0700</bug_when>
    <thetext>Comment on attachment 324066
Patch for [iOS] Don&apos;t turn fields yellow after filling credentials

View in context: https://bugs.webkit.org/attachment.cgi?id=324066&amp;action=review

&gt; Source/WebCore/ChangeLog:5
&gt; +

rdar://?

&gt; Source/WebCore/editing/ios/AutofillElements.cpp:-124
&gt; -        m_username-&gt;setAutoFilled();

Do we still need the underlying mechanism?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1361476</commentid>
    <comment_count>4</comment_count>
      <attachid>324066</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2017-10-17 16:38:30 -0700</bug_when>
    <thetext>Comment on attachment 324066
Patch for [iOS] Don&apos;t turn fields yellow after filling credentials

Clearing flags on attachment: 324066

Committed r223585: &lt;https://trac.webkit.org/changeset/223585&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1361477</commentid>
    <comment_count>5</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2017-10-17 16:38:31 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1361478</commentid>
    <comment_count>6</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2017-10-17 16:38:55 -0700</bug_when>
    <thetext>&lt;rdar://problem/35041874&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>324066</attachid>
            <date>2017-10-17 15:45:58 -0700</date>
            <delta_ts>2017-10-17 16:38:30 -0700</delta_ts>
            <desc>Patch for [iOS] Don&apos;t turn fields yellow after filling credentials</desc>
            <filename>noyellowfields.txt</filename>
            <type>text/plain</type>
            <size>1484</size>
            <attacher name="Chelsea Pugh">cpugh</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No
YW5nZUxvZwppbmRleCA1MzQ4ZDMxNjY5Ni4uNmY4MTVlZmRkMmYgMTAwNjQ0Ci0tLSBhL1NvdXJj
ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs
MyArMSwxNCBAQAorMjAxNy0xMC0xNyAgQ2hlbHNlYSBQdWdoICA8Y3B1Z2hAYXBwbGUuY29tPgor
CisgICAgICAgIFtpT1NdIERvbid0IHR1cm4gZmllbGRzIHllbGxvdyBhZnRlciBmaWxsaW5nIGNy
ZWRlbnRpYWxzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p
ZD0xNzg0MTEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg
ICAqIGVkaXRpbmcvaW9zL0F1dG9maWxsRWxlbWVudHMuY3BwOgorICAgICAgICAoV2ViQ29yZTo6
QXV0b2ZpbGxFbGVtZW50czo6YXV0b2ZpbGwpOiBXZSBkb24ndCB3YW50IHRvIHR1cm4gZmllbGRz
IHllbGxvdyB3aGVuIGZpbGxpbmcgdGhlIHVzZXIgbmFtZQorICAgICAgICBhbmQgcGFzc3dvcmQu
IFJlbW92ZSB0aGUgY29kZSB0aGF0IHdhcyBjYXVzaW5nIHRoYXQgdG8gaGFwcGVuLgorCiAyMDE3
LTEwLTE2ICBEZWFuIEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWJHTCBj
bGFtcHMgZHJhd2luZ0J1ZmZlcldpZHRoIHRvIDQwOTYgcGl4ZWxzIG9uIGEgNTEyMCBtb25pdG9y
L2NhbnZhcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZWRpdGluZy9pb3MvQXV0b2ZpbGxF
bGVtZW50cy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL2lvcy9BdXRvZmlsbEVsZW1lbnRz
LmNwcAppbmRleCA5YmE4YTQ0YzU5Ni4uNzViMWEwNGQ0NzIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X
ZWJDb3JlL2VkaXRpbmcvaW9zL0F1dG9maWxsRWxlbWVudHMuY3BwCisrKyBiL1NvdXJjZS9XZWJD
b3JlL2VkaXRpbmcvaW9zL0F1dG9maWxsRWxlbWVudHMuY3BwCkBAIC0xMTksMTQgKzExOSwxMCBA
QCBzdGQ6Om9wdGlvbmFsPEF1dG9maWxsRWxlbWVudHM+IEF1dG9maWxsRWxlbWVudHM6OmNvbXB1
dGVBdXRvZmlsbEVsZW1lbnRzKFJlZjxIVAogCiB2b2lkIEF1dG9maWxsRWxlbWVudHM6OmF1dG9m
aWxsKFN0cmluZyB1c2VybmFtZSwgU3RyaW5nIHBhc3N3b3JkKQogewotICAgIGlmIChtX3VzZXJu
YW1lKSB7CisgICAgaWYgKG1fdXNlcm5hbWUpCiAgICAgICAgIG1fdXNlcm5hbWUtPnNldFZhbHVl
Rm9yVXNlcih1c2VybmFtZSk7Ci0gICAgICAgIG1fdXNlcm5hbWUtPnNldEF1dG9GaWxsZWQoKTsK
LSAgICB9Ci0gICAgaWYgKG1fcGFzc3dvcmQpIHsKKyAgICBpZiAobV9wYXNzd29yZCkKICAgICAg
ICAgbV9wYXNzd29yZC0+c2V0VmFsdWVGb3JVc2VyKHBhc3N3b3JkKTsKLSAgICAgICAgbV9wYXNz
d29yZC0+c2V0QXV0b0ZpbGxlZCgpOwotICAgIH0KIH0KIAogfSAvLyBuYW1lc3BhY2UgV2ViQ29y
ZQo=
</data>

          </attachment>
      

    </bug>

</bugzilla>