178407 2017-10-17 14:06:39 -0700 [GTK][Stable] BackingStoreBackendCairoImpl.h:23:10: fatal error: WebCore/HysteresisActivity.h 2017-10-18 06:26:58 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Local Build Mac macOS 10.13 RESOLVED FIXED P2 Normal --- 1 s172262 webkit-unassigned bugs-noreply cgarcia clopez mcatanzaro zan oldest_to_newest 1361409 0 s172262 2017-10-17 14:06:39 -0700 I tried to build webkitgtk+ ver 2.18.0 with cairo on macos10.13. >BackingStoreBackendCairoImpl.h:23:10: fatal error: WebCore/HysteresisActivity.h Please change in Source/WebCore/platform/graphics/cairo/BackingStoreBackendCairoImpl.h at line 23. - #include <WebCore/HysteresisActivity.h> + #include <WebCore/platform/HysteresisActivity.h> 1361479 1 mcatanzaro 2017-10-17 16:39:59 -0700 Thanks for this bug report. (In reply to s172262 from comment #0) > I tried to build webkitgtk+ ver 2.18.0 with cairo on macos10.13. > > >BackingStoreBackendCairoImpl.h:23:10: fatal error: WebCore/HysteresisActivity.h > > Please change in > Source/WebCore/platform/graphics/cairo/BackingStoreBackendCairoImpl.h at > line 23. > > - #include <WebCore/HysteresisActivity.h> > + #include <WebCore/platform/HysteresisActivity.h> WebKit coding style is to add the right include directories, so that full paths are not required. So the right fix is to add the right include path in some CMake file somewhere. Can't tell where without more of a build log to see where BackingStoreBackendCairoImpl.h is being included from. But it's very, very odd that WebCore/platform would not already be in the include path. Anyway, HysteresisActivity has been moved to PAL in trunk, so it'll need to be fixed separately for 2.18. We're not going to fix it ourselves as we don't actually develop or support WebKitGTK+ on Mac, but we do consider community patches when posted following the guidance at https://webkit.org/contributing-code/#create-the-patch if you want to take a stab at it. 1361537 2 s172262 2017-10-17 19:30:35 -0700 > We're not going to fix it ourselves as we don't actually develop or support WebKitGTK+ on Mac, > but we do consider community patches when posted following the guidance at > https://webkit.org/contributing-code/#create-the-patch if you want to take a stab at it. I know this isn't only MacOS's matter. See https://www.mail-archive.com/slackbuilds-users@slackbuilds.org/msg17290.html and https://lists.nongnu.org/archive/html/bug-guix/2017-10/msg00083.html 1361546 3 clopez 2017-10-17 20:03:58 -0700 I think the fix may be to include the header quoted as the include is from a header or WebCore into another of WebCore. Can you check if this will fix the issue? - #include <WebCore/HysteresisActivity.h> + #include "HysteresisActivity.h" 1361579 4 324099 cgarcia 2017-10-17 23:38:43 -0700 Created attachment 324099 Patch This is for 2.18, it won't apply in trunk 1361631 5 cgarcia 2017-10-18 02:56:20 -0700 Committed r223597 1361670 6 clopez 2017-10-18 06:26:58 -0700 The fix was merged on WebKitGTK+ 2.18.1 that was released a few hours ago. 324099 2017-10-17 23:38:43 -0700 2017-10-18 02:53:10 -0700 Patch wc-include.diff text/plain 1479 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAyYjg2MmVhODAyMC4uZDEyMjE5ODBiNmUgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNCBAQAorMjAxNy0xMC0xNyAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGln YWxpYS5jb20+CisKKyAgICAgICAgW0dUS11bU3RhYmxlXSBCYWNraW5nU3RvcmVCYWNrZW5kQ2Fp cm9JbXBsLmg6MjM6MTA6IGZhdGFsIGVycm9yOiBXZWJDb3JlL0h5c3RlcmVzaXNBY3Rpdml0eS5o CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzg0MDcK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEbyBub3Qg dXNlICNpbmNsdWRlIDxXZWJDb3JlL0Zvby5oPiBpbnNpZGUgV2ViQ29yZS4KKworICAgICAgICAq IHBsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL0JhY2tpbmdTdG9yZUJhY2tlbmRDYWlyb0ltcGwuaDoK KwogMjAxNy0wOC0xNyAgWmFuIERvYmVyc2VrICA8emRvYmVyc2VrQGlnYWxpYS5jb20+CiAKICAg ICAgICAgW0dTdHJlYW1lcl0gR3N0U3RydWN0dXJlIHNob3VsZG4ndCBiZSBoYW5kbGVkIHRocm91 Z2ggR1JlZlB0cgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv Y2Fpcm8vQmFja2luZ1N0b3JlQmFja2VuZENhaXJvSW1wbC5oIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvY2Fpcm8vQmFja2luZ1N0b3JlQmFja2VuZENhaXJvSW1wbC5oCmluZGV4 IDQ1MzdkMzUxODgyLi5mMzljZWMxNzNlNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvY2Fpcm8vQmFja2luZ1N0b3JlQmFja2VuZENhaXJvSW1wbC5oCisrKyBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL0JhY2tpbmdTdG9yZUJhY2tl bmRDYWlyb0ltcGwuaApAQCAtMjAsNyArMjAsNyBAQAogCiAjaWYgVVNFKENBSVJPKQogI2luY2x1 ZGUgIkJhY2tpbmdTdG9yZUJhY2tlbmRDYWlyby5oIgotI2luY2x1ZGUgPFdlYkNvcmUvSHlzdGVy ZXNpc0FjdGl2aXR5Lmg+CisjaW5jbHVkZSAiSHlzdGVyZXNpc0FjdGl2aXR5LmgiCiAKIG5hbWVz cGFjZSBXZWJDb3JlIHsKIApAQCAtMzMsNyArMzMsNyBAQCBwcml2YXRlOgogICAgIHZvaWQgc2Ny b2xsKGNvbnN0IEludFJlY3QmLCBjb25zdCBJbnRTaXplJikgb3ZlcnJpZGU7CiAKICAgICBSZWZQ dHI8Y2Fpcm9fc3VyZmFjZV90PiBtX3Njcm9sbFN1cmZhY2U7Ci0gICAgV2ViQ29yZTo6SHlzdGVy ZXNpc0FjdGl2aXR5IG1fc2Nyb2xsZWRIeXN0ZXJlc2lzOworICAgIEh5c3RlcmVzaXNBY3Rpdml0 eSBtX3Njcm9sbGVkSHlzdGVyZXNpczsKIH07CiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUK