178391 2017-10-17 09:08:30 -0700 [FrameView::layout cleanup] Move text auto sizing logic to a separate function 2017-10-17 11:11:07 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham commit-queue koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1361246 0 zalan 2017-10-17 09:08:30 -0700 from FrameView::layout 1361247 1 webkit-bug-importer 2017-10-17 09:08:53 -0700 <rdar://problem/35030264> 1361248 2 324017 zalan 2017-10-17 09:12:31 -0700 Created attachment 324017 Patch 1361251 3 324017 koivisto 2017-10-17 09:14:17 -0700 Comment on attachment 324017 Patch r=me 1361263 4 324017 commit-queue 2017-10-17 09:34:49 -0700 Comment on attachment 324017 Patch Clearing flags on attachment: 324017 Committed r223551: <https://trac.webkit.org/changeset/223551> 1361264 5 commit-queue 2017-10-17 09:34:50 -0700 All reviewed patches have been landed. Closing bug. 1361316 6 324017 simon.fraser 2017-10-17 11:11:07 -0700 Comment on attachment 324017 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=324017&action=review > Source/WebCore/page/FrameView.cpp:1304 > +static void applyTextSizingIfNeeded(RenderElement& layoutRoot) I wonder if this name should make it more clear that it does another layout. Maybe relayoutApplyingTextAutoSizingIfNeeded ? 324017 2017-10-17 09:12:31 -0700 2017-10-17 09:34:49 -0700 Patch bug-178391-20171017091230.patch text/plain 3363 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjIzNDUyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzYzZTQ4OTM4ODFjZjAz MDQ5MmJlMDQ4M2NiODI2MGJkZTk2MWViMy4uYjBmZTAyZTFhNThkMzg2OWFmZGMzM2Y3ZTA2Mjcx MWYyNzUzMzVjNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE3LTEwLTE3ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0ZyYW1lVmlldzo6bGF5b3V0 IGNsZWFudXBdIE1vdmUgdGV4dCBhdXRvIHNpemluZyBsb2dpYyB0byBhIHNlcGFyYXRlIGZ1bmN0 aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzgz OTEKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzM1MDMwMjY0PgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIGNoYW5nZSBpbiBmdW5jdGlvbmFsaXR5 LgorCisgICAgICAgICogcGFnZS9GcmFtZVZpZXcuY3BwOgorICAgICAgICAoV2ViQ29yZTo6YXBw bHlUZXh0U2l6aW5nSWZOZWVkZWQpOgorICAgICAgICAoV2ViQ29yZTo6RnJhbWVWaWV3OjpsYXlv dXQpOgorCiAyMDE3LTEwLTE2ICBKZXIgTm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgogCiAg ICAgICAgIEltYWdlRGVjb2RlckFWRk9iakMgZmFpbHMgdG8gY3JlYXRlIG1vcmUgQ01TYW1wbGVC dWZmZXJzIGFmdGVyIGNyZWF0aW5nIGFib3V0IDMyTUIgd29ydGguCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1l Vmlldy5jcHAKaW5kZXggM2I1NTI5YWJkNDc5MzFkYjEyM2E3ZGIyYjNhOTU4NTZhZTA3NTE3Yy4u OWIwNDJkY2E3MDU5ODkwODM5NjNlNWZhYWVhMjMyNWIzYmFkMTQ1ZiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2Uv RnJhbWVWaWV3LmNwcApAQCAtMTMwMCw2ICsxMzAwLDI4IEBAIGlubGluZSB2b2lkIEZyYW1lVmll dzo6Zm9yY2VMYXlvdXRQYXJlbnRWaWV3SWZOZWVkZWQoKQogICAgIG93bmVyUmVuZGVyZXItPnZp ZXcoKS5mcmFtZVZpZXcoKS5zY2hlZHVsZVJlbGF5b3V0KCk7CiB9CiAKKyNpZiBFTkFCTEUoVEVY VF9BVVRPU0laSU5HKQorc3RhdGljIHZvaWQgYXBwbHlUZXh0U2l6aW5nSWZOZWVkZWQoUmVuZGVy RWxlbWVudCYgbGF5b3V0Um9vdCkKK3sKKyAgICBhdXRvJiBzZXR0aW5ncyA9IGxheW91dFJvb3Qu c2V0dGluZ3MoKTsKKyAgICBpZiAoIXNldHRpbmdzLnRleHRBdXRvc2l6aW5nRW5hYmxlZCgpIHx8 IGxheW91dFJvb3QudmlldygpLnByaW50aW5nKCkpCisgICAgICAgIHJldHVybjsKKyAgICBhdXRv IG1pbmltdW1ab29tRm9udFNpemUgPSBzZXR0aW5ncy5taW5pbXVtWm9vbUZvbnRTaXplKCk7Cisg ICAgaWYgKCFtaW5pbXVtWm9vbUZvbnRTaXplKQorICAgICAgICByZXR1cm47CisgICAgYXV0byB0 ZXh0QXV0b3NpemluZ1dpZHRoID0gbGF5b3V0Um9vdC5wYWdlKCkudGV4dEF1dG9zaXppbmdXaWR0 aCgpOworICAgIGlmIChhdXRvIG92ZXJyaWRlV2lkdGggPSBzZXR0aW5ncy50ZXh0QXV0b3Npemlu Z1dpbmRvd1NpemVPdmVycmlkZSgpLndpZHRoKCkpCisgICAgICAgIHRleHRBdXRvc2l6aW5nV2lk dGggPSBvdmVycmlkZVdpZHRoOworICAgIGlmICghdGV4dEF1dG9zaXppbmdXaWR0aCkKKyAgICAg ICAgcmV0dXJuOworICAgIGxheW91dFJvb3QuYWRqdXN0Q29tcHV0ZWRGb250U2l6ZXNPbkJsb2Nr cyhtaW5pbXVtWm9vbUZvbnRTaXplLCB0ZXh0QXV0b3NpemluZ1dpZHRoKTsKKyAgICBpZiAoIWxh eW91dFJvb3QubmVlZHNMYXlvdXQoKSkKKyAgICAgICAgcmV0dXJuOworICAgIExPRyhUZXh0QXV0 b3NpemluZywgIlRleHQgQXV0b3NpemluZzogbWluaW11bVpvb21Gb250U2l6ZT0lLjJmIHRleHRB dXRvc2l6aW5nV2lkdGg9JS4yZiIsIG1pbmltdW1ab29tRm9udFNpemUsIHRleHRBdXRvc2l6aW5n V2lkdGgpOworICAgIGxheW91dFJvb3QubGF5b3V0KCk7Cit9CisjZW5kaWYKKwogdm9pZCBGcmFt ZVZpZXc6OmxheW91dChib29sIGFsbG93U3VidHJlZSkKIHsKICAgICBBU1NFUlRfV0lUSF9TRUNV UklUWV9JTVBMSUNBVElPTighZnJhbWUoKS5kb2N1bWVudCgpLT5pblJlbmRlclRyZWVVcGRhdGUo KSk7CkBAIC0xNTA2LDIwICsxNTI4LDcgQEAgdm9pZCBGcmFtZVZpZXc6OmxheW91dChib29sIGFs bG93U3VidHJlZSkKICAgICAgICAgcm9vdC0+bGF5b3V0KCk7CiAKICNpZiBFTkFCTEUoVEVYVF9B VVRPU0laSU5HKQotICAgICAgICBpZiAoZnJhbWUoKS5zZXR0aW5ncygpLnRleHRBdXRvc2l6aW5n RW5hYmxlZCgpICYmICFyb290LT52aWV3KCkucHJpbnRpbmcoKSkgewotICAgICAgICAgICAgZmxv YXQgbWluaW11bVpvb21Gb250U2l6ZSA9IGZyYW1lKCkuc2V0dGluZ3MoKS5taW5pbXVtWm9vbUZv bnRTaXplKCk7Ci0gICAgICAgICAgICBmbG9hdCB0ZXh0QXV0b3NpemluZ1dpZHRoID0gZnJhbWUo KS5wYWdlKCkgPyBmcmFtZSgpLnBhZ2UoKS0+dGV4dEF1dG9zaXppbmdXaWR0aCgpIDogMDsKLSAg ICAgICAgICAgIGlmIChpbnQgb3ZlcnJpZGVXaWR0aCA9IGZyYW1lKCkuc2V0dGluZ3MoKS50ZXh0 QXV0b3NpemluZ1dpbmRvd1NpemVPdmVycmlkZSgpLndpZHRoKCkpCi0gICAgICAgICAgICAgICAg dGV4dEF1dG9zaXppbmdXaWR0aCA9IG92ZXJyaWRlV2lkdGg7Ci0KLSAgICAgICAgICAgIExPRyhU ZXh0QXV0b3NpemluZywgIlRleHQgQXV0b3NpemluZzogbWluaW11bVpvb21Gb250U2l6ZT0lLjJm IHRleHRBdXRvc2l6aW5nV2lkdGg9JS4yZiIsIG1pbmltdW1ab29tRm9udFNpemUsIHRleHRBdXRv c2l6aW5nV2lkdGgpOwotICAgICAgICAgICAgCi0gICAgICAgICAgICBpZiAobWluaW11bVpvb21G b250U2l6ZSAmJiB0ZXh0QXV0b3NpemluZ1dpZHRoKSB7Ci0gICAgICAgICAgICAgICAgcm9vdC0+ YWRqdXN0Q29tcHV0ZWRGb250U2l6ZXNPbkJsb2NrcyhtaW5pbXVtWm9vbUZvbnRTaXplLCB0ZXh0 QXV0b3NpemluZ1dpZHRoKTsKLSAgICAgICAgICAgICAgICBpZiAocm9vdC0+bmVlZHNMYXlvdXQo KSkKLSAgICAgICAgICAgICAgICAgICAgcm9vdC0+bGF5b3V0KCk7Ci0gICAgICAgICAgICB9Ci0g ICAgICAgIH0KKyAgICAgICAgYXBwbHlUZXh0U2l6aW5nSWZOZWVkZWQoKnJvb3QpOwogI2VuZGlm CiAKICAgICAgICAgQVNTRVJUKG1fbGF5b3V0UGhhc2UgPT0gSW5SZW5kZXJUcmVlTGF5b3V0KTsK