178374 2017-10-16 20:41:24 -0700 ServiceWorkerRegistration should subclass RefCounted<> 2017-10-16 22:14:18 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=174541 InRadar P2 Normal --- 1 cdumez cdumez achristensen beidson commit-queue rniwa webkit-bug-importer youennf oldest_to_newest 1361091 0 cdumez 2017-10-16 20:41:24 -0700 ServiceWorkerRegistration should subclass RefCounted<>. 1361093 1 323982 cdumez 2017-10-16 20:44:27 -0700 Created attachment 323982 Patch 1361097 2 323982 rniwa 2017-10-16 20:47:44 -0700 Comment on attachment 323982 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=323982&action=review > Source/WebCore/workers/service/ServiceWorkerRegistration.h:40 > -class ServiceWorkerRegistration final : public EventTargetWithInlineData, public ActiveDOMObject { > +class ServiceWorkerRegistration final : public EventTargetWithInlineData, public ActiveDOMObject, public RefCounted<ServiceWorkerRegistration> { We typically put RefCounted as the first class listed in the inheritance list. 1361113 3 323991 cdumez 2017-10-16 21:32:38 -0700 Created attachment 323991 Patch 1361124 4 323991 commit-queue 2017-10-16 22:12:56 -0700 Comment on attachment 323991 Patch Clearing flags on attachment: 323991 Committed r223457: <https://trac.webkit.org/changeset/223457> 1361125 5 commit-queue 2017-10-16 22:12:57 -0700 All reviewed patches have been landed. Closing bug. 1361126 6 webkit-bug-importer 2017-10-16 22:14:18 -0700 <rdar://problem/35022851> 323982 2017-10-16 20:44:27 -0700 2017-10-16 21:32:36 -0700 Patch bug-178374-20171016204426.patch text/plain 2174 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjIzNDQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTkzYTc0NDM2ZGM0YWVk NjkyYTljMTcxYzEyNmI5ZDFiY2VlZTgzYS4uY2JkYTk2MDhlMTIyNzYwY2RhZTQwMTE4YzhmM2Mz MzlkNzdhMmU5ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE3LTEwLTE2ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgU2VydmljZVdvcmtlclJlZ2lz dHJhdGlvbiBzaG91bGQgc3ViY2xhc3MgUmVmQ291bnRlZDw+CisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzgzNzQKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTZXJ2aWNlV29ya2VyUmVnaXN0cmF0aW9uIHNo b3VsZCBzdWJjbGFzcyBSZWZDb3VudGVkPD4gb3Igd2UgZW5kIHVwIHdpdGggYW4gaW5maW5pdGUg cmVjdXJzaW9uCisgICAgICAgIHdoZW4gY29uc3RydWN0aW5nIHN1Y2ggb2JqZWN0LiBUaGlzIGlz IGJlY2F1c2UgU2VydmljZVdvcmtlclJlZ2lzdHJhdGlvbiBzdWJjbGFzc2VzCisgICAgICAgIEV2 ZW50VGFyZ2V0V2l0aElubGluZURhdGEgd2hpY2ggaW1wbGVtZW50cyByZWYoKSAvIGRlcmVmKCkg YnkgY2FsbGluZyByZWZFdmVudFRhcmdldCgpIC8KKyAgICAgICAgZGVyZWZFdmVudFRhcmdldCgp LiByZWZFdmVudFRhcmdldCgpIC8gZGVyZWZFdmVudFRhcmdldCgpIGFyZSBpbXBsZW1lbnRlZCBp bgorICAgICAgICBTZXJ2aWNlV29ya2VyUmVnaXN0cmF0aW9uIHNvIHRoYXQgdGhleSBjYWxsIHJl ZigpIC8gZGVyZWYoKSAod2hpY2ggZW5kcyB1cCBiZWluZyBFdmVudFRhcmdldCdzCisgICAgICAg IG1ldGhvZHMpLgorCisgICAgICAgICogd29ya2Vycy9zZXJ2aWNlL1NlcnZpY2VXb3JrZXJSZWdp c3RyYXRpb24uaDoKKwogMjAxNy0xMC0xNiAgWW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5j b20+CiAKICAgICAgICAgW0ZFVENIXSBSZW1vdmUgUmVxdWVzdC50eXBlIGdldHRlcgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvd29ya2Vycy9zZXJ2aWNlL1NlcnZpY2VXb3JrZXJSZWdpc3Ry YXRpb24uaCBiL1NvdXJjZS9XZWJDb3JlL3dvcmtlcnMvc2VydmljZS9TZXJ2aWNlV29ya2VyUmVn aXN0cmF0aW9uLmgKaW5kZXggMzQ5YjE2MmFiY2I0YWZjMDY0ZDMyNmZlOGU4MWE3OTRiYjY3NGZl Ny4uZDdiMTk2YzUwYTRkMTgyOTJkYzM5YTNiYmJiNDZjY2NlMTRlMzg4NCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvd29ya2Vycy9zZXJ2aWNlL1NlcnZpY2VXb3JrZXJSZWdpc3RyYXRpb24u aAorKysgYi9Tb3VyY2UvV2ViQ29yZS93b3JrZXJzL3NlcnZpY2UvU2VydmljZVdvcmtlclJlZ2lz dHJhdGlvbi5oCkBAIC0zNyw3ICszNyw3IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKIGNsYXNzIFNj cmlwdEV4ZWN1dGlvbkNvbnRleHQ7CiBjbGFzcyBTZXJ2aWNlV29ya2VyOwogCi1jbGFzcyBTZXJ2 aWNlV29ya2VyUmVnaXN0cmF0aW9uIGZpbmFsIDogcHVibGljIEV2ZW50VGFyZ2V0V2l0aElubGlu ZURhdGEsIHB1YmxpYyBBY3RpdmVET01PYmplY3QgeworY2xhc3MgU2VydmljZVdvcmtlclJlZ2lz dHJhdGlvbiBmaW5hbCA6IHB1YmxpYyBFdmVudFRhcmdldFdpdGhJbmxpbmVEYXRhLCBwdWJsaWMg QWN0aXZlRE9NT2JqZWN0LCBwdWJsaWMgUmVmQ291bnRlZDxTZXJ2aWNlV29ya2VyUmVnaXN0cmF0 aW9uPiB7CiBwdWJsaWM6CiAgICAgZW51bSBjbGFzcyBVcGRhdGVWaWFDYWNoZSB7CiAgICAgICAg IEltcG9ydHMsCkBAIC02Miw2ICs2Miw5IEBAIHB1YmxpYzoKICAgICB2b2lkIHVwZGF0ZShSZWY8 RGVmZXJyZWRQcm9taXNlPiYmKTsKICAgICB2b2lkIHVucmVnaXN0ZXIoUmVmPERlZmVycmVkUHJv bWlzZT4mJik7CiAKKyAgICB1c2luZyBSZWZDb3VudGVkOjpyZWY7CisgICAgdXNpbmcgUmVmQ291 bnRlZDo6ZGVyZWY7CisKIHByaXZhdGU6CiAgICAgU2VydmljZVdvcmtlclJlZ2lzdHJhdGlvbihT Y3JpcHRFeGVjdXRpb25Db250ZXh0JiwgY29uc3QgU2VydmljZVdvcmtlclJlZ2lzdHJhdGlvbkRh dGEmKTsKIAo= 323991 2017-10-16 21:32:38 -0700 2017-10-16 22:12:56 -0700 Patch bug-178374-20171016213237.patch text/plain 2172 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjIzNDQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTkzYTc0NDM2ZGM0YWVk NjkyYTljMTcxYzEyNmI5ZDFiY2VlZTgzYS4uNzUxYzI4YzFjNDNmNTg1ODU4YTUyYWVlYTJmYzU3 ZWQ5ODNjZjkwOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE3LTEwLTE2ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgU2VydmljZVdvcmtlclJlZ2lz dHJhdGlvbiBzaG91bGQgc3ViY2xhc3MgUmVmQ291bnRlZDw+CisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzgzNzQKKworICAgICAgICBSZXZpZXdlZCBi eSBSeW9zdWtlIE5pd2EuCisKKyAgICAgICAgU2VydmljZVdvcmtlclJlZ2lzdHJhdGlvbiBzaG91 bGQgc3ViY2xhc3MgUmVmQ291bnRlZDw+IG9yIHdlIGVuZCB1cCB3aXRoIGFuIGluZmluaXRlIHJl Y3Vyc2lvbgorICAgICAgICB3aGVuIGNvbnN0cnVjdGluZyBzdWNoIG9iamVjdC4gVGhpcyBpcyBi ZWNhdXNlIFNlcnZpY2VXb3JrZXJSZWdpc3RyYXRpb24gc3ViY2xhc3NlcworICAgICAgICBFdmVu dFRhcmdldFdpdGhJbmxpbmVEYXRhIHdoaWNoIGltcGxlbWVudHMgcmVmKCkgLyBkZXJlZigpIGJ5 IGNhbGxpbmcgcmVmRXZlbnRUYXJnZXQoKSAvCisgICAgICAgIGRlcmVmRXZlbnRUYXJnZXQoKS4g cmVmRXZlbnRUYXJnZXQoKSAvIGRlcmVmRXZlbnRUYXJnZXQoKSBhcmUgaW1wbGVtZW50ZWQgaW4K KyAgICAgICAgU2VydmljZVdvcmtlclJlZ2lzdHJhdGlvbiBzbyB0aGF0IHRoZXkgY2FsbCByZWYo KSAvIGRlcmVmKCkgKHdoaWNoIGVuZHMgdXAgYmVpbmcgRXZlbnRUYXJnZXQncworICAgICAgICBt ZXRob2RzKS4KKworICAgICAgICAqIHdvcmtlcnMvc2VydmljZS9TZXJ2aWNlV29ya2VyUmVnaXN0 cmF0aW9uLmg6CisKIDIwMTctMTAtMTYgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29t PgogCiAgICAgICAgIFtGRVRDSF0gUmVtb3ZlIFJlcXVlc3QudHlwZSBnZXR0ZXIKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL3dvcmtlcnMvc2VydmljZS9TZXJ2aWNlV29ya2VyUmVnaXN0cmF0 aW9uLmggYi9Tb3VyY2UvV2ViQ29yZS93b3JrZXJzL3NlcnZpY2UvU2VydmljZVdvcmtlclJlZ2lz dHJhdGlvbi5oCmluZGV4IDM0OWIxNjJhYmNiNGFmYzA2NGQzMjZmZThlODFhNzk0YmI2NzRmZTcu LmVhNmIwNTMwMzkxY2ViYzZkZWIxNDlhN2YzN2E1ZTI4YjNiOTJiZjQgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3dvcmtlcnMvc2VydmljZS9TZXJ2aWNlV29ya2VyUmVnaXN0cmF0aW9uLmgK KysrIGIvU291cmNlL1dlYkNvcmUvd29ya2Vycy9zZXJ2aWNlL1NlcnZpY2VXb3JrZXJSZWdpc3Ry YXRpb24uaApAQCAtMzcsNyArMzcsNyBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiBjbGFzcyBTY3Jp cHRFeGVjdXRpb25Db250ZXh0OwogY2xhc3MgU2VydmljZVdvcmtlcjsKIAotY2xhc3MgU2Vydmlj ZVdvcmtlclJlZ2lzdHJhdGlvbiBmaW5hbCA6IHB1YmxpYyBFdmVudFRhcmdldFdpdGhJbmxpbmVE YXRhLCBwdWJsaWMgQWN0aXZlRE9NT2JqZWN0IHsKK2NsYXNzIFNlcnZpY2VXb3JrZXJSZWdpc3Ry YXRpb24gZmluYWwgOiBwdWJsaWMgUmVmQ291bnRlZDxTZXJ2aWNlV29ya2VyUmVnaXN0cmF0aW9u PiwgcHVibGljIEV2ZW50VGFyZ2V0V2l0aElubGluZURhdGEsIHB1YmxpYyBBY3RpdmVET01PYmpl Y3QgewogcHVibGljOgogICAgIGVudW0gY2xhc3MgVXBkYXRlVmlhQ2FjaGUgewogICAgICAgICBJ bXBvcnRzLApAQCAtNjIsNiArNjIsOSBAQCBwdWJsaWM6CiAgICAgdm9pZCB1cGRhdGUoUmVmPERl ZmVycmVkUHJvbWlzZT4mJik7CiAgICAgdm9pZCB1bnJlZ2lzdGVyKFJlZjxEZWZlcnJlZFByb21p c2U+JiYpOwogCisgICAgdXNpbmcgUmVmQ291bnRlZDo6cmVmOworICAgIHVzaW5nIFJlZkNvdW50 ZWQ6OmRlcmVmOworCiBwcml2YXRlOgogICAgIFNlcnZpY2VXb3JrZXJSZWdpc3RyYXRpb24oU2Ny aXB0RXhlY3V0aW9uQ29udGV4dCYsIGNvbnN0IFNlcnZpY2VXb3JrZXJSZWdpc3RyYXRpb25EYXRh Jik7CiAK