178352 2017-10-16 11:37:04 -0700 run-webkit-tests help text should mention arguments too 2017-10-16 18:09:38 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ross.kirsling webkit-unassigned ap buildbot commit-queue don.olmstead glenn thorton webkit-bug-importer oldest_to_newest 1360854 0 ross.kirsling 2017-10-16 11:37:04 -0700 run-webkit-tests help text should mention arguments too 1360855 1 323915 ross.kirsling 2017-10-16 11:37:19 -0700 Created attachment 323915 Patch 1360857 2 ross.kirsling 2017-10-16 11:38:55 -0700 This is using the deprecated optparse instead of argparse, so apparently the only way to document arguments is by writing the Usage line manually. Still, this is an improvement for people just getting started with LayoutTests. 1360859 3 323915 thorton 2017-10-16 11:43:18 -0700 Comment on attachment 323915 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=323915&action=review > Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:346 > + option_parser = optparse.OptionParser(usage="run_webkit_tests.py [options] [<path>...]") Technically run_webkit_tests.py should be %prog 1360861 4 thorton 2017-10-16 11:44:31 -0700 Though oddly it shows the .py even though I'm running it as 'run-webkit-tests', so maybe this is already broken somehow. 1360866 5 323919 ross.kirsling 2017-10-16 11:51:40 -0700 Created attachment 323919 Patch 1360921 6 323919 commit-queue 2017-10-16 13:27:23 -0700 Comment on attachment 323919 Patch Clearing flags on attachment: 323919 Committed r223429: <https://trac.webkit.org/changeset/223429> 1360922 7 commit-queue 2017-10-16 13:27:25 -0700 All reviewed patches have been landed. Closing bug. 1360925 8 webkit-bug-importer 2017-10-16 13:29:10 -0700 <rdar://problem/35013298> 1361040 9 ap 2017-10-16 18:03:21 -0700 What is the observable effect of this change? There was a lot of documentation about arguments printed by run-webkit-tests —help already. 1361041 10 thorton 2017-10-16 18:09:38 -0700 (In reply to Alexey Proskuryakov from comment #9) > What is the observable effect of this change? There was a lot of > documentation about arguments printed by run-webkit-tests —help already. This just changes the very first line, which previously didn’t mention the fact that you can pass test paths. 323915 2017-10-16 11:37:19 -0700 2017-10-16 11:51:38 -0700 Patch bug-178352-20171016113718.patch text/plain 1444 ross.kirsling U3VidmVyc2lvbiBSZXZpc2lvbjogMjIzMjcwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggODY4ZjJlYTA4M2UwODgwZDIxYWUzZDQwYTBjYjM2NjZj NGVkODUzOS4uN2FhMmJmODI2MTY3NjM5NDNiODZlMzM4MjEzZjdiMjczNzEzZDIzYyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDE3LTEwLTE2ICBSb3NzIEtpcnNsaW5nICA8cm9zcy5raXJzbGluZ0Bzb255LmNvbT4K KworICAgICAgICBydW4td2Via2l0LXRlc3RzIGhlbHAgdGV4dCBzaG91bGQgbWVudGlvbiBhcmd1 bWVudHMgdG9vCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNzgzNTIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3J1bl93ZWJraXRfdGVzdHMucHk6Cisg ICAgICAgIChwYXJzZV9hcmdzKToKKwogMjAxNy0xMC0xMiAgWW91ZW5uIEZhYmxldCAgPHlvdWVu bkBhcHBsZS5jb20+CiAKICAgICAgICAgTGF5b3V0IFRlc3QgaHR0cC90ZXN0cy9jYWNoZS1zdG9y YWdlL2NhY2hlLWNsZWFyaW5nLmh0dHBzLmh0bWwgaXMgZmFpbGluZwpkaWZmIC0tZ2l0IGEvVG9v bHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcnVuX3dlYmtpdF90ZXN0cy5weSBiL1Rv b2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3J1bl93ZWJraXRfdGVzdHMucHkKaW5k ZXggMGM2MTdjOGMzMGJlNTVkNzY5NWI0YTU3ZTgxZmQxYWVhOGYzN2QzMi4uYTUxNTAwMGI1ZjRl YWFlMjM3ZWVmNjdkYmVkZjM3ZWQyY2FmNjM3YyAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy93 ZWJraXRweS9sYXlvdXRfdGVzdHMvcnVuX3dlYmtpdF90ZXN0cy5weQorKysgYi9Ub29scy9TY3Jp cHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9ydW5fd2Via2l0X3Rlc3RzLnB5CkBAIC0zNDMsNyAr MzQzLDcgQEAgZGVmIHBhcnNlX2FyZ3MoYXJncyk6CiAgICAgICAgICAgICBoZWxwPSgiSWYgc3Bl Y2lmaWVkLCB0ZXN0cyBhcmUgYWxsb3dlZCB0byBtYWtlIHJlcXVlc3RzIHRvIHRoZSBzcGVjaWZp ZWQgaG9zdG5hbWUuIikpCiAgICAgXSkpCiAKLSAgICBvcHRpb25fcGFyc2VyID0gb3B0cGFyc2Uu T3B0aW9uUGFyc2VyKCkKKyAgICBvcHRpb25fcGFyc2VyID0gb3B0cGFyc2UuT3B0aW9uUGFyc2Vy KHVzYWdlPSJydW5fd2Via2l0X3Rlc3RzLnB5IFtvcHRpb25zXSBbPHBhdGg+Li4uXSIpCiAKICAg ICBmb3IgZ3JvdXBfbmFtZSwgZ3JvdXBfb3B0aW9ucyBpbiBvcHRpb25fZ3JvdXBfZGVmaW5pdGlv bnM6CiAgICAgICAgIG9wdGlvbl9ncm91cCA9IG9wdHBhcnNlLk9wdGlvbkdyb3VwKG9wdGlvbl9w YXJzZXIsIGdyb3VwX25hbWUpCg== 323919 2017-10-16 11:51:40 -0700 2017-10-16 13:27:23 -0700 Patch bug-178352-20171016115140.patch text/plain 1430 ross.kirsling U3VidmVyc2lvbiBSZXZpc2lvbjogMjIzMjcwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggODY4ZjJlYTA4M2UwODgwZDIxYWUzZDQwYTBjYjM2NjZj NGVkODUzOS4uN2FhMmJmODI2MTY3NjM5NDNiODZlMzM4MjEzZjdiMjczNzEzZDIzYyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDE3LTEwLTE2ICBSb3NzIEtpcnNsaW5nICA8cm9zcy5raXJzbGluZ0Bzb255LmNvbT4K KworICAgICAgICBydW4td2Via2l0LXRlc3RzIGhlbHAgdGV4dCBzaG91bGQgbWVudGlvbiBhcmd1 bWVudHMgdG9vCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNzgzNTIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3J1bl93ZWJraXRfdGVzdHMucHk6Cisg ICAgICAgIChwYXJzZV9hcmdzKToKKwogMjAxNy0xMC0xMiAgWW91ZW5uIEZhYmxldCAgPHlvdWVu bkBhcHBsZS5jb20+CiAKICAgICAgICAgTGF5b3V0IFRlc3QgaHR0cC90ZXN0cy9jYWNoZS1zdG9y YWdlL2NhY2hlLWNsZWFyaW5nLmh0dHBzLmh0bWwgaXMgZmFpbGluZwpkaWZmIC0tZ2l0IGEvVG9v bHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcnVuX3dlYmtpdF90ZXN0cy5weSBiL1Rv b2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3J1bl93ZWJraXRfdGVzdHMucHkKaW5k ZXggMGM2MTdjOGMzMGJlNTVkNzY5NWI0YTU3ZTgxZmQxYWVhOGYzN2QzMi4uNmU2YjM5OTJlMzgw N2QxZDE5OGE5Y2FlMGE1YjAyMGM2NTM2MGNjZiAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy93 ZWJraXRweS9sYXlvdXRfdGVzdHMvcnVuX3dlYmtpdF90ZXN0cy5weQorKysgYi9Ub29scy9TY3Jp cHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9ydW5fd2Via2l0X3Rlc3RzLnB5CkBAIC0zNDMsNyAr MzQzLDcgQEAgZGVmIHBhcnNlX2FyZ3MoYXJncyk6CiAgICAgICAgICAgICBoZWxwPSgiSWYgc3Bl Y2lmaWVkLCB0ZXN0cyBhcmUgYWxsb3dlZCB0byBtYWtlIHJlcXVlc3RzIHRvIHRoZSBzcGVjaWZp ZWQgaG9zdG5hbWUuIikpCiAgICAgXSkpCiAKLSAgICBvcHRpb25fcGFyc2VyID0gb3B0cGFyc2Uu T3B0aW9uUGFyc2VyKCkKKyAgICBvcHRpb25fcGFyc2VyID0gb3B0cGFyc2UuT3B0aW9uUGFyc2Vy KHVzYWdlPSIlcHJvZyBbb3B0aW9uc10gWzxwYXRoPi4uLl0iKQogCiAgICAgZm9yIGdyb3VwX25h bWUsIGdyb3VwX29wdGlvbnMgaW4gb3B0aW9uX2dyb3VwX2RlZmluaXRpb25zOgogICAgICAgICBv cHRpb25fZ3JvdXAgPSBvcHRwYXJzZS5PcHRpb25Hcm91cChvcHRpb25fcGFyc2VyLCBncm91cF9u YW1lKQo=