178342 2017-10-16 09:14:50 -0700 REGRESSION(223307): ASSERTION FAILED: document.page() in WebCore::ResourceLoadObserver::logUserInteractionWithReducedTimeResolution(WebCore::Document const&) 2017-10-16 11:06:01 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ryanhaddad bfulgham bfulgham cdumez jlewis3 webkit-bug-importer oldest_to_newest 1360776 0 ryanhaddad 2017-10-16 09:14:50 -0700 The following two API tests are timing out due to an assertion failure: WebKit2_CommandBackForwardTestWKWebView.LTR WebKit2_CommandBackForwardTestWKWebView.RTL ASSERTION FAILED: document.page() /Volumes/Data/slave/elcapitan-debug/build/Source/WebCore/loader/ResourceLoadObserver.cpp(277) : void WebCore::ResourceLoadObserver::logUserInteractionWithReducedTimeResolution(const WebCore::Document &) 1 0x11bf10ec0 WTFCrash 2 0x10fa8ff77 WebCore::ResourceLoadObserver::logUserInteractionWithReducedTimeResolution(WebCore::Document const&) 3 0x10dce5c0f WebCore::EventHandler::keyEvent(WebCore::PlatformKeyboardEvent const&) 4 0x11015860b WebCore::UserInputBridge::handleKeyEvent(WebCore::PlatformKeyboardEvent const&, WebCore::InputSource) 5 0x109776edd WebKit::handleKeyEvent(WebKit::WebKeyboardEvent const&, WebCore::Page*) 6 0x109776d84 WebKit::WebPage::keyEvent(WebKit::WebKeyboardEvent const&) 7 0x1098072df void IPC::callMemberFunctionImpl<WebKit::WebPage, void (WebKit::WebPage::*)(WebKit::WebKeyboardEvent const&), std::__1::tuple<WebKit::WebKeyboardEvent>, 0ul>(WebKit::WebPage*, void (WebKit::WebPage::*)(WebKit::WebKeyboardEvent const&), std::__1::tuple<WebKit::WebKeyboardEvent>&&, std::__1::integer_sequence<unsigned long, 0ul>) 8 0x109807238 void IPC::callMemberFunction<WebKit::WebPage, void (WebKit::WebPage::*)(WebKit::WebKeyboardEvent const&), std::__1::tuple<WebKit::WebKeyboardEvent>, std::__1::integer_sequence<unsigned long, 0ul> >(std::__1::tuple<WebKit::WebKeyboardEvent>&&, WebKit::WebPage*, void (WebKit::WebPage::*)(WebKit::WebKeyboardEvent const&)) 9 0x1097f7612 void IPC::handleMessage<Messages::WebPage::KeyEvent, WebKit::WebPage, void (WebKit::WebPage::*)(WebKit::WebKeyboardEvent const&)>(IPC::Decoder&, WebKit::WebPage*, void (WebKit::WebPage::*)(WebKit::WebKeyboardEvent const&)) 10 0x1097f0660 WebKit::WebPage::didReceiveWebPageMessage(IPC::Connection&, IPC::Decoder&) 11 0x10977bd67 WebKit::WebPage::didReceiveMessage(IPC::Connection&, IPC::Decoder&) 12 0x10977bda7 non-virtual thunk to WebKit::WebPage::didReceiveMessage(IPC::Connection&, IPC::Decoder&) 13 0x1090c1624 IPC::MessageReceiverMap::dispatchMessage(IPC::Connection&, IPC::Decoder&) 14 0x10997cc6d WebKit::WebProcess::didReceiveMessage(IPC::Connection&, IPC::Decoder&) 15 0x108fb5513 IPC::Connection::dispatchMessage(IPC::Decoder&) 16 0x108fac7d1 IPC::Connection::dispatchMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >) 17 0x108fb5b1f IPC::Connection::dispatchOneMessage() 18 0x108fbcb4d IPC::Connection::enqueueIncomingMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >)::$_14::operator()() 19 0x108fbca9c WTF::Function<void ()>::CallableWrapper<IPC::Connection::enqueueIncomingMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >)::$_14>::call() 20 0x11bf4f0fe WTF::Function<void ()>::operator()() const 21 0x11bf6f67b WTF::RunLoop::performWork() 22 0x11bf6ff64 WTF::RunLoop::performWork(void*) 23 0x7fff9e9497e1 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ 24 0x7fff9e928f0c __CFRunLoopDoSources0 25 0x7fff9e92842f __CFRunLoopRun 26 0x7fff9e927e28 CFRunLoopRunSpecific 27 0x7fff9f4cf935 RunCurrentEventLoopInMode 28 0x7fff9f4cf76f ReceiveNextEventCommon 29 0x7fff9f4cf5af _BlockUntilNextEventMatchingListInModeWithFilter 30 0x7fff96047df6 _DPSNextEvent 31 0x7fff96047226 -[NSApplication _nextEventMatchingEventMask:untilDate:inMode:dequeue:] https://build.webkit.org/builders/Apple%20Sierra%20Debug%20WK2%20%28Tests%29/builds/3521 1360777 1 ryanhaddad 2017-10-16 09:15:26 -0700 This started with https://trac.webkit.org/changeset/223307/webkit. Brent, do the tests need to be updated? 1360803 2 bfulgham 2017-10-16 10:01:00 -0700 (In reply to Ryan Haddad from comment #1) > This started with https://trac.webkit.org/changeset/223307/webkit. > > Brent, do the tests need to be updated? No, but I think this assertion isn't quite right. I'll fix this to get the bots green. 1360805 3 bfulgham 2017-10-16 10:04:42 -0700 In Bug 178183 I made a mistake in the topDocument to use for logging user interaction. I was using 'topDocument->topDocument()', which I should have been using 'm_frame.document()->topDocument()'. 1360806 4 webkit-bug-importer 2017-10-16 10:07:45 -0700 <rdar://problem/35008505> 1360807 5 323904 bfulgham 2017-10-16 10:07:59 -0700 Created attachment 323904 Patch 1360808 6 323904 cdumez 2017-10-16 10:10:26 -0700 Comment on attachment 323904 Patch r=me 1360812 7 bfulgham 2017-10-16 10:18:02 -0700 (In reply to Chris Dumez from comment #6) > Comment on attachment 323904 [details] > Patch > > r=me I'll obviously fix my lack of an "address-of" operator before landing. :-\ 1360835 8 bfulgham 2017-10-16 11:06:01 -0700 Committed r223418: <https://trac.webkit.org/changeset/223418> 323904 2017-10-16 10:07:59 -0700 2017-10-16 10:10:26 -0700 Patch bug-178342-20171016100759.patch text/plain 1628 bfulgham SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIyMzQxMykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE3LTEwLTE2ICBCcmVudCBG dWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04oMjIzMzA3 KTogQVNTRVJUSU9OIGluIFdlYkNvcmU6OlJlc291cmNlTG9hZE9ic2VydmVyOjpsb2dVc2VySW50 ZXJhY3Rpb25XaXRoUmVkdWNlZFRpbWVSZXNvbHV0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzgzNDIKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbiByMjIzMzA3IEkgbWlzdGFrZW5seSB1c2VkICd0 b3BEb2N1bWVudC0+dG9wRG9jdW1lbnQoKScgYmVjYXVzZSBvZiBhIGNvcHkvcGFzdGUgZXJyb3Iu IEkgc2hvdWxkIGhhdmUganVzdCB1c2VkCisgICAgICAgICd0b3BEb2N1bWVudCcuCisKKyAgICAg ICAgVGVzdHM6IENvbW1hbmRCYWNrRm9yd2FyZFRlc3RXS1dlYlZpZXcgaW4gVGVzdFdlYktpdEFQ SS4KKworICAgICAgICAqIHBhZ2UvRXZlbnRIYW5kbGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OkV2ZW50SGFuZGxlcjo6a2V5RXZlbnQpOiBDb3JyZWN0IHRoZSBhcmd1bWVudCBwYXNzZWQgdG8g dGhlIGxvZyBmdW5jdGlvbi4KKwogMjAxNy0xMC0xNiAgQWxlamFuZHJvIEcuIENhc3RybyAgPGFs ZXhAaWdhbGlhLmNvbT4KIAogICAgICAgICBNYWtlIFJlYWx0aW1lSW5jb21pbmdBdWRpb1NvdXJj ZXMgYW5kIFJlYWx0aW1lT3V0Z29pbmdBdWRpb1NvdXJjZXMgcG9ydCBhZ25vc3RpYwpJbmRleDog U291cmNlL1dlYkNvcmUvcGFnZS9FdmVudEhhbmRsZXIuY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9XZWJDb3JlL3BhZ2UvRXZlbnRIYW5kbGVyLmNwcAkocmV2aXNpb24gMjIzMzEyKQorKysgU291 cmNlL1dlYkNvcmUvcGFnZS9FdmVudEhhbmRsZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zMTMw LDcgKzMxMzAsNyBAQCBib29sIEV2ZW50SGFuZGxlcjo6a2V5RXZlbnQoY29uc3QgUGxhdGZvCiAg ICAgICAgIGlmICghd2FzSGFuZGxlZCkKICAgICAgICAgICAgIHRvcERvY3VtZW50LT5zZXRVc2Vy RGlkSW50ZXJhY3RXaXRoUGFnZShzYXZlZFVzZXJEaWRJbnRlcmFjdFdpdGhQYWdlKTsKICAgICAg ICAgZWxzZQotICAgICAgICAgICAgUmVzb3VyY2VMb2FkT2JzZXJ2ZXI6OnNoYXJlZCgpLmxvZ1Vz ZXJJbnRlcmFjdGlvbldpdGhSZWR1Y2VkVGltZVJlc29sdXRpb24odG9wRG9jdW1lbnQtPnRvcERv Y3VtZW50KCkpOworICAgICAgICAgICAgUmVzb3VyY2VMb2FkT2JzZXJ2ZXI6OnNoYXJlZCgpLmxv Z1VzZXJJbnRlcmFjdGlvbldpdGhSZWR1Y2VkVGltZVJlc29sdXRpb24odG9wRG9jdW1lbnQpOwog ICAgIH0KIAogICAgIHJldHVybiB3YXNIYW5kbGVkOwo=