178325 2017-10-15 19:55:00 -0700 Web Inspector: scrolling the editor while debugging shouldn't trigger popovers 2019-06-19 14:36:15 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=199036 InRadar P2 Normal --- 1 mattbaker mattbaker commit-queue hi inspector-bugzilla-changes webkit-bug-importer oldest_to_newest 1360639 0 mattbaker 2017-10-15 19:55:00 -0700 Summary: Scrolling the editor while debugging shouldn't trigger popovers. After one or more mousewheel events, a single mousemove event is fired. This causes the CodeMirrorTokenTrackingController to display a popover if a token comes to rest under the cursor. This can be *extremely* distracting when reading/scrolling code while the debugger is paused. It also causes a situation where popovers can appear while the mouse cursor is hidden. Steps to Reproduce: 1. Pause in the debugger 2. Cursor around in the editor using the arrow keys => The mouse cursor disappears 3. Scroll the editor using the trackpad/mouse wheel, a few lines at a time => Popover eventually appears once hidden cursor comes to rest over a token 1360641 1 323863 mattbaker 2017-10-15 19:57:45 -0700 Created attachment 323863 Patch 1360642 2 webkit-bug-importer 2017-10-15 19:58:57 -0700 <rdar://problem/35000636> 1362981 3 323863 hi 2017-10-20 21:40:03 -0700 Comment on attachment 323863 Patch r=me. Nice! I've definitely run into this issue before :P 1362991 4 323863 commit-queue 2017-10-20 22:04:32 -0700 Comment on attachment 323863 Patch Clearing flags on attachment: 323863 Committed r223807: <https://trac.webkit.org/changeset/223807> 1362992 5 commit-queue 2017-10-20 22:04:33 -0700 All reviewed patches have been landed. Closing bug. 323863 2017-10-15 19:57:45 -0700 2017-10-20 22:04:32 -0700 Patch bug-178325-20171015195745.patch text/plain 3898 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMjIzMzMwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCBi YTg1YWFkZDhhZTRjNDNmODI2M2E5MDZhZTc5MGQyYzBkMTZjMjdkLi4zOWUwMDM4Y2JkYjlhZDI5 MzllYThhZGJkNjI0NWMzZDJkNTFiOWM1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMCBAQAorMjAxNy0xMC0xNSAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3Rvcjogc2Nyb2xsaW5nIHRoZSBlZGl0b3Igd2hpbGUgZGVi dWdnaW5nIHNob3VsZG4ndCB0cmlnZ2VyIHBvcG92ZXJzCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzgzMjUKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJZ25vcmUgdGhlIG5leHQgIm1vdXNlbW92ZSIgZXZl bnQgaW1tZWRpYXRlbHkgZm9sbG93aW5nIGEgIm1vdXNld2hlZWwiLAorICAgICAgICB3aGVuIGRl dGVybWluaW5nIHRoZSBob3ZlcmVkIGl0ZW0gZm9yIHB1cnBvc2VzIG9mIHRyaWdnZXJpbmcgYSBw b3BvdmVyLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9Db250cm9sbGVycy9Db2RlTWlycm9y VG9rZW5UcmFja2luZ0NvbnRyb2xsZXIuanM6CisgICAgICAgIChXSS5Db2RlTWlycm9yVG9rZW5U cmFja2luZ0NvbnRyb2xsZXIpOgorICAgICAgICAoV0kuQ29kZU1pcnJvclRva2VuVHJhY2tpbmdD b250cm9sbGVyLnByb3RvdHlwZS5fc3RhcnRUcmFja2luZyk6CisgICAgICAgIChXSS5Db2RlTWly cm9yVG9rZW5UcmFja2luZ0NvbnRyb2xsZXIucHJvdG90eXBlLl9zdG9wVHJhY2tpbmcpOgorICAg ICAgICAoV0kuQ29kZU1pcnJvclRva2VuVHJhY2tpbmdDb250cm9sbGVyLnByb3RvdHlwZS5oYW5k bGVFdmVudCk6CisgICAgICAgIChXSS5Db2RlTWlycm9yVG9rZW5UcmFja2luZ0NvbnRyb2xsZXIu cHJvdG90eXBlLl9tb3VzZU1vdmVkT3ZlckVkaXRvcik6CisKIDIwMTctMTAtMTQgIE5pa2l0YSBW YXNpbHlldiAgPG52YXNpbHlldkBhcHBsZS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTiAocjIy MzMxMCk6IFdlYiBJbnNwZWN0b3I6IENsYXNzIGxpc3QgY29udGFpbmVyIGlzIHRyYW5zcGFyZW50 IGFuZCB1bnJlYWRhYmxlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlcklu dGVyZmFjZS9Db250cm9sbGVycy9Db2RlTWlycm9yVG9rZW5UcmFja2luZ0NvbnRyb2xsZXIuanMg Yi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Db250cm9sbGVycy9Db2RlTWly cm9yVG9rZW5UcmFja2luZ0NvbnRyb2xsZXIuanMKaW5kZXggZGNlNGI5NjMzOTBiNDYwZTRhYTRh Y2U4YjNiZWMzODU5YzY0MzFlMy4uZTg1OTZjNzA4ODZmNWI3MzJlNTFhYjg0NmYyNjc2ZWIzNTcw MDNlZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQ29u dHJvbGxlcnMvQ29kZU1pcnJvclRva2VuVHJhY2tpbmdDb250cm9sbGVyLmpzCisrKyBiL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0NvbnRyb2xsZXJzL0NvZGVNaXJyb3JUb2tl blRyYWNraW5nQ29udHJvbGxlci5qcwpAQCAtNDMsNiArNDMsNyBAQCBXSS5Db2RlTWlycm9yVG9r ZW5UcmFja2luZ0NvbnRyb2xsZXIgPSBjbGFzcyBDb2RlTWlycm9yVG9rZW5UcmFja2luZ0NvbnRy b2xsZXIgZQogICAgICAgICB0aGlzLl90cmFja2luZyA9IGZhbHNlOwogICAgICAgICB0aGlzLl9w cmV2aW91c1Rva2VuSW5mbyA9IG51bGw7CiAgICAgICAgIHRoaXMuX2hvdmVyZWRNYXJrZXIgPSBu dWxsOworICAgICAgICB0aGlzLl9pZ25vcmVOZXh0TW91c2VNb3ZlID0gZmFsc2U7CiAKICAgICAg ICAgY29uc3QgaGlkZVBvcG92ZXIgPSB0aGlzLl9oaWRlUG9wb3Zlci5iaW5kKHRoaXMpOwogCkBA IC0xOTgsMTIgKzE5OSwxNCBAQCBXSS5Db2RlTWlycm9yVG9rZW5UcmFja2luZ0NvbnRyb2xsZXIg PSBjbGFzcyBDb2RlTWlycm9yVG9rZW5UcmFja2luZ0NvbnRyb2xsZXIgZQogICAgICAgICAgICAg cmV0dXJuOwogCiAgICAgICAgIHRoaXMuX3RyYWNraW5nID0gdHJ1ZTsKKyAgICAgICAgdGhpcy5f aWdub3JlTmV4dE1vdXNlTW92ZSA9IGZhbHNlOwogCiAgICAgICAgIHZhciB3cmFwcGVyID0gdGhp cy5fY29kZU1pcnJvci5nZXRXcmFwcGVyRWxlbWVudCgpOwogICAgICAgICB3cmFwcGVyLmFkZEV2 ZW50TGlzdGVuZXIoIm1vdXNlbW92ZSIsIHRoaXMsIHRydWUpOwogICAgICAgICB3cmFwcGVyLmFk ZEV2ZW50TGlzdGVuZXIoIm1vdXNlb3V0IiwgdGhpcywgZmFsc2UpOwogICAgICAgICB3cmFwcGVy LmFkZEV2ZW50TGlzdGVuZXIoIm1vdXNlZG93biIsIHRoaXMsIGZhbHNlKTsKICAgICAgICAgd3Jh cHBlci5hZGRFdmVudExpc3RlbmVyKCJtb3VzZXVwIiwgdGhpcywgZmFsc2UpOworICAgICAgICB3 cmFwcGVyLmFkZEV2ZW50TGlzdGVuZXIoIm1vdXNld2hlZWwiLCB0aGlzLCBmYWxzZSk7CiAgICAg ICAgIHdpbmRvdy5hZGRFdmVudExpc3RlbmVyKCJibHVyIiwgdGhpcywgdHJ1ZSk7CiAgICAgfQog CkBAIC0yMjAsNiArMjIzLDcgQEAgV0kuQ29kZU1pcnJvclRva2VuVHJhY2tpbmdDb250cm9sbGVy ID0gY2xhc3MgQ29kZU1pcnJvclRva2VuVHJhY2tpbmdDb250cm9sbGVyIGUKICAgICAgICAgd3Jh cHBlci5yZW1vdmVFdmVudExpc3RlbmVyKCJtb3VzZW91dCIsIHRoaXMsIGZhbHNlKTsKICAgICAg ICAgd3JhcHBlci5yZW1vdmVFdmVudExpc3RlbmVyKCJtb3VzZWRvd24iLCB0aGlzLCBmYWxzZSk7 CiAgICAgICAgIHdyYXBwZXIucmVtb3ZlRXZlbnRMaXN0ZW5lcigibW91c2V1cCIsIHRoaXMsIGZh bHNlKTsKKyAgICAgICAgd3JhcHBlci5yZW1vdmVFdmVudExpc3RlbmVyKCJtb3VzZXdoZWVsIiwg dGhpcywgZmFsc2UpOwogICAgICAgICB3aW5kb3cucmVtb3ZlRXZlbnRMaXN0ZW5lcigiYmx1ciIs IHRoaXMsIHRydWUpOwogICAgICAgICB3aW5kb3cucmVtb3ZlRXZlbnRMaXN0ZW5lcigibW91c2Vt b3ZlIiwgdGhpcywgdHJ1ZSk7CiAKQEAgLTI1Miw2ICsyNTYsOSBAQCBXSS5Db2RlTWlycm9yVG9r ZW5UcmFja2luZ0NvbnRyb2xsZXIgPSBjbGFzcyBDb2RlTWlycm9yVG9rZW5UcmFja2luZ0NvbnRy b2xsZXIgZQogICAgICAgICBjYXNlICJtb3VzZXVwIjoKICAgICAgICAgICAgIHRoaXMuX21vdXNl QnV0dG9uV2FzUmVsZWFzZWRPdmVyRWRpdG9yKGV2ZW50KTsKICAgICAgICAgICAgIGJyZWFrOwor ICAgICAgICBjYXNlICJtb3VzZXdoZWVsIjoKKyAgICAgICAgICAgIHRoaXMuX2lnbm9yZU5leHRN b3VzZU1vdmUgPSB0cnVlOworICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIGNhc2UgImJsdXIi OgogICAgICAgICAgICAgdGhpcy5fd2luZG93TG9zdEZvY3VzKGV2ZW50KTsKICAgICAgICAgICAg IGJyZWFrOwpAQCAtMzE4LDYgKzMyNSwxMSBAQCBXSS5Db2RlTWlycm9yVG9rZW5UcmFja2luZ0Nv bnRyb2xsZXIgPSBjbGFzcyBDb2RlTWlycm9yVG9rZW5UcmFja2luZ0NvbnRyb2xsZXIgZQogCiAg ICAgX21vdXNlTW92ZWRPdmVyRWRpdG9yKGV2ZW50KQogICAgIHsKKyAgICAgICAgaWYgKHRoaXMu X2lnbm9yZU5leHRNb3VzZU1vdmUpIHsKKyAgICAgICAgICAgIHRoaXMuX2lnbm9yZU5leHRNb3Vz ZU1vdmUgPSBmYWxzZTsKKyAgICAgICAgICAgIHJldHVybjsKKyAgICAgICAgfQorCiAgICAgICAg IHRoaXMuX3VwZGF0ZUhvdmVyZWRUb2tlbkluZm8oe2xlZnQ6IGV2ZW50LnBhZ2VYLCB0b3A6IGV2 ZW50LnBhZ2VZfSk7CiAgICAgfQogCg==